mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Raúl Marín
1e3d3c4926
`git show $sha:.gitmodules | grep -q ...` returns grep's exit code, so a missing pinned commit (incomplete/corrupted cache) silently looked like "no nested submodules". Add an explicit `git cat-file -e` check so a missing commit fails loudly. Addresses review feedback on PR #105053.
73 lines
3.3 KiB
Bash
Executable File
73 lines
3.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# The script checks if all submodules defined in .gitmodules exist in contrib/,
|
|
# validates their URLs and names, and ensures there are no recursive submodules.
|
|
|
|
set -e
|
|
|
|
cd "$(git rev-parse --show-toplevel)"
|
|
|
|
# Resolve every submodule's pinned gitlink SHA from the superproject in one
|
|
# call (avoids one `git rev-parse` per submodule).
|
|
declare -A pinned_sha
|
|
while IFS=$'\t' read -r meta path; do
|
|
pinned_sha["$path"]=${meta##* }
|
|
done < <(git config --file .gitmodules --get-regexp path | awk '{print $2}' | xargs git ls-tree HEAD)
|
|
|
|
# For each registered submodule: ensure its bare repo is present and that
|
|
# the pinned commit does not pull in nested submodules. We read .gitmodules
|
|
# directly from the bare repo at the pinned SHA so we don't need the
|
|
# submodule working tree and don't trust the bare repo's HEAD.
|
|
# Process substitution (not a pipe) so `exit 1` aborts the whole script.
|
|
while IFS= read -r -d '' submodule_path; do
|
|
if ! test -d "$submodule_path"; then
|
|
echo "Directory for submodule $submodule_path is not found"
|
|
exit 1
|
|
fi
|
|
# An initialized submodule has its bare repo at .git/modules/<path>;
|
|
# without it, we cannot inspect the pinned commit.
|
|
submodule_git_dir=".git/modules/$submodule_path"
|
|
if [ ! -d "$submodule_git_dir" ]; then
|
|
echo "Submodule $submodule_path is not initialized; run 'git submodule init'."
|
|
exit 1
|
|
fi
|
|
submodule_sha=${pinned_sha[$submodule_path]}
|
|
if [ -z "$submodule_sha" ]; then
|
|
echo "Failed to resolve pinned commit for submodule $submodule_path"
|
|
exit 1
|
|
fi
|
|
# Assert the pinned commit is actually present in the bare repo. Without
|
|
# this, `git show $sha:.gitmodules | grep ...` would silently treat a
|
|
# missing commit (e.g. incomplete cache) as "no nested submodules" because
|
|
# the pipeline's exit code comes from grep, not git show.
|
|
if ! git --git-dir="$submodule_git_dir" cat-file -e "$submodule_sha^{commit}" 2>/dev/null; then
|
|
echo "Pinned commit $submodule_sha for submodule $submodule_path is missing from $submodule_git_dir; the submodule cache may be incomplete."
|
|
exit 1
|
|
fi
|
|
if git --git-dir="$submodule_git_dir" show "$submodule_sha:.gitmodules" 2>/dev/null | grep -q '\[submodule'; then
|
|
echo "Recursive submodules are not allowed: $submodule_path contains its own .gitmodules with submodule entries"
|
|
exit 1
|
|
fi
|
|
done < <(git config --file .gitmodules --null --get-regexp path | sed -z 's|.*\n||')
|
|
|
|
# All submodules should be from https://github.com/
|
|
while read -r line; do
|
|
name=${line#submodule.}; name=${name%.url*}
|
|
url=${line#* }
|
|
if [[ "$url" != 'https://github.com/'* ]]; then
|
|
echo "All submodules should be from https://github.com/, submodule '$name' has '$url'"
|
|
exit 1
|
|
fi
|
|
done < <(git config --file .gitmodules --get-regexp 'submodule\..+\.url')
|
|
|
|
# All submodules should be of this form: [submodule "contrib/libxyz"]
|
|
# (for consistency, the submodule name should equal its path)
|
|
while read -r line; do
|
|
name=${line#submodule.}; name=${name%.path*}
|
|
path=${line#* }
|
|
if [ "$name" != "$path" ]; then
|
|
echo "Submodule name '$name' is not equal to its path '$path'"
|
|
exit 1
|
|
fi
|
|
done < <(git config --file .gitmodules --get-regexp 'submodule\..+\.path')
|