mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
109 lines
3.6 KiB
Python
109 lines
3.6 KiB
Python
#!/usr/bin/env python3
|
|
|
|
import dataclasses
|
|
import json
|
|
import sys
|
|
from datetime import datetime, timedelta
|
|
|
|
sys.path.append(".")
|
|
from ci.praktika.utils import Shell
|
|
|
|
REPOS = [
|
|
"ClickHouse/ClickHouse",
|
|
"ClickHouse/ClickHouse-private",
|
|
]
|
|
|
|
INTERVAL_DAYS = 7
|
|
|
|
|
|
@dataclasses.dataclass
|
|
class PullRequest:
|
|
number: int
|
|
title: str
|
|
merged_at: str
|
|
repo: str
|
|
url: str
|
|
|
|
|
|
if __name__ == "__main__":
|
|
result_merged = [] # List[PullRequest]
|
|
|
|
if not Shell.check("gh auth status", strict=False):
|
|
print(
|
|
"Error: GitHub CLI is not authenticated. Please run 'gh auth login' first."
|
|
)
|
|
exit(1)
|
|
|
|
result_approved = [] # List[PullRequest]
|
|
for repo in REPOS:
|
|
print(f"Processing repository: {repo}")
|
|
|
|
try:
|
|
seven_days_ago = (datetime.now() - timedelta(days=INTERVAL_DAYS)).strftime(
|
|
"%Y-%m-%d"
|
|
)
|
|
res = Shell.get_output(
|
|
f"gh pr list --json number,title,mergedAt,headRepository,url --limit 1000 --repo {repo} --author @me --state merged --search 'merged:>{seven_days_ago}'"
|
|
)
|
|
if res:
|
|
prs_data = json.loads(res)
|
|
for pr_data in prs_data:
|
|
if pr_data.get("mergedAt"): # Only include actually merged PRs
|
|
pr = PullRequest(
|
|
number=pr_data["number"],
|
|
title=pr_data["title"],
|
|
merged_at=pr_data["mergedAt"],
|
|
repo=repo,
|
|
url=pr_data["url"],
|
|
)
|
|
result_merged.append(pr)
|
|
except (json.JSONDecodeError, KeyError) as e:
|
|
print(f"Error processing authored PRs for {repo}: {e}")
|
|
continue
|
|
|
|
try:
|
|
print(" Checking PRs reviewed by me...")
|
|
seven_days_ago = (datetime.now() - timedelta(days=INTERVAL_DAYS)).strftime(
|
|
"%Y-%m-%d"
|
|
)
|
|
res = Shell.get_output(
|
|
f"gh pr list --json number,title,mergedAt,headRepository,url,author --limit 1000 --repo {repo} --state merged --search 'merged:>{seven_days_ago} reviewed-by:@me'"
|
|
)
|
|
|
|
if res and res.strip() != "[]":
|
|
prs_data = json.loads(res)
|
|
current_user = Shell.get_output("gh api user --jq .login").strip()
|
|
for pr_data in prs_data:
|
|
if pr_data.get("author", {}).get("login") == current_user:
|
|
continue
|
|
pr = PullRequest(
|
|
number=pr_data["number"],
|
|
title=pr_data["title"],
|
|
merged_at=pr_data["mergedAt"],
|
|
url=pr_data["url"],
|
|
repo=repo,
|
|
)
|
|
result_approved.append(pr)
|
|
except (json.JSONDecodeError, KeyError) as e:
|
|
print(f"Error processing approved PRs for {repo}: {e}")
|
|
continue
|
|
|
|
print("\nSummary:")
|
|
print(f"- Authored and merged: {len(result_merged)} PRs")
|
|
print(f"- Reviewed and merged: {len(result_approved)} PRs")
|
|
|
|
# Display results
|
|
print(f"\n=== Merged in the last {INTERVAL_DAYS}d ===")
|
|
if result_merged:
|
|
for pr in result_merged:
|
|
print(f"{pr.url}: {pr.title}") # - merged at {pr.merged_at}
|
|
else:
|
|
print("No PRs found")
|
|
|
|
print(f"\n=== Reviewed in the last {INTERVAL_DAYS}d ===")
|
|
if result_approved:
|
|
for pr in result_approved:
|
|
print(f"{pr.url}: {pr.title}") # - merged at {pr.merged_at}
|
|
else:
|
|
print("No PRs found")
|