mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
42 lines
1.2 KiB
Python
42 lines
1.2 KiB
Python
import shlex
|
|
import sys
|
|
import traceback
|
|
|
|
from ci.defs.defs import SYNC
|
|
from ci.praktika.gh import GH
|
|
from ci.praktika.info import Info
|
|
from ci.praktika.result import Result
|
|
from ci.praktika.utils import Shell
|
|
|
|
|
|
def check():
|
|
info = Info()
|
|
if info.user_name not in ("yariks5s", "maxknv"):
|
|
print(f"Not enabled for [{info.user_name}]")
|
|
return
|
|
cmd = (
|
|
"gh workflow run private_quick_sync.yml --repo ClickHouse/clickhouse-private --ref master "
|
|
+ f"--field pr_number={shlex.quote(str(info.pr_number))} "
|
|
+ f"--field branch_name={shlex.quote(str(info.git_branch))} "
|
|
+ f"--field title={shlex.quote(str(info.pr_title))} "
|
|
+ f"--field sha={shlex.quote(str(info.sha))}"
|
|
)
|
|
|
|
if not Shell.check(cmd):
|
|
GH.post_commit_status(
|
|
name=SYNC, status=Result.Status.ERROR, description="failed to start the sync", url=""
|
|
)
|
|
else:
|
|
GH.post_commit_status(
|
|
name=SYNC, status=Result.Status.PENDING, description="sync started", url=""
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
try:
|
|
check()
|
|
except Exception:
|
|
print("Failed to initiate sync")
|
|
traceback.print_exc()
|
|
sys.exit(1)
|