mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
38 lines
932 B
Python
38 lines
932 B
Python
|
|
from helpers.cluster import ClickHouseCluster
|
|
|
|
|
|
def start_clickhouse(config, err_msg):
|
|
cluster = ClickHouseCluster(__file__)
|
|
cluster.add_instance("node", main_configs=[config])
|
|
caught_exception = ""
|
|
try:
|
|
cluster.start()
|
|
except Exception as e:
|
|
caught_exception = str(e)
|
|
assert err_msg in caught_exception
|
|
|
|
|
|
def test_wrong_method():
|
|
start_clickhouse(
|
|
"configs/config_wrong_method.xml", "Unknown encryption method. Got WRONG"
|
|
)
|
|
|
|
|
|
def test_invalid_chars():
|
|
start_clickhouse(
|
|
"configs/config_invalid_chars.xml",
|
|
"Cannot read encrypted text, check for valid characters",
|
|
)
|
|
|
|
|
|
def test_no_encryption_key():
|
|
start_clickhouse(
|
|
"configs/config_no_encryption_key.xml",
|
|
"Empty params in CompressionCodecEncrypted configuration",
|
|
)
|
|
|
|
|
|
def test_subnodes():
|
|
start_clickhouse("configs/config_subnodes.xml", "cannot contain nested elements")
|