mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
93 lines
3.2 KiB
Python
93 lines
3.2 KiB
Python
|
|
import pytest
|
|
|
|
from helpers.cluster import ClickHouseCluster
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
instance = cluster.add_instance(
|
|
"instance",
|
|
user_configs=[
|
|
"configs/users.xml",
|
|
],
|
|
)
|
|
|
|
|
|
@pytest.fixture(scope="module", autouse=True)
|
|
def start_cluster():
|
|
try:
|
|
cluster.start()
|
|
yield cluster
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
def test_create_query_const_constraints():
|
|
instance.query("CREATE USER u_const SETTINGS max_threads = 1 CONST")
|
|
instance.query("GRANT ALL ON *.* TO u_const")
|
|
|
|
expected_error = "Setting max_threads should not be changed"
|
|
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE USER inner_user SETTINGS max_threads = 1", user="u_const"
|
|
)
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE USER inner_user SETTINGS max_threads MIN 0 MAX 2", user="u_const"
|
|
)
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE USER inner_user SETTINGS max_threads WRITABLE", user="u_const"
|
|
)
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE ROLE inner_role SETTINGS max_threads = 1", user="u_const"
|
|
)
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE SETTINGS PROFILE inner_profile SETTINGS max_threads = 1", user="u_const"
|
|
)
|
|
|
|
instance.query(
|
|
"CREATE USER inner_user_1 SETTINGS max_threads CONST", user="u_const"
|
|
)
|
|
instance.query(
|
|
"CREATE USER inner_user_2 SETTINGS max_threads = 1 CONST", user="u_const"
|
|
)
|
|
instance.query("DROP USER u_const, inner_user_1, inner_user_2")
|
|
|
|
|
|
def test_create_query_minmax_constraints():
|
|
instance.query("CREATE USER u_minmax SETTINGS max_threads = 4 MIN 2 MAX 6")
|
|
instance.query("GRANT ALL ON *.* TO u_minmax")
|
|
|
|
expected_error = "Setting max_threads shouldn't be less than"
|
|
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE USER inner_user SETTINGS max_threads = 1", user="u_minmax"
|
|
)
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE USER inner_user SETTINGS max_threads MIN 1 MAX 3", user="u_minmax"
|
|
)
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE ROLE inner_role SETTINGS max_threads MIN 1 MAX 3", user="u_minmax"
|
|
)
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE SETTINGS PROFILE inner_profile SETTINGS max_threads MIN 1 MAX 3",
|
|
user="u_minmax",
|
|
)
|
|
|
|
expected_error = "Setting max_threads shouldn't be greater than"
|
|
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE USER inner_user SETTINGS max_threads = 8", user="u_minmax"
|
|
)
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE USER inner_user SETTINGS max_threads MIN 4 MAX 8", user="u_minmax"
|
|
)
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE ROLE inner_role SETTINGS max_threads MIN 4 MAX 8", user="u_minmax"
|
|
)
|
|
assert expected_error in instance.query_and_get_error(
|
|
"CREATE SETTINGS PROFILE inner_profile SETTINGS max_threads MIN 4 MAX 8",
|
|
user="u_minmax",
|
|
)
|
|
|
|
instance.query("CREATE USER inner_user SETTINGS max_threads = 3", user="u_minmax")
|
|
instance.query("DROP USER u_minmax, inner_user")
|