mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
56 lines
2.0 KiB
Python
56 lines
2.0 KiB
Python
"""
|
|
This test is similar to test_cross_replication, except
|
|
in this test we write into per-node tables and read from the distributed table.
|
|
|
|
The default database in the distributed table definition is left empty on purpose to test
|
|
default database deduction.
|
|
"""
|
|
|
|
from contextlib import contextmanager
|
|
|
|
|
|
from helpers.cluster import ClickHouseCluster
|
|
from helpers.test_tools import TSV
|
|
|
|
|
|
def bootstrap(cluster):
|
|
for i, node in enumerate(list(cluster.instances.values())):
|
|
node.query(f"DROP DATABASE IF EXISTS r{i}")
|
|
node.query(f"CREATE DATABASE r{i}")
|
|
node.query(f"CREATE TABLE r{i}.test_data(v UInt64) ENGINE = Memory()")
|
|
node.query(f"INSERT INTO r{i}.test_data SELECT * FROM numbers(10)")
|
|
node.query(
|
|
f"""CREATE TABLE default.test AS r{i}.test_data ENGINE = Distributed(secure, '', test_data, rand())"""
|
|
)
|
|
|
|
|
|
@contextmanager
|
|
def start_cluster():
|
|
cluster_disabled = ClickHouseCluster(__file__)
|
|
cluster_disabled.add_instance(
|
|
"node1",
|
|
main_configs=["configs/remote_servers.xml"],
|
|
user_configs=["configs/users.xml"],
|
|
)
|
|
cluster_disabled.add_instance(
|
|
"node2",
|
|
main_configs=["configs/remote_servers.xml"],
|
|
user_configs=["configs/users.xml"],
|
|
)
|
|
try:
|
|
cluster_disabled.start()
|
|
bootstrap(cluster_disabled)
|
|
yield cluster_disabled
|
|
finally:
|
|
cluster_disabled.shutdown()
|
|
|
|
|
|
def test_query():
|
|
with start_cluster() as cluster:
|
|
node1 = cluster.instances["node1"]
|
|
# For now, serialize_query_plan is disabled, because all the tables must exist on initiator.
|
|
assert TSV(node1.query("SELECT count() FROM default.test settings serialize_query_plan = 0")) == TSV("20")
|
|
|
|
# Setting allow_push_predicate_ast_for_distributed_subqueries should work when the inner table does not exist.
|
|
assert TSV(node1.query("SELECT count() FROM (SELECT v FROM default.test) where v != 0 settings serialize_query_plan = 0")) == TSV("18")
|