mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
72 lines
2.3 KiB
Python
72 lines
2.3 KiB
Python
|
|
import pytest
|
|
|
|
from helpers.cluster import ClickHouseCluster
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
node = cluster.add_instance(
|
|
"node", main_configs=["configs/config.xml"],
|
|
)
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def started_cluster():
|
|
try:
|
|
cluster.start()
|
|
yield cluster
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
def test_insert_query_profile_events(started_cluster):
|
|
select_insert_query = (
|
|
"SELECT value FROM system.events WHERE event = 'InsertQuery'"
|
|
)
|
|
select_async_insert_query = (
|
|
"SELECT value FROM system.events WHERE event = 'AsyncInsertQuery'"
|
|
)
|
|
|
|
non_async_inserts = 2
|
|
async_inserts = 2
|
|
inserts = non_async_inserts + async_inserts
|
|
|
|
insert_count = node.query(select_insert_query).strip()
|
|
async_insert_count = node.query(select_async_insert_query).strip()
|
|
|
|
orig_insert_count = int(insert_count) if insert_count else 0
|
|
orig_async_insert_count = int(async_insert_count) if async_insert_count else 0
|
|
|
|
node.query(
|
|
"DROP TABLE IF EXISTS test_insert_query_profile_events"
|
|
)
|
|
|
|
try:
|
|
node.query(
|
|
"CREATE TABLE test_insert_query_profile_events (id UInt32, s String) ENGINE = Memory"
|
|
)
|
|
|
|
node.query(
|
|
"INSERT INTO test_insert_query_profile_events SETTINGS async_insert=0 VALUES (1,'Non Async Insert')"
|
|
)
|
|
node.query(
|
|
"INSERT INTO test_insert_query_profile_events SETTINGS async_insert=0 VALUES (2,'Non Async Insert')"
|
|
)
|
|
|
|
node.query(
|
|
"INSERT INTO test_insert_query_profile_events SETTINGS async_insert=1 VALUES (3,'Async Insert')"
|
|
)
|
|
node.query(
|
|
"INSERT INTO test_insert_query_profile_events SETTINGS async_insert=1 VALUES (4,'Async Insert')"
|
|
)
|
|
|
|
insert_count = node.query(select_insert_query).strip()
|
|
async_insert_count = node.query(select_async_insert_query).strip()
|
|
|
|
current_insert_count = int(insert_count) if insert_count else 0
|
|
current_async_insert_count = int(async_insert_count) if async_insert_count else 0
|
|
|
|
assert current_insert_count - orig_insert_count == inserts
|
|
assert current_async_insert_count - orig_async_insert_count == async_inserts
|
|
finally:
|
|
node.query("DROP TABLE IF EXISTS test_insert_query_profile_events SYNC")
|