mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
73 lines
1.9 KiB
Python
73 lines
1.9 KiB
Python
|
|
import pytest
|
|
|
|
from helpers.cluster import ClickHouseCluster
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
node = cluster.add_instance("node", with_zookeeper=True)
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def started_cluster():
|
|
try:
|
|
cluster.start()
|
|
|
|
yield cluster
|
|
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
# This test constructs intersecting parts intentionally. It's not an elegant test.
|
|
# TODO(hanfei): write a test which select part 1_1 merging with part 2_2 and drop range.
|
|
def test_intersect_parts_when_restart(started_cluster):
|
|
node.query("DROP TABLE IF EXISTS data SYNC")
|
|
node.query(
|
|
"""
|
|
CREATE TABLE data (
|
|
key Int
|
|
)
|
|
ENGINE = ReplicatedMergeTree('/ch/tables/default/data', 'node')
|
|
ORDER BY key;
|
|
"""
|
|
)
|
|
node.query("system stop cleanup data")
|
|
node.query("INSERT INTO data values (1)")
|
|
node.query("INSERT INTO data values (2)")
|
|
node.query("INSERT INTO data values (3)")
|
|
node.query("INSERT INTO data values (4)")
|
|
node.query("ALTER TABLE data DROP PART 'all_1_1_0'")
|
|
node.query("ALTER TABLE data DROP PART 'all_2_2_0'")
|
|
node.query("OPTIMIZE TABLE data FINAL")
|
|
|
|
part_path = node.query(
|
|
"SELECT path FROM system.parts WHERE table = 'data' and name = 'all_0_3_1'"
|
|
).strip()
|
|
|
|
assert len(part_path) != 0
|
|
|
|
node.query("detach table data")
|
|
new_path = part_path[:-6] + "1_2_3"
|
|
node.exec_in_container(
|
|
[
|
|
"bash",
|
|
"-c",
|
|
"cp -r {p} {p1}".format(p=part_path, p1=new_path),
|
|
],
|
|
privileged=True,
|
|
)
|
|
|
|
# mock empty part
|
|
node.exec_in_container(
|
|
[
|
|
"bash",
|
|
"-c",
|
|
"echo -n 0 > {p1}/count.txt".format(p1=new_path),
|
|
],
|
|
privileged=True,
|
|
)
|
|
|
|
node.query("attach table data")
|
|
data_size = node.query("SELECT sum(key) FROM data").strip()
|
|
assert data_size == "5"
|