mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.6
1128a20015
The test bind-mounts a fake /sys/devices/system/cpu/online to simulate having fewer online CPUs than configured. However, `sysconf(_SC_NPROCESSORS_ONLN)` does not always read from that file - glibc can use `sched_getaffinity` instead, especially on newer kernels or ARM. When the override doesn't take effect, the test fails with `assert online_cpus == 1` getting the real CPU count. Skip instead of failing, since the test's precondition cannot be guaranteed on all systems. Co-Authored-By: Claude Opus 4.6 <[email protected]>
118 lines
3.7 KiB
Python
Executable File
118 lines
3.7 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# pylint: disable=line-too-long
|
|
|
|
import multiprocessing
|
|
import os
|
|
import subprocess
|
|
from tempfile import NamedTemporaryFile
|
|
|
|
import pytest
|
|
|
|
CPU_ID = 4
|
|
|
|
|
|
def run_command_in_container(cmd, *args):
|
|
# /clickhouse is mounted by integration tests runner
|
|
alternative_binary = os.getenv("CLICKHOUSE_BINARY", "/clickhouse")
|
|
if alternative_binary:
|
|
args += (
|
|
"--volume",
|
|
f"{alternative_binary}:/usr/bin/clickhouse",
|
|
)
|
|
|
|
return subprocess.check_output(
|
|
[
|
|
"docker",
|
|
"run",
|
|
"--rm",
|
|
*args,
|
|
"ubuntu:22.04",
|
|
"sh",
|
|
"-c",
|
|
cmd,
|
|
]
|
|
)
|
|
|
|
|
|
def run_with_cpu_limit(cmd, *args):
|
|
with NamedTemporaryFile() as online_cpu:
|
|
# NOTE: this is not the number of CPUs, but specific CPU ID
|
|
online_cpu.write(f"{CPU_ID}".encode())
|
|
online_cpu.flush()
|
|
|
|
# replace /sys/devices/system/cpu/online to full _SC_NPROCESSORS_ONLN
|
|
# like LXD/LXC from [1] does.
|
|
#
|
|
# [1]: https://github.com/ClickHouse/ClickHouse/issues/32806
|
|
args += (
|
|
"--volume",
|
|
f"{online_cpu.name}:/sys/devices/system/cpu/online:ro",
|
|
)
|
|
|
|
return run_command_in_container(cmd, *args)
|
|
|
|
|
|
def skip_if_jemalloc_disabled():
|
|
output = run_command_in_container(
|
|
"""clickhouse local -q "
|
|
SELECT value FROM system.build_options WHERE name = 'USE_JEMALLOC'"
|
|
"""
|
|
).strip()
|
|
if output != b"ON" and output != b"1":
|
|
pytest.skip(f"Compiled without jemalloc (USE_JEMALLOC={output})")
|
|
|
|
|
|
# Ensure that clickhouse works even when number of online CPUs
|
|
# (_SC_NPROCESSORS_ONLN) is smaller then available (_SC_NPROCESSORS_CONF).
|
|
#
|
|
# Refs: https://github.com/jemalloc/jemalloc/pull/2181
|
|
def test_jemalloc_percpu_arena():
|
|
skip_if_jemalloc_disabled()
|
|
|
|
assert multiprocessing.cpu_count() > CPU_ID
|
|
|
|
online_cpus = int(run_with_cpu_limit("getconf _NPROCESSORS_ONLN"))
|
|
if online_cpus != 1:
|
|
pytest.skip(
|
|
f"sysconf(_SC_NPROCESSORS_ONLN) returned {online_cpus} instead of 1: "
|
|
"/sys/devices/system/cpu/online override not effective on this system"
|
|
)
|
|
|
|
all_cpus = int(run_with_cpu_limit("getconf _NPROCESSORS_CONF"))
|
|
assert all_cpus == multiprocessing.cpu_count(), all_cpus
|
|
|
|
# implicitly disable percpu arena
|
|
result = run_with_cpu_limit(
|
|
'clickhouse local -q "select 1"',
|
|
# NOTE: explicitly disable, since it is enabled by default in debug build
|
|
# (and even though debug builds are not in CI let's state this).
|
|
"--env",
|
|
"MALLOC_CONF=abort_conf:false",
|
|
)
|
|
assert int(result) == int(1), result
|
|
|
|
# jemalloc compares sysconf(_SC_NPROCESSORS_ONLN) and sysconf(_SC_NPROCESSORS_CONF) to determine the CPU topology info
|
|
# Apparently sometimes _SC_NPROCESSORS_ONLN SOMETIMES ignores the override of /sys/devices/system/cpu/online and it should be equal to
|
|
# _SC_NPROCESSORS_CONF
|
|
# Latter it also checks sched_getaffinity() + CPU_COUNT(&set), so, we rely also on --cpuset-cpus (taskset) in order to trigger the
|
|
# second condition
|
|
with pytest.raises(subprocess.CalledProcessError):
|
|
# should fail because of abort_conf:true but:
|
|
run_with_cpu_limit(
|
|
'clickhouse local -q "select 1"',
|
|
"--cpuset-cpus", f"{CPU_ID}",
|
|
"--env", "MALLOC_CONF=abort_conf:true",
|
|
)
|
|
|
|
# should not fail even with abort_conf:true, due to explicit narenas
|
|
# NOTE: abort:false to make it compatible with debug build
|
|
run_with_cpu_limit(
|
|
'clickhouse local -q "select 1"',
|
|
"--env", f"MALLOC_CONF=abort_conf:true,abort:false,narenas:{all_cpus}",
|
|
)
|
|
|
|
|
|
# For manual run.
|
|
if __name__ == "__main__":
|
|
test_jemalloc_percpu_arena()
|