mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
unintendedandClaude Fable 5
3c05bc9d85
Container semantics are persisted state: snapshot restore repopulates container_paths even when the flag is off, but the GC thread was only started when it was on, so after a restart with create_container=0 existing containers were never cleaned up once childless. Start the GC thread unconditionally; the flag now gates only the creation of new container nodes by clients. Validate container_gc_period_ms unconditionally as well. Also bump write_snapshot_version to 9 in the integration test configs (the V9 gate rejects create_container=1 with a lower write version at startup) and add a restart regression test with the flag disabled. https://github.com/ClickHouse/ClickHouse/pull/108908#discussion_r3547641181 Co-Authored-By: Claude Fable 5 <[email protected]>