mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
unintendedandClaude Sonnet 5
8cd8d2b7de
Mirrors the CreateTTL rollout gate: a not-yet-upgraded replica does not recognise the CreateContainer opcode and would abort when replaying it from the Raft log during a rolling upgrade. Add KeeperFeatureFlag::CREATE_CONTAINER (disabled by default, like CREATE_TTL), gate the CreateContainer opnum in KeeperContext::isOperationSupported, and gate the container GC thread's startup/join and its container_gc_period_ms validation behind the same flag. Addresses review feedback on #108908: https://github.com/ClickHouse/ClickHouse/pull/108908#discussion_r3532407001 Co-Authored-By: Claude Sonnet 5 <[email protected]>
32 lines
933 B
Python
32 lines
933 B
Python
#!/usr/bin/env python3
|
|
|
|
import uuid
|
|
import helpers.keeper_utils as keeper_utils
|
|
from helpers.cluster import ClickHouseCluster
|
|
import pytest
|
|
from kazoo.retry import RetryFailedError
|
|
|
|
def get_fake_zk(cluster, nodename, timeout=30.0):
|
|
return keeper_utils.get_fake_zk(cluster, nodename, timeout=timeout)
|
|
|
|
|
|
def test_container_disabled():
|
|
run_uuid = uuid.uuid4()
|
|
cluster = ClickHouseCluster(__file__, str(run_uuid))
|
|
# Disable `with_remote_database_disk` as the test does not use the default Keeper.
|
|
cluster.add_instance(
|
|
"node1", main_configs=["configs/disable_keeper1.xml"], stay_alive=True, with_remote_database_disk=False,
|
|
)
|
|
node1_zk = None
|
|
|
|
cluster.start()
|
|
|
|
node1_zk = get_fake_zk(cluster, "node1")
|
|
with pytest.raises(RetryFailedError):
|
|
node1_zk.create("/test_alive", b"", container=True)
|
|
cluster.shutdown()
|
|
|
|
if node1_zk:
|
|
node1_zk.stop()
|
|
node1_zk.close()
|