mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
71 lines
1.8 KiB
Python
71 lines
1.8 KiB
Python
#!/usr/bin/env python3
|
|
|
|
import threading
|
|
|
|
import pytest
|
|
|
|
import helpers.keeper_utils as keeper_utils
|
|
from helpers.cluster import ClickHouseCluster
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
node1 = cluster.add_instance(
|
|
"node1", main_configs=["config/enable_keeper1.xml"], stay_alive=True
|
|
)
|
|
node2 = cluster.add_instance(
|
|
"node2", main_configs=["config/enable_keeper2.xml"], stay_alive=True
|
|
)
|
|
node3 = cluster.add_instance(
|
|
"node3", main_configs=["config/enable_keeper3.xml"], stay_alive=True
|
|
)
|
|
|
|
NOT_SERVING_REQUESTS_ERROR_MSG = "This instance is not currently serving requests"
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def started_cluster():
|
|
try:
|
|
cluster.start()
|
|
|
|
yield cluster
|
|
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
def test_aggressive_mntr(started_cluster):
|
|
def go_mntr(node):
|
|
for _ in range(10000):
|
|
try:
|
|
print(node.name, keeper_utils.send_4lw_cmd(cluster, node, "mntr"))
|
|
except ConnectionRefusedError:
|
|
pass
|
|
|
|
node1_thread = threading.Thread(target=lambda: go_mntr(node1))
|
|
node2_thread = threading.Thread(target=lambda: go_mntr(node2))
|
|
node3_thread = threading.Thread(target=lambda: go_mntr(node3))
|
|
node1_thread.start()
|
|
node2_thread.start()
|
|
node3_thread.start()
|
|
|
|
node2.stop_clickhouse()
|
|
node3.stop_clickhouse()
|
|
|
|
keeper_utils.wait_until_quorum_lost(cluster, node1)
|
|
|
|
node1.stop_clickhouse()
|
|
starters = []
|
|
for node in [node1, node2, node3]:
|
|
start_thread = threading.Thread(target=lambda: node.start_clickhouse())
|
|
start_thread.start()
|
|
starters.append(start_thread)
|
|
|
|
for start_thread in starters:
|
|
start_thread.join()
|
|
|
|
node1_thread.join()
|
|
node2_thread.join()
|
|
node3_thread.join()
|
|
|
|
for node in [node1, node2, node3]:
|
|
assert not node.contains_in_log("LOGICAL_ERROR")
|