mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
95 lines
2.8 KiB
Python
95 lines
2.8 KiB
Python
import pytest
|
||
|
||
from helpers.cluster import ClickHouseCluster
|
||
|
||
cluster = ClickHouseCluster(__file__)
|
||
|
||
node = cluster.add_instance(
|
||
"node1",
|
||
main_configs=["configs/keeper_config1.xml"],
|
||
stay_alive=True,
|
||
)
|
||
node2 = cluster.add_instance(
|
||
"node2",
|
||
main_configs=["configs/keeper_config2.xml"],
|
||
stay_alive=True,
|
||
with_minio=True,
|
||
)
|
||
node3 = cluster.add_instance(
|
||
"node3",
|
||
main_configs=["configs/keeper_config3.xml"],
|
||
stay_alive=True,
|
||
with_minio=True,
|
||
)
|
||
|
||
|
||
@pytest.fixture(scope="module", autouse=True)
|
||
def started_cluster():
|
||
try:
|
||
cluster.start()
|
||
yield cluster
|
||
|
||
finally:
|
||
cluster.shutdown()
|
||
|
||
|
||
def test_profiler(started_cluster):
|
||
node = cluster.instances["node1"]
|
||
if node.is_built_with_sanitizer():
|
||
return
|
||
|
||
node.query(
|
||
"CREATE TABLE t (key UInt32, value String) Engine = ReplicatedMergeTree('/clickhouse-tables/test1', 'r1') ORDER BY key"
|
||
)
|
||
|
||
for _ in range(100):
|
||
node.query("INSERT INTO t SELECT number, toString(number) from numbers(100)")
|
||
|
||
node.query("system flush logs")
|
||
assert int(node.query("exists system.trace_log"))
|
||
|
||
result = node.query(
|
||
"""
|
||
set allow_introspection_functions=1;
|
||
system flush logs;
|
||
select cnt from (
|
||
select count() as cnt, formatReadableSize(sum(size)),
|
||
arrayStringConcat(
|
||
arrayMap(x, y -> concat(x, ': ', y), arrayMap(x -> addressToLine(x), trace), arrayMap(x -> demangle(addressToSymbol(x)), trace)),
|
||
'\n') as trace
|
||
from system.trace_log where trace_type = ‘Real’ and (trace ilike '%KeeperTCPHandler%' or trace ilike '%KeeperDispatcher%') group by trace order by cnt desc) limit 1;
|
||
"""
|
||
)
|
||
|
||
if len(result) == 0:
|
||
assert 0 < int(
|
||
node.query(
|
||
"""
|
||
set allow_introspection_functions=1;
|
||
system flush logs;
|
||
select sum(cnt) from (
|
||
select count() as cnt, formatReadableSize(sum(size)),
|
||
arrayStringConcat(
|
||
arrayMap(x, y -> concat(x, ': ', y), arrayMap(x -> addressToLine(x), trace), arrayMap(x -> demangle(addressToSymbol(x)), trace)),
|
||
'\n') as trace
|
||
from system.trace_log where trace_type = ‘Real’ group by trace);
|
||
"""
|
||
)
|
||
)
|
||
result = node.query(
|
||
"""
|
||
set allow_introspection_functions=1;
|
||
system flush logs;
|
||
select * from (
|
||
select count() as cnt, formatReadableSize(sum(size)),
|
||
arrayStringConcat(
|
||
arrayMap(x, y -> concat(x, ': ', y), arrayMap(x -> addressToLine(x), trace), arrayMap(x -> demangle(addressToSymbol(x)), trace)),
|
||
'\n') as trace
|
||
from system.trace_log where trace_type = ‘Real’ group by trace);
|
||
"""
|
||
)
|
||
print(result)
|
||
assert False
|
||
|
||
assert 1 < int(result)
|