mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
62 lines
1.4 KiB
Python
62 lines
1.4 KiB
Python
|
|
import pytest
|
|
|
|
from helpers.cluster import ClickHouseCluster
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
|
|
node = cluster.add_instance("node", main_configs=["configs/logs.xml"], stay_alive=True)
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def started_cluster():
|
|
try:
|
|
cluster.start()
|
|
yield cluster
|
|
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
def check_log_file():
|
|
assert node.path_exists("/var/log/clickhouse-server/clickhouse-server.log.lz4")
|
|
|
|
lz4_output = node.exec_in_container(
|
|
[
|
|
"bash",
|
|
"-c",
|
|
"lz4 -t /var/log/clickhouse-server/clickhouse-server.log.lz4 2>&1",
|
|
],
|
|
user="root",
|
|
)
|
|
assert lz4_output.count("Error") == 0, lz4_output
|
|
|
|
compressed_size = int(
|
|
node.exec_in_container(
|
|
[
|
|
"bash",
|
|
"-c",
|
|
"du -b /var/log/clickhouse-server/clickhouse-server.log.lz4 | awk {' print $1 '}",
|
|
],
|
|
user="root",
|
|
)
|
|
)
|
|
uncompressed_size = int(lz4_output.split()[3])
|
|
assert 0 < compressed_size < uncompressed_size, lz4_output
|
|
|
|
|
|
def test_concatenation(started_cluster):
|
|
node.stop_clickhouse()
|
|
node.start_clickhouse()
|
|
node.stop_clickhouse()
|
|
|
|
check_log_file()
|
|
|
|
|
|
def test_incomplete_rotation(started_cluster):
|
|
node.stop_clickhouse(kill=True)
|
|
node.start_clickhouse()
|
|
node.stop_clickhouse()
|
|
|
|
check_log_file()
|