mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
63 lines
1.3 KiB
Python
63 lines
1.3 KiB
Python
#!/usr/bin/env python3
|
|
import time
|
|
from multiprocessing.dummy import Pool
|
|
|
|
import pytest
|
|
|
|
from helpers.cluster import ClickHouseCluster
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
|
|
node = cluster.add_instance(
|
|
"node",
|
|
main_configs=[
|
|
"configs/async_metrics_no.xml",
|
|
],
|
|
user_configs=[
|
|
"configs/disable_max_bytes_ratio_before_external_group_by.xml",
|
|
],
|
|
mem_limit="4g",
|
|
)
|
|
|
|
|
|
@pytest.fixture(scope="module", autouse=True)
|
|
def start_cluster():
|
|
try:
|
|
cluster.start()
|
|
yield cluster
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
def test_multiple_queries():
|
|
if node.is_built_with_sanitizer():
|
|
return
|
|
|
|
p = Pool(15)
|
|
|
|
def run_query(node):
|
|
try:
|
|
node.query("SELECT * FROM system.numbers GROUP BY number")
|
|
except Exception as ex:
|
|
print("Exception", ex)
|
|
raise ex
|
|
try:
|
|
node.query("SYSTEM FLUSH LOGS")
|
|
except Exception as ex:
|
|
print("Exception", ex)
|
|
raise ex
|
|
|
|
tasks = []
|
|
for i in range(30):
|
|
tasks.append(p.apply_async(run_query, (node,)))
|
|
time.sleep(i * 0.1)
|
|
|
|
for task in tasks:
|
|
try:
|
|
task.get()
|
|
except Exception as ex:
|
|
print("Exception", ex)
|
|
|
|
# test that we didn't kill the server
|
|
node.query("SELECT 1")
|