mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
103 lines
2.6 KiB
Python
103 lines
2.6 KiB
Python
#!/usr/bin/env python3
|
|
|
|
import os
|
|
import time
|
|
|
|
import pytest
|
|
|
|
from helpers.cluster import ClickHouseCluster
|
|
from helpers.test_tools import get_retry_number
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
node1 = cluster.add_instance(
|
|
"node1",
|
|
with_zookeeper=True,
|
|
)
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def started_cluster():
|
|
try:
|
|
cluster.start()
|
|
|
|
yield cluster
|
|
|
|
except Exception as ex:
|
|
print(ex)
|
|
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
def test_part_finally_removed(started_cluster, request):
|
|
node1.query("DROP TABLE IF EXISTS drop_outdated_part")
|
|
retry = get_retry_number(request)
|
|
node1.query(
|
|
f"""
|
|
CREATE TABLE drop_outdated_part (Key UInt64) ENGINE = ReplicatedMergeTree('/table/d{retry}', '1') ORDER BY tuple()
|
|
SETTINGS old_parts_lifetime=10, cleanup_delay_period=10, cleanup_delay_period_random_add=1, cleanup_thread_preferred_points_per_iteration=0
|
|
"""
|
|
)
|
|
node1.query("INSERT INTO drop_outdated_part VALUES (1)")
|
|
|
|
node1.query("OPTIMIZE TABLE drop_outdated_part FINAL")
|
|
|
|
data_path = node1.query(
|
|
"SELECT arrayElement(data_paths, 1) FROM system.tables WHERE database='default' AND name='drop_outdated_part'"
|
|
).strip()
|
|
|
|
node1.exec_in_container(
|
|
[
|
|
"bash",
|
|
"-c",
|
|
f"chown -R root:root {data_path}/all_0_0_0",
|
|
],
|
|
privileged=True,
|
|
user="root",
|
|
)
|
|
|
|
node1.query(
|
|
"ALTER TABLE drop_outdated_part MODIFY SETTING old_parts_lifetime=1, cleanup_delay_period=1, cleanup_delay_period_random_add=1, cleanup_thread_preferred_points_per_iteration=0"
|
|
)
|
|
|
|
for i in range(60):
|
|
if node1.contains_in_log("Cannot quickly remove directory"):
|
|
break
|
|
time.sleep(0.5)
|
|
|
|
node1.exec_in_container(
|
|
[
|
|
"bash",
|
|
"-c",
|
|
f"chown -R {os.getuid()}:{os.getgid()} {data_path}/*",
|
|
],
|
|
privileged=True,
|
|
user="root",
|
|
)
|
|
|
|
for i in range(60):
|
|
if (
|
|
node1.query(
|
|
"SELECT count() from system.parts WHERE table = 'drop_outdated_part'"
|
|
)
|
|
== "1\n"
|
|
):
|
|
out = node1.exec_in_container(
|
|
[
|
|
"bash",
|
|
"-c",
|
|
f"ls {data_path} | grep '_' | grep 'all'",
|
|
],
|
|
privileged=True,
|
|
user="root",
|
|
)
|
|
|
|
assert (
|
|
"all_0_0_0" not in out
|
|
), f"Print found part which must be deleted: {out}"
|
|
|
|
break
|
|
time.sleep(0.5)
|
|
|
|
node1.query("DROP TABLE drop_outdated_part")
|