mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
45 lines
1.2 KiB
Python
Executable File
45 lines
1.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
|
|
# This is a helper utility, it downloads presets of time series from "demo.promlabs.com"
|
|
# and put them to the "presets" folder.
|
|
|
|
import os
|
|
import zipfile
|
|
from prometheus_test_utils import PRESETS_DIR, execute_query_via_http_api
|
|
|
|
|
|
def download_preset(preset_name, host, port, path, query):
|
|
print(f"Downloading preset {preset_name}")
|
|
data = execute_query_via_http_api(host, port, path, query)
|
|
data_bytes = data.encode()
|
|
preset_fullname = os.path.join(PRESETS_DIR, preset_name)
|
|
if preset_fullname.endswith(".zip"):
|
|
with zipfile.ZipFile(
|
|
preset_fullname, mode="w", compression=zipfile.ZIP_DEFLATED
|
|
) as zip:
|
|
with zip.open(
|
|
os.path.splitext(os.path.basename(preset_fullname))[0] + ".json",
|
|
mode="w",
|
|
) as file:
|
|
file.write(data_bytes)
|
|
else:
|
|
with open(preset_fullname, mode="wb") as file:
|
|
file.write(data_bytes)
|
|
|
|
print("Done")
|
|
|
|
|
|
def download_presets():
|
|
download_preset(
|
|
"demo.promlabs.com-30s.zip",
|
|
"demo.promlabs.com",
|
|
80,
|
|
"api/v1/query",
|
|
'{__name__=~".+"}[30s]',
|
|
)
|
|
|
|
|
|
# MAIN
|
|
if __name__ == "__main__":
|
|
download_presets()
|