mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
82 lines
1.7 KiB
Python
82 lines
1.7 KiB
Python
import pytest
|
|
|
|
from helpers.cluster import ClickHouseCluster
|
|
from helpers.database_disk import get_database_disk_name
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
node = cluster.add_instance(
|
|
"node",
|
|
main_configs=["configs/config.xml"],
|
|
stay_alive=True,
|
|
)
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def start_cluster():
|
|
try:
|
|
cluster.start()
|
|
yield cluster
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
def test_recovery_time_metric(start_cluster):
|
|
node.query(
|
|
"""
|
|
DROP DATABASE IF EXISTS rdb;
|
|
CREATE DATABASE rdb
|
|
ENGINE = Replicated('/test/test_recovery_time_metric', 'shard1', 'replica1')
|
|
"""
|
|
)
|
|
|
|
node.query(
|
|
"""
|
|
DROP TABLE IF EXISTS rdb.t;
|
|
CREATE TABLE rdb.t
|
|
(
|
|
`x` UInt32
|
|
)
|
|
ENGINE = MergeTree
|
|
ORDER BY x
|
|
"""
|
|
)
|
|
|
|
db_disk_name = get_database_disk_name(node)
|
|
metadata_path = node.query(
|
|
"SELECT metadata_path FROM system.tables WHERE database='rdb' AND name='t'"
|
|
).strip()
|
|
|
|
node.exec_in_container(
|
|
[
|
|
"/usr/bin/clickhouse",
|
|
"disks",
|
|
"-C",
|
|
"/etc/clickhouse-server/config.xml",
|
|
"--disk",
|
|
f"{db_disk_name}",
|
|
"--save-logs",
|
|
"--query",
|
|
f"remove {metadata_path}",
|
|
],
|
|
user="root",
|
|
)
|
|
|
|
node.restart_clickhouse()
|
|
|
|
ret = int(
|
|
node.query(
|
|
"""
|
|
SELECT recovery_time
|
|
FROM system.clusters
|
|
WHERE cluster = 'rdb'
|
|
"""
|
|
).strip()
|
|
)
|
|
assert ret > 0
|
|
|
|
node.query(
|
|
"""
|
|
DROP DATABASE rdb
|
|
"""
|
|
)
|