mirror of
https://github.com/hanzoai/datastore.git
synced 2026-09-26 13:55:07 +00:00
Alexey MilovidovandClaude Opus 4.8
295ced78d1
Follow-up to #105171, which added `ruff` with a deliberately narrow, bug-class-only rule set and left the unused-name and star-import rules off pending a dedicated cleanup pass. This enables that second batch in `pyproject.toml` and fixes every violation across the tree (the bulk in integration tests): - `F401` unused-import and `F841` unused-variable: removed, preserving any side-effecting right-hand side (e.g. `result = node.query(...)` becomes `node.query(...)`). Two `try: import ...` feature probes are kept with `# noqa: F401`. - `F541` f-string-missing-placeholders: dropped the redundant `f` prefix. - `F403`/`F405` star imports: every `from module import *` is expanded into explicit imports of the names actually used, taken from each name's real origin, so stdlib/third-party names import from their real source rather than through a test "convenience bundle". The now-empty `tests/integration/helpers/kafka/common_direct.py` bundle is removed and its three remaining consumers import `_VarintBytes`/`KafkaAdminClient` directly. Eliminating the star imports surfaced a real bug the wildcard had masked from `F821`: `generate_presets.py` in `test_prometheus_protocols` called an undefined `execute_instant_query_with_http_api`; fixed to the existing `execute_query_via_http_api`. No `black`/`isort` reformatting was applied (neither is enforced in the style check), so the diff is limited to the lint fixes themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
61 lines
1.5 KiB
Python
61 lines
1.5 KiB
Python
# Tag no-fasttest: requires S3
|
|
|
|
|
|
import pytest
|
|
|
|
from helpers.cluster import ClickHouseCluster
|
|
|
|
cluster = ClickHouseCluster(__file__)
|
|
|
|
replica1 = cluster.add_instance(
|
|
"replica1",
|
|
with_zookeeper=True,
|
|
main_configs=["configs/remote_servers.xml"],
|
|
macros={"shard": "shard1", "replica": "replica1"},
|
|
)
|
|
replica2 = cluster.add_instance(
|
|
"replica2",
|
|
with_zookeeper=True,
|
|
main_configs=["configs/remote_servers.xml"],
|
|
macros={"shard": "shard1", "replica": "replica2"},
|
|
)
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def start_cluster():
|
|
try:
|
|
cluster.start()
|
|
yield cluster
|
|
except Exception as ex:
|
|
print(ex)
|
|
finally:
|
|
cluster.shutdown()
|
|
|
|
|
|
def test_replicated_detach_table(start_cluster):
|
|
replica1.query("DROP DATABASE IF EXISTS db ON CLUSTER test_cluster SYNC")
|
|
replica1.query(
|
|
"CREATE DATABASE db ON CLUSTER test_cluster ENGINE=Replicated('/clickhouse/tables/db/test_replicated_table', '{shard}', '{replica}');"
|
|
)
|
|
|
|
replica1.query_with_retry(
|
|
"""
|
|
CREATE TABLE db.test_replicated_table
|
|
(
|
|
number UInt64
|
|
)
|
|
ENGINE=ReplicatedMergeTree
|
|
ORDER BY number
|
|
"""
|
|
)
|
|
replica1.query(
|
|
"INSERT INTO db.test_replicated_table SELECT number FROM system.numbers LIMIT 6;"
|
|
)
|
|
replica1.query(
|
|
"SYSTEM SYNC REPLICA db.test_replicated_table;",
|
|
timeout=20,
|
|
)
|
|
replica1.query("DETACH TABLE db.test_replicated_table PERMANENTLY;")
|
|
|
|
replica1.query("DROP DATABASE db ON CLUSTER test_cluster SYNC")
|