Files
Alexey MilovidovandClaude Opus 4.8 295ced78d1 Enable more Ruff checks (F401/F403/F405/F541/F841) and clean up tests
Follow-up to #105171, which added `ruff` with a deliberately narrow,
bug-class-only rule set and left the unused-name and star-import rules
off pending a dedicated cleanup pass. This enables that second batch in
`pyproject.toml` and fixes every violation across the tree (the bulk in
integration tests):

- `F401` unused-import and `F841` unused-variable: removed, preserving
  any side-effecting right-hand side (e.g. `result = node.query(...)`
  becomes `node.query(...)`). Two `try: import ...` feature probes are
  kept with `# noqa: F401`.
- `F541` f-string-missing-placeholders: dropped the redundant `f` prefix.
- `F403`/`F405` star imports: every `from module import *` is expanded
  into explicit imports of the names actually used, taken from each
  name's real origin, so stdlib/third-party names import from their real
  source rather than through a test "convenience bundle". The now-empty
  `tests/integration/helpers/kafka/common_direct.py` bundle is removed and
  its three remaining consumers import `_VarintBytes`/`KafkaAdminClient`
  directly.

Eliminating the star imports surfaced a real bug the wildcard had masked
from `F821`: `generate_presets.py` in `test_prometheus_protocols` called
an undefined `execute_instant_query_with_http_api`; fixed to the existing
`execute_query_via_http_api`.

No `black`/`isort` reformatting was applied (neither is enforced in the
style check), so the diff is limited to the lint fixes themselves.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
2026-06-18 23:22:25 +00:00

32 lines
1.2 KiB
Python

from keeper.faults.registry import register_fault
from keeper.framework.core.settings import DEFAULT_FAULT_DURATION_S
from keeper.framework.core.util import for_each_target, sh_strict
def cpu_hog(node, seconds=60):
# Run blocking (same pattern as mem_hog_block): sh_strict returns after timeout expires.
# Backgrounding with & left the CPU-burning process running with no cleanup path.
sh_strict(node, f"timeout {seconds} sh -c 'while :; do :; done'", timeout=seconds + 10)
def mem_hog_block(node, mb=512, seconds=60):
sh_strict(
node,
f"python3 - <<'PY'\nimport time\n_ = bytearray({int(max(1, mb))}*1024*1024)\ntime.sleep({int(max(1, seconds))})\nPY",
timeout=int(max(30, seconds + 30)),
)
@register_fault("cpu_hog")
def _f_cpu_hog(ctx, nodes, leader, step):
secs = int(step.get("seconds") or DEFAULT_FAULT_DURATION_S)
for_each_target(step, nodes, leader, lambda t: cpu_hog(t, secs))
@register_fault("mem_hog")
def _f_mem_hog(ctx, nodes, leader, step):
mb = int(step.get("mb") or 512)
secs = int(step.get("seconds") or DEFAULT_FAULT_DURATION_S)
for_each_target(step, nodes, leader, lambda t: mem_hog_block(t, mb, secs))