Two corrections on top of the naming pass, both found by checking the live
cluster rather than the source.
The rename had silently changed the user-facing annotation key from
argocd.argoproj.io/sync-wave to cd.argoproj.io/sync-wave — 63 live
Applications carry the old key, so deploying that would have ignored every
sync-wave and broken fleet deploy ordering. The key is now cd.hanzo.ai/*,
and universe 575650286 moves the ApplicationSet template that stamps it, so
the controller regenerates all 63 consistently.
The API group in code said argoproj.io/v1alpha1 in 157 places while the
cluster has served apps.hanzo.ai/v1alpha1 since 2026-07-23 (the CRDs are
applications.apps.hanzo.ai). Code now matches what is actually served.
The legacy applications.argoproj.io/app-name label had ZERO live users, so it
went with the rest. foo.argoproj.io test fixtures became foo.example.com —
arbitrary test domains should not carry a vendor name.
go build ./... exit 0.
Co-authored-by: Hanzo Dev <[email protected]>
Every command is cd-*: cd, cd-server, cd-repo-server,
cd-application-controller, cd-applicationset-controller, cd-cmp-server,
cd-commit-server, cd-dex, cd-git-ask-pass, cd-k8s-auth, cd-notification.
util/argo is util/cd; util/notification/argocd is util/notification/cd.
Preserved deliberately: github.com/argoproj/argocd-example-apps is an
EXTERNAL repo used as an e2e fixture, and notifications-engine + pkg/v2 are
real dependencies. Renaming a URL we do not own would break the tests.
Two bugs I made and caught, both from a careless sed:
- s/argo/cd/g turned 'argocd' into 'cdcd' in two directory names
- renaming the package declaration left every call site saying argo.X
go build ./... exit 0.
Co-authored-by: Hanzo Dev <[email protected]>
The fork was already ours everywhere that matters — our image, our IAM (dex
is not deployed), hanzo kv behind what the env still called REDIS. Only the
vocabulary was upstream's: ARGOCD_* across the Go, the manifests, the docs
and the plugin contract, and mkdocs still titled 'Argo CD' pointing at
argoproj/argo-cd.
ARGOCD_ -> CD_ and REDIS_ -> KV_ across 345 files, plus the 8 e2e/cmp
fixtures that assert the plugin env contract — those had to move with the
binary, which now emits CD_APP_NAME where they expected ARGOCD_APP_NAME.
Left alone deliberately, because renaming them would be wrong:
- util/helm/testdata/redis/ and gitops-engine/.../statefulset*.yaml are
fixtures for a THIRD-PARTY chart named redis, not our config
- util/kustomize/testdata/ likewise
- generated.proto regenerates from types.go, which is already clean
go build ./... exit 0.
LOCKSTEP: the live StatefulSet sets 47 ARGOCD_* names the binary no longer
reads. universe 4a5375735 carries the matching manifest change; they deploy
together or the controller falls back to defaults.
Co-authored-by: Hanzo Dev <[email protected]>
* self service notification
Signed-off-by: May Zhang <[email protected]>
* revert back the changes for redis-ha
Signed-off-by: May Zhang <[email protected]>
* revert back the changes for redis-ha
Signed-off-by: May Zhang <[email protected]>
* update notification engine
Signed-off-by: May Zhang <[email protected]>
* re-trigger build
Signed-off-by: May Zhang <[email protected]>
* self service notification
Signed-off-by: May Zhang <[email protected]>
* revert back the changes for redis-ha
Signed-off-by: May Zhang <[email protected]>
* revert back the changes for redis-ha
Signed-off-by: May Zhang <[email protected]>
* update notification engine
Signed-off-by: May Zhang <[email protected]>
* re-trigger build
Signed-off-by: May Zhang <[email protected]>
* fix conflict
Signed-off-by: May Zhang <[email protected]>
* fix conflict
Signed-off-by: May Zhang <[email protected]>
* fix conflict
Signed-off-by: May Zhang <[email protected]>
* fix conflict
Signed-off-by: May Zhang <[email protected]>
* update notification enginer version
Signed-off-by: May Zhang <[email protected]>
* update notification enginer version
Signed-off-by: May Zhang <[email protected]>
* fixing go tidy
Signed-off-by: May Zhang <[email protected]>
* fixing go tidy
Signed-off-by: May Zhang <[email protected]>
* fixing go tidy
Signed-off-by: May Zhang <[email protected]>
* fixing go tidy
Signed-off-by: May Zhang <[email protected]>
* fixing go tidy
Signed-off-by: May Zhang <[email protected]>
* add back checkAppNotInAdditionalNamespaces
Signed-off-by: May Zhang <[email protected]>
* add cm and secret to clusterRole
Signed-off-by: May Zhang <[email protected]>
* if applicationNamespaces is not used, then use namespaced appClient
Signed-off-by: May Zhang <[email protected]>
* fix merge conflict
Signed-off-by: May Zhang <[email protected]>
* fix doc and test based on review
Signed-off-by: May Zhang <[email protected]>
* self service notification
Signed-off-by: May Zhang <[email protected]>
* revert back the changes for redis-ha
Signed-off-by: May Zhang <[email protected]>
* revert back the changes for redis-ha
Signed-off-by: May Zhang <[email protected]>
* update notification engine
Signed-off-by: May Zhang <[email protected]>
* re-trigger build
Signed-off-by: May Zhang <[email protected]>
* fix conflict
Signed-off-by: May Zhang <[email protected]>
* self service notification
Signed-off-by: May Zhang <[email protected]>
* revert back the changes for redis-ha
Signed-off-by: May Zhang <[email protected]>
* revert back the changes for redis-ha
Signed-off-by: May Zhang <[email protected]>
* update notification engine
Signed-off-by: May Zhang <[email protected]>
* re-trigger build
Signed-off-by: May Zhang <[email protected]>
* fix conflict
Signed-off-by: May Zhang <[email protected]>
* fix conflict
Signed-off-by: May Zhang <[email protected]>
* fix conflict
Signed-off-by: May Zhang <[email protected]>
* update notification enginer version
Signed-off-by: May Zhang <[email protected]>
* update notification enginer version
Signed-off-by: May Zhang <[email protected]>
* fixing go tidy
Signed-off-by: May Zhang <[email protected]>
* fixing go tidy
Signed-off-by: May Zhang <[email protected]>
* fixing go tidy
Signed-off-by: May Zhang <[email protected]>
* fixing go tidy
Signed-off-by: May Zhang <[email protected]>
* fixing go tidy
Signed-off-by: May Zhang <[email protected]>
* add back checkAppNotInAdditionalNamespaces
Signed-off-by: May Zhang <[email protected]>
* add cm and secret to clusterRole
Signed-off-by: May Zhang <[email protected]>
* if applicationNamespaces is not used, then use namespaced appClient
Signed-off-by: May Zhang <[email protected]>
* fix doc and test based on review
Signed-off-by: May Zhang <[email protected]>
* disable defining and using secrets within notification templates for self-service
Signed-off-by: May Zhang <[email protected]>
* tweaks
Signed-off-by: Michael Crenshaw <[email protected]>
* fix docs formatting
Signed-off-by: Michael Crenshaw <[email protected]>
* more docs and Procfile update for local run convenience
Signed-off-by: Michael Crenshaw <[email protected]>
---------
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
* Allow notifications controller to notify on all namespaces
This adds functionality to the notifications controller to be notified
of and send notifications for applications in any namespace. The
namespaces to watch are controlled by the same --application-namespaces
and ARGOCD_APPLICATION_NAMESPACES variables as in the application
controller.
Signed-off-by: Nikolas Skoufis <[email protected]>
* Add SEEK to users.md
Signed-off-by: Nikolas Skoufis <[email protected]>
* Remove unused fields
Signed-off-by: Nikolas Skoufis <[email protected]>
* Revert changes to Procfile
Signed-off-by: Nik Skoufis <[email protected]>
* Fix unit tests
Signed-off-by: Nikolas Skoufis <[email protected]>
* - add argocd namespaces environment variable to notifications controller
Signed-off-by: Stewart Thomson <[email protected]>
* - add example cluster role rbac
Signed-off-by: Stewart Thomson <[email protected]>
* - only look for projects in the controller's namespace (argocd by default)
Signed-off-by: Stewart Thomson <[email protected]>
* - update base manifest
Signed-off-by: Stewart Thomson <[email protected]>
* - skip app processing in notification controller
Signed-off-by: Stewart Thomson <[email protected]>
* added unit test and updated doc
Signed-off-by: May Zhang <[email protected]>
* added unit test and updated doc
Signed-off-by: May Zhang <[email protected]>
* updated examples/k8s-rbac/argocd-server-applications/kustomization.yaml's resources
Signed-off-by: May Zhang <[email protected]>
---------
Signed-off-by: Nikolas Skoufis <[email protected]>
Signed-off-by: Nik Skoufis <[email protected]>
Signed-off-by: Stewart Thomson <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Co-authored-by: Nikolas Skoufis <[email protected]>
Co-authored-by: Nik Skoufis <[email protected]>
Co-authored-by: Stewart Thomson <[email protected]>
* feat: parameterized CMPs
Signed-off-by: Michael Crenshaw <[email protected]>
* values types for parameters
Signed-off-by: Michael Crenshaw <[email protected]>
* Add types for CMP announcement
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* Reorg
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* finish type
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* First pass at working GetParametersAnnouncement
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* Typos
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* Make all fields optional
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* Make sure response makes it to repo server
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* Refactor for testing
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* lint
Signed-off-by: Michael Crenshaw <[email protected]>
* send build env to param announcement gen
Signed-off-by: Michael Crenshaw <[email protected]>
* test parameter announcement
Signed-off-by: Michael Crenshaw <[email protected]>
* tests
Signed-off-by: Michael Crenshaw <[email protected]>
* environ tests
Signed-off-by: Michael Crenshaw <[email protected]>
* Rename workdir to app dir
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* handle empty command, start ui work (#11)
* Add types for CMP announcement
Signed-off-by: zachaller <[email protected]>
* Reorg
Signed-off-by: zachaller <[email protected]>
* finish type
Signed-off-by: zachaller <[email protected]>
* First pass at working GetParametersAnnouncement
Signed-off-by: zachaller <[email protected]>
* Typos
Signed-off-by: zachaller <[email protected]>
* Make all fields optional
Signed-off-by: zachaller <[email protected]>
* Make sure response makes it to repo server
Signed-off-by: zachaller <[email protected]>
* Refactor for testing
Signed-off-by: zachaller <[email protected]>
* values types for parameters
Signed-off-by: Michael Crenshaw <[email protected]>
* lint
Signed-off-by: Michael Crenshaw <[email protected]>
* send build env to param announcement gen
Signed-off-by: Michael Crenshaw <[email protected]>
* test parameter announcement
* tests
Signed-off-by: Michael Crenshaw <[email protected]>
* environ tests
Signed-off-by: Michael Crenshaw <[email protected]>
* Rename workdir to app dir
Signed-off-by: zachaller <[email protected]>
* handle empty command, start ui work
Signed-off-by: Michael Crenshaw <[email protected]>
* fix order
Signed-off-by: Michael Crenshaw <[email protected]>
* fix map merging, make params read-only
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: zachaller <[email protected]>
* Add helm PoC example plugin
Signed-off-by: zachaller <[email protected]>
* example as kustomize overlay
Signed-off-by: Michael Crenshaw <[email protected]>
* Parameterized cmps docs (#12)
* use printf instead of echo
Signed-off-by: Michael Crenshaw <[email protected]>
* docs
Signed-off-by: Michael Crenshaw <[email protected]>
* test for temp dir cleanup
Signed-off-by: Michael Crenshaw <[email protected]>
* handle empty params
Signed-off-by: Michael Crenshaw <[email protected]>
* handle empty values
Signed-off-by: Michael Crenshaw <[email protected]>
* consolidate types
Signed-off-by: Michael Crenshaw <[email protected]>
* fix tests
Signed-off-by: Michael Crenshaw <[email protected]>
* docs
Signed-off-by: Michael Crenshaw <[email protected]>
* docs
Signed-off-by: Michael Crenshaw <[email protected]>
* remove duplicate info
Signed-off-by: Michael Crenshaw <[email protected]>
* add warning about param announcements vs param values
Signed-off-by: Michael Crenshaw <[email protected]>
* tests (#13)
Signed-off-by: Michael Crenshaw <[email protected]>
* tests
Signed-off-by: Michael Crenshaw <[email protected]>
* fix types
Signed-off-by: Michael Crenshaw <[email protected]>
* fix test
Signed-off-by: Michael Crenshaw <[email protected]>
* fix codegen
Signed-off-by: Michael Crenshaw <[email protected]>
* fix codegen
Signed-off-by: Michael Crenshaw <[email protected]>
* revert test hack
Signed-off-by: Michael Crenshaw <[email protected]>
* docs correction
Signed-off-by: Michael Crenshaw <[email protected]>
* fix indentation
Signed-off-by: Michael Crenshaw <[email protected]>
* fix spacing
Signed-off-by: CI <[email protected]>
* move util function to util file and add test
Signed-off-by: CI <[email protected]>
* wrap error
Signed-off-by: CI <[email protected]>
* correct version number
Signed-off-by: CI <[email protected]>
* document necessity of collectionType param
Signed-off-by: CI <[email protected]>
* remove part of error message that's not useful (dir name is now randomized)
Signed-off-by: CI <[email protected]>
* fix things so that they are not broken
Signed-off-by: CI <[email protected]>
* don't close file before caller gets a chance to use it
Signed-off-by: CI <[email protected]>
* codegen
Signed-off-by: Michael Crenshaw <[email protected]>
* fix test
Signed-off-by: Michael Crenshaw <[email protected]>
* comments
Signed-off-by: Michael Crenshaw <[email protected]>
* fix test
Signed-off-by: Michael Crenshaw <[email protected]>
* DON'T PANIC
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: CI <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: zachaller <[email protected]>
* Template Out Hardcoded Prometheus Data Source
* This allows monitoring Argo CD deployed on different Promethei
Change-Id: I89a326865c30515716c78f9485fa91769dc9fe4c
* Take into account number of unavailable replicas to decided if deployment is healthy or not
* Run one controller for all e2e tests to reduce tests duration
* Apply reviewer notes: use logic from kubectl/rollout_status.go to check deployment health
zeekayandHanzo Dev