Michael Crenshaw and GitHub
a1f4e6c6b3
fix(hydrator): normalize repo URL when grouping ( #23564 ) ( #23565 )
...
Signed-off-by: Michael Crenshaw <[email protected] >
2025-07-01 16:33:04 +00:00
Michael Crenshaw and GitHub
ba889a0c86
feat: source hydrator ( #20345 )
...
* feat(hydrator): add sourceHydrator types
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
fix(codegen): use kube_codegen.sh deepcopy and client gen correctly
Signed-off-by: Michael Crenshaw <[email protected] >
deepcopy gen
Signed-off-by: Michael Crenshaw <[email protected] >
* feat(hydrator): add commit-server component
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
go mod tidy
Signed-off-by: Michael Crenshaw <[email protected] >
one test file for both implementations
Signed-off-by: Michael Crenshaw <[email protected] >
simplify
Signed-off-by: Michael Crenshaw <[email protected] >
fix test for linux
Signed-off-by: Michael Crenshaw <[email protected] >
fix git client mock
Signed-off-by: Michael Crenshaw <[email protected] >
fix git client mock
Signed-off-by: Michael Crenshaw <[email protected] >
address comments
Signed-off-by: Michael Crenshaw <[email protected] >
unit tests
Signed-off-by: Michael Crenshaw <[email protected] >
lint
Signed-off-by: Michael Crenshaw <[email protected] >
fix image, fix health checks, fix merge issue
Signed-off-by: Michael Crenshaw <[email protected] >
fix lint issues
Signed-off-by: Michael Crenshaw <[email protected] >
remove code that doesn't work for GHE
Signed-off-by: Michael Crenshaw <[email protected] >
changes from comments
Signed-off-by: Michael Crenshaw <[email protected] >
* feat(hydrator): enable controller
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
feat(hydrator): enable controller
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
allow opt-in
Signed-off-by: Michael Crenshaw <[email protected] >
separation between app controller and hydrator
Signed-off-by: Michael Crenshaw <[email protected] >
simplify diff
Signed-off-by: Michael Crenshaw <[email protected] >
todos
Signed-off-by: Michael Crenshaw <[email protected] >
simplify
Signed-off-by: Michael Crenshaw <[email protected] >
add dry sha to logs
Signed-off-by: Michael Crenshaw <[email protected] >
add app name to logs
Signed-off-by: Michael Crenshaw <[email protected] >
more logging, no caching
Signed-off-by: Michael Crenshaw <[email protected] >
fix cluster install
Signed-off-by: Michael Crenshaw <[email protected] >
don't interrupt an ongoing hydrate operation
Signed-off-by: Michael Crenshaw <[email protected] >
revert hydrate loop fix
Signed-off-by: Michael Crenshaw <[email protected] >
handle project-scoped repo creds
Signed-off-by: Michael Crenshaw <[email protected] >
codegen
Signed-off-by: Michael Crenshaw <[email protected] >
improve docs
Signed-off-by: Michael Crenshaw <[email protected] >
fixes from comments
Signed-off-by: Michael Crenshaw <[email protected] >
* set hydrator enabled key when using hydrator manifests
Signed-off-by: Michael Crenshaw <[email protected] >
fix manifests
Signed-off-by: Michael Crenshaw <[email protected] >
improve docs
Signed-off-by: Michael Crenshaw <[email protected] >
* feat(hydrator): enable controller
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
feat(hydrator): enable controller
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
allow opt-in
Signed-off-by: Michael Crenshaw <[email protected] >
separation between app controller and hydrator
Signed-off-by: Michael Crenshaw <[email protected] >
simplify diff
Signed-off-by: Michael Crenshaw <[email protected] >
todos
Signed-off-by: Michael Crenshaw <[email protected] >
simplify
Signed-off-by: Michael Crenshaw <[email protected] >
add dry sha to logs
Signed-off-by: Michael Crenshaw <[email protected] >
add app name to logs
Signed-off-by: Michael Crenshaw <[email protected] >
more logging, no caching
Signed-off-by: Michael Crenshaw <[email protected] >
fix cluster install
Signed-off-by: Michael Crenshaw <[email protected] >
don't interrupt an ongoing hydrate operation
Signed-off-by: Michael Crenshaw <[email protected] >
revert hydrate loop fix
Signed-off-by: Michael Crenshaw <[email protected] >
handle project-scoped repo creds
Signed-off-by: Michael Crenshaw <[email protected] >
codegen
Signed-off-by: Michael Crenshaw <[email protected] >
improve docs
Signed-off-by: Michael Crenshaw <[email protected] >
fixes from comments
Signed-off-by: Michael Crenshaw <[email protected] >
* feat(hydrator): add sourceHydrator types
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
fix(codegen): use kube_codegen.sh deepcopy and client gen correctly
Signed-off-by: Michael Crenshaw <[email protected] >
deepcopy gen
Signed-off-by: Michael Crenshaw <[email protected] >
* feat(hydrator): enable controller
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
feat(hydrator): enable controller
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
allow opt-in
Signed-off-by: Michael Crenshaw <[email protected] >
separation between app controller and hydrator
Signed-off-by: Michael Crenshaw <[email protected] >
simplify diff
Signed-off-by: Michael Crenshaw <[email protected] >
todos
Signed-off-by: Michael Crenshaw <[email protected] >
simplify
Signed-off-by: Michael Crenshaw <[email protected] >
add dry sha to logs
Signed-off-by: Michael Crenshaw <[email protected] >
add app name to logs
Signed-off-by: Michael Crenshaw <[email protected] >
more logging, no caching
Signed-off-by: Michael Crenshaw <[email protected] >
fix cluster install
Signed-off-by: Michael Crenshaw <[email protected] >
don't interrupt an ongoing hydrate operation
Signed-off-by: Michael Crenshaw <[email protected] >
revert hydrate loop fix
Signed-off-by: Michael Crenshaw <[email protected] >
handle project-scoped repo creds
Signed-off-by: Michael Crenshaw <[email protected] >
codegen
Signed-off-by: Michael Crenshaw <[email protected] >
* feat(hydrator): write credentials handling + UI
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
feat(hydrator): enable controller
Co-authored-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Omer Azmon <[email protected] >
Co-authored-by: daengdaengLee <[email protected] >
Co-authored-by: Juwon Hwang (Kevin) <[email protected] >
Co-authored-by: thisishwan2 <[email protected] >
Co-authored-by: mirageoasis <[email protected] >
Co-authored-by: Robin Lieb <[email protected] >
Co-authored-by: miiiinju1 <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
allow opt-in
Signed-off-by: Michael Crenshaw <[email protected] >
separation between app controller and hydrator
Signed-off-by: Michael Crenshaw <[email protected] >
simplify diff
Signed-off-by: Michael Crenshaw <[email protected] >
todos
Signed-off-by: Michael Crenshaw <[email protected] >
simplify
Signed-off-by: Michael Crenshaw <[email protected] >
add dry sha to logs
Signed-off-by: Michael Crenshaw <[email protected] >
add app name to logs
Signed-off-by: Michael Crenshaw <[email protected] >
more logging, no caching
Signed-off-by: Michael Crenshaw <[email protected] >
fix cluster install
Signed-off-by: Michael Crenshaw <[email protected] >
don't interrupt an ongoing hydrate operation
Signed-off-by: Michael Crenshaw <[email protected] >
revert hydrate loop fix
Signed-off-by: Michael Crenshaw <[email protected] >
feat(hydrator): write credentials handling + UI
Signed-off-by: Michael Crenshaw <[email protected] >
WIP: add new APIs for write creds
Signed-off-by: Michael Crenshaw <[email protected] >
write api and template api
Signed-off-by: Michael Crenshaw <[email protected] >
fix time function
Signed-off-by: Michael Crenshaw <[email protected] >
fix lint issues
Signed-off-by: Michael Crenshaw <[email protected] >
don't enrich with read creds
Signed-off-by: Michael Crenshaw <[email protected] >
revert tls change
Signed-off-by: Michael Crenshaw <[email protected] >
don't disable buttons in UI
Signed-off-by: Michael Crenshaw <[email protected] >
ask repo server for specific revision
Signed-off-by: Michael Crenshaw <[email protected] >
fixes
Signed-off-by: Michael Crenshaw <[email protected] >
lint ui
Signed-off-by: Michael Crenshaw <[email protected] >
remove unnecessary change
Signed-off-by: Michael Crenshaw <[email protected] >
fix test and lint
Signed-off-by: Michael Crenshaw <[email protected] >
lint
Signed-off-by: Michael Crenshaw <[email protected] >
enable hydrator for e2e tests
Signed-off-by: Michael Crenshaw <[email protected] >
* free disk space for e2e tests
Signed-off-by: Michael Crenshaw <[email protected] >
don't free disk space
Signed-off-by: Michael Crenshaw <[email protected] >
* free disk space for e2e tests
Signed-off-by: Michael Crenshaw <[email protected] >
* remove comment that breaks auth
Signed-off-by: Michael Crenshaw <[email protected] >
* try removing extra function
Signed-off-by: Michael Crenshaw <[email protected] >
* cleanup from comments
Signed-off-by: Michael Crenshaw <[email protected] >
* fix test
Signed-off-by: Michael Crenshaw <[email protected] >
---------
Signed-off-by: Michael Crenshaw <[email protected] >
2024-12-16 16:59:09 -05:00
Andrii Korotkov and GitHub
3966e4fda2
fix: Allow to delete repos with invalid urls ( #20921 ) ( #20975 )
...
* fix: Allow to delete repos with invalid urls (#20921 )
Fixes #20921
Normalization of repo url is attempted during repo deletion before comparison with existing repos. Before this change, it'd fail on invalid urls and return "", resulting in permission denied. This ended up in a state where people can add repos with invalid urls but couldn't delete them. Return raw repo url if url parsing failed. Add a test to validate the deletion can be performed and make sure it fails without the main change.
This needs to be cherry-picked to v2.11-2.13
Signed-off-by: Andrii Korotkov <[email protected] >
* Don't modify the original NormalizeGitURL
Signed-off-by: Andrii Korotkov <[email protected] >
---------
Signed-off-by: Andrii Korotkov <[email protected] >
2024-12-02 14:00:35 +02:00
Nathanael Liechti and GitHub
626f237eb2
feat: allow no_proxy to be specified on repoCreds ( #18526 )
...
Signed-off-by: Nathanael Liechti <[email protected] >
2024-08-20 12:54:39 -04:00
satoru and GitHub
67a6f1411e
chore: just use strings.TrimSuffix ( #14248 )
...
It's implemented in the same way in the standard library.
Signed-off-by: satoru <[email protected] >
2023-06-28 09:46:49 -04:00
Chetan Banavikalmutt and GitHub
f89cd78a34
feat: add first class support to access repositories using proxy ( #5581 ) ( #6286 )
...
* feat: add first class support to access repositories using proxy
Currently, users need to set the proxy URLs as env variables in the repo server. This is not user-friendly and also error-prone. This PR adds support to maintain proxy URLs along with repository configs in the argocd-cm. Argo CD uses this proxy to access your repository. In case the custom proxy is absent, it defaults to reading the proxy from the env variables.
Signed-off-by: Chetan Banavikalmutt <[email protected] >
* set both http & https proxy variables
Signed-off-by: Chetan Banavikalmutt <[email protected] >
2021-06-16 14:45:10 +02:00
jannfis and GitHub
8f55931d34
fix: Handle SSH URLs in 'git@server:org/repo' notation correctly ( #3062 )
...
* Handle invalid repo URLs better
* Safeguard Git repository root at client creation
2020-01-31 01:14:22 -08:00
jannfis and Alex Collins
04ea46e86b
Allow '@'-character in SSH usernames when connecting a repository ( #2612 )
2019-11-01 11:03:28 -07:00
Alexander Matyushentsev and GitHub
c8c2d1b97c
Refactor Helm client and unit test repo server ( #2377 )
2019-09-30 15:04:13 -07:00
Alexander Matyushentsev and GitHub
2559d184ae
Issue #2261 - Refactor Helm first class support ( #2364 )
...
* Issue #2261 - Refactor Helm first class support
* Address code review comments
* Remove unused field from GetAppDetails method
2019-09-26 12:05:12 -07:00
Alex Collins and GitHub
206cc78710
Adds support for Helm 1st-class. Closes #1145 ( #1865 )
2019-09-06 15:37:25 -07:00
jannfis and Alexander Matyushentsev
05a9e826de
Add support for Git LFS enabled repositories ( fixes #1853 ) ( #1941 )
...
* Add support for LFS enabled repositories
2019-07-18 12:49:49 -07:00
Alexander Matyushentsev and GitHub
28005f0517
Issues #1513 - Make sure insecure flag works for remote Kustomize bases ( #1934 )
...
* Make sure insecure flag works for remote Kustomize bases
2019-07-12 17:17:23 -07:00
jannfis and Alex Collins
ee0a665c94
Simplify server certificate and known hosts management ( #1807 )
2019-07-11 16:00:47 -07:00
Alexander Matyushentsev and GitHub
7fd4db3842
Issue #1596 - SSH URLs support is partially broken ( #1597 )
2019-05-09 08:53:11 -07:00
Jesse Suen and GitHub
da604ab2ed
Git cloning via SSH was not verifying host public key ( #1276 )
2019-03-15 14:29:10 -07:00
Jesse Suen and GitHub
4142b5b79e
Remove git URL normalization in favor of fuzzy equivalence (issue #838 ) ( #849 )
2018-11-30 10:41:47 -08:00
Jesse Suen and Jesse Suen
1a828e8287
Switch to go-git for all remote git interactions including auth (issue #651 )
2018-09-27 12:48:23 -07:00
Jesse Suen and GitHub
78558ac62f
Do not append .git extension during normalization for Azure hosted git (issue #643 ) ( #645 )
2018-09-27 11:54:04 -07:00
Jesse Suen and GitHub
7eca8c892a
Trim git url during normalization (issue #614 ) ( #623 )
2018-09-20 16:26:17 -07:00
Jesse Suen and GitHub
b61d7166b1
In-memory implementation of ls-remote using go-git to reduce repo lock contention ( #574 )
2018-09-11 13:53:51 -07:00
dthomson25 and GitHub
0f9cdd14e8
Create default project on startup ( #535 )
...
Implements to solve issue #514
2018-08-28 10:06:01 -07:00
Jesse Suen and GitHub
e32d70a87d
If manifest query is a commit sha, check cache first to prevent locking git repo ( #382 )
2018-07-12 04:15:12 -07:00
Jesse Suen and GitHub
f757693aae
Fix git authentication implementation when using using SSH key ( resolves #339 ) ( #362 )
2018-07-10 10:50:56 -07:00
Jesse Suen
9476003b8d
Remove local git credential test to prevent clobbering of OSX keychain credentials ( resolves #315 )
2018-06-24 03:39:05 -07:00
Alexander Matyushentsev and GitHub
8c2ff6d421
Take into account number of unavailable replicas to decided if deployment is healthy or not ( #270 )
...
* Take into account number of unavailable replicas to decided if deployment is healthy or not
* Run one controller for all e2e tests to reduce tests duration
* Apply reviewer notes: use logic from kubectl/rollout_status.go to check deployment health
2018-06-07 11:05:46 -07:00
Jesse Suen and GitHub
35563f0765
Add connect timeouts when interacting with SSH git repos ( resolves #131 ) ( #203 )
2018-05-15 10:30:31 -07:00
Andrew Merenbach and GitHub
d1710ef77e
Expand Git repo URL normalization ( #162 )
...
* Expand unit tests for Git functions
* Update tests for IsSSHUrl
* Add TODO
* Add EnsureSuffix tests
* Add EnsureSuffix function
* Lowercase repo name in secret name
* Expand normalization and related tests
* Add tests for EnsurePrefix
* Rm redundant strings.ToLower
* Update repository names to fix broken tests
* Expand tests some more to include missing .git suffix, thanks @jessesuen
* Add additional repository tests, thanks @jessesuen
* Fix typo in comment
2018-05-04 17:31:04 -07:00
Jesse Suen and Jesse Suen
11395b3844
Add application validation
2018-04-20 16:37:54 -07:00
Alexander Matyushentsev and GitHub
86aca45acf
Disable strict host key checking while cloning repo in repo-server ( #45 )
...
* Disable strict host key checking while cloning repo in repo-server
* Use correct environment during fetching git repo in repo-server
2018-03-20 11:52:42 -07:00
Alexander Matyushentsev and GitHub
2157134530
Issue #34 - Support ssh git URLs and ssh key authentication ( #37 )
...
* Issue #34 - Support ssh git URLs and ssh key authentication
* Add git unit tests
2018-03-15 13:00:54 -07:00
Jesse Suen
6afc03027d
Update to latest ksonnet with single destination. Fix linting errors. Update build container
2018-02-26 13:47:42 -08:00
Jesse Suen
a8288bf5b0
Support persistence of repos as secrets
2018-02-21 03:01:43 -08:00
Jesse Suen
f404f50f72
Add repository service, CLI subcommand, and backend implementation
2018-02-20 14:06:15 -08:00