Mike Cutsail and GitHub
60da71f608
feat: oidc background token refresh ( #23727 )
...
Signed-off-by: Mike Cutsail <[email protected] >
2025-11-13 11:37:53 -05:00
Nathanael Liechti and GitHub
60af0c2fd5
fix(oidc): check userinfo endpoint in AuthMiddleware ( #23586 )
...
Signed-off-by: Nathanael Liechti <[email protected] >
2025-10-06 09:22:47 -04:00
Matthieu MOREL and GitHub
c16ce981b9
chore: enable noctx linter ( #24765 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2025-09-29 20:20:53 +02:00
sathiya06 and GitHub
3e66f6c2d1
feat: Export metrics to track number of users ( #20801 ) ( #23343 )
...
Signed-off-by: Sathiya Narayanan Venkatesan <[email protected] >
Signed-off-by: sathiya06 <[email protected] >
2025-06-30 10:00:33 -07:00
c6bc92cf7a
chore: move OIDC PKCE support from UI to backend ( #21729 )
...
Signed-off-by: Yann Soubeyrand <[email protected] >
Signed-off-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Michael Crenshaw <[email protected] >
Co-authored-by: Alexandre Gaudreault <[email protected] >
2025-06-17 18:18:24 +00:00
Matthieu MOREL and GitHub
e6874ff246
chore(lint): enable ptrToRefParam rule from go-critic ( #23424 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2025-06-16 19:28:57 +00:00
Matthieu MOREL and GitHub
1920efe837
chore(lint): enable httpNoBody rule from go-critic ( #23399 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2025-06-15 16:11:38 -04:00
Michael Crenshaw and GitHub
1be75662b9
fix(server): race condition in revoked token logic ( #23311 ) ( #23312 )
...
Signed-off-by: Michael Crenshaw <[email protected] >
2025-06-06 16:49:59 -04:00
Michael Crenshaw and GitHub
24d690d040
fix(server): avoid unnecessary claims restrictions ( #22973 ) ( #23202 )
...
Signed-off-by: Michael Crenshaw <[email protected] >
2025-05-29 18:57:12 +00:00
Kanika Rana and GitHub
fc8411e9b8
chore: use name imports for argocd Utilio ( #22836 )
...
Signed-off-by: Kanika Rana <[email protected] >
2025-05-21 16:25:32 +00:00
Seth Gupton and GitHub
6cd6c3c41d
fix: Increase Scan count and move Scan outside of mutex lock to avoid slow calls timing out ( #17645 ) ( #21926 )
...
Signed-off-by: Seth Gupton <[email protected] >
2025-04-10 14:08:21 -07:00
7caee1cfbb
chore(ci): upgrade golangci-lint to v2 ( #22484 )
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <[email protected] >
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-27 12:37:52 -04:00
sivchari and GitHub
b97525c11e
chore: upgrade Go to 1.24 ( #22242 )
...
Signed-off-by: sivchari <[email protected] >
2025-03-10 10:14:41 -04:00
Andrii Korotkov and GitHub
f60ead34ca
fix: Use t.Fatal instead of os.Exit in tests (part 2) ( #21003 ) ( #22187 )
...
Signed-off-by: Andrii Korotkov <[email protected] >
2025-03-06 19:24:07 +00:00
893abf6730
fix(ui, rbac): project-roles ( #21829 )
...
Signed-off-by: wyttime04 <[email protected] >
Signed-off-by: Blake Pettersson <[email protected] >
Co-authored-by: wyttime04 <[email protected] >
2025-02-20 11:40:15 +01:00
Matthieu MOREL and GitHub
be13c7b8a8
chore: enable var-naming from revive ( #21861 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2025-02-18 11:02:38 -05:00
Matthieu MOREL and GitHub
2fa86b1259
chore: use testify instead of native testing ( #21781 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2025-02-05 09:46:52 -05:00
b15cd40f7f
fix: override sub with federated_claims.user_id when dex is used ( #20683 )
...
Signed-off-by: Atif Ali <[email protected] >
Signed-off-by: Alexandre Gaudreault <[email protected] >
Co-authored-by: Alexandre Gaudreault <[email protected] >
2025-01-30 10:06:36 -05:00
Matthieu MOREL and GitHub
dc58694282
chore: enable singleCaseSwitch and commentFormatting rules from gocritic ( #21616 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2025-01-22 10:45:32 -05:00
Matthieu MOREL and GitHub
eeba57b115
chore: enable nolintlint ( #21559 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2025-01-21 13:49:14 -05:00
8334da36f2
Bump major version to 3 ( #21410 )
...
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: crenshaw-dev <[email protected] >
2025-01-10 16:14:00 -05:00
Matthieu MOREL and GitHub
eec6f8526a
chore: enable unused-parameter from revive ( #21365 )
...
* chore: enable unused-parameter from revive
Signed-off-by: Matthieu MOREL <[email protected] >
* apply recommandations
Signed-off-by: Matthieu MOREL <[email protected] >
---------
Signed-off-by: Matthieu MOREL <[email protected] >
2025-01-07 10:12:56 -05:00
Matthieu MOREL and GitHub
a4a0120a98
chore: enable increment-decrement from revive ( #21366 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2025-01-03 22:45:03 +00:00
Matthieu MOREL and GitHub
7a212a833c
chore: enable use-any from revive ( #21282 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2025-01-02 18:26:59 -05:00
Matthieu MOREL and GitHub
fde63a265b
chore: use github.com/golang-jwt/jwt/v5 ( #21276 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2025-01-02 18:23:28 -05:00
Matthieu MOREL and GitHub
c85bb38a83
chore: enable errorf of perfsprint linter ( #21280 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2024-12-30 10:56:41 +02:00
Matthieu MOREL and GitHub
4156151f8f
chore: enable err-error and strconcat of perfsprint linter ( #21267 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2024-12-20 16:22:28 +00:00
13c8fbaf99
chore: Graceful shutdown for API Server ( #18642 ) ( #21224 )
...
* fix: Graceful shutdown for the API server (#18642 ) (#20981 )
* fix: Graceful shutdown for the API server (#18642 )
Closes #18642
Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating.
Signed-off-by: Andrii Korotkov <[email protected] >
Co-authored-by: Leonardo Luz Almeida <[email protected] >
Co-authored-by: Michael Crenshaw <[email protected] >
* Init server only once, but keep re-initializing listeners
Signed-off-by: Andrii Korotkov <[email protected] >
* Check error for SetParamInSettingConfigMap as needed after fresh master
Signed-off-by: Andrii Korotkov <[email protected] >
* Prevent a data race
Signed-off-by: Andrii Korotkov <[email protected] >
* Remove unused variable, don't pass lock when not necessary
Signed-off-by: Andrii Korotkov <[email protected] >
* Try overriding URL instead of additional URLs
Signed-off-by: Andrii Korotkov <[email protected] >
* Use a more specific url
Signed-off-by: Andrii Korotkov <[email protected] >
---------
Signed-off-by: Andrii Korotkov <[email protected] >
Co-authored-by: Leonardo Luz Almeida <[email protected] >
Co-authored-by: Michael Crenshaw <[email protected] >
* Use a custom signal for graceful restart
Signed-off-by: Andrii Korotkov <[email protected] >
* Re-run tests
Signed-off-by: Andrii Korotkov <[email protected] >
---------
Signed-off-by: Andrii Korotkov <[email protected] >
Co-authored-by: Leonardo Luz Almeida <[email protected] >
Co-authored-by: Michael Crenshaw <[email protected] >
2024-12-17 16:51:18 -05:00
Pasha Kostohrys and GitHub
cf2b59c529
Revert "fix: Graceful shutdown for the API server ( #18642 ) ( #20981 )" ( #21221 )
2024-12-17 18:56:00 +02:00
Michael Crenshaw and GitHub
a2ea49ba1b
chore: use new fake k8s client constructor ( #21186 )
...
Signed-off-by: Michael Crenshaw <[email protected] >
2024-12-16 14:49:30 +05:30
Joowon Lim and GitHub
de27f89003
chore: use %q to simplify fmt.Sprintf ( #21108 )
...
Signed-off-by: Joowon Lim <[email protected] >
2024-12-09 13:52:32 -05:00
4ccaaadeac
fix: Graceful shutdown for the API server ( #18642 ) ( #20981 )
...
* fix: Graceful shutdown for the API server (#18642 )
Closes #18642
Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating.
Signed-off-by: Andrii Korotkov <[email protected] >
Co-authored-by: Leonardo Luz Almeida <[email protected] >
Co-authored-by: Michael Crenshaw <[email protected] >
* Init server only once, but keep re-initializing listeners
Signed-off-by: Andrii Korotkov <[email protected] >
* Check error for SetParamInSettingConfigMap as needed after fresh master
Signed-off-by: Andrii Korotkov <[email protected] >
* Prevent a data race
Signed-off-by: Andrii Korotkov <[email protected] >
* Remove unused variable, don't pass lock when not necessary
Signed-off-by: Andrii Korotkov <[email protected] >
* Try overriding URL instead of additional URLs
Signed-off-by: Andrii Korotkov <[email protected] >
* Use a more specific url
Signed-off-by: Andrii Korotkov <[email protected] >
---------
Signed-off-by: Andrii Korotkov <[email protected] >
Co-authored-by: Leonardo Luz Almeida <[email protected] >
Co-authored-by: Michael Crenshaw <[email protected] >
2024-12-03 15:32:26 -05:00
Matthieu MOREL and GitHub
8d7dd843b0
chore: use testify instead of testing.Fatal or testing.Error in util ( #20751 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2024-11-11 17:55:11 +02:00
Matthieu MOREL and GitHub
478219ef2e
chore: enable perfsprint linter ( #20685 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2024-11-10 21:00:57 -05:00
Matthieu MOREL and GitHub
6fecf70f92
chore: enable usestdlibvars linter ( #20399 )
2024-10-16 07:54:00 -04:00
Matthieu MOREL and GitHub
4f6f65afb1
fix: use ErrorContains(t, err instead of Contains(t, err.Error() ( #20220 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2024-10-04 09:36:05 -04:00
Matthieu MOREL and GitHub
24d8f10000
chore: extend require-error rule from testifylint ( #18658 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2024-06-14 09:15:31 -04:00
Matthieu MOREL and GitHub
e1c8779ad8
chore: enable gocritic linter ( #18633 )
...
* chore: enable gocritic linter
Signed-off-by: Matthieu MOREL <[email protected] >
* Update settings.go
Signed-off-by: Matthieu MOREL <[email protected] >
* Update app.go
Signed-off-by: Matthieu MOREL <[email protected] >
* Update grpcproxy.go
Signed-off-by: Matthieu MOREL <[email protected] >
* Update grpcproxy.go
Signed-off-by: Matthieu MOREL <[email protected] >
* Update util.go
Signed-off-by: Matthieu MOREL <[email protected] >
* Update server.go
Signed-off-by: Matthieu MOREL <[email protected] >
* Update app_management_ns_test.go
Signed-off-by: Matthieu MOREL <[email protected] >
* Update app_management_test.go
Signed-off-by: Matthieu MOREL <[email protected] >
* Update path_traversal.go
Signed-off-by: Matthieu MOREL <[email protected] >
* Update sessionmanager.go
Signed-off-by: Matthieu MOREL <[email protected] >
* Update .golangci.yaml
Signed-off-by: Matthieu MOREL <[email protected] >
---------
Signed-off-by: Matthieu MOREL <[email protected] >
2024-06-13 15:10:00 -04:00
Matthieu MOREL and GitHub
417ff7b19e
chore: enable gofumpt and whitespace linters ( #18567 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2024-06-11 15:41:55 +00:00
Matthieu MOREL and GitHub
483a5e85a0
chore: enable errorlint linter on util folder ( #18588 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2024-06-11 10:42:32 -04:00
Matthieu MOREL and GitHub
6042442da4
chore: enable error-nil rule from testifylint linter ( #18544 )
...
Signed-off-by: Matthieu MOREL <[email protected] >
2024-06-10 10:38:55 -04:00
Michael Crenshaw and GitHub
f4f772ed5a
fix(api): respect all allowed audiences, regardless of check order ( #17876 )
...
Signed-off-by: Michael Crenshaw <[email protected] >
2024-04-17 20:42:58 -04:00
Jann Fischer and GitHub
87c864fa4d
chore: Fix linter issue with session manager ( #17597 )
...
Signed-off-by: jannfis <[email protected] >
2024-03-22 15:05:18 +00:00
ef27948a16
Merge pull request from GHSA-6v85-wr92-q4p7
...
* fix: Fix concurrency issue in session manager
Signed-off-by: jannfis <[email protected] >
* Add note that modification to the map must be done in a thread safe manner
* chore: fix linter issues
Signed-off-by: pashakostohrys <[email protected] >
---------
Signed-off-by: jannfis <[email protected] >
Signed-off-by: pashakostohrys <[email protected] >
Co-authored-by: Dan Garfield <[email protected] >
Co-authored-by: pashakostohrys <[email protected] >
2024-03-18 03:59:06 -04:00
698e10e0c7
Merge pull request from GHSA-2vgg-9h6w-m454
...
* feat: pick random user and exclude admin user and current user from deletion candidates
Signed-off-by: pashakostohrys <[email protected] >
* feat: increase default max cache size
Signed-off-by: pashakostohrys <[email protected] >
* add nil protection
Signed-off-by: pashakostohrys <[email protected] >
* Update util/session/sessionmanager.go
Signed-off-by: Dan Garfield <[email protected] >
Signed-off-by: Dan Garfield <[email protected] >
* chore: fix linter issues
Signed-off-by: pashakostohrys <[email protected] >
---------
Signed-off-by: pashakostohrys <[email protected] >
Signed-off-by: Dan Garfield <[email protected] >
Co-authored-by: Dan Garfield <[email protected] >
2024-03-18 03:58:18 -04:00
Eng Zer Jun and GitHub
9807275c7b
chore: use t.Setenv to set env vars in tests ( #14377 )
...
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <[email protected] >
2023-07-06 19:50:08 -04:00
Nolan Emirot and GitHub
57c226dcff
chore: update redis client to v9 ( #12746 )
...
* chore: update redis
Signed-off-by: emirot <[email protected] >
* chore: update redis
Signed-off-by: emirot <[email protected] >
* chore: update redis
Signed-off-by: emirot <[email protected] >
---------
Signed-off-by: emirot <[email protected] >
2023-03-08 09:42:10 -05:00
Michael Crenshaw and GitHub
9550fd84fa
feat(security): require the aud claim from OIDC providers by default ( #12187 )
...
Signed-off-by: Michael Crenshaw <[email protected] >
2023-01-27 21:29:08 +00:00
02db31be97
Merge pull request from GHSA-q9hr-j4rf-8fjc
...
* fix: verify audience claim
Co-Authored-By: Vladimir Pouzanov <[email protected] >
Signed-off-by: CI <[email protected] >
* fix lint
Signed-off-by: Michael Crenshaw <[email protected] >
* fix handling of expired token error
Signed-off-by: Michael Crenshaw <[email protected] >
* go mod tidy
Signed-off-by: Michael Crenshaw <[email protected] >
* handle single aud claim marshaled as a string
Signed-off-by: Michael Crenshaw <[email protected] >
Signed-off-by: CI <[email protected] >
Signed-off-by: Michael Crenshaw <[email protected] >
Co-authored-by: Vladimir Pouzanov <[email protected] >
2023-01-25 09:15:03 -05:00
Leonardo Luz Almeida and GitHub
50ab4805e0
chore: Refactor terminal handler to use auth-middleware ( #12052 )
...
* chore: Refactor terminal handler to use auth-middleware
Signed-off-by: Leonardo Luz Almeida <[email protected] >
* remove context key for now
Signed-off-by: Leonardo Luz Almeida <[email protected] >
* implement unit-tests
Signed-off-by: Leonardo Luz Almeida <[email protected] >
* remove claim valid check for now
Signed-off-by: Leonardo Luz Almeida <[email protected] >
* remove unnecessary test
Signed-off-by: Leonardo Luz Almeida <[email protected] >
* fix lint
Signed-off-by: Leonardo Luz Almeida <[email protected] >
* don't too much details in http response
Signed-off-by: Leonardo Luz Almeida <[email protected] >
* Fix error
Signed-off-by: Leonardo Luz Almeida <[email protected] >
* Fix lint
Signed-off-by: Leonardo Luz Almeida <[email protected] >
* trigger build
Signed-off-by: Leonardo Luz Almeida <[email protected] >
* builder pattern in terminal feature-flag middleware
Signed-off-by: Leonardo Luz Almeida <[email protected] >
Signed-off-by: Leonardo Luz Almeida <[email protected] >
2023-01-24 10:46:36 -05:00