Commit Graph
81 Commits
Author SHA1 Message Date
Alexandre GaudreaultandGitHub f7a6d93792 fix: deadlock in controller (#14304)
Signed-off-by: Alexandre Gaudreault <[email protected]>
2023-07-01 16:32:33 -04:00
bb25090d99 feat: add ignoreResourceUpdates to reduce controller CPU usage (#13534) (#13912)
* feat: ignore watched resource update

Signed-off-by: Alexandre Gaudreault <[email protected]>

* add doc and CLI

Signed-off-by: Alexandre Gaudreault <[email protected]>

* update doc index

Signed-off-by: Alexandre Gaudreault <[email protected]>

* add command

Signed-off-by: Alexandre Gaudreault <[email protected]>

* codegen

Signed-off-by: Alexandre Gaudreault <[email protected]>

* revert formatting

Signed-off-by: Alexandre Gaudreault <[email protected]>

* do not skip on health change

Signed-off-by: Alexandre Gaudreault <[email protected]>

* update doc

Signed-off-by: Alexandre Gaudreault <[email protected]>

* update logging to use context

Signed-off-by: Alexandre Gaudreault <[email protected]>

* fix typos. local build broken...

Signed-off-by: Alexandre Gaudreault <[email protected]>

* change after review

Signed-off-by: Alexandre Gaudreault <[email protected]>

* manifestHash to string

Signed-off-by: Alexandre Gaudreault <[email protected]>

* more doc

Signed-off-by: Alexandre Gaudreault <[email protected]>

* example for argoproj Application

Signed-off-by: Alexandre Gaudreault <[email protected]>

* add unit test for ignored logs

Signed-off-by: Alexandre Gaudreault <[email protected]>

* codegen

Signed-off-by: Alexandre Gaudreault <[email protected]>

* Update docs/operator-manual/reconcile.md

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>

* move hash and set log to debug

Signed-off-by: Alexandre Gaudreault <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>

* feature flag

Signed-off-by: Michael Crenshaw <[email protected]>

* fix

Signed-off-by: Michael Crenshaw <[email protected]>

* less aggressive managedFields ignore rule

Signed-off-by: Michael Crenshaw <[email protected]>

* Update docs/operator-manual/reconcile.md

Co-authored-by: Alexandre Gaudreault <[email protected]>

* use local settings

Signed-off-by: Michael Crenshaw <[email protected]>

* latest settings

Signed-off-by: Michael Crenshaw <[email protected]>

* safety first

Signed-off-by: Michael Crenshaw <[email protected]>

* since it's behind a feature flag, go aggressive on overrides

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-06-25 01:32:20 +00:00
Alexander MatyushentsevandGitHub 78e2f7b65c fix: avoid acquiring lock on two mutexes at the same time to prevent deadlock (#13636)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2023-05-18 19:20:13 +00:00
f98ca55a94 chore: Comment format (#12399)
* feat: Comment format

Signed-off-by: fengshunli <[email protected]>

* Apply suggestions from code review

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: fengshunli <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-03-29 19:41:22 +00:00
Tsubasa NagasawaandGitHub 0add57d255 fix: suppress Kubernetes API deprecation warnings from application controller (#12067)
Completely suppress warning logs only for log levels that are less than Debug.

Signed-off-by: toVersus <[email protected]>
2023-03-06 16:48:06 -05:00
e84ab9f36b fix: populate parentRefs correctly with multiple owners (#3910) (#11715)
* fix: populate parentRefs correctly with multiple owners

It previously simply wrote to key 0, instead of appending all owners

Signed-off-by: Jellyfrog <[email protected]>

* test multiple resource owners

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: Jellyfrog <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-01-19 11:57:45 -05:00
Alex EftimieandGitHub 11e1243560 feature: allow a custom labels on any resource to surface in the UI (tree view node tags) (#11153)
* feature: allow a custom label on any resource to surface the UI

Signed-off-by: Alex Eftimie <[email protected]>
2022-11-18 22:29:22 +00:00
Prajilesh NandGitHub eeae87f157 chore: improve error logs (#10933)
Signed-off-by: Prajilesh <[email protected]>

Signed-off-by: Prajilesh <[email protected]>
2022-10-13 17:53:06 -04:00
jannfisandGitHub 75d334705a feat: Applications in any namespace (#9755)
* feat: Applications in any namespace

Signed-off-by: jannfis <[email protected]>

* Fix typo in CI

Signed-off-by: jannfis <[email protected]>

* Create argocd-e2e-external namespace

Signed-off-by: jannfis <[email protected]>

* Update from codegen

Signed-off-by: jannfis <[email protected]>

* Remove debug code

Signed-off-by: jannfis <[email protected]>

* Update help text for -N option to app create

Signed-off-by: jannfis <[email protected]>

* Wrap error when retrieving AppProject from cache

Signed-off-by: jannfis <[email protected]>

* Check for controller namespace first before matching on additional ns

Signed-off-by: jannfis <[email protected]>

* Improve TestAppProjectIsSourceNamespacePermitted unit test

Signed-off-by: jannfis <[email protected]>

* Get rid of some debug leftovers

Signed-off-by: jannfis <[email protected]>

* Better error wrapping; return IsNotFound as-is

Signed-off-by: jannfis <[email protected]>

* Updates from codegen

Signed-off-by: jannfis <[email protected]>

* We don't need AppShortName() anymore

Signed-off-by: jannfis <[email protected]>

* Update end-to-end tests to use annotation methods

Signed-off-by: jannfis <[email protected]>

* Add e2e tests to test for app creation in not permitted ns

Signed-off-by: jannfis <[email protected]>

* Remove deprecated code

Signed-off-by: jannfis <[email protected]>

* Remove dead code

Signed-off-by: jannfis <[email protected]>

* Add RBACName() method to application type

Signed-off-by: jannfis <[email protected]>

* Update from codegen

Signed-off-by: jannfis <[email protected]>

* Fix e2e test

Signed-off-by: jannfis <[email protected]>

* Update codegen

Signed-off-by: jannfis <[email protected]>

* Move RBAC name generation to an application receiver

Signed-off-by: jannfis <[email protected]>

* Fix sync window status in UI

Signed-off-by: jannfis <[email protected]>

* Fix pod logs viewer

Signed-off-by: jannfis <[email protected]>

* Fix application events in UI

Signed-off-by: jannfis <[email protected]>

* Fix application search in UI

Signed-off-by: jannfis <[email protected]>

* Fix yarn lint

Signed-off-by: jannfis <[email protected]>

* Only set up cluster-wide application informer when additional namespaces are specified

Signed-off-by: jannfis <[email protected]>

* Adapt e2e test to a changed error message

Signed-off-by: jannfis <[email protected]>

* Application namespace should be taken into account for create

Signed-off-by: jannfis <[email protected]>

* Use non-qualified application name as Helm release name

Signed-off-by: jannfis <[email protected]>

* Support --app-namespace in e2e tests

Signed-off-by: jannfis <[email protected]>

* Enable more e2e tests

Signed-off-by: jannfis <[email protected]>

* Increase e2e timeout for newly added tests

Signed-off-by: jannfis <[email protected]>
2022-08-10 11:39:10 +02:00
jannfisandGitHub 2c9fa95c4d fix: Make change of tracking method work at runtime (#9820)
* fix: Make change of tracking method work at runtime

Signed-off-by: jannfis <[email protected]>

* GetAppName() will figure tracking label or annotation on its own

Signed-off-by: jannfis <[email protected]>

* Correct test comments and add another test

Signed-off-by: jannfis <[email protected]>

* Add a read lock before getting cache settings

Signed-off-by: jannfis <[email protected]>
2022-07-06 18:53:38 +02:00
Yuan TangandGitHub c49c8d55a0 feat: Treat connection reset as a retryable error (#9739)
Signed-off-by: Yuan Tang <[email protected]>
2022-06-29 08:52:28 -07:00
a94795cdc4 Merge pull request from GHSA-2f5v-8r3f-8pww
* fix: application resource APIs must enforce project restrictions

Signed-off-by: Alexander Matyushentsev <[email protected]>

* Fix unit tests

Signed-off-by: jannfis <[email protected]>

Co-authored-by: jannfis <[email protected]>
2022-03-22 10:57:30 -07:00
Yuan TangandGitHub 9e699c8361 feat: Support additional retryable errors (#8578)
* feat: Support additional retryable errors

Signed-off-by: Yuan Tang <[email protected]>

* Concise conditions

Signed-off-by: Yuan Tang <[email protected]>
2022-02-26 09:21:16 +01:00
Ben YeandGitHub 3308575dbb feat: expose cluster sync retry duration (#8481)
Signed-off-by: Ben Ye <[email protected]>
2022-02-21 22:44:22 +01:00
jannfisandGitHub 3cdc292899 feat: Make cluster cache sync more robust (#8438)
* feat: Support retry for list operations in cluster cache sync

Signed-off-by: jannfis <[email protected]>

* Fix default retries

Signed-off-by: jannfis <[email protected]>

* Pull in latest gitops-engine

Signed-off-by: jannfis <[email protected]>

* Default retry limit should be 1

Signed-off-by: jannfis <[email protected]>

* Make type conversion earlier

Signed-off-by: jannfis <[email protected]>

* Rename limit to attempt

Signed-off-by: jannfis <[email protected]>

* Revert Makefile change

Signed-off-by: jannfis <[email protected]>
2022-02-16 12:52:38 +01:00
Jesse SuenandGitHub cc7091a1b0 feat: update gitops-engine to v0.5.1 and add additional tuning options (#7917)
Signed-off-by: Jesse Suen <[email protected]>
2021-12-13 18:39:25 -08:00
Alexander MatyushentsevandGitHub 8fa6dda80f fix: Argo CD should provide apiversion and kinds to 'helm template' command (#7519)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-10-25 16:52:19 -07:00
pasha-codefreshandGitHub f9cc2cf2b8 fix: compare app state (#7341)
* fix compare app state

Signed-off-by: pashavictorovich <[email protected]>
2021-10-01 09:18:01 -07:00
pasha-codefreshandGitHub 38c8ba460b feat: rename app identifier (#7251)
feat: rename app identifier (#7251)

Signed-off-by: pashavictorovich <[email protected]>
2021-09-28 08:35:17 -07:00
Alexander MatyushentsevandGitHub 5340dce0f9 feat: support managing cluster resources in a namespaced mode (#6581)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-07-19 11:58:58 -07:00
AikawaandGitHub ddca6da103 fix: use current logrus config when logrus is created internally (#6234) (#6301)
fix: use current logrus config when logrus is created internally (#6234) (#6301)
Signed-off-by: yu-croco <[email protected]>
2021-05-28 16:27:57 -07:00
Shoubhik BoseandGitHub 043f559fac chore: Organize Application-related defaults/constants in the Application API's package. (#5893)
chore: Organize Application-related defaults/constants in the Application API's package. (#5893)

Signed-off-by: Shoubhik Bose <[email protected]>
2021-05-19 12:43:04 -07:00
Remington BreezeandGitHub 246600530b fix(ui): Don't count errored or completed neighbor pods toward resource consumption (#6259)
Signed-off-by: Remington Breeze <[email protected]>
2021-05-18 16:01:23 -07:00
1d472ba293 chore: Upgrade Go module to v2 (#5931)
* chore: Upgrade Go module to v2

Signed-off-by: jannfis <[email protected]>

* Restore import order

Signed-off-by: jannfis <[email protected]>

* fix knowntypes_normalizer codegen error

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix codegen

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix Procfile

Signed-off-by: Alexander Matyushentsev <[email protected]>

Co-authored-by: Alexander Matyushentsev <[email protected]>
2021-04-01 20:44:18 +02:00
kshamajain99andGitHub 741a80dca3 fix: fix memory leak in application controller (#5604)
fix: fix memory leak in application controller
2021-02-25 08:57:54 -08:00
Alexander MatyushentsevandGitHub 8e53175ee1 fix: controller should load application related nodes from target cluster (#5208)
* fix: controller should load application related nodes from target cluster

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix: make sure node capasity and pod requests are in same unit, improve unit formatting

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix: application hosts should include info about resources requested by app neighbors

Signed-off-by: Alexander Matyushentsev <[email protected]>

* apply reviewer notes

Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-01-11 12:35:47 -08:00
Alexander MatyushentsevandGitHub 301d9bf4c9 refactor: upgrade gitops-engine version ( breaking API changes related to logr mirgation ) (#4652) 2020-10-27 14:10:24 -07:00
Alexander MatyushentsevandGitHub d351d134e3 feat: Support controller horizontal scaling (#4285) 2020-10-09 13:16:54 -07:00
Alexander MatyushentsevandGitHub 8698c5d42c fix: limit concurrent list requests accross all clusters (#4328) 2020-09-14 14:45:02 -07:00
Alexander MatyushentsevandGitHub 07374b294a fix: cluster settings change is not applied correctly (#4070) 2020-08-10 16:13:06 -07:00
Alexander MatyushentsevandGitHub dff8d5e81b feat: support overriding default cluster re-sync duration (#4014) 2020-07-30 10:00:19 -07:00
May ZhangandGitHub afda2020fa feat: auto create namespace (#3976)
* feat: auto create namespace

* feat: fixing yarn lint error.

* feat: fixing yarn lint error.

* update to the latest gitops-engine

* fix tidiness of go.sum
2020-07-27 13:33:08 -07:00
Hiroki SakamotoandGitHub d4b37b4007 feat: add resource's age & creation time (#3931)
* feat: add resource creation time to api response

* feat: add creation time to model

* feat: add resource's age to app detail page

* feat: add created_at to resource summary page
2020-07-14 16:54:00 +02:00
Alexander MatyushentsevandGitHub 59f07746cd fix: avoid lock contention in GetClustersInfo method (#3844) 2020-06-24 17:19:39 -07:00
Alexander MatyushentsevandGitHub ca0967a624 feat: Display cluster info on cluster details page (#3793)
* feat: Display cluster info on cluster details page

* Store cluster info in cache instead of secret
2020-06-22 17:51:20 -07:00
Alexander MatyushentsevandGitHub 09f9e991db fix: application controller should not modify cached applications (#3821) 2020-06-22 11:04:25 -07:00
Alexander MatyushentsevandGitHub b46eeb2209 fix: cluster state cache should be initialized before using (#3752) (#3763) 2020-06-12 15:05:01 -07:00
Alexander MatyushentsevandGitHub 7eff98e2dd fix: ensure cache settings read/writes are protected by mutex (#3753) 2020-06-11 12:54:10 -07:00
May ZhangandGitHub 518e28be40 feat: get cluster connection status from cluster synced time (#3604)
feat: get cluster connection status from cluster synced time (#3604)
2020-06-04 11:36:26 -07:00
Alexander MatyushentsevandGitHub 853075ea25 refactor: upgrade gitops engine (#3687) 2020-06-01 20:23:07 +02:00
Alexander MatyushentsevandGitHub d57d53f49d fix: upgrade gitops engine dependency (#3668) 2020-05-28 18:42:01 -07:00
Josh SorefandGitHub 53500a12b8 chore: Spelling (#3647)
chore: Spelling (#3647)
2020-05-27 10:22:13 -07:00
May ZhangandGitHub d29238e176 Fixing how to compare two objects. (#3636) 2020-05-22 15:10:25 -07:00
Alexander MatyushentsevandGitHub 295c74ddfc fix: fix nil pointer dereference error after cluster deletion (#3634) 2020-05-22 09:35:04 -07:00
Alexander MatyushentsevandGitHub 5b721367aa feat: upgrade gitops engine version (#3624) 2020-05-20 11:15:23 -07:00
Alexander MatyushentsevandGitHub a68b34dd33 feat: move engine code to argoproj/gitops-engine repo (#3599) 2020-05-15 14:39:29 -07:00
Alexander MatyushentsevandGitHub 171127a40f feat: Gitops engine (#3066)
* Move utils packages that are required for gitops engine under engine/pkg/utils package.
Following changes were implemented:
* util/health package is split into two parts: resource health assessement & resource health assessement and moved into engine/pkg/utils
* utils packages moved: Closer and Close method of util package moved into engine/pkg/utils/io package
* packages diff, errors, exec, json, kube and tracing moved into engine/pkg/utils

* Move single cluster caching into engine/kube/cache package

* move sync functionality to engine/kube/sync package

* remove dependency on metrics package from engine/pkg/utils/kube/cache

* move annotation label definitions into engine/pkg/utils/kube/sync

* make sure engine/pkg has no dependencies on other argo-cd packages

* allow importing engine as a go module

* implement a high-level interface that might be consumed by flux

* fix deadlock caused by cluster cache event handler

* ClusterCache should return error if requested group kind not found

* remove obsolete tests

* apply reviewer notes
2020-05-15 10:01:18 -07:00
Alexander MatyushentsevandGitHub b6b7c7f0b6 fix: prevent syncing the same cluster cache multiple times due to race condition (#3256) 2020-03-19 12:44:23 -07:00
Jesse SuenandGitHub 2d2a484649 perf: reduce unnecessary K8s calls for CRDs during reconciliation (#3246)
* reduce K8s calls for CRDs during reconciliation
* additional metric labels to k8s API requests (server, verb, kind, namespace)
2020-03-18 03:28:31 -07:00
Alexander MatyushentsevandGitHub 53365beda7 feat: use --api-versions during helm chart rendering (#3243) 2020-03-17 14:20:36 -07:00