Commit Graph
218 Commits
Author SHA1 Message Date
bb25090d99 feat: add ignoreResourceUpdates to reduce controller CPU usage (#13534) (#13912)
* feat: ignore watched resource update

Signed-off-by: Alexandre Gaudreault <[email protected]>

* add doc and CLI

Signed-off-by: Alexandre Gaudreault <[email protected]>

* update doc index

Signed-off-by: Alexandre Gaudreault <[email protected]>

* add command

Signed-off-by: Alexandre Gaudreault <[email protected]>

* codegen

Signed-off-by: Alexandre Gaudreault <[email protected]>

* revert formatting

Signed-off-by: Alexandre Gaudreault <[email protected]>

* do not skip on health change

Signed-off-by: Alexandre Gaudreault <[email protected]>

* update doc

Signed-off-by: Alexandre Gaudreault <[email protected]>

* update logging to use context

Signed-off-by: Alexandre Gaudreault <[email protected]>

* fix typos. local build broken...

Signed-off-by: Alexandre Gaudreault <[email protected]>

* change after review

Signed-off-by: Alexandre Gaudreault <[email protected]>

* manifestHash to string

Signed-off-by: Alexandre Gaudreault <[email protected]>

* more doc

Signed-off-by: Alexandre Gaudreault <[email protected]>

* example for argoproj Application

Signed-off-by: Alexandre Gaudreault <[email protected]>

* add unit test for ignored logs

Signed-off-by: Alexandre Gaudreault <[email protected]>

* codegen

Signed-off-by: Alexandre Gaudreault <[email protected]>

* Update docs/operator-manual/reconcile.md

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>

* move hash and set log to debug

Signed-off-by: Alexandre Gaudreault <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>

* feature flag

Signed-off-by: Michael Crenshaw <[email protected]>

* fix

Signed-off-by: Michael Crenshaw <[email protected]>

* less aggressive managedFields ignore rule

Signed-off-by: Michael Crenshaw <[email protected]>

* Update docs/operator-manual/reconcile.md

Co-authored-by: Alexandre Gaudreault <[email protected]>

* use local settings

Signed-off-by: Michael Crenshaw <[email protected]>

* latest settings

Signed-off-by: Michael Crenshaw <[email protected]>

* safety first

Signed-off-by: Michael Crenshaw <[email protected]>

* since it's behind a feature flag, go aggressive on overrides

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-06-25 01:32:20 +00:00
a4e32b2cef fix: Fixes sharding placement algorithm and allows development of alternative algorithms (#13018)
* fix: Extraction of DistributionFunction to allow passing different type of functions to filter clusters by shard
- Adding unit tests for sharding
- Refresh clusters list on DistributionFunction call

Signed-off-by: Akram Ben Aissi <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* fix: Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type uint32 without an upper bound check.

Signed-off-by: Akram Ben Aissi <[email protected]>

* Added config to switch to round-robin sharding

Signed-off-by: Raghavi Shirur <[email protected]>
Signed-off-by: Akram Ben Aissi <[email protected]>

* Documenting sharding more, adding shuffling tests (skipped), re-enable sharding algo env var

Signed-off-by: Akram Ben Aissi <[email protected]>

* Allow configuration through argocd-cmd-params-cm configMap and key: controller.sharding.algorithm

Signed-off-by: Akram Ben Aissi <[email protected]>

* De-duplicate code, remove reflection for default case, shorten distribution methods name, ran codegen on manifests
Signed-off-by: Akram Ben Aissi <[email protected]>

Signed-off-by: Akram Ben Aissi <[email protected]>

---------

Signed-off-by: Akram Ben Aissi <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>
Signed-off-by: Raghavi Shirur <[email protected]>
Co-authored-by: Raghavi Shirur <[email protected]>
2023-06-05 09:19:14 -04:00
4a9b59cb89 feat: Add controllerNamespace to .status of an application (#13081)
Signed-off-by: Kevin Huber <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-05-27 22:08:59 +00:00
Blake PetterssonandGitHub 0d52a16b14 fix: update managed namespace metadata (#13074)
* fix: update managed namespace metadata

This commit fixes an issue where a namespace does not get updated
unless a sync is performed. Since the `managedNamespaceMetadata` is not
a part of the Application Git state, we need a way to force a sync once
the metadata has changed. In order to do that, we need to add state
to compare with.

Once a sync is performed, the `ManagedNamespaceMetadata` gets copied
to `SyncResult`, which will then be compared with on subsequent syncs.
If there's a mismatch between
`app.Spec.SyncPolicy.ManagedNamespaceMetadata` and
`app.Status.OperationState.SyncResult.ManagedNamespaceMetadata` we mark
the Application as `OutOfSync`.

Fixes #12661.

Signed-off-by: Blake Pettersson <[email protected]>

* fix: nil check

Signed-off-by: Blake Pettersson <[email protected]>

* fix: allow empty apps to be updated

If an app is empty but still differs in terms of
`managedNamespaceMetadata`, it should still be kept up to date.

Signed-off-by: Blake Pettersson <[email protected]>

* test: add unit tests in appcontroller

Signed-off-by: Blake Pettersson <[email protected]>

* fix: rebase

Signed-off-by: Blake Pettersson <[email protected]>

* refactor: extract method

Consolidate checks to `app.HasChangedManagedNamespaceMetadata()`

Signed-off-by: Blake Pettersson <[email protected]>

* chore: make codegen

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Blake Pettersson <[email protected]>
2023-05-19 09:55:08 -04:00
Alexander MatyushentsevandGitHub cdc470cacb feat: support 'helm.sh/resource-policy: keep' helm annotation (#13157)
* feat: support 'helm.sh/resource-policy: keep' helm annotation

Signed-off-by: Alexander Matyushentsev <[email protected]>

* document  annotation

Signed-off-by: Alexander Matyushentsev <[email protected]>

---------

Signed-off-by: Alexander Matyushentsev <[email protected]>
2023-04-24 13:41:21 -07:00
e80659dfab feat: UI write support CMP (#11754) (#12137)
* #11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <[email protected]>

* CMP parameter changes

Signed-off-by: schakradari <[email protected]>

* fix: pointers to param values

Signed-off-by: Michael Crenshaw <[email protected]>

better?

Signed-off-by: Michael Crenshaw <[email protected]>

fix silliness

Signed-off-by: Michael Crenshaw <[email protected]>

terrible hacks

Signed-off-by: Michael Crenshaw <[email protected]>

maybe better codegen

Signed-off-by: Michael Crenshaw <[email protected]>

fix tests

Signed-off-by: Michael Crenshaw <[email protected]>

* same prefix issue fixed

Signed-off-by: schakradari <[email protected]>

* fix for delete param name

Signed-off-by: schakradari <[email protected]>

* lint changes

Signed-off-by: schakradari <[email protected]>

* lint fix

Signed-off-by: schakradari <[email protected]>

* lint fix

Signed-off-by: schakradari <[email protected]>

* finalChanges

Signed-off-by: schakradari <[email protected]>

* Delete application-resource-list.tsx

Not needed for this PR.

Signed-off-by: schakrad <[email protected]>

* added file which was deleted as it was not the change needed for this feature.

Signed-off-by: schakradari <[email protected]>

* refactored MapValuField and added fix for some edge cases

Signed-off-by: schakradari <[email protected]>

* Update application-resource-list.tsx

Reverting the change as this is not related to this PR.

Signed-off-by: schakrad <[email protected]>

* Reverting the change in application-resource-list

Signed-off-by: schakradari <[email protected]>

* Showing application parameter values irrespective of parameter present or not in plugin.yaml

Signed-off-by: schakradari <[email protected]>

* fix for lint errors

Signed-off-by: schakradari <[email protected]>

* fix false source mismatch

Signed-off-by: Michael Crenshaw <[email protected]>

* fix equals

Signed-off-by: Michael Crenshaw <[email protected]>

* fix swagger doc

Signed-off-by: Michael Crenshaw <[email protected]>

* Tooltip description change.

Signed-off-by: schakrad <[email protected]>

* fixed lint

Signed-off-by: schakrad <[email protected]>

* CMP fix for empty array.

Signed-off-by: schakrad <[email protected]>

---------

Signed-off-by: schakradari <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: schakrad <[email protected]>
Signed-off-by: schakrad <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-03-21 14:39:10 -04:00
Michael CrenshawandGitHub 5d752908f9 feat: add 'user' field to audit logs (#12644)
Signed-off-by: Michael Crenshaw <[email protected]>
2023-03-16 22:20:10 +02:00
Michael CrenshawandGitHub 2f25df2904 fix: evaluate all possible refresh reasons for multi-source apps (#12379) (#12576)
* fix: evaluate all possible refresh reasons for multi-source apps (#12379)

Signed-off-by: Michael Crenshaw <[email protected]>

* remove redundant parentheses

Signed-off-by: Michael Crenshaw <[email protected]>

* tests

Signed-off-by: Michael Crenshaw <[email protected]>

* don't auto-sync, it makes tests flaky

Signed-off-by: Michael Crenshaw <[email protected]>

* auto-sync because sync CLI doesn't work for multi-source apps

Signed-off-by: Michael Crenshaw <[email protected]>

* don't require out-of-sync - app may sync quickly

Signed-off-by: Michael Crenshaw <[email protected]>

* timeout 60

Signed-off-by: Michael Crenshaw <[email protected]>

* fix timeout

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
2023-02-24 13:30:18 -05:00
Mike NgandGitHub ec8ab77884 feat: add app skip reconcile annotation to optionally bypass application controller processing (#11879)
Signed-off-by: Mike Ng <[email protected]>
2023-02-23 12:02:50 -05:00
Soumya Ghosh DastidarandGitHub 5daa92c22b feat: add sync delete option (#12448)
feat: add sync delete option (#12448)
2023-02-14 19:51:53 +00:00
c7db9cee41 Merge pull request from GHSA-6p4m-hw2h-6gmw
Signed-off-by: ChangZhuo Chen (陳昌倬) <[email protected]>

add test

Signed-off-by: CI <[email protected]>

better comment

Signed-off-by: CI <[email protected]>

Signed-off-by: CI <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-01-25 09:14:29 -05:00
Michael CrenshawandGitHub d070fccaf0 chore: better error messages (#11738)
* chore: better error messages

Signed-off-by: Michael Crenshaw <[email protected]>

* Update util/db/cluster.go

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: Michael Crenshaw <[email protected]>
2023-01-09 16:32:27 -05:00
2cd7949613 fix: Application's own link in UI (#11123) (#11124)
Signed-off-by: Alex Eftimie <[email protected]>
Co-authored-by: Remington Breeze <[email protected]>
2023-01-04 10:40:51 -08:00
f6c1a78677 feat: Multiple sources for applications (#2789) (#10432)
* feat: support multiple sources for application

Signed-off-by: ishitasequeira <[email protected]>

remove debug logging and unwanted code

Signed-off-by: ishitasequeira <[email protected]>

fix lint and unit test errors

Signed-off-by: ishitasequeira <[email protected]>

fix lint and unit test errors

Signed-off-by: ishitasequeira <[email protected]>

* fix bug introduced after rebase

Signed-off-by: ishitasequeira <[email protected]>

executed make codegen

Signed-off-by: ishitasequeira <[email protected]>

* rebase with master

Signed-off-by: ishitasequeira <[email protected]>

remove unwanted logging

Signed-off-by: ishitasequeira <[email protected]>

fix ci failures

Signed-off-by: ishitasequeira <[email protected]>

* fix index out of bounds error

Signed-off-by: ishitasequeira <[email protected]>

* ui fixes

Signed-off-by: ishitasequeira <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* add revisions to SyncOperation for rollback

Signed-off-by: ishitasequeira <[email protected]>

* change Source to *ApplicationSource in ApplicationSpec

Signed-off-by: ishitasequeira <[email protected]>

* fix env variable read logic for ValueFiles

Signed-off-by: ishitasequeira <[email protected]>

* update multiple sources doc

Signed-off-by: ishitasequeira <[email protected]>

* add repository lock and checkout target revision

Signed-off-by: ishitasequeira <[email protected]>

fix codegen

Signed-off-by: ishitasequeira <[email protected]>

* checkout all sources before generating manifest

Signed-off-by: ishitasequeira <[email protected]>

generate mock reposerverclient

Signed-off-by: ishitasequeira <[email protected]>

* update logic for returning ManifestResponse to avoid nil pointer issues

Signed-off-by: ishitasequeira <[email protected]>

* fix nil reference and key mismatch bugs; add more logs (#6)

* fix nil reference and key mismatch bugs; add more logs
* remove temporary comment
* addressed the lint failure and added chart to RefTargeRevisionMapping
* normalize git repo (#7)
* do not leak lock releases
* prevent deadlock
* allow spec update
* move settings fetch outside loop
* cache busing
* return err instead of logging it
* no caching in test
* fix cache key marshaling

Signed-off-by: Michael Crenshaw <[email protected]>

Rebase with master

Signed-off-by: ishitasequeira <[email protected]>

* update grpc field numbers

Signed-off-by: ishitasequeira <[email protected]>

* path resolution tests (#12)

Signed-off-by: Michael Crenshaw <[email protected]>

do things in better ways

Signed-off-by: Michael Crenshaw <[email protected]>

consolidate

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* add regex check for value of source.ref

Signed-off-by: ishitasequeira <[email protected]>

* add webhook tests

Signed-off-by: Michael Crenshaw <[email protected]>

change Source to *ApplicationSource in ApplicationSpec

Signed-off-by: ishitasequeira <[email protected]>

address PR comments

Signed-off-by: ishitasequeira <[email protected]>

rebase with master

Signed-off-by: ishitasequeira <[email protected]>

Retrigger CI pipeline

Signed-off-by: ishitasequeira <[email protected]>

rebased with master

Signed-off-by: ishitasequeira <[email protected]>

* fix env variable read logic for ValueFiles

Signed-off-by: ishitasequeira <[email protected]>

Address PR comments

Signed-off-by: ishitasequeira <[email protected]>

* add repository lock and checkout target revision

Signed-off-by: ishitasequeira <[email protected]>

fix codegen

Signed-off-by: ishitasequeira <[email protected]>

* checkout all sources before generating manifest

Signed-off-by: ishitasequeira <[email protected]>

* generate mock reposerverclient

Signed-off-by: ishitasequeira <[email protected]>

* address comments

Signed-off-by: ishitasequeira <[email protected]>

* update logic for returning ManifestResponse to avoid nil pointer issues

Signed-off-by: ishitasequeira <[email protected]>

* fix nil reference and key mismatch bugs; add more logs (#6)

* fix nil reference and key mismatch bugs; add more logs
* remove temporary comment
* addressed the lint failure and added chart to RefTargeRevisionMapping
* normalize git repo (#7)
* do not leak lock releases
* prevent deadlock
* allow spec update
* move settings fetch outside loop
* cache busing
* return err instead of logging it
* no caching in test
* fix cache key marshaling

Signed-off-by: Michael Crenshaw <[email protected]>

Rebase with master

Signed-off-by: ishitasequeira <[email protected]>

* update grpc field numbers

Signed-off-by: ishitasequeira <[email protected]>

* add regex check for value of source.ref

Signed-off-by: ishitasequeira <[email protected]>

* Rebase with master

Signed-off-by: ishitasequeira <[email protected]>

* Added unit tests (#15)

* add unit tests 1
* fix lint

Signed-off-by: ishitasequeira <[email protected]>

* fix application parameters tab, rebased UI changes, tests

Signed-off-by: ishitasequeira <[email protected]>

* More tests (#16)

* more tests

Signed-off-by: Michael Crenshaw <[email protected]>

fix lint error

Signed-off-by: ishitasequeira <[email protected]>

Test get ref sources (#17)

* test GetRefSources

Signed-off-by: Michael Crenshaw <[email protected]>

* fix lint

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: ishitasequeira <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: ishitasequeira <[email protected]>

GenerateManifests test (#18)

* GenerateManifests test

Signed-off-by: Michael Crenshaw <[email protected]>

Fix broken tests (#19)

* fix broken tests

Signed-off-by: Michael Crenshaw <[email protected]>

Symlink test (#20)

* check referenced sources for out-of-bounds symlinks

Signed-off-by: Michael Crenshaw <[email protected]>

* unlock the values file repo before doing a symlink check (#22)

Signed-off-by: Michael Crenshaw <[email protected]>

* multi source docs (#21)

* multi source docs

Signed-off-by: Michael Crenshaw <[email protected]>

* fix warning title

Signed-off-by: Michael Crenshaw <[email protected]>

* clarify

Signed-off-by: Michael Crenshaw <[email protected]>

* clarify

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: Michael Crenshaw <[email protected]>

* add e2e tests for multiple sources and fix UI lint (#23)

* add e2e tests for multiple sources and fix UI lint

Signed-off-by: ishitasequeira <[email protected]>

* add auto-sync and hard refresh to e2e tests

Signed-off-by: ishitasequeira <[email protected]>

* change refresh type to RefreshTypeNormal for e2e

Signed-off-by: ishitasequeira <[email protected]>

* update e2e testcase with helm data

Signed-off-by: ishitasequeira <[email protected]>

* add TestMultiSourceAppWithSourceOverride

Signed-off-by: ishitasequeira <[email protected]>

* add missing yaml file

Signed-off-by: ishitasequeira <[email protected]>

Signed-off-by: ishitasequeira <[email protected]>

* rebase with master

Signed-off-by: ishitasequeira <[email protected]>

* rebase with master

Signed-off-by: ishitasequeira <[email protected]>

* fix lint

Signed-off-by: ishitasequeira <[email protected]>

Signed-off-by: ishitasequeira <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2022-12-16 15:47:08 -05:00
Alexander MatyushentsevandGitHub e845aeb7d5 fix: application stuck in infinite reconciliation loop if using wrong project (#11246)
* fix: application stuck in infinite reconciliation loop if using wrong project

Signed-off-by: Alexander Matyushentsev <[email protected]>

* add missing unit test

Signed-off-by: Alexander Matyushentsev <[email protected]>

Signed-off-by: Alexander Matyushentsev <[email protected]>
2022-11-18 20:57:34 -05:00
cdc33f62d8 chore: wrap errors with message (#10592) (#10986)
* issue-10592 Wrap errors with message

Signed-off-by: Apoorva Mahabaleshwara <[email protected]>
Signed-off-by: Apoorva Mahabaleshwara <[email protected]>

* issue-10592 remove unwanted error  wrappers

Signed-off-by: Apoorva Mahabaleshwara <[email protected]>
Signed-off-by: Apoorva Mahabaleshwara <[email protected]>

* chore: fix  error wrapper messages

Signed-off-by: Apoorva Mahabaleshwara <[email protected]>

Signed-off-by: Apoorva Mahabaleshwara <[email protected]>
Signed-off-by: Apoorva Mahabaleshwara <[email protected]>
Co-authored-by: Apoorva Mahabaleshwara <[email protected]>
2022-10-19 19:21:32 +00:00
Blake PetterssonandGitHub 839188e760 feat: add permitOnlyProjectScopedClusters flag (#10237)
This commit adds a new flag, `permitOnlyProjectScopedClusters`, which
prevents any application from syncing to clusters which are not a part
of the same project. Fixes #10220.

Signed-off-by: Blake Pettersson <[email protected]>

Signed-off-by: Blake Pettersson <[email protected]>
2022-09-08 07:33:10 -04:00
Alexander MatyushentsevandGitHub bedad4340d chore: infer managed resources health from redis instead of storing it in CRD (#10191)
* chore: infer managed resources health from redis instead of storing it in CRD

Signed-off-by: Alexander Matyushentsev <[email protected]>

* apply reviewer notes

Signed-off-by: Alexander Matyushentsev <[email protected]>

Signed-off-by: Alexander Matyushentsev <[email protected]>
2022-08-17 21:03:24 +00:00
jannfisandGitHub 75d334705a feat: Applications in any namespace (#9755)
* feat: Applications in any namespace

Signed-off-by: jannfis <[email protected]>

* Fix typo in CI

Signed-off-by: jannfis <[email protected]>

* Create argocd-e2e-external namespace

Signed-off-by: jannfis <[email protected]>

* Update from codegen

Signed-off-by: jannfis <[email protected]>

* Remove debug code

Signed-off-by: jannfis <[email protected]>

* Update help text for -N option to app create

Signed-off-by: jannfis <[email protected]>

* Wrap error when retrieving AppProject from cache

Signed-off-by: jannfis <[email protected]>

* Check for controller namespace first before matching on additional ns

Signed-off-by: jannfis <[email protected]>

* Improve TestAppProjectIsSourceNamespacePermitted unit test

Signed-off-by: jannfis <[email protected]>

* Get rid of some debug leftovers

Signed-off-by: jannfis <[email protected]>

* Better error wrapping; return IsNotFound as-is

Signed-off-by: jannfis <[email protected]>

* Updates from codegen

Signed-off-by: jannfis <[email protected]>

* We don't need AppShortName() anymore

Signed-off-by: jannfis <[email protected]>

* Update end-to-end tests to use annotation methods

Signed-off-by: jannfis <[email protected]>

* Add e2e tests to test for app creation in not permitted ns

Signed-off-by: jannfis <[email protected]>

* Remove deprecated code

Signed-off-by: jannfis <[email protected]>

* Remove dead code

Signed-off-by: jannfis <[email protected]>

* Add RBACName() method to application type

Signed-off-by: jannfis <[email protected]>

* Update from codegen

Signed-off-by: jannfis <[email protected]>

* Fix e2e test

Signed-off-by: jannfis <[email protected]>

* Update codegen

Signed-off-by: jannfis <[email protected]>

* Move RBAC name generation to an application receiver

Signed-off-by: jannfis <[email protected]>

* Fix sync window status in UI

Signed-off-by: jannfis <[email protected]>

* Fix pod logs viewer

Signed-off-by: jannfis <[email protected]>

* Fix application events in UI

Signed-off-by: jannfis <[email protected]>

* Fix application search in UI

Signed-off-by: jannfis <[email protected]>

* Fix yarn lint

Signed-off-by: jannfis <[email protected]>

* Only set up cluster-wide application informer when additional namespaces are specified

Signed-off-by: jannfis <[email protected]>

* Adapt e2e test to a changed error message

Signed-off-by: jannfis <[email protected]>

* Application namespace should be taken into account for create

Signed-off-by: jannfis <[email protected]>

* Use non-qualified application name as Helm release name

Signed-off-by: jannfis <[email protected]>

* Support --app-namespace in e2e tests

Signed-off-by: jannfis <[email protected]>

* Enable more e2e tests

Signed-off-by: jannfis <[email protected]>

* Increase e2e timeout for newly added tests

Signed-off-by: jannfis <[email protected]>
2022-08-10 11:39:10 +02:00
Leonardo Luz AlmeidaandGitHub 4cebcfc61e fix: Ignore diff with schema (#9170) 2022-05-31 13:21:22 -04:00
69e82828a3 feat: add --app-hard-resync flag to controller (#8928)
* feat: add --app-hard-resync flag to controller

Signed-off-by: darshanime <[email protected]>

* add to approvers

Signed-off-by: pashavictorovich <[email protected]>

* Merge branch 'master' of github.com:pasha-codefresh/argo-cd into hard-refresh

Signed-off-by: pashavictorovich <[email protected]>

# Conflicts:
#	cmd/argocd-application-controller/main.go
#	controller/appcontroller.go

* merge

Signed-off-by: pashavictorovich <[email protected]>

* merge

Signed-off-by: pashavictorovich <[email protected]>

* regenerate docs

Signed-off-by: pashavictorovich <[email protected]>

* regenerate docs

Signed-off-by: pashavictorovich <[email protected]>

* fix tests

Signed-off-by: pashavictorovich <[email protected]>

* read variable from cm

Signed-off-by: pashavictorovich <[email protected]>

* reconciliation variable

Signed-off-by: pashavictorovich <[email protected]>

* manifest

Signed-off-by: pashavictorovich <[email protected]>

Co-authored-by: darshanime <[email protected]>
2022-04-04 10:44:35 -04:00
a94795cdc4 Merge pull request from GHSA-2f5v-8r3f-8pww
* fix: application resource APIs must enforce project restrictions

Signed-off-by: Alexander Matyushentsev <[email protected]>

* Fix unit tests

Signed-off-by: jannfis <[email protected]>

Co-authored-by: jannfis <[email protected]>
2022-03-22 10:57:30 -07:00
Ben YeandGitHub b25e07d9e5 fix: register controller workqueue metrics correctly (#8318)
Signed-off-by: Ben Ye <[email protected]>
2022-02-01 10:57:20 -08:00
jannfisandGitHub c8d2d8f38d chore: Log out the resource triggering reconciliation (#8192)
* chore: Log out the resource triggering reconciliation

Signed-off-by: jannfis <[email protected]>

* chore: Log out the resource triggering reconciliation

Signed-off-by: jannfis <[email protected]>
2022-01-18 08:22:26 +01:00
Leonardo Luz AlmeidaandGitHub d2b9099d9e fix: Inconsistent normalization logic during diff (#7980)
fix: Inconsistent normalization logic during diff (#7980)

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2021-12-22 08:57:48 -08:00
jomenxiaoandGitHub 82c75fa3bc fix nil point (#7905)
Signed-off-by: jomenxiao <[email protected]>
2021-12-10 21:23:37 -08:00
Alexander MatyushentsevandGitHub 6bb96caea8 refactor: add indexes to secret informers to speedup settings parsing (#7882)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-12-07 14:15:11 -08:00
Alexander MatyushentsevandGitHub 73843bb01c refactor: avoid loading project in frequently executed controller methods (#7853)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-12-03 13:18:08 -08:00
Alexander MatyushentsevandGitHub 3449cbe9db refactor: use cached project while calculating resource tree (#7747)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-11-18 15:45:19 -08:00
Leonardo Luz AlmeidaandGitHub fcd30aa98f fix: Address issue during diff when secret data is nil (#7603)
* fix: update gitops-engine to latest + log improvements

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* run go mod tidy

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2021-11-03 12:46:05 -07:00
Alexander MatyushentsevandGitHub 9e2ccba385 fix: Invalid memory address or nil pointer dereference in processRequestedAppOperation (#7501)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-10-20 08:03:55 -07:00
Alexander MatyushentsevandGitHub eeb2b0fb79 fix: Operation has completed with phase: Running (#7482)
* fix: Operation has completed with phase: Running

Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-10-19 17:16:31 -07:00
pasha-codefreshandGitHub 74c7247f1e feat: Cluster name as part of sync (#7394)
feat: Cluster name as part of sync (#7394)

Signed-off-by: pashavictorovich <[email protected]>
2021-10-18 18:44:54 -07:00
Leonardo Luz AlmeidaandGitHub 0b8ca7d7d9 Expose Application labels in prometheus metric (#7374)
Expose Application labels in prometheus metric (#7374)

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2021-10-08 10:15:51 -07:00
pasha-codefreshandGitHub f9cc2cf2b8 fix: compare app state (#7341)
* fix compare app state

Signed-off-by: pashavictorovich <[email protected]>
2021-10-01 09:18:01 -07:00
pasha-codefreshandGitHub 38c8ba460b feat: rename app identifier (#7251)
feat: rename app identifier (#7251)

Signed-off-by: pashavictorovich <[email protected]>
2021-09-28 08:35:17 -07:00
Alexander MatyushentsevandGitHub 664e92ee5e refactor: cache virtual project calculation to improve performance (#7274)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-09-21 12:20:49 -07:00
pasha-codefreshandGitHub 7303e9c0a8 feat: Project scoped repo (#6943)
feat: Project scoped repo (#6943)

Signed-off-by: pashavictorovich <[email protected]>
2021-08-16 09:38:37 -07:00
6d39cfd098 chore: Spelling (#5373)
* spelling: across

Signed-off-by: Josh Soref <[email protected]>

* spelling: anyway

Signed-off-by: Josh Soref <[email protected]>

* spelling: assessment

Signed-off-by: Josh Soref <[email protected]>

* spelling: attribute

Signed-off-by: Josh Soref <[email protected]>

* spelling: crlf

Signed-off-by: Josh Soref <[email protected]>

* spelling: cmux

Signed-off-by: Josh Soref <[email protected]>

* spelling: committed

Signed-off-by: Josh Soref <[email protected]>

* spelling: convenience

Signed-off-by: Josh Soref <[email protected]>

* spelling: does-not

Signed-off-by: Josh Soref <[email protected]>

* spelling: e.g.

Signed-off-by: Josh Soref <[email protected]>

* spelling: fall back

Signed-off-by: Josh Soref <[email protected]>

* spelling: fall back to

Signed-off-by: Josh Soref <[email protected]>

* spelling: then ... falls back

Signed-off-by: Josh Soref <[email protected]>

* spelling: formatted

Signed-off-by: Josh Soref <[email protected]>

* spelling: github

Signed-off-by: Josh Soref <[email protected]>

* spelling: gitlab

Signed-off-by: Josh Soref <[email protected]>

* spelling: gitops

Signed-off-by: Josh Soref <[email protected]>

* spelling: health checks

Signed-off-by: Josh Soref <[email protected]>

* spelling: located

Signed-off-by: Josh Soref <[email protected]>

* spelling: logging

Signed-off-by: Josh Soref <[email protected]>

* spelling: oidc

Signed-off-by: Josh Soref <[email protected]>

* spelling: openshift

Signed-off-by: Josh Soref <[email protected]>

* spelling: os

Signed-off-by: Josh Soref <[email protected]>

* spelling: powershell

Signed-off-by: Josh Soref <[email protected]>

* spelling: preferred

Signed-off-by: Josh Soref <[email protected]>

* spelling: redact

Signed-off-by: Josh Soref <[email protected]>

* spelling: repo

Signed-off-by: Josh Soref <[email protected]>

* spelling: similarly

Signed-off-by: Josh Soref <[email protected]>

* spelling: staging

Signed-off-by: Josh Soref <[email protected]>

* spelling: statefulset

Signed-off-by: Josh Soref <[email protected]>

* spelling: stopped

Signed-off-by: Josh Soref <[email protected]>

* spelling: superseded

Signed-off-by: Josh Soref <[email protected]>

* spelling: synchronization

Signed-off-by: Josh Soref <[email protected]>

* spelling: to

Signed-off-by: Josh Soref <[email protected]>

* spelling: unified

Signed-off-by: Josh Soref <[email protected]>

* spelling: verification

Signed-off-by: Josh Soref <[email protected]>

* spelling: zookeeper

Signed-off-by: Josh Soref <[email protected]>

Co-authored-by: Josh Soref <[email protected]>
2021-07-13 19:02:03 +02:00
Jonathan WestandGitHub 3303c634be fix: unable to delete an Application if its target cluster is deleted, Argo CD enters infinite app deletion reconciliation loop (#6557)
Signed-off-by: Jonathan West <[email protected]>
2021-06-29 16:32:21 -04:00
Kshama JainandGitHub b6e563b8b4 feat: update app informer to avoid stale cache (#6372)
feat: update app informer to avoid stale cache (#6372)

Signed-off-by: kshamajain99 <[email protected]>
2021-06-03 15:40:35 -07:00
AikawaandGitHub ddca6da103 fix: use current logrus config when logrus is created internally (#6234) (#6301)
fix: use current logrus config when logrus is created internally (#6234) (#6301)
Signed-off-by: yu-croco <[email protected]>
2021-05-28 16:27:57 -07:00
Alexander MatyushentsevandGitHub 473a0ab3a4 fix: controller should refresh app before running sync operation (#6294)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-05-21 13:32:31 -07:00
Shoubhik BoseandGitHub 043f559fac chore: Organize Application-related defaults/constants in the Application API's package. (#5893)
chore: Organize Application-related defaults/constants in the Application API's package. (#5893)

Signed-off-by: Shoubhik Bose <[email protected]>
2021-05-19 12:43:04 -07:00
Alexander MatyushentsevandGitHub e6a4826232 feat: cache resolved git/helm repository revisions (#6102)
* feat: cache resolved git/helm repository revisions

Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-05-19 12:30:15 -07:00
Remington BreezeandGitHub 246600530b fix(ui): Don't count errored or completed neighbor pods toward resource consumption (#6259)
Signed-off-by: Remington Breeze <[email protected]>
2021-05-18 16:01:23 -07:00
yanclandGitHub 15958e5d83 fix: remove break for appsCount (#6115)
Signed-off-by: yancl <[email protected]>
2021-04-28 12:37:46 -07:00
1d472ba293 chore: Upgrade Go module to v2 (#5931)
* chore: Upgrade Go module to v2

Signed-off-by: jannfis <[email protected]>

* Restore import order

Signed-off-by: jannfis <[email protected]>

* fix knowntypes_normalizer codegen error

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix codegen

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix Procfile

Signed-off-by: Alexander Matyushentsev <[email protected]>

Co-authored-by: Alexander Matyushentsev <[email protected]>
2021-04-01 20:44:18 +02:00
Chetan BanavikalmuttandGitHub aa9ea1268a feat: support background propagation policy while deleting applications (#5216) (#5524)
* feat: support background propagation policy

Currently, Argo CD only supports foreground propagation policy ie. delete all the resources in the foreground and then delete the application in the end. This PR introduces a new flag `propagation-policy` to decide the type of policy when cascading is enabled. It also adds an annotation `propagation-policy.argocd.argoproj.io`, which is used by the application controller to decide the order of deletion.

Fixes: #5216
Signed-off-by: Chetan Banavikalmutt <[email protected]>

* fix lint and doc errors

Signed-off-by: Chetan Banavikalmutt <[email protected]>

* update logs to display the application name

Signed-off-by: Chetan Banavikalmutt <[email protected]>

* address review comments

* remove application name from logs since it's already present
* update the propagation policy annotation key

Signed-off-by: Chetan Banavikalmutt <[email protected]>

* Add radio buttons in the UI to select propagation policy

Signed-off-by: Chetan Banavikalmutt <[email protected]>

* inject finalizers instead of annotations for specifying propagation policy

Signed-off-by: Chetan Banavikalmutt <[email protected]>

* rebase branch on master

Signed-off-by: Chetan Banavikalmutt <[email protected]>

* update the controller to set the policy only for application's resources

Signed-off-by: Chetan Banavikalmutt <[email protected]>

* fix the label of policy radio button

Signed-off-by: Chetan Banavikalmutt <[email protected]>
2021-03-15 17:27:41 +01:00
Ishita SequeiraandGitHub 6409707729 feat: added cascade option to delete resources #5368 (#5538)
* feat: added cascade option to delete resources #5368

Signed-off-by: ishitasequeira <[email protected]>

* addressed PR comments related to cascade delete

Signed-off-by: ishitasequeira <[email protected]>

* feat: update gitops-engine version

Signed-off-by: ishitasequeira <[email protected]>

* Fix e2e tests

Signed-off-by: ishitasequeira <[email protected]>

* feat: update gitops-engine version

Signed-off-by: ishitasequeira <[email protected]>

* fix: Address PR comments

Signed-off-by: ishitasequeira <[email protected]>
2021-03-09 14:04:14 +01:00