Commit Graph
16 Commits
Author SHA1 Message Date
Matthieu MORELandGitHub 5051940c20 chore: use testify instead of testing.Fatal (#21258)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-02 18:27:41 -05:00
Matthieu MORELandGitHub 7a212a833c chore: enable use-any from revive (#21282)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-02 18:26:59 -05:00
Matthieu MORELandGitHub 6a8208c4ca chore: enable importas for k8s.io/apimachinery/pkg/apis/meta/v1 (#21284)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-12-31 10:34:11 +02:00
Arthur VardevanyanandGitHub 19e2fb51ec fix(AnyNameSpaceRegex): Additional Functions Glob to Regexexp (#19516)
Signed-off-by: Arthur <[email protected]>
2024-08-13 19:14:16 +03:00
Arthur VardevanyanandGitHub 8befe4d616 feat(sourceNamespace): Regex Support (#19016) (#19017)
* feat(sourceNamespace): Regex Support

Signed-off-by: Arthur <[email protected]>

* feat(sourceNamespace): Separate exactMatch into patternMatch

Signed-off-by: Arthur <[email protected]>

---------

Signed-off-by: Arthur <[email protected]>
2024-08-13 08:46:25 -04:00
c348ce0796 chore: enable require-error rule from errorlint linter on controller folder (#18690)
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: pasha-codefresh <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
2024-06-17 13:05:27 +00:00
Matthieu MORELandGitHub e1c8779ad8 chore: enable gocritic linter (#18633)
* chore: enable gocritic linter

Signed-off-by: Matthieu MOREL <[email protected]>

* Update settings.go

Signed-off-by: Matthieu MOREL <[email protected]>

* Update app.go

Signed-off-by: Matthieu MOREL <[email protected]>

* Update grpcproxy.go

Signed-off-by: Matthieu MOREL <[email protected]>

* Update grpcproxy.go

Signed-off-by: Matthieu MOREL <[email protected]>

* Update util.go

Signed-off-by: Matthieu MOREL <[email protected]>

* Update server.go

Signed-off-by: Matthieu MOREL <[email protected]>

* Update app_management_ns_test.go

Signed-off-by: Matthieu MOREL <[email protected]>

* Update app_management_test.go

Signed-off-by: Matthieu MOREL <[email protected]>

* Update path_traversal.go

Signed-off-by: Matthieu MOREL <[email protected]>

* Update sessionmanager.go

Signed-off-by: Matthieu MOREL <[email protected]>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <[email protected]>

---------

Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-13 15:10:00 -04:00
Matthieu MORELandGitHub 417ff7b19e chore: enable gofumpt and whitespace linters (#18567)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-11 15:41:55 +00:00
Matthieu MORELandGitHub eb14360d0b chore: enable goimports linter (#18564)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-10 09:18:12 -04:00
dc88e84734 feat: Argocd notification self service (#16488)
* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix merge conflict

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* self service notification

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* revert back the changes for redis-ha

Signed-off-by: May Zhang <[email protected]>

* update notification engine

Signed-off-by: May Zhang <[email protected]>

* re-trigger build

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* fix conflict

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* update notification enginer version

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* fixing go tidy

Signed-off-by: May Zhang <[email protected]>

* add back checkAppNotInAdditionalNamespaces

Signed-off-by: May Zhang <[email protected]>

* add cm and secret to clusterRole

Signed-off-by: May Zhang <[email protected]>

* if applicationNamespaces is not used, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix doc and test based on review

Signed-off-by: May Zhang <[email protected]>

* disable defining and using secrets within notification templates for self-service

Signed-off-by: May Zhang <[email protected]>

* tweaks

Signed-off-by: Michael Crenshaw <[email protected]>

* fix docs formatting

Signed-off-by: Michael Crenshaw <[email protected]>

* more docs and Procfile update for local run convenience

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: May Zhang <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-11-30 21:40:33 +00:00
Siddhesh GhadiandGitHub b39899d71f Set cert resolver in notifications-controller (#15394)
Signed-off-by: Siddhesh Ghadi <[email protected]>
2023-10-30 02:14:04 +00:00
May ZhangandGitHub d8c6b7d996 fix: argocd notification controller app cluster permission issue (#16057)
* if applicationNamespaces is not provided as input parameter, then use namespaced appClient

Signed-off-by: May Zhang <[email protected]>

* fix go lint error

Signed-off-by: May Zhang <[email protected]>

---------

Signed-off-by: May Zhang <[email protected]>
2023-10-23 21:44:49 +00:00
e8416af558 fix(notifications): Allow notifications controller to notify on all namespaces (#15702)
* Allow notifications controller to notify on all namespaces

This adds functionality to the notifications controller to be notified
of and send notifications for applications in any namespace. The
namespaces to watch are controlled by the same --application-namespaces
and ARGOCD_APPLICATION_NAMESPACES variables as in the application
controller.

Signed-off-by: Nikolas Skoufis <[email protected]>

* Add SEEK to users.md

Signed-off-by: Nikolas Skoufis <[email protected]>

* Remove unused fields

Signed-off-by: Nikolas Skoufis <[email protected]>

* Revert changes to Procfile

Signed-off-by: Nik Skoufis <[email protected]>

* Fix unit tests

Signed-off-by: Nikolas Skoufis <[email protected]>

* - add argocd namespaces environment variable to notifications controller

Signed-off-by: Stewart Thomson <[email protected]>

* - add example cluster role rbac

Signed-off-by: Stewart Thomson <[email protected]>

* - only look for projects in the controller's namespace (argocd by default)

Signed-off-by: Stewart Thomson <[email protected]>

* - update base manifest

Signed-off-by: Stewart Thomson <[email protected]>

* - skip app processing in notification controller

Signed-off-by: Stewart Thomson <[email protected]>

* added unit test and updated doc

Signed-off-by: May Zhang <[email protected]>

* added unit test and updated doc

Signed-off-by: May Zhang <[email protected]>

* updated examples/k8s-rbac/argocd-server-applications/kustomization.yaml's resources

Signed-off-by: May Zhang <[email protected]>

---------

Signed-off-by: Nikolas Skoufis <[email protected]>
Signed-off-by: Nik Skoufis <[email protected]>
Signed-off-by: Stewart Thomson <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Co-authored-by: Nikolas Skoufis <[email protected]>
Co-authored-by: Nik Skoufis <[email protected]>
Co-authored-by: Stewart Thomson <[email protected]>
2023-10-06 20:25:38 +00:00
Zubair HaqueandGitHub 824c0dbe00 chore: adding test coverage for the notification_controller (#13339)
* Adding unit tests for the Init function: for the notification controller

Signed-off-by: zhaque44 <[email protected]>

* Adding unit tests for getAppProj function: for the notification controller

Signed-off-by: zhaque44 <[email protected]>

* fixing linting errors for indexer.Add in build

Signed-off-by: zhaque44 <[email protected]>

* rm appProj test(s) to assess linting issue

Signed-off-by: zhaque44 <[email protected]>

* adding first test case for getAppProj

Signed-off-by: zhaque44 <[email protected]>

* add happy path for getAppProj func()

Signed-off-by: zhaque44 <[email protected]>

* updating test function to reduce duplication

Signed-off-by: zhaque44 <[email protected]>

* sanity test fot getAppProj: rm test struct pattern to test generic scenarios

Signed-off-by: zhaque44 <[email protected]>

* verifies that getAppProj gracefully handles input with missing "project" field and returns nil

Signed-off-by: zhaque44 <[email protected]>

* chore: isAppSyncStatusRefreshed test for improved coverage

Signed-off-by: zhaque44 <[email protected]>

---------

Signed-off-by: zhaque44 <[email protected]>
2023-04-27 07:23:51 -04:00
9f631a19e2 chore: Reused argo define api Kind and Group (#11844)
Signed-off-by: yanggang <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-03-24 14:43:43 +00:00
pasha-codefreshandGitHub 5bae4d367e feat: Migrate argocd notifications to argocd (#7744)
feat: Migrate argocd notifications to argocd (#7744)

Signed-off-by: pashavictorovich <[email protected]>
2021-11-29 18:47:46 -08:00