Commit Graph
133 Commits
Author SHA1 Message Date
Andrii KorotkovandGitHub 887e6fccba fix: New kube applier for server side diff dry run with refactoring (#21488) (#21749)
Signed-off-by: Andrii Korotkov <[email protected]>
2025-02-07 12:26:03 -05:00
Michael CrenshawandGitHub e0f3b47846 chore(refactor): remove app destination inferrence logic (#21189)
* refactor: remove app destination inferrence logic

Signed-off-by: Michael Crenshaw <[email protected]>

* simplify

Signed-off-by: Michael Crenshaw <[email protected]>

* more fixes

Signed-off-by: Michael Crenshaw <[email protected]>

* more fixes

Signed-off-by: Michael Crenshaw <[email protected]>

* codegen

Signed-off-by: Michael Crenshaw <[email protected]>

* fix mocks

Signed-off-by: Michael Crenshaw <[email protected]>

* simplify

Signed-off-by: Michael Crenshaw <[email protected]>

* clusters all the way down

Signed-off-by: Michael Crenshaw <[email protected]>

* simplify

Signed-off-by: Michael Crenshaw <[email protected]>

* test

Signed-off-by: Michael Crenshaw <[email protected]>

* lint

Signed-off-by: Michael Crenshaw <[email protected]>

* tidy

Signed-off-by: Michael Crenshaw <[email protected]>

* be less radical

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
2025-01-13 13:15:42 -05:00
8334da36f2 Bump major version to 3 (#21410)
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: crenshaw-dev <[email protected]>
2025-01-10 16:14:00 -05:00
Matthieu MORELandGitHub 064b5ae081 chore: enable indent-error-flow from revive (#21394)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-07 10:25:22 -05:00
Matthieu MORELandGitHub eec6f8526a chore: enable unused-parameter from revive (#21365)
* chore: enable unused-parameter from revive

Signed-off-by: Matthieu MOREL <[email protected]>

* apply recommandations

Signed-off-by: Matthieu MOREL <[email protected]>

---------

Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-07 10:12:56 -05:00
Matthieu MORELandGitHub 3e3bcf0246 chore: enable context-as-argument from revive (#21371)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-07 10:08:51 -05:00
Matthieu MORELandGitHub 75e3d10f27 chore: enable var-declaration from revive (#21370)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-03 18:44:23 -05:00
Matthieu MORELandGitHub 7a212a833c chore: enable use-any from revive (#21282)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-02 18:26:59 -05:00
Matthieu MORELandGitHub 6a8208c4ca chore: enable importas for k8s.io/apimachinery/pkg/apis/meta/v1 (#21284)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-12-31 10:34:11 +02:00
Matthieu MORELandGitHub c85bb38a83 chore: enable errorf of perfsprint linter (#21280)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-12-30 10:56:41 +02:00
Matthieu MORELandGitHub 4156151f8f chore: enable err-error and strconcat of perfsprint linter (#21267)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-12-20 16:22:28 +00:00
Alexander MatyushentsevandGitHub 8b6ffe3c02 feat: application resource deletion protection (#20497)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2024-10-24 00:08:24 -07:00
Kunho LeeandGitHub e0c6797ffd fix: check err before use schedule and duration (#20043)
* fix: check err before use schedule and duration

Signed-off-by: daengdaengLee <[email protected]>

* test: add tests for invalid schedule and duration

Signed-off-by: daengdaengLee <[email protected]>

* feat: change to return error when sync window is invalid

Signed-off-by: daengdaengLee <[email protected]>

* fix: use assert.Error or assert.NoError

Signed-off-by: daengdaengLee <[email protected]>

* fix: use require instead of assert

Signed-off-by: daengdaengLee <[email protected]>

---------

Signed-off-by: daengdaengLee <[email protected]>
2024-10-12 13:32:46 -04:00
ABBOUD MoncefandGitHub 590263c8d2 fix: handle incorrect cluster RESTconfig without panic (#20150)
Signed-off-by: cef <[email protected]>
2024-10-06 17:55:26 +03:00
Alexander MatyushentsevandGitHub bd895ce9c9 fix: support managing cluster with multiple argocd instances and annotation based tracking (#20222)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2024-10-04 17:54:37 -07:00
Anand Francis JosephandGitHub 0931a86aa4 chore: Added unit tests and fix e2e tests for application sync decoupling feature (#19966)
* fixed doc comments and added unit tests

Signed-off-by: anandf <[email protected]>

* Added comments for the newly added unit tests

Signed-off-by: anandf <[email protected]>

* Refactored method name to deriveServiceAccountToImpersonate

Signed-off-by: anandf <[email protected]>

* Using const name in return value

Signed-off-by: anandf <[email protected]>

* Added unit tests for argocd proj add-destination-service-accounts

Signed-off-by: anandf <[email protected]>

* Fixed failing e2e tests

Signed-off-by: anandf <[email protected]>

* Fix linting errors

Signed-off-by: anandf <[email protected]>

* Using require package instead of assert and fixed code generation

Signed-off-by: anandf <[email protected]>

* Removed parallel execution of tests for sync with impersonate

Signed-off-by: anandf <[email protected]>

* Added err checks for glob validations

Signed-off-by: anandf <[email protected]>

* Fixed e2e tests for sync impersonation

Signed-off-by: anandf <[email protected]>

* Using consistently based expects in E2E tests

Signed-off-by: anandf <[email protected]>

* Added more unit tests and fixed go generate

Signed-off-by: anandf <[email protected]>

* Fixed failed lint errors, unit and e2e test failures

Signed-off-by: anandf <[email protected]>

* Fixed goimports linter issue

Signed-off-by: anandf <[email protected]>

* Added code comments and added few missing unit tests

Signed-off-by: anandf <[email protected]>

* Added missing unit test for GetDestinationServiceAccounts method

Signed-off-by: anandf <[email protected]>

* Fixed goimports formatting with local for project_test.go

Signed-off-by: anandf <[email protected]>

* Corrected typo in a field name additionalObjs

Signed-off-by: anandf <[email protected]>

* Fixed failing unit tests

Signed-off-by: anandf <[email protected]>

---------

Signed-off-by: anandf <[email protected]>
2024-10-03 07:37:50 -07:00
afc53cc903 feat: Decoupling application sync using impersonation (#17403)
* Implementation of app sync with impersonation support

Signed-off-by: anandf <[email protected]>

* negation test

Signed-off-by: Mangaal <[email protected]>

* Update doc comments to remove server name as its not supported.

Co-authored-by: Ishita Sequeira <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>

* Update glob pattern check for matching destinations.

Co-authored-by: Ishita Sequeira <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>

* Corrected the code comments for namespace field and destination matching logic

Signed-off-by: anandf <[email protected]>

* Added missing generated files

Signed-off-by: anandf <[email protected]>

* Fixed golint errors caused due to to gofumpt validations

Signed-off-by: anandf <[email protected]>

* Fix golint errors with unit test code

Signed-off-by: anandf <[email protected]>

* Updated the go import ordering with local packages at the end

Signed-off-by: anandf <[email protected]>

* Addressed review comments

Signed-off-by: anandf <[email protected]>

* Fixed ES lint error caused due to missing class

Signed-off-by: anandf <[email protected]>

* Updated the documentation to address the review comments

Signed-off-by: anandf <[email protected]>

* Simplified the sync code and improved logs and error handling

Signed-off-by: anandf <[email protected]>

* Fixed E2E tests to fail when no sa is configured

Signed-off-by: anandf <[email protected]>

* Updated help message generated for CLI commands

Signed-off-by: anandf <[email protected]>

* Fixed failing tests due to default service account not used for sync operation

Signed-off-by: anandf <[email protected]>

* Fixed the error message when sync fails due to no matching sa

Signed-off-by: anandf <[email protected]>

* Removed repeating logs and added impersonation fields to logger

Signed-off-by: anandf <[email protected]>

* Made changes in the proposal to match the behaviour when no matching sa is found

Signed-off-by: Anand Francis Joseph <[email protected]>

---------

Signed-off-by: anandf <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
Co-authored-by: Mangaal <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
2024-09-04 14:18:47 -04:00
Michael CrenshawandGitHub e6877a6bc2 chore: remove unused params (#19473)
* chore: remove unused params

Signed-off-by: Michael Crenshaw <[email protected]>

* more

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
2024-08-15 07:29:51 -04:00
Matthieu MORELandGitHub 417ff7b19e chore: enable gofumpt and whitespace linters (#18567)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-11 15:41:55 +00:00
1796b8821e feat(application-controller): Add support for rollback multi-source applications (#14124)
* feat(application-controller): Add support for rollback multi-source applications

Signed-off-by: Jorge Turrado <[email protected]>

* regenerate codegen after rebase

Signed-off-by: Jorge Turrado <[email protected]>

* fix tests

Signed-off-by: Jorge Turrado <[email protected]>

* fix front linting

Signed-off-by: Jorge Turrado <[email protected]>

* update test

Signed-off-by: Jorge Turrado <[email protected]>

* update codegen

Signed-off-by: Jorge Turrado <[email protected]>

* Update server/application/application.go

Co-authored-by: Ishita Sequeira <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>

* apply feedback

Signed-off-by: Jorge Turrado <[email protected]>

* fix errors

Signed-off-by: Jorge Turrado <[email protected]>

* add support for switching between single and multi

Signed-off-by: Jorge Turrado <[email protected]>

* fix dereference issue

Signed-off-by: Jorge Turrado <[email protected]>

* remove unnecesary code

Signed-off-by: Jorge Turrado <[email protected]>

* Rebase master

Signed-off-by: Jorge Turrado <[email protected]>

* fix style

Signed-off-by: Jorge Turrado <[email protected]>

* fix reference

Signed-off-by: Jorge Turrado <[email protected]>

* add a comment

Signed-off-by: Jorge Turrado <[email protected]>

---------

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
2024-06-10 17:54:07 -04:00
Matthieu MORELandGitHub eb14360d0b chore: enable goimports linter (#18564)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-10 09:18:12 -04:00
9f667f77de fix: fix calculating patch for respect ignore diff feature (#17693)
* test: unit test for respectIgnoreDifferences bug

Signed-off-by: Jesse Suen <[email protected]>

* test: simplify unit test

Signed-off-by: Jesse Suen <[email protected]>

* fix: fix calculating patch for respect ignore diff feature

Signed-off-by: Alexander Matyushentsev <[email protected]>

---------

Signed-off-by: Jesse Suen <[email protected]>
Signed-off-by: Alexander Matyushentsev <[email protected]>
Co-authored-by: Jesse Suen <[email protected]>
2024-04-03 22:56:59 +00:00
812473cf92 fix: Appcontroller respects sync windows (#16492)
* fix: Appcontroller keeps op running when denied by sync window

Signed-off-by: Charles Coupal-Jetté <[email protected]>

* fix: Update test name

Signed-off-by: Charles Coupal-Jetté <[email protected]>

---------

Signed-off-by: Charles Coupal-Jetté <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
2024-03-26 08:45:35 -04:00
Sorav Kumar SharmaandGitHub b64559d732 fix the typo (#17116) 2024-02-07 18:32:07 +05:30
Robin LiebandGitHub 085bff8651 feat: add initiated by in history and rollback view (#16654)
Signed-off-by: Robin Lieb <[email protected]>
2023-12-22 16:50:33 +00:00
Leonardo Luz AlmeidaandGitHub 1946addd6f feat: Implement Server-Side Diff (#13663)
* feat: Implement Server-Side Diff

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* propagate the refreshtype to the diff config

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Create the serverSideDiff config

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* chore: add featureflag utility package

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* remove featureflag package

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* add param

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* make ssd configurable with app annotation

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* add server-side-diff flags

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* apply the same logic regardless of the refresh type

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* fix gitops-engine reference

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* address review comments

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* docs: add docs related to server-side-diff

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* docs: update doc

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Add config to include mutation webhooks

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* go mod update

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Add sdd cache test case

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* fix ssd cache unit test

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Update clidocs

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* update manifests

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Fix procfile

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* additional doc changes

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* update gitops-engine version

Signed-off-by: Leonardo Luz Almeida <[email protected]>

---------

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2023-12-18 20:37:13 +00:00
Alexander MatyushentsevandGitHub 272fbd32cb feat: PostDelete hook support (#16595)
* feat: PostDelete hooks support

Signed-off-by: Alexander Matyushentsev <[email protected]>


---------

Signed-off-by: Alexander Matyushentsev <[email protected]>
2023-12-18 08:40:23 -08:00
gdsoumyaandGitHub f63e51e7df feat: grace period for repo errors to prevent aggressive unknown sync state (#16085)
* feat: added grace period for repo errors to prevent aggressive sync state unknowns

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* feat: updated docs

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* fix: e2e test

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* feat: resolved review comments

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* feat: update unit test

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* fix: codegen

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

---------

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Signed-off-by: gdsoumya <[email protected]>
2023-11-02 11:51:16 -04:00
Blake PetterssonandGitHub 0d52a16b14 fix: update managed namespace metadata (#13074)
* fix: update managed namespace metadata

This commit fixes an issue where a namespace does not get updated
unless a sync is performed. Since the `managedNamespaceMetadata` is not
a part of the Application Git state, we need a way to force a sync once
the metadata has changed. In order to do that, we need to add state
to compare with.

Once a sync is performed, the `ManagedNamespaceMetadata` gets copied
to `SyncResult`, which will then be compared with on subsequent syncs.
If there's a mismatch between
`app.Spec.SyncPolicy.ManagedNamespaceMetadata` and
`app.Status.OperationState.SyncResult.ManagedNamespaceMetadata` we mark
the Application as `OutOfSync`.

Fixes #12661.

Signed-off-by: Blake Pettersson <[email protected]>

* fix: nil check

Signed-off-by: Blake Pettersson <[email protected]>

* fix: allow empty apps to be updated

If an app is empty but still differs in terms of
`managedNamespaceMetadata`, it should still be kept up to date.

Signed-off-by: Blake Pettersson <[email protected]>

* test: add unit tests in appcontroller

Signed-off-by: Blake Pettersson <[email protected]>

* fix: rebase

Signed-off-by: Blake Pettersson <[email protected]>

* refactor: extract method

Consolidate checks to `app.HasChangedManagedNamespaceMetadata()`

Signed-off-by: Blake Pettersson <[email protected]>

* chore: make codegen

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Blake Pettersson <[email protected]>
2023-05-19 09:55:08 -04:00
62e95ceb0b fix: Add more context to the sync failed message when resource kind doesn't exist (#12980)
* fix: add more context to k8s message

Signed-off-by: ashutosh16 <[email protected]>

* fix: add more context to k8s message

Signed-off-by: ashutosh16 <[email protected]>

* fix: add more context to k8s message

Signed-off-by: ashutosh16 <[email protected]>

* fix: add more context to k8s message

Signed-off-by: ashutosh16 <[email protected]>

* fix: add more context to k8s message

Signed-off-by: ashutosh16 <[email protected]>

* fix: add more context to k8s message

Signed-off-by: ashutosh16 <[email protected]>

* Update util/argo/argo.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: asingh <[email protected]>

* Update util/argo/argo.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: asingh <[email protected]>

* improvements, maybe

Signed-off-by: Michael Crenshaw <[email protected]>

* remove unnecessary end quote

Signed-off-by: Michael Crenshaw <[email protected]>

* avoid conflicts with other tests

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: asingh <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-04-03 15:48:50 +00:00
f6c1a78677 feat: Multiple sources for applications (#2789) (#10432)
* feat: support multiple sources for application

Signed-off-by: ishitasequeira <[email protected]>

remove debug logging and unwanted code

Signed-off-by: ishitasequeira <[email protected]>

fix lint and unit test errors

Signed-off-by: ishitasequeira <[email protected]>

fix lint and unit test errors

Signed-off-by: ishitasequeira <[email protected]>

* fix bug introduced after rebase

Signed-off-by: ishitasequeira <[email protected]>

executed make codegen

Signed-off-by: ishitasequeira <[email protected]>

* rebase with master

Signed-off-by: ishitasequeira <[email protected]>

remove unwanted logging

Signed-off-by: ishitasequeira <[email protected]>

fix ci failures

Signed-off-by: ishitasequeira <[email protected]>

* fix index out of bounds error

Signed-off-by: ishitasequeira <[email protected]>

* ui fixes

Signed-off-by: ishitasequeira <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* add revisions to SyncOperation for rollback

Signed-off-by: ishitasequeira <[email protected]>

* change Source to *ApplicationSource in ApplicationSpec

Signed-off-by: ishitasequeira <[email protected]>

* fix env variable read logic for ValueFiles

Signed-off-by: ishitasequeira <[email protected]>

* update multiple sources doc

Signed-off-by: ishitasequeira <[email protected]>

* add repository lock and checkout target revision

Signed-off-by: ishitasequeira <[email protected]>

fix codegen

Signed-off-by: ishitasequeira <[email protected]>

* checkout all sources before generating manifest

Signed-off-by: ishitasequeira <[email protected]>

generate mock reposerverclient

Signed-off-by: ishitasequeira <[email protected]>

* update logic for returning ManifestResponse to avoid nil pointer issues

Signed-off-by: ishitasequeira <[email protected]>

* fix nil reference and key mismatch bugs; add more logs (#6)

* fix nil reference and key mismatch bugs; add more logs
* remove temporary comment
* addressed the lint failure and added chart to RefTargeRevisionMapping
* normalize git repo (#7)
* do not leak lock releases
* prevent deadlock
* allow spec update
* move settings fetch outside loop
* cache busing
* return err instead of logging it
* no caching in test
* fix cache key marshaling

Signed-off-by: Michael Crenshaw <[email protected]>

Rebase with master

Signed-off-by: ishitasequeira <[email protected]>

* update grpc field numbers

Signed-off-by: ishitasequeira <[email protected]>

* path resolution tests (#12)

Signed-off-by: Michael Crenshaw <[email protected]>

do things in better ways

Signed-off-by: Michael Crenshaw <[email protected]>

consolidate

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: ishitasequeira <[email protected]>

* add regex check for value of source.ref

Signed-off-by: ishitasequeira <[email protected]>

* add webhook tests

Signed-off-by: Michael Crenshaw <[email protected]>

change Source to *ApplicationSource in ApplicationSpec

Signed-off-by: ishitasequeira <[email protected]>

address PR comments

Signed-off-by: ishitasequeira <[email protected]>

rebase with master

Signed-off-by: ishitasequeira <[email protected]>

Retrigger CI pipeline

Signed-off-by: ishitasequeira <[email protected]>

rebased with master

Signed-off-by: ishitasequeira <[email protected]>

* fix env variable read logic for ValueFiles

Signed-off-by: ishitasequeira <[email protected]>

Address PR comments

Signed-off-by: ishitasequeira <[email protected]>

* add repository lock and checkout target revision

Signed-off-by: ishitasequeira <[email protected]>

fix codegen

Signed-off-by: ishitasequeira <[email protected]>

* checkout all sources before generating manifest

Signed-off-by: ishitasequeira <[email protected]>

* generate mock reposerverclient

Signed-off-by: ishitasequeira <[email protected]>

* address comments

Signed-off-by: ishitasequeira <[email protected]>

* update logic for returning ManifestResponse to avoid nil pointer issues

Signed-off-by: ishitasequeira <[email protected]>

* fix nil reference and key mismatch bugs; add more logs (#6)

* fix nil reference and key mismatch bugs; add more logs
* remove temporary comment
* addressed the lint failure and added chart to RefTargeRevisionMapping
* normalize git repo (#7)
* do not leak lock releases
* prevent deadlock
* allow spec update
* move settings fetch outside loop
* cache busing
* return err instead of logging it
* no caching in test
* fix cache key marshaling

Signed-off-by: Michael Crenshaw <[email protected]>

Rebase with master

Signed-off-by: ishitasequeira <[email protected]>

* update grpc field numbers

Signed-off-by: ishitasequeira <[email protected]>

* add regex check for value of source.ref

Signed-off-by: ishitasequeira <[email protected]>

* Rebase with master

Signed-off-by: ishitasequeira <[email protected]>

* Added unit tests (#15)

* add unit tests 1
* fix lint

Signed-off-by: ishitasequeira <[email protected]>

* fix application parameters tab, rebased UI changes, tests

Signed-off-by: ishitasequeira <[email protected]>

* More tests (#16)

* more tests

Signed-off-by: Michael Crenshaw <[email protected]>

fix lint error

Signed-off-by: ishitasequeira <[email protected]>

Test get ref sources (#17)

* test GetRefSources

Signed-off-by: Michael Crenshaw <[email protected]>

* fix lint

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: ishitasequeira <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: ishitasequeira <[email protected]>

GenerateManifests test (#18)

* GenerateManifests test

Signed-off-by: Michael Crenshaw <[email protected]>

Fix broken tests (#19)

* fix broken tests

Signed-off-by: Michael Crenshaw <[email protected]>

Symlink test (#20)

* check referenced sources for out-of-bounds symlinks

Signed-off-by: Michael Crenshaw <[email protected]>

* unlock the values file repo before doing a symlink check (#22)

Signed-off-by: Michael Crenshaw <[email protected]>

* multi source docs (#21)

* multi source docs

Signed-off-by: Michael Crenshaw <[email protected]>

* fix warning title

Signed-off-by: Michael Crenshaw <[email protected]>

* clarify

Signed-off-by: Michael Crenshaw <[email protected]>

* clarify

Signed-off-by: Michael Crenshaw <[email protected]>

Signed-off-by: Michael Crenshaw <[email protected]>

* add e2e tests for multiple sources and fix UI lint (#23)

* add e2e tests for multiple sources and fix UI lint

Signed-off-by: ishitasequeira <[email protected]>

* add auto-sync and hard refresh to e2e tests

Signed-off-by: ishitasequeira <[email protected]>

* change refresh type to RefreshTypeNormal for e2e

Signed-off-by: ishitasequeira <[email protected]>

* update e2e testcase with helm data

Signed-off-by: ishitasequeira <[email protected]>

* add TestMultiSourceAppWithSourceOverride

Signed-off-by: ishitasequeira <[email protected]>

* add missing yaml file

Signed-off-by: ishitasequeira <[email protected]>

Signed-off-by: ishitasequeira <[email protected]>

* rebase with master

Signed-off-by: ishitasequeira <[email protected]>

* rebase with master

Signed-off-by: ishitasequeira <[email protected]>

* fix lint

Signed-off-by: ishitasequeira <[email protected]>

Signed-off-by: ishitasequeira <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2022-12-16 15:47:08 -05:00
cf61c74192 feat: enable metadata to be set on namespaces (#10672)
* namespace labels

Signed-off-by: pashavictorovich <[email protected]>

* create namespace should support annotations

Signed-off-by: pashavictorovich <[email protected]>

* handle also modification hook

Signed-off-by: pashavictorovich <[email protected]>

* regenerate entity on modify hook

Signed-off-by: pashavictorovich <[email protected]>

* manifests

Signed-off-by: pashavictorovich <[email protected]>

* feat: enable metadata to be set on namespaces

This builds upon the work that @pasha-codefresh did in #10288.

The main differences between this PR and the previous one is that we use
SSA to diff between different versions of the namespace, as well as
having a slightly different API in gitops-engine for setting the
namespace modifier.

We now also set the ownership of the namespace in ArgoCD.

Closes #4628
Closes #6215
Closes #7799

Signed-off-by: Blake Pettersson <[email protected]>

* fix: don't always track namespaces

For now, only allow namespaces managed with `managedNamespaceMetadata`
to have tracking set by Argo. Ideally we'd like new namespaces to also
be tracked by Argo, but there's currently an issue with a failing
integration test.

Also wrap error message if setting the app instance errors on the
namespace.

Signed-off-by: Blake Pettersson <[email protected]>

* fix: always return true with `hasManagedMetadata`

If `hasManagedMetadata` is set, `true` should always be returned.

Signed-off-by: Blake Pettersson <[email protected]>

* docs: add clarifying docs on resource tracking

Signed-off-by: Blake Pettersson <[email protected]>

* style: pr tweaks

Signed-off-by: Blake Pettersson <[email protected]>

* fix: re-add label unsetting

Signed-off-by: Blake Pettersson <[email protected]>

* Update gitops-engine to current master

Signed-off-by: Leonardo Luz Almeida <[email protected]>

Signed-off-by: pashavictorovich <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Co-authored-by: pashavictorovich <[email protected]>
Co-authored-by: Leonardo Luz Almeida <[email protected]>
2022-11-04 08:59:16 -04:00
Leonardo Luz AlmeidaandGitHub 64389b8e39 fix: handle apiGroup updates in resource-tracking (#11012)
* fix: handle apiGroup updates in resource-tracking

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Fix test

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* change the fix approach by inspecting tracking id from the config

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* add unit-test to validate the scenario

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* fix test lint

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* review fixes

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Reword godocs for clarity

Signed-off-by: Leonardo Luz Almeida <[email protected]>

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2022-11-03 15:02:13 -04:00
Blake PetterssonandGitHub 839188e760 feat: add permitOnlyProjectScopedClusters flag (#10237)
This commit adds a new flag, `permitOnlyProjectScopedClusters`, which
prevents any application from syncing to clusters which are not a part
of the same project. Fixes #10220.

Signed-off-by: Blake Pettersson <[email protected]>

Signed-off-by: Blake Pettersson <[email protected]>
2022-09-08 07:33:10 -04:00
jannfisandGitHub 75d334705a feat: Applications in any namespace (#9755)
* feat: Applications in any namespace

Signed-off-by: jannfis <[email protected]>

* Fix typo in CI

Signed-off-by: jannfis <[email protected]>

* Create argocd-e2e-external namespace

Signed-off-by: jannfis <[email protected]>

* Update from codegen

Signed-off-by: jannfis <[email protected]>

* Remove debug code

Signed-off-by: jannfis <[email protected]>

* Update help text for -N option to app create

Signed-off-by: jannfis <[email protected]>

* Wrap error when retrieving AppProject from cache

Signed-off-by: jannfis <[email protected]>

* Check for controller namespace first before matching on additional ns

Signed-off-by: jannfis <[email protected]>

* Improve TestAppProjectIsSourceNamespacePermitted unit test

Signed-off-by: jannfis <[email protected]>

* Get rid of some debug leftovers

Signed-off-by: jannfis <[email protected]>

* Better error wrapping; return IsNotFound as-is

Signed-off-by: jannfis <[email protected]>

* Updates from codegen

Signed-off-by: jannfis <[email protected]>

* We don't need AppShortName() anymore

Signed-off-by: jannfis <[email protected]>

* Update end-to-end tests to use annotation methods

Signed-off-by: jannfis <[email protected]>

* Add e2e tests to test for app creation in not permitted ns

Signed-off-by: jannfis <[email protected]>

* Remove deprecated code

Signed-off-by: jannfis <[email protected]>

* Remove dead code

Signed-off-by: jannfis <[email protected]>

* Add RBACName() method to application type

Signed-off-by: jannfis <[email protected]>

* Update from codegen

Signed-off-by: jannfis <[email protected]>

* Fix e2e test

Signed-off-by: jannfis <[email protected]>

* Update codegen

Signed-off-by: jannfis <[email protected]>

* Move RBAC name generation to an application receiver

Signed-off-by: jannfis <[email protected]>

* Fix sync window status in UI

Signed-off-by: jannfis <[email protected]>

* Fix pod logs viewer

Signed-off-by: jannfis <[email protected]>

* Fix application events in UI

Signed-off-by: jannfis <[email protected]>

* Fix application search in UI

Signed-off-by: jannfis <[email protected]>

* Fix yarn lint

Signed-off-by: jannfis <[email protected]>

* Only set up cluster-wide application informer when additional namespaces are specified

Signed-off-by: jannfis <[email protected]>

* Adapt e2e test to a changed error message

Signed-off-by: jannfis <[email protected]>

* Application namespace should be taken into account for create

Signed-off-by: jannfis <[email protected]>

* Use non-qualified application name as Helm release name

Signed-off-by: jannfis <[email protected]>

* Support --app-namespace in e2e tests

Signed-off-by: jannfis <[email protected]>

* Enable more e2e tests

Signed-off-by: jannfis <[email protected]>

* Increase e2e timeout for newly added tests

Signed-off-by: jannfis <[email protected]>
2022-08-10 11:39:10 +02:00
jannfisandGitHub 6928397473 fix: Ignore non-self-referencing resources while pruning (#10198)
* fix: Ignore non-self-referencing resources while pruning

Signed-off-by: jannfis <[email protected]>

* Pull in latest gitops-engine code

Signed-off-by: jannfis <[email protected]>

* Revert a replace in go.mod

Signed-off-by: jannfis <[email protected]>
2022-08-08 19:37:45 +02:00
Leonardo Luz AlmeidaandGitHub a6a133d80f feat: Introduces Server-Side Apply as sync option (#9711)
* feat: Introduces Server-Side Apply as sync option

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* add docs

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Implement the structured-merge diff when ssa is enabled

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* update gitops-engine

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* update gitops-engine

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* go mod tidy

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Add server-side apply option to the UI

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* update gitops-engine to master

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* fix live default values

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2022-08-05 19:16:35 -04:00
Michael CrenshawandGitHub ccdcb1b7ec Merge pull request from GHSA-2m7h-86qq-fp4v
Signed-off-by: Michael Crenshaw <[email protected]>

fix references

Signed-off-by: Michael Crenshaw <[email protected]>

use long enough state param for oauth2

Signed-off-by: Michael Crenshaw <[email protected]>

typo

Signed-off-by: Michael Crenshaw <[email protected]>

more entropy

Signed-off-by: Michael Crenshaw <[email protected]>

fix test

Signed-off-by: Michael Crenshaw <[email protected]>
2022-06-21 09:39:01 -04:00
Leonardo Luz AlmeidaandGitHub 4cebcfc61e fix: Ignore diff with schema (#9170) 2022-05-31 13:21:22 -04:00
Leonardo Luz AlmeidaandGitHub ad239171e0 feat: Allow configuring system wide ignore differences for all resources (#8224)
* feat: Allow configuring system wide ignore differences for all resources

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Add example config to argocd-cm.yaml

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2022-01-19 14:57:43 -08:00
Leonardo Luz AlmeidaandGitHub bab3ef805a feat: new sync option to use ignore diff configs during sync (#8078)
feat: new sync option to use ignore diff configs during sync (#8078)

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2022-01-13 13:00:17 -08:00
Leonardo Luz AlmeidaandGitHub 6dcaa08173 feat: add new sync option to fail if finds shared resources (#7444)
* feat: add new sync option to fail if finds shared resources

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* docs: add docs for FailOnSharedResource sync option

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2021-10-20 08:06:41 -07:00
pasha-codefreshandGitHub 74c7247f1e feat: Cluster name as part of sync (#7394)
feat: Cluster name as part of sync (#7394)

Signed-off-by: pashavictorovich <[email protected]>
2021-10-18 18:44:54 -07:00
pasha-codefreshandGitHub 7303e9c0a8 feat: Project scoped repo (#6943)
feat: Project scoped repo (#6943)

Signed-off-by: pashavictorovich <[email protected]>
2021-08-16 09:38:37 -07:00
Alexander MatyushentsevandGitHub c0caa8a56e refactor: upgrade gitops engine (argoproj/gitops-engine/#286) (#6491)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-06-17 12:06:18 -07:00
Alexander MatyushentsevandGitHub e12ed94912 fix: avoid possible nip pointer dereference during syncing (#6354)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-05-28 07:25:35 -07:00
Alexander MatyushentsevandGitHub 22a84a2fac refactor: upgrade k8s client to v0.21.0 (#6322)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-05-27 10:20:53 -07:00
Alexander MatyushentsevandGitHub e6a4826232 feat: cache resolved git/helm repository revisions (#6102)
* feat: cache resolved git/helm repository revisions

Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-05-19 12:30:15 -07:00
1d472ba293 chore: Upgrade Go module to v2 (#5931)
* chore: Upgrade Go module to v2

Signed-off-by: jannfis <[email protected]>

* Restore import order

Signed-off-by: jannfis <[email protected]>

* fix knowntypes_normalizer codegen error

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix codegen

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix Procfile

Signed-off-by: Alexander Matyushentsev <[email protected]>

Co-authored-by: Alexander Matyushentsev <[email protected]>
2021-04-01 20:44:18 +02:00
Alexander MatyushentsevandGitHub 145b7aaddd feat: Support kubectl replace instead of apply (#2730) (#5802)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-03-17 22:02:43 -07:00