Commit Graph
176 Commits
Author SHA1 Message Date
Soumya Ghosh DastidarandGitHub f9e16abde7 chore: update mockery version (#22126)
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
2025-03-03 16:57:20 +02:00
3a24e1732a feat: add bearer token auth (#21462)
Signed-off-by: reggie-k <[email protected]>
Co-authored-by: Pasha Kostohrys <[email protected]>
2025-02-24 12:44:07 +02:00
Matthieu MORELandGitHub be13c7b8a8 chore: enable var-naming from revive (#21861)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-02-18 11:02:38 -05:00
Matthieu MORELandGitHub 2fa86b1259 chore: use testify instead of native testing (#21781)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-02-05 09:46:52 -05:00
Matthieu MORELandGitHub 3bfa4e0cb8 chore: enable several rules from revive (#21638)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-22 21:32:09 +00:00
Matthieu MORELandGitHub eeba57b115 chore: enable nolintlint (#21559)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-21 13:49:14 -05:00
e7897666b3 feat: Add support for Azure workload identity for Git and OCI repositories. (#21118)
---------

Signed-off-by: Jagpreet Singh Tamber <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]>
2025-01-17 12:33:36 -05:00
8334da36f2 Bump major version to 3 (#21410)
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: crenshaw-dev <[email protected]>
2025-01-10 16:14:00 -05:00
Matthieu MORELandGitHub a0d38d653a chore: enable early-return from revive (#21423)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-08 15:26:02 -05:00
Matthieu MORELandGitHub 064b5ae081 chore: enable indent-error-flow from revive (#21394)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-07 10:25:22 -05:00
Matthieu MORELandGitHub eec6f8526a chore: enable unused-parameter from revive (#21365)
* chore: enable unused-parameter from revive

Signed-off-by: Matthieu MOREL <[email protected]>

* apply recommandations

Signed-off-by: Matthieu MOREL <[email protected]>

---------

Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-07 10:12:56 -05:00
Matthieu MORELandGitHub bc8756f606 chore: enable receiver-naming from revive (#21372)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-06 14:45:11 -05:00
Matthieu MORELandGitHub bda1b76bd6 chore: enable superfluous-else from revive (#21373)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-06 11:41:38 -05:00
Matthieu MORELandGitHub 75e3d10f27 chore: enable var-declaration from revive (#21370)
Signed-off-by: Matthieu MOREL <[email protected]>
2025-01-03 18:44:23 -05:00
Matthieu MORELandGitHub c85bb38a83 chore: enable errorf of perfsprint linter (#21280)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-12-30 10:56:41 +02:00
Matthieu MORELandGitHub 4156151f8f chore: enable err-error and strconcat of perfsprint linter (#21267)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-12-20 16:22:28 +00:00
Michael CrenshawandGitHub ba889a0c86 feat: source hydrator (#20345)
* feat(hydrator): add sourceHydrator types

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

fix(codegen): use kube_codegen.sh deepcopy and client gen correctly

Signed-off-by: Michael Crenshaw <[email protected]>

deepcopy gen

Signed-off-by: Michael Crenshaw <[email protected]>

* feat(hydrator): add commit-server component

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

go mod tidy

Signed-off-by: Michael Crenshaw <[email protected]>

one test file for both implementations

Signed-off-by: Michael Crenshaw <[email protected]>

simplify

Signed-off-by: Michael Crenshaw <[email protected]>

fix test for linux

Signed-off-by: Michael Crenshaw <[email protected]>

fix git client mock

Signed-off-by: Michael Crenshaw <[email protected]>

fix git client mock

Signed-off-by: Michael Crenshaw <[email protected]>

address comments

Signed-off-by: Michael Crenshaw <[email protected]>

unit tests

Signed-off-by: Michael Crenshaw <[email protected]>

lint

Signed-off-by: Michael Crenshaw <[email protected]>

fix image, fix health checks, fix merge issue

Signed-off-by: Michael Crenshaw <[email protected]>

fix lint issues

Signed-off-by: Michael Crenshaw <[email protected]>

remove code that doesn't work for GHE

Signed-off-by: Michael Crenshaw <[email protected]>

changes from comments

Signed-off-by: Michael Crenshaw <[email protected]>

* feat(hydrator): enable controller

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

feat(hydrator): enable controller

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

allow opt-in

Signed-off-by: Michael Crenshaw <[email protected]>

separation between app controller and hydrator

Signed-off-by: Michael Crenshaw <[email protected]>

simplify diff

Signed-off-by: Michael Crenshaw <[email protected]>

todos

Signed-off-by: Michael Crenshaw <[email protected]>

simplify

Signed-off-by: Michael Crenshaw <[email protected]>

add dry sha to logs

Signed-off-by: Michael Crenshaw <[email protected]>

add app name to logs

Signed-off-by: Michael Crenshaw <[email protected]>

more logging, no caching

Signed-off-by: Michael Crenshaw <[email protected]>

fix cluster install

Signed-off-by: Michael Crenshaw <[email protected]>

don't interrupt an ongoing hydrate operation

Signed-off-by: Michael Crenshaw <[email protected]>

revert hydrate loop fix

Signed-off-by: Michael Crenshaw <[email protected]>

handle project-scoped repo creds

Signed-off-by: Michael Crenshaw <[email protected]>

codegen

Signed-off-by: Michael Crenshaw <[email protected]>

improve docs

Signed-off-by: Michael Crenshaw <[email protected]>

fixes from comments

Signed-off-by: Michael Crenshaw <[email protected]>

* set hydrator enabled key when using hydrator manifests

Signed-off-by: Michael Crenshaw <[email protected]>

fix manifests

Signed-off-by: Michael Crenshaw <[email protected]>

improve docs

Signed-off-by: Michael Crenshaw <[email protected]>

* feat(hydrator): enable controller

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

feat(hydrator): enable controller

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

allow opt-in

Signed-off-by: Michael Crenshaw <[email protected]>

separation between app controller and hydrator

Signed-off-by: Michael Crenshaw <[email protected]>

simplify diff

Signed-off-by: Michael Crenshaw <[email protected]>

todos

Signed-off-by: Michael Crenshaw <[email protected]>

simplify

Signed-off-by: Michael Crenshaw <[email protected]>

add dry sha to logs

Signed-off-by: Michael Crenshaw <[email protected]>

add app name to logs

Signed-off-by: Michael Crenshaw <[email protected]>

more logging, no caching

Signed-off-by: Michael Crenshaw <[email protected]>

fix cluster install

Signed-off-by: Michael Crenshaw <[email protected]>

don't interrupt an ongoing hydrate operation

Signed-off-by: Michael Crenshaw <[email protected]>

revert hydrate loop fix

Signed-off-by: Michael Crenshaw <[email protected]>

handle project-scoped repo creds

Signed-off-by: Michael Crenshaw <[email protected]>

codegen

Signed-off-by: Michael Crenshaw <[email protected]>

improve docs

Signed-off-by: Michael Crenshaw <[email protected]>

fixes from comments

Signed-off-by: Michael Crenshaw <[email protected]>

* feat(hydrator): add sourceHydrator types

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

fix(codegen): use kube_codegen.sh deepcopy and client gen correctly

Signed-off-by: Michael Crenshaw <[email protected]>

deepcopy gen

Signed-off-by: Michael Crenshaw <[email protected]>

* feat(hydrator): enable controller

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

feat(hydrator): enable controller

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

allow opt-in

Signed-off-by: Michael Crenshaw <[email protected]>

separation between app controller and hydrator

Signed-off-by: Michael Crenshaw <[email protected]>

simplify diff

Signed-off-by: Michael Crenshaw <[email protected]>

todos

Signed-off-by: Michael Crenshaw <[email protected]>

simplify

Signed-off-by: Michael Crenshaw <[email protected]>

add dry sha to logs

Signed-off-by: Michael Crenshaw <[email protected]>

add app name to logs

Signed-off-by: Michael Crenshaw <[email protected]>

more logging, no caching

Signed-off-by: Michael Crenshaw <[email protected]>

fix cluster install

Signed-off-by: Michael Crenshaw <[email protected]>

don't interrupt an ongoing hydrate operation

Signed-off-by: Michael Crenshaw <[email protected]>

revert hydrate loop fix

Signed-off-by: Michael Crenshaw <[email protected]>

handle project-scoped repo creds

Signed-off-by: Michael Crenshaw <[email protected]>

codegen

Signed-off-by: Michael Crenshaw <[email protected]>

* feat(hydrator): write credentials handling + UI

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

feat(hydrator): enable controller

Co-authored-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Omer Azmon <[email protected]>
Co-authored-by: daengdaengLee <[email protected]>
Co-authored-by: Juwon Hwang (Kevin) <[email protected]>
Co-authored-by: thisishwan2 <[email protected]>
Co-authored-by: mirageoasis <[email protected]>
Co-authored-by: Robin Lieb <[email protected]>
Co-authored-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

allow opt-in

Signed-off-by: Michael Crenshaw <[email protected]>

separation between app controller and hydrator

Signed-off-by: Michael Crenshaw <[email protected]>

simplify diff

Signed-off-by: Michael Crenshaw <[email protected]>

todos

Signed-off-by: Michael Crenshaw <[email protected]>

simplify

Signed-off-by: Michael Crenshaw <[email protected]>

add dry sha to logs

Signed-off-by: Michael Crenshaw <[email protected]>

add app name to logs

Signed-off-by: Michael Crenshaw <[email protected]>

more logging, no caching

Signed-off-by: Michael Crenshaw <[email protected]>

fix cluster install

Signed-off-by: Michael Crenshaw <[email protected]>

don't interrupt an ongoing hydrate operation

Signed-off-by: Michael Crenshaw <[email protected]>

revert hydrate loop fix

Signed-off-by: Michael Crenshaw <[email protected]>

feat(hydrator): write credentials handling + UI

Signed-off-by: Michael Crenshaw <[email protected]>

WIP: add new APIs for write creds

Signed-off-by: Michael Crenshaw <[email protected]>

write api and template api

Signed-off-by: Michael Crenshaw <[email protected]>

fix time function

Signed-off-by: Michael Crenshaw <[email protected]>

fix lint issues

Signed-off-by: Michael Crenshaw <[email protected]>

don't enrich with read creds

Signed-off-by: Michael Crenshaw <[email protected]>

revert tls change

Signed-off-by: Michael Crenshaw <[email protected]>

don't disable buttons in UI

Signed-off-by: Michael Crenshaw <[email protected]>

ask repo server for specific revision

Signed-off-by: Michael Crenshaw <[email protected]>

fixes

Signed-off-by: Michael Crenshaw <[email protected]>

lint ui

Signed-off-by: Michael Crenshaw <[email protected]>

remove unnecessary change

Signed-off-by: Michael Crenshaw <[email protected]>

fix test and lint

Signed-off-by: Michael Crenshaw <[email protected]>

lint

Signed-off-by: Michael Crenshaw <[email protected]>

enable hydrator for e2e tests

Signed-off-by: Michael Crenshaw <[email protected]>

* free disk space for e2e tests

Signed-off-by: Michael Crenshaw <[email protected]>

don't free disk space

Signed-off-by: Michael Crenshaw <[email protected]>

* free disk space for e2e tests

Signed-off-by: Michael Crenshaw <[email protected]>

* remove comment that breaks auth

Signed-off-by: Michael Crenshaw <[email protected]>

* try removing extra function

Signed-off-by: Michael Crenshaw <[email protected]>

* cleanup from comments

Signed-off-by: Michael Crenshaw <[email protected]>

* fix test

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
2024-12-16 16:59:09 -05:00
Andrii KorotkovandGitHub 3966e4fda2 fix: Allow to delete repos with invalid urls (#20921) (#20975)
* fix: Allow to delete repos with invalid urls (#20921)

Fixes #20921

Normalization of repo url is attempted during repo deletion before comparison with existing repos. Before this change, it'd fail on invalid urls and return "", resulting in permission denied. This ended up in a state where people can add repos with invalid urls but couldn't delete them. Return raw repo url if url parsing failed. Add a test to validate the deletion can be performed and make sure it fails without the main change.

This needs to be cherry-picked to v2.11-2.13

Signed-off-by: Andrii Korotkov <[email protected]>

* Don't modify the original NormalizeGitURL

Signed-off-by: Andrii Korotkov <[email protected]>

---------

Signed-off-by: Andrii Korotkov <[email protected]>
2024-12-02 14:00:35 +02:00
Matthieu MORELandGitHub 478219ef2e chore: enable perfsprint linter (#20685)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-11-10 21:00:57 -05:00
60d88bf029 fix: allow pipes to be present in git username (#20040)
* fix: [#15949] split git revision metadata by newline not pipe symbol

pipe symbol '|' could appear in username or commit message body

Signed-off-by: Petr Studeny <[email protected]>

* test: add test

Signed-off-by: Blake Pettersson <[email protected]>

* Update util/git/client_test.go

Co-authored-by: Petr Studeny <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>

* test: fix test

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Petr Studeny <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
Co-authored-by: Petr Studeny <[email protected]>
2024-10-08 08:10:46 -04:00
Paul LarsenandGitHub b5a80450f2 fix: Rework git tag semver resolution (#20083) (#20096)
* Write initial tests

Signed-off-by: Paul Larsen <[email protected]>

* Improve git tag semver resolution

Signed-off-by: Paul Larsen <[email protected]>

* Add company to list of users

Signed-off-by: Paul Larsen <[email protected]>

* Fix broken error string check

Signed-off-by: Paul Larsen <[email protected]>

* Fix incorrect semver test assumption

Signed-off-by: Paul Larsen <[email protected]>

* switch to debug statement

Signed-off-by: Paul Larsen <[email protected]>

* Add more testcases for review

Signed-off-by: Paul Larsen <[email protected]>

* review comments

Signed-off-by: Paul Larsen <[email protected]>

---------

Signed-off-by: Paul Larsen <[email protected]>
2024-10-03 15:52:01 +05:30
8853d070d5 fix: Fix semver resolution (#19644)
Signed-off-by: Pierre Lebrun <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
2024-09-03 18:48:32 +00:00
Nathanael LiechtiandGitHub 626f237eb2 feat: allow no_proxy to be specified on repoCreds (#18526)
Signed-off-by: Nathanael Liechti <[email protected]>
2024-08-20 12:54:39 -04:00
Michael CrenshawandGitHub 0d1c577b98 feat(askpass): make askpass socket path configurable (#19313)
* feat(askpass): make askpass socket path configurable

Signed-off-by: Michael Crenshaw <[email protected]>

* remove unused const

Signed-off-by: Michael Crenshaw <[email protected]>

* remove unnecessary fmt call

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
2024-08-01 13:12:41 -04:00
Cayde6andGitHub 2d535b4aed chore(migrate): migrate mockery codegen to use packages(#18579) (#18617)
* chore(migrate): mockery migrate to packages

migrate interface
- remove go:generate
- generate mock

Signed-off-by: Jack-R-lantern <[email protected]>

* chore(migrate: mockery migrate to package

add mockgen stage
- add mockgen command to Makefile
- add generate-mock.sh
- add install mockery to install-codegen-go-tool.sh

Signed-off-by: Jack-R-lantern <[email protected]>

---------

Signed-off-by: Jack-R-lantern <[email protected]>
2024-07-02 10:48:38 -04:00
49336d601c feat(reposerver): Skip calling git fetch if commit to checkout exists locally (#18657)
* Skip fetch if revision to check out exists locally

Signed-off-by: Shady Rafehi <[email protected]>

* Test reposerver/repository.checkoutRevision

Signed-off-by: Shady Rafehi <[email protected]>

* Test client.IsRevisionPresent

Signed-off-by: Shady Rafehi <[email protected]>

* Signoff

Signed-off-by: Shady Rafehi <[email protected]>

* Update reposerver/repository/repository.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Shady Rafehi <[email protected]>

---------

Signed-off-by: Shady Rafehi <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2024-06-15 15:10:13 -04:00
Matthieu MORELandGitHub c9777278bc chore: extend require-error rule from testifylint (#18681)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-15 13:51:18 -04:00
4a16d5fc68 feat(appset): appset git generator verifies GPG signatures (#18545)
* feat(appset): appset git generator verifies GPG signatures

Signed-off-by: ishitasequeira <[email protected]>

* fix unit tests

Signed-off-by: ishitasequeira <[email protected]>

* fix generated code

Signed-off-by: ishitasequeira <[email protected]>

* add check for signatures in project and fix tests

Signed-off-by: ishitasequeira <[email protected]>

* fix tests

Signed-off-by: ishitasequeira <[email protected]>

* add e2e tests

Signed-off-by: ishitasequeira <[email protected]>

* address golang ci lint issue

Signed-off-by: ishitasequeira <[email protected]>

* fix golangci lint

Signed-off-by: ishitasequeira <[email protected]>

* Address comments

Signed-off-by: ishitasequeira <[email protected]>

* rebase and resolve conflicts

Signed-off-by: ishitasequeira <[email protected]>

---------

Signed-off-by: ishitasequeira <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
2024-06-12 07:57:25 +00:00
Matthieu MORELandGitHub 417ff7b19e chore: enable gofumpt and whitespace linters (#18567)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-11 15:41:55 +00:00
Matthieu MORELandGitHub 483a5e85a0 chore: enable errorlint linter on util folder (#18588)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-11 10:42:32 -04:00
Matthieu MORELandGitHub 6042442da4 chore: enable error-nil rule from testifylint linter (#18544)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-10 10:38:55 -04:00
Matthieu MORELandGitHub eb14360d0b chore: enable goimports linter (#18564)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-10 09:18:12 -04:00
Matthieu MORELandGitHub 8421ddbc37 chore: enable len and empty rules from testifylint linter (#18516)
Signed-off-by: Matthieu MOREL <[email protected]>
2024-06-07 15:12:50 -04:00
Pablo AguilarandGitHub 85a04489d9 feat: changes git client to resolve semantic versioning tags (#17566)
* feat: changes git client to resolve semantic versioning tags

Signed-off-by: Pablo Aguilar <[email protected]>

* docs: update documentation

Signed-off-by: Pablo Aguilar <[email protected]>

* feat: simplify `resolveSemverRevision` method

Signed-off-by: Pablo Aguilar <[email protected]>

* chore: add two more test cases

Signed-off-by: Pablo Aguilar <[email protected]>

* chore: update `resolveSemverRevision` behavior

Signed-off-by: Pablo Aguilar <[email protected]>

* chore: add end to end test

Signed-off-by: Pablo Aguilar <[email protected]>

* chore: fix end to end test

Signed-off-by: Pablo Aguilar <[email protected]>

* chore: improve semver constraint e2e testing

Signed-off-by: Pablo Aguilar <[email protected]>

---------

Signed-off-by: Pablo Aguilar <[email protected]>
2024-06-05 20:25:06 -04:00
Matthieu MORELandGitHub 118fd87fc3 fix: enable bool-compare rule from testifylint linter (#18414) 2024-06-05 18:13:45 -04:00
5c010b3720 chore: automate mock generation v2 (#18371)
* Add go:generate statements for mockery

Signed-off-by: Will Roden <[email protected]>

* revert whitespace change

Signed-off-by: Will Roden <[email protected]>

* go generate everything

Signed-off-by: Will Roden <[email protected]>

* make gogen

Signed-off-by: Will Roden <[email protected]>

* chore: upgrade to mockery v2.40.2

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Will Roden <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
Co-authored-by: Will Roden <[email protected]>
2024-05-23 11:15:15 +03:00
Leonardo Luz AlmeidaandGitHub fba20709d5 chore: fix unit-tests (#18215)
Signed-off-by: Leonardo Luz Almeida <[email protected]>
2024-05-14 13:30:57 -04:00
Jonathan WestandGitHub add5d9ff09 fix: prevent leak of files to /dev/shm in corner cases (#17658) (#17659)
Signed-off-by: Jonathan West <[email protected]>
2024-04-11 11:47:38 +00:00
Alexy ManthaandGitHub 94ec1faff6 chore: cleanup follow up for enforce manifest generate path (#15636) (#17761)
* cleanup

Signed-off-by: Alexy Mantha <[email protected]>

* update docs

Signed-off-by: Alexy Mantha <[email protected]>

---------

Signed-off-by: Alexy Mantha <[email protected]>
2024-04-07 13:26:33 -04:00
cf3b2fd8ad feat(controller): use manifest generate path during comparison (#14242) (#15636)
* squash commits

Signed-off-by: Alexy Mantha <[email protected]>

* Update util/git/client.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Alexy Mantha <[email protected]>

* fix error message

Signed-off-by: Alexy Mantha <[email protected]>

* add git client options

Signed-off-by: Alexy Mantha <[email protected]>

* Update generated code

Signed-off-by: Alexy Mantha <[email protected]>

* run fmt

Signed-off-by: Alexy Mantha <[email protected]>

* fix tests

Signed-off-by: Alexy Mantha <[email protected]>

* failed gen

Signed-off-by: Alexy Mantha <[email protected]>

* tweak logs and rename cache

Signed-off-by: Alexy Mantha <[email protected]>

* validate revisions

Signed-off-by: Alexy Mantha <[email protected]>

* fix tests

Signed-off-by: Alexy Mantha <[email protected]>

* fix tests

Signed-off-by: Alexy Mantha <[email protected]>

* fmt

Signed-off-by: Alexy Mantha <[email protected]>

* fix linting

Signed-off-by: Alexy Mantha <[email protected]>

* fixes from review

Signed-off-by: Alexy Mantha <[email protected]>

* generate

Signed-off-by: Alexy Mantha <[email protected]>

* fix

Signed-off-by: Alexy Mantha <[email protected]>

* use log context

Signed-off-by: Alexy Mantha <[email protected]>

---------

Signed-off-by: Alexy Mantha <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2024-04-04 16:01:11 -04:00
a52ee3f25e fix(repo-server): excess git requests, add shared cache lock on revisions (Issue #14725) (#17109)
* fix(repo-server): excess git requests, cache lock on revisions

Signed-off-by: nromriell <[email protected]>

* fix: pr feedback, simplify, add configurable variable

Signed-off-by: nromriell <[email protected]>

* fix: codegen, lint

Signed-off-by: nromriell <[email protected]>

* fix: test print, no opts set, var type nit

Signed-off-by: nromriell <[email protected]>

* chore: add additional logging for unexpected cache error

Signed-off-by: nromriell <[email protected]>

---------

Signed-off-by: nromriell <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
2024-03-25 11:26:14 -04:00
Anand Francis JosephandGitHub 286cd7aa51 Added socks5 proxy support for ssh based git URL, upgraded go-git to 5.10.1 (#15864)
Signed-off-by: Anand Francis Joseph <[email protected]>
2024-01-09 09:41:12 -05:00
Alexander MatyushentsevandGitHub 2941adef9a feat: make git requests configurable (#15646)
* feat: make git requests configurable

Signed-off-by: Alexander Matyushentsev <[email protected]>

* docs: mention new settings in 'argocd-cmd-params-cm' configmap

Signed-off-by: Alexander Matyushentsev <[email protected]>

* add comment about ignored error

Signed-off-by: Alexander Matyushentsev <[email protected]>

---------

Signed-off-by: Alexander Matyushentsev <[email protected]>
2023-10-24 20:41:22 +00:00
Eng Zer JunandGitHub 9807275c7b chore: use t.Setenv to set env vars in tests (#14377)
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.Setenv

Signed-off-by: Eng Zer Jun <[email protected]>
2023-07-06 19:50:08 -04:00
satoruandGitHub 67a6f1411e chore: just use strings.TrimSuffix (#14248)
It's implemented in the same way in the standard library.

Signed-off-by: satoru <[email protected]>
2023-06-28 09:46:49 -04:00
jannfisandGitHub 85ba1c2775 fix: Correctly verify signatures when targetRevision is a branch name (#14214)
* fix: Correctly verify signatures when targetRevision is a branch name

Signed-off-by: jannfis <[email protected]>

* Add more e2e tests

Signed-off-by: jannfis <[email protected]>

* Fix a bug and add unit test

Signed-off-by: jannfis <[email protected]>

---------

Signed-off-by: jannfis <[email protected]>
2023-06-27 10:56:45 -04:00
Michael CrenshawandGitHub 0e402645c6 fix(cmp): discover plugins relative to app path (#13940) (#13946)
* fix(cmp): discover plugins relative to app path (#13940)

Signed-off-by: Michael Crenshaw <[email protected]>

* securejoin

Signed-off-by: Michael Crenshaw <[email protected]>

* intuitive constant names

Signed-off-by: Michael Crenshaw <[email protected]>

* comments

Signed-off-by: Michael Crenshaw <[email protected]>

* add missing import

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
2023-06-15 21:17:04 +00:00
9f56010bb7 fix: add optional safer Git file generator globbing (#13313) (#13314)
Signed-off-by: Denis Dupeyron <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
2023-05-27 21:15:03 -04:00
Yann SoubeyrandandGitHub 4a13a39830 fix(repo-server): completely clean up Git working directory (#3683) (#13001)
* refactor(util/git/client): make runCredentialedCmd() signature coherent with runCmd() one

Signed-off-by: Yann Soubeyrand <[email protected]>

* fix(repo-server): completely clean up Git working directory

In some cases, for example when a Git submodule wasn’t present anymore
in a Git revision, the repo-server didn’t completely clean up its Git
working directory.

Fixes #3683

Signed-off-by: Yann Soubeyrand <[email protected]>

---------

Signed-off-by: Yann Soubeyrand <[email protected]>
2023-05-27 15:57:59 -04:00
david-becherandGitHub 73b0e65ad6 fix: Use CredsStore for GoogleCloudCreds (#12391)
git-ask-pass.sh is no longer supported for credentials

Signed-off-by: David Becher <[email protected]>
2023-03-06 16:44:45 -05:00