Commit Graph
465 Commits
Author SHA1 Message Date
Prajilesh NandGitHub eeae87f157 chore: improve error logs (#10933)
Signed-off-by: Prajilesh <[email protected]>

Signed-off-by: Prajilesh <[email protected]>
2022-10-13 17:53:06 -04:00
Mitsuo HeijoandGitHub c69497112e chore: update robfig/cron to v3 (#10588)
* chore: update robfig/cron to v3

Signed-off-by: Mitsuo Heijo <[email protected]>

* fix parser option to keep old non-standard behavior

Signed-off-by: Mitsuo Heijo <[email protected]>

* fix parser option to keep old non-standard behavior

Signed-off-by: Mitsuo Heijo <[email protected]>

* Revert "fix parser option to keep old non-standard behavior"

This reverts commit f3d75b68f43851ecbb0a0ac2ebf8c0159a4d41ac.

Signed-off-by: Mitsuo Heijo <[email protected]>

* Revert "fix parser option to keep old non-standard behavior"

This reverts commit 49ec9ef7ec976e4225afcd268dd250347575ad26.

Signed-off-by: Mitsuo Heijo <[email protected]>

* add chain to recover from panic

Signed-off-by: Mitsuo Heijo <[email protected]>

Signed-off-by: Mitsuo Heijo <[email protected]>
2022-10-07 17:01:49 -04:00
Blake PetterssonandGitHub 839188e760 feat: add permitOnlyProjectScopedClusters flag (#10237)
This commit adds a new flag, `permitOnlyProjectScopedClusters`, which
prevents any application from syncing to clusters which are not a part
of the same project. Fixes #10220.

Signed-off-by: Blake Pettersson <[email protected]>

Signed-off-by: Blake Pettersson <[email protected]>
2022-09-08 07:33:10 -04:00
jannfisandGitHub f373204105 fix: Correctly assume cluster-scoped resources to be self-referenced (#10390)
Signed-off-by: jannfis <[email protected]>

Signed-off-by: jannfis <[email protected]>
2022-08-18 20:15:38 +00:00
Alexander MatyushentsevandGitHub bedad4340d chore: infer managed resources health from redis instead of storing it in CRD (#10191)
* chore: infer managed resources health from redis instead of storing it in CRD

Signed-off-by: Alexander Matyushentsev <[email protected]>

* apply reviewer notes

Signed-off-by: Alexander Matyushentsev <[email protected]>

Signed-off-by: Alexander Matyushentsev <[email protected]>
2022-08-17 21:03:24 +00:00
jannfisandGitHub 75d334705a feat: Applications in any namespace (#9755)
* feat: Applications in any namespace

Signed-off-by: jannfis <[email protected]>

* Fix typo in CI

Signed-off-by: jannfis <[email protected]>

* Create argocd-e2e-external namespace

Signed-off-by: jannfis <[email protected]>

* Update from codegen

Signed-off-by: jannfis <[email protected]>

* Remove debug code

Signed-off-by: jannfis <[email protected]>

* Update help text for -N option to app create

Signed-off-by: jannfis <[email protected]>

* Wrap error when retrieving AppProject from cache

Signed-off-by: jannfis <[email protected]>

* Check for controller namespace first before matching on additional ns

Signed-off-by: jannfis <[email protected]>

* Improve TestAppProjectIsSourceNamespacePermitted unit test

Signed-off-by: jannfis <[email protected]>

* Get rid of some debug leftovers

Signed-off-by: jannfis <[email protected]>

* Better error wrapping; return IsNotFound as-is

Signed-off-by: jannfis <[email protected]>

* Updates from codegen

Signed-off-by: jannfis <[email protected]>

* We don't need AppShortName() anymore

Signed-off-by: jannfis <[email protected]>

* Update end-to-end tests to use annotation methods

Signed-off-by: jannfis <[email protected]>

* Add e2e tests to test for app creation in not permitted ns

Signed-off-by: jannfis <[email protected]>

* Remove deprecated code

Signed-off-by: jannfis <[email protected]>

* Remove dead code

Signed-off-by: jannfis <[email protected]>

* Add RBACName() method to application type

Signed-off-by: jannfis <[email protected]>

* Update from codegen

Signed-off-by: jannfis <[email protected]>

* Fix e2e test

Signed-off-by: jannfis <[email protected]>

* Update codegen

Signed-off-by: jannfis <[email protected]>

* Move RBAC name generation to an application receiver

Signed-off-by: jannfis <[email protected]>

* Fix sync window status in UI

Signed-off-by: jannfis <[email protected]>

* Fix pod logs viewer

Signed-off-by: jannfis <[email protected]>

* Fix application events in UI

Signed-off-by: jannfis <[email protected]>

* Fix application search in UI

Signed-off-by: jannfis <[email protected]>

* Fix yarn lint

Signed-off-by: jannfis <[email protected]>

* Only set up cluster-wide application informer when additional namespaces are specified

Signed-off-by: jannfis <[email protected]>

* Adapt e2e test to a changed error message

Signed-off-by: jannfis <[email protected]>

* Application namespace should be taken into account for create

Signed-off-by: jannfis <[email protected]>

* Use non-qualified application name as Helm release name

Signed-off-by: jannfis <[email protected]>

* Support --app-namespace in e2e tests

Signed-off-by: jannfis <[email protected]>

* Enable more e2e tests

Signed-off-by: jannfis <[email protected]>

* Increase e2e timeout for newly added tests

Signed-off-by: jannfis <[email protected]>
2022-08-10 11:39:10 +02:00
jannfisandGitHub 6928397473 fix: Ignore non-self-referencing resources while pruning (#10198)
* fix: Ignore non-self-referencing resources while pruning

Signed-off-by: jannfis <[email protected]>

* Pull in latest gitops-engine code

Signed-off-by: jannfis <[email protected]>

* Revert a replace in go.mod

Signed-off-by: jannfis <[email protected]>
2022-08-08 19:37:45 +02:00
Leonardo Luz AlmeidaandGitHub a6a133d80f feat: Introduces Server-Side Apply as sync option (#9711)
* feat: Introduces Server-Side Apply as sync option

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* add docs

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Implement the structured-merge diff when ssa is enabled

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* update gitops-engine

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* update gitops-engine

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* go mod tidy

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Add server-side apply option to the UI

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* update gitops-engine to master

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* fix live default values

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2022-08-05 19:16:35 -04:00
OmarKalloushandGitHub 0ae8c44b14 chore: Upgrade Golang to 1.19 (#10176) (#10186)
* Upgrade Golang to 1.19

Signed-off-by: OmarKalloush <[email protected]>

* go mod tidy with go 1.19

Signed-off-by: OmarKalloush <[email protected]>

* Replace deprecated ioutil

Signed-off-by: OmarKalloush <[email protected]>

* make codegen changes

Signed-off-by: OmarKalloush <[email protected]>

* Codegen Changes

Signed-off-by: OmarKalloush <[email protected]>
2022-08-05 12:59:28 -04:00
jannfisandGitHub 35bcc9eeb3 fix: Check tracking annotation for being self-referencing (#9791)
* fix: Check tracking annotation for being self-referencing

Signed-off-by: jannfis <[email protected]>

* Tweak isManagedLiveObj() logic

Signed-off-by: jannfis <[email protected]>

* Rename isManagedLiveResource to isSelfReferencedObj

Signed-off-by: jannfis <[email protected]>

* Add e2e test

Signed-off-by: jannfis <[email protected]>
2022-07-06 18:12:34 +00:00
jannfisandGitHub 2c9fa95c4d fix: Make change of tracking method work at runtime (#9820)
* fix: Make change of tracking method work at runtime

Signed-off-by: jannfis <[email protected]>

* GetAppName() will figure tracking label or annotation on its own

Signed-off-by: jannfis <[email protected]>

* Correct test comments and add another test

Signed-off-by: jannfis <[email protected]>

* Add a read lock before getting cache settings

Signed-off-by: jannfis <[email protected]>
2022-07-06 18:53:38 +02:00
Yuan TangandGitHub c49c8d55a0 feat: Treat connection reset as a retryable error (#9739)
Signed-off-by: Yuan Tang <[email protected]>
2022-06-29 08:52:28 -07:00
Michael CrenshawandGitHub ccdcb1b7ec Merge pull request from GHSA-2m7h-86qq-fp4v
Signed-off-by: Michael Crenshaw <[email protected]>

fix references

Signed-off-by: Michael Crenshaw <[email protected]>

use long enough state param for oauth2

Signed-off-by: Michael Crenshaw <[email protected]>

typo

Signed-off-by: Michael Crenshaw <[email protected]>

more entropy

Signed-off-by: Michael Crenshaw <[email protected]>

fix test

Signed-off-by: Michael Crenshaw <[email protected]>
2022-06-21 09:39:01 -04:00
Leonardo Luz AlmeidaandGitHub 4cebcfc61e fix: Ignore diff with schema (#9170) 2022-05-31 13:21:22 -04:00
69e82828a3 feat: add --app-hard-resync flag to controller (#8928)
* feat: add --app-hard-resync flag to controller

Signed-off-by: darshanime <[email protected]>

* add to approvers

Signed-off-by: pashavictorovich <[email protected]>

* Merge branch 'master' of github.com:pasha-codefresh/argo-cd into hard-refresh

Signed-off-by: pashavictorovich <[email protected]>

# Conflicts:
#	cmd/argocd-application-controller/main.go
#	controller/appcontroller.go

* merge

Signed-off-by: pashavictorovich <[email protected]>

* merge

Signed-off-by: pashavictorovich <[email protected]>

* regenerate docs

Signed-off-by: pashavictorovich <[email protected]>

* regenerate docs

Signed-off-by: pashavictorovich <[email protected]>

* fix tests

Signed-off-by: pashavictorovich <[email protected]>

* read variable from cm

Signed-off-by: pashavictorovich <[email protected]>

* reconciliation variable

Signed-off-by: pashavictorovich <[email protected]>

* manifest

Signed-off-by: pashavictorovich <[email protected]>

Co-authored-by: darshanime <[email protected]>
2022-04-04 10:44:35 -04:00
Michael CrenshawandGitHub 2954202a9c chore: fix imports and unit tests (#8857)
* chore: fix imports

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: fix unit test

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: keep changes minimal

Signed-off-by: Michael Crenshaw <[email protected]>

* chore: fix another test

Signed-off-by: Michael Crenshaw <[email protected]>
2022-03-22 12:52:48 -07:00
a94795cdc4 Merge pull request from GHSA-2f5v-8r3f-8pww
* fix: application resource APIs must enforce project restrictions

Signed-off-by: Alexander Matyushentsev <[email protected]>

* Fix unit tests

Signed-off-by: jannfis <[email protected]>

Co-authored-by: jannfis <[email protected]>
2022-03-22 10:57:30 -07:00
Edgar MaganaandGitHub 5299024284 fix: Minor cleanup for app errors #5273 (#8623)
First timer commit to fix a gramma issue

Signed-off-by: Edgar Magana <[email protected]>
2022-03-15 17:42:15 +01:00
Yuan TangandGitHub 9e699c8361 feat: Support additional retryable errors (#8578)
* feat: Support additional retryable errors

Signed-off-by: Yuan Tang <[email protected]>

* Concise conditions

Signed-off-by: Yuan Tang <[email protected]>
2022-02-26 09:21:16 +01:00
Ben YeandGitHub 3308575dbb feat: expose cluster sync retry duration (#8481)
Signed-off-by: Ben Ye <[email protected]>
2022-02-21 22:44:22 +01:00
Alexander MatyushentsevandGitHub 6b7f50a6d7 feat: support custom helm values file schemes (#8535)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2022-02-17 11:51:17 -08:00
Alexander MatyushentsevandGitHub 2704940036 feat: support disabling manifest generation using config management tools (#8514)
* feat: support disabling manifest generation using config management tools

Signed-off-by: Alexander Matyushentsev <[email protected]>

* rename EnableManifestGenerationForSourceType to EnableSourceTypes

Signed-off-by: Alexander Matyushentsev <[email protected]>
2022-02-16 21:03:04 -08:00
jannfisandGitHub b43aab7c8b fix: Return early on error when updating clusters (#8526)
Signed-off-by: jannfis <[email protected]>
2022-02-16 09:27:28 -08:00
jannfisandGitHub 3cdc292899 feat: Make cluster cache sync more robust (#8438)
* feat: Support retry for list operations in cluster cache sync

Signed-off-by: jannfis <[email protected]>

* Fix default retries

Signed-off-by: jannfis <[email protected]>

* Pull in latest gitops-engine

Signed-off-by: jannfis <[email protected]>

* Default retry limit should be 1

Signed-off-by: jannfis <[email protected]>

* Make type conversion earlier

Signed-off-by: jannfis <[email protected]>

* Rename limit to attempt

Signed-off-by: jannfis <[email protected]>

* Revert Makefile change

Signed-off-by: jannfis <[email protected]>
2022-02-16 12:52:38 +01:00
Yuan TangandGitHub fa714c21f9 feat: Ability to disable in-cluster server address. Fixes #7571 (#7620)
Signed-off-by: Yuan Tang <[email protected]>
2022-02-15 19:09:40 -08:00
Ben YeandGitHub b25e07d9e5 fix: register controller workqueue metrics correctly (#8318)
Signed-off-by: Ben Ye <[email protected]>
2022-02-01 10:57:20 -08:00
Leonardo Luz AlmeidaandGitHub ad239171e0 feat: Allow configuring system wide ignore differences for all resources (#8224)
* feat: Allow configuring system wide ignore differences for all resources

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Add example config to argocd-cm.yaml

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2022-01-19 14:57:43 -08:00
Tristan KeenandGitHub 309159e5e3 fix: Allow all resources to add external links (#7923)
Signed-off-by: Tristan Keen <[email protected]>
2022-01-18 08:23:58 -08:00
jannfisandGitHub c8d2d8f38d chore: Log out the resource triggering reconciliation (#8192)
* chore: Log out the resource triggering reconciliation

Signed-off-by: jannfis <[email protected]>

* chore: Log out the resource triggering reconciliation

Signed-off-by: jannfis <[email protected]>
2022-01-18 08:22:26 +01:00
Leonardo Luz AlmeidaandGitHub bab3ef805a feat: new sync option to use ignore diff configs during sync (#8078)
feat: new sync option to use ignore diff configs during sync (#8078)

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2022-01-13 13:00:17 -08:00
Leonardo Luz AlmeidaandGitHub d2b9099d9e fix: Inconsistent normalization logic during diff (#7980)
fix: Inconsistent normalization logic during diff (#7980)

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2021-12-22 08:57:48 -08:00
Xabier Larrakoetxea GallegoandGitHub 959c384643 Fix Kubernetes labels normalization for Prometheus (#7925)
* When adding Kubernetes labels as Prometheus labels, replace with  all the invalid Prometheus label chars

Signed-off-by: Xabier Larrakoetxea <[email protected]>

* Add Fonoa company to users doc

Signed-off-by: Xabier Larrakoetxea <[email protected]>

* Add comment and link to the Prometheus label valid characters

Signed-off-by: Xabier Larrakoetxea <[email protected]>
2021-12-14 12:38:25 -08:00
Leonardo Luz AlmeidaandGitHub 67e2d948fc Feat: Ignore differences owned by trusted managers from managedFields (#7869)
* feat: implement managed fields normalizer

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2021-12-14 10:49:55 -08:00
Jesse SuenandGitHub cc7091a1b0 feat: update gitops-engine to v0.5.1 and add additional tuning options (#7917)
Signed-off-by: Jesse Suen <[email protected]>
2021-12-13 18:39:25 -08:00
jomenxiaoandGitHub 82c75fa3bc fix nil point (#7905)
Signed-off-by: jomenxiao <[email protected]>
2021-12-10 21:23:37 -08:00
Alexander MatyushentsevandGitHub 6bb96caea8 refactor: add indexes to secret informers to speedup settings parsing (#7882)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-12-07 14:15:11 -08:00
Alexander MatyushentsevandGitHub 73843bb01c refactor: avoid loading project in frequently executed controller methods (#7853)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-12-03 13:18:08 -08:00
Alexander MatyushentsevandGitHub 3449cbe9db refactor: use cached project while calculating resource tree (#7747)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-11-18 15:45:19 -08:00
Leonardo Luz AlmeidaandGitHub fcd30aa98f fix: Address issue during diff when secret data is nil (#7603)
* fix: update gitops-engine to latest + log improvements

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* run go mod tidy

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2021-11-03 12:46:05 -07:00
Ben YeandGitHub 13e82eb33e feat: support pprof endpoints (#7533)
Signed-off-by: Ben Ye <[email protected]>
2021-11-01 10:49:43 -07:00
Alexander MatyushentsevandGitHub 8fa6dda80f fix: Argo CD should provide apiversion and kinds to 'helm template' command (#7519)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-10-25 16:52:19 -07:00
Leonardo Luz AlmeidaandGitHub 6dcaa08173 feat: add new sync option to fail if finds shared resources (#7444)
* feat: add new sync option to fail if finds shared resources

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* docs: add docs for FailOnSharedResource sync option

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2021-10-20 08:06:41 -07:00
Alexander MatyushentsevandGitHub 9e2ccba385 fix: Invalid memory address or nil pointer dereference in processRequestedAppOperation (#7501)
Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-10-20 08:03:55 -07:00
Alexander MatyushentsevandGitHub eeb2b0fb79 fix: Operation has completed with phase: Running (#7482)
* fix: Operation has completed with phase: Running

Signed-off-by: Alexander Matyushentsev <[email protected]>
2021-10-19 17:16:31 -07:00
pasha-codefreshandGitHub 74c7247f1e feat: Cluster name as part of sync (#7394)
feat: Cluster name as part of sync (#7394)

Signed-off-by: pashavictorovich <[email protected]>
2021-10-18 18:44:54 -07:00
Leonardo Luz AlmeidaandGitHub 7abc7ce560 Fix argocd_cluster_connection_status metric (#7419)
* bug: fix argocd_cluster_connection_status metric + docs

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2021-10-17 19:58:02 -07:00
Leonardo Luz AlmeidaandGitHub 0b8ca7d7d9 Expose Application labels in prometheus metric (#7374)
Expose Application labels in prometheus metric (#7374)

Signed-off-by: Leonardo Luz Almeida <[email protected]>
2021-10-08 10:15:51 -07:00
pasha-codefreshandGitHub 85e249def0 feat: Resources should be normalized in order to prevent our of sync during migration (#7388)
feat: Resources should be normalized in order to prevent our of sync during migration (#7388)

Signed-off-by: pashavictorovich <[email protected]>
2021-10-07 09:51:29 -07:00
pasha-codefreshandGitHub f9cc2cf2b8 fix: compare app state (#7341)
* fix compare app state

Signed-off-by: pashavictorovich <[email protected]>
2021-10-01 09:18:01 -07:00
pasha-codefreshandGitHub 38c8ba460b feat: rename app identifier (#7251)
feat: rename app identifier (#7251)

Signed-off-by: pashavictorovich <[email protected]>
2021-09-28 08:35:17 -07:00