mirror of
https://github.com/hanzoai/deploy.git
synced 2026-10-07 08:44:50 +00:00
zeekayandHanzo Dev
1ab6e799c1
go.mod still declared `module github.com/hanzoai/deploy` after the repo was renamed. A Go module path is not cosmetic — it is the resolvable location. So `go get github.com/hanzoai/cd` could not work, and anything importing this module had to spell a name that no longer exists at that address. The build log of v3.6.0 is where it surfaced: the compiler was still emitting github.com/hanzoai/deploy/cmd/cd/commands. 3541 import paths across 690 .go, 19 .proto, 4 .yaml, 3 .sh, 2 .mod, Procfile and Makefile. Plus the 62 ghcr.io/hanzoai/deploy image references, moved to ghcr.io/hanzoai/cd to match hanzo.yml's build target — a distinct string from the module path, replaced separately so neither could clobber the other. go mod tidy clean, CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build ./... clean. Co-authored-by: Hanzo Dev <[email protected]>
666 lines
17 KiB
Go
666 lines
17 KiB
Go
package controllers
|
|
|
|
import (
|
|
"testing"
|
|
|
|
argocommon "github.com/hanzoai/cd/common"
|
|
|
|
log "github.com/sirupsen/logrus"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
corev1 "k8s.io/api/core/v1"
|
|
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
ctrl "sigs.k8s.io/controller-runtime"
|
|
"sigs.k8s.io/controller-runtime/pkg/client/fake"
|
|
"sigs.k8s.io/controller-runtime/pkg/reconcile"
|
|
|
|
argov1alpha1 "github.com/hanzoai/cd/pkg/apis/application/v1alpha1"
|
|
)
|
|
|
|
type mockAddRateLimitingInterface struct {
|
|
addedItems []reconcile.Request
|
|
}
|
|
|
|
// Add checks the type, and adds it to the internal list of received additions
|
|
func (obj *mockAddRateLimitingInterface) Add(item reconcile.Request) {
|
|
obj.addedItems = append(obj.addedItems, item)
|
|
}
|
|
|
|
func TestClusterEventHandler(t *testing.T) {
|
|
t.Parallel()
|
|
scheme := runtime.NewScheme()
|
|
err := argov1alpha1.AddToScheme(scheme)
|
|
require.NoError(t, err)
|
|
|
|
err = argov1alpha1.AddToScheme(scheme)
|
|
require.NoError(t, err)
|
|
|
|
tests := []struct {
|
|
name string
|
|
items []argov1alpha1.ApplicationSet
|
|
secret corev1.Secret
|
|
expectedRequests []ctrl.Request
|
|
}{
|
|
{
|
|
name: "no application sets should mean no requests",
|
|
items: []argov1alpha1.ApplicationSet{},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "a cluster generator should produce a request",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &argov1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{{
|
|
NamespacedName: types.NamespacedName{Namespace: "cd", Name: "my-app-set"},
|
|
}},
|
|
},
|
|
{
|
|
name: "multiple cluster generators should produce multiple requests",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &argov1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set2",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &argov1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{
|
|
{NamespacedName: types.NamespacedName{Namespace: "cd", Name: "my-app-set"}},
|
|
{NamespacedName: types.NamespacedName{Namespace: "cd", Name: "my-app-set2"}},
|
|
},
|
|
},
|
|
{
|
|
name: "non-cluster generator should not match",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &argov1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "app-set-non-cluster",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
List: &argov1alpha1.ListGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{
|
|
{NamespacedName: types.NamespacedName{Namespace: "cd", Name: "my-app-set"}},
|
|
},
|
|
},
|
|
{
|
|
name: "cluster generators in other namespaces should not match",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "my-namespace-not-allowed",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &argov1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "non-argo cd secret should not match",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "another-namespace",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Clusters: &argov1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-non-cd-secret",
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "a matrix generator with a cluster generator should produce a request",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Matrix: &argov1alpha1.MatrixGenerator{
|
|
Generators: []argov1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Clusters: &argov1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{{
|
|
NamespacedName: types.NamespacedName{Namespace: "cd", Name: "my-app-set"},
|
|
}},
|
|
},
|
|
{
|
|
name: "a matrix generator with non cluster generator should not match",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Matrix: &argov1alpha1.MatrixGenerator{
|
|
Generators: []argov1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
List: &argov1alpha1.ListGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "a matrix generator with a nested matrix generator containing a cluster generator should produce a request",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Matrix: &argov1alpha1.MatrixGenerator{
|
|
Generators: []argov1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Matrix: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"clusters": {
|
|
"selector": {
|
|
"matchLabels": {
|
|
"cd.hanzo.ai/secret-type": "cluster"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}`,
|
|
),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{{
|
|
NamespacedName: types.NamespacedName{Namespace: "cd", Name: "my-app-set"},
|
|
}},
|
|
},
|
|
{
|
|
name: "a matrix generator with a nested matrix generator containing non cluster generator should not match",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Matrix: &argov1alpha1.MatrixGenerator{
|
|
Generators: []argov1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Matrix: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"list": {
|
|
"elements": [
|
|
"a",
|
|
"b"
|
|
]
|
|
}
|
|
}
|
|
]
|
|
}`,
|
|
),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "a merge generator with a cluster generator should produce a request",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Merge: &argov1alpha1.MergeGenerator{
|
|
Generators: []argov1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Clusters: &argov1alpha1.ClusterGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{{
|
|
NamespacedName: types.NamespacedName{Namespace: "cd", Name: "my-app-set"},
|
|
}},
|
|
},
|
|
{
|
|
name: "a matrix generator with non cluster generator should not match",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Merge: &argov1alpha1.MergeGenerator{
|
|
Generators: []argov1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
List: &argov1alpha1.ListGenerator{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
{
|
|
name: "a merge generator with a nested merge generator containing a cluster generator should produce a request",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Merge: &argov1alpha1.MergeGenerator{
|
|
Generators: []argov1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Merge: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"clusters": {
|
|
"selector": {
|
|
"matchLabels": {
|
|
"cd.hanzo.ai/secret-type": "cluster"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}`,
|
|
),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{{
|
|
NamespacedName: types.NamespacedName{Namespace: "cd", Name: "my-app-set"},
|
|
}},
|
|
},
|
|
{
|
|
name: "a merge generator with a nested merge generator containing non cluster generator should not match",
|
|
items: []argov1alpha1.ApplicationSet{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "my-app-set",
|
|
Namespace: "cd",
|
|
},
|
|
Spec: argov1alpha1.ApplicationSetSpec{
|
|
Generators: []argov1alpha1.ApplicationSetGenerator{
|
|
{
|
|
Merge: &argov1alpha1.MergeGenerator{
|
|
Generators: []argov1alpha1.ApplicationSetNestedGenerator{
|
|
{
|
|
Merge: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"list": {
|
|
"elements": [
|
|
"a",
|
|
"b"
|
|
]
|
|
}
|
|
}
|
|
]
|
|
}`,
|
|
),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
secret: corev1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "cd",
|
|
Name: "my-secret",
|
|
Labels: map[string]string{
|
|
argocommon.LabelKeySecretType: argocommon.LabelValueSecretTypeCluster,
|
|
},
|
|
},
|
|
},
|
|
expectedRequests: []reconcile.Request{},
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
appSetList := argov1alpha1.ApplicationSetList{
|
|
Items: test.items,
|
|
}
|
|
|
|
fakeClient := fake.NewClientBuilder().WithScheme(scheme).WithLists(&appSetList).Build()
|
|
|
|
handler := &clusterSecretEventHandler{
|
|
Client: fakeClient,
|
|
Log: log.WithField("type", "createSecretEventHandler"),
|
|
ApplicationSetNamespaces: []string{"cd"},
|
|
}
|
|
|
|
mockAddRateLimitingInterface := mockAddRateLimitingInterface{}
|
|
|
|
handler.queueRelatedAppGenerators(t.Context(), &mockAddRateLimitingInterface, &test.secret)
|
|
|
|
assert.ElementsMatch(t, mockAddRateLimitingInterface.addedItems, test.expectedRequests)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNestedGeneratorHasClusterGenerator_NestedClusterGenerator(t *testing.T) {
|
|
t.Parallel()
|
|
nested := argov1alpha1.ApplicationSetNestedGenerator{
|
|
Clusters: &argov1alpha1.ClusterGenerator{},
|
|
}
|
|
|
|
hasClusterGenerator, err := nestedGeneratorHasClusterGenerator(nested)
|
|
|
|
require.NoError(t, err)
|
|
assert.True(t, hasClusterGenerator)
|
|
}
|
|
|
|
func TestNestedGeneratorHasClusterGenerator_NestedMergeGenerator(t *testing.T) {
|
|
t.Parallel()
|
|
nested := argov1alpha1.ApplicationSetNestedGenerator{
|
|
Merge: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"clusters": {
|
|
"selector": {
|
|
"matchLabels": {
|
|
"cd.hanzo.ai/secret-type": "cluster"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}`,
|
|
),
|
|
},
|
|
}
|
|
|
|
hasClusterGenerator, err := nestedGeneratorHasClusterGenerator(nested)
|
|
|
|
require.NoError(t, err)
|
|
assert.True(t, hasClusterGenerator)
|
|
}
|
|
|
|
func TestNestedGeneratorHasClusterGenerator_NestedMergeGeneratorWithInvalidJSON(t *testing.T) {
|
|
t.Parallel()
|
|
nested := argov1alpha1.ApplicationSetNestedGenerator{
|
|
Merge: &apiextensionsv1.JSON{
|
|
Raw: []byte(
|
|
`{
|
|
"generators": [
|
|
{
|
|
"clusters": {
|
|
"selector": {
|
|
"matchLabels": {
|
|
"cd.hanzo.ai/secret-type": "cluster"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
]
|
|
`,
|
|
),
|
|
},
|
|
}
|
|
|
|
hasClusterGenerator, err := nestedGeneratorHasClusterGenerator(nested)
|
|
|
|
require.Error(t, err)
|
|
assert.False(t, hasClusterGenerator)
|
|
}
|