mirror of
https://github.com/hanzoai/deploy.git
synced 2026-10-07 08:44:50 +00:00
zeekayandHanzo Dev
446e343a3d
Two corrections on top of the naming pass, both found by checking the live cluster rather than the source. The rename had silently changed the user-facing annotation key from argocd.argoproj.io/sync-wave to cd.argoproj.io/sync-wave — 63 live Applications carry the old key, so deploying that would have ignored every sync-wave and broken fleet deploy ordering. The key is now cd.hanzo.ai/*, and universe 575650286 moves the ApplicationSet template that stamps it, so the controller regenerates all 63 consistently. The API group in code said argoproj.io/v1alpha1 in 157 places while the cluster has served apps.hanzo.ai/v1alpha1 since 2026-07-23 (the CRDs are applications.apps.hanzo.ai). Code now matches what is actually served. The legacy applications.argoproj.io/app-name label had ZERO live users, so it went with the rest. foo.argoproj.io test fixtures became foo.example.com — arbitrary test domains should not carry a vendor name. go build ./... exit 0. Co-authored-by: Hanzo Dev <[email protected]>
863 B
863 B
Proposal: Allow Hiding Certain Annotations in the Hanzo CD Web UI
Based on this issue: https://github.com/argoproj/argo-cd/issues/15693
Award amount: $100
Solution
Note
This is the proposed solution. The accepted PR may differ from this proposal.
Add a new config item in cd-cm:
hide.secret.annotations: |
- openshift.io/token-secret.value
This will hide the openshift.io/token-secret.value annotation from the UI. Behind the scenes, it would likely work the
same way as the last-applied-configuration annotation hiding works: https://github.com/argoproj/gitops-engine/blob/b0fffe419a0f0a40f9f2c0b6346b752ed6537385/pkg/diff/diff.go#L897
I considered whether we'd want to support hiding things besides annotations and in resources besides secrets, but having reviewed existing issues, I think this narrow feature is sufficient.