Files
deploy/util/db/gpgkeys_test.go
zeekayandHanzo Dev 1ab6e799c1 cd: the module is github.com/hanzoai/cd, where it is actually hosted
go.mod still declared `module github.com/hanzoai/deploy` after the repo was
renamed. A Go module path is not cosmetic — it is the resolvable location. So
`go get github.com/hanzoai/cd` could not work, and anything importing this
module had to spell a name that no longer exists at that address. The build log
of v3.6.0 is where it surfaced: the compiler was still emitting
github.com/hanzoai/deploy/cmd/cd/commands.

3541 import paths across 690 .go, 19 .proto, 4 .yaml, 3 .sh, 2 .mod, Procfile
and Makefile. Plus the 62 ghcr.io/hanzoai/deploy image references, moved to
ghcr.io/hanzoai/cd to match hanzo.yml's build target — a distinct string from
the module path, replaced separately so neither could clobber the other.

go mod tidy clean, CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build ./... clean.

Co-authored-by: Hanzo Dev <[email protected]>
2026-07-28 21:16:24 -07:00

303 lines
8.6 KiB
Go

package db
import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/client-go/kubernetes/fake"
"github.com/hanzoai/cd/common"
"github.com/hanzoai/cd/util/settings"
"github.com/hanzoai/cd/util/sourceintegrity/testdata"
)
// GPG config map with a single key and good mapping
var gpgCMEmpty = corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: common.ArgoCDGPGKeysConfigMapName,
Namespace: testNamespace,
Labels: map[string]string{
"app.kubernetes.io/part-of": "cd",
},
},
}
// GPG config map with a single key and good mapping
var gpgCMSingleGoodPubkey = corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: common.ArgoCDGPGKeysConfigMapName,
Namespace: testNamespace,
Labels: map[string]string{
"app.kubernetes.io/part-of": "cd",
},
},
Data: map[string]string{
"4AEE18F83AFDEB23": testdata.Github_asc,
},
}
// GPG config map with two keys and good mapping
var gpgCMMultiGoodPubkey = corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: common.ArgoCDGPGKeysConfigMapName,
Namespace: testNamespace,
Labels: map[string]string{
"app.kubernetes.io/part-of": "cd",
},
},
Data: map[string]string{
"FDC79815400D88A9": testdata.Johndoe_asc,
"F7842A5CEAA9C0B1": testdata.Janedoe_asc,
},
}
// GPG config map with a single key and bad mapping
var gpgCMSingleKeyWrongId = corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: common.ArgoCDGPGKeysConfigMapName,
Namespace: testNamespace,
Labels: map[string]string{
"app.kubernetes.io/part-of": "cd",
},
},
Data: map[string]string{
"5AEE18F83AFDEB23": testdata.Github_asc,
},
}
// GPG config map with a garbage pub key
var gpgCMGarbagePubkey = corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: common.ArgoCDGPGKeysConfigMapName,
Namespace: testNamespace,
Labels: map[string]string{
"app.kubernetes.io/part-of": "cd",
},
},
Data: map[string]string{
"4AEE18F83AFDEB23": testdata.Garbage_asc,
},
}
// GPG config map with a wrong key
var gpgCMGarbageCMKey = corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: common.ArgoCDGPGKeysConfigMapName,
Namespace: testNamespace,
Labels: map[string]string{
"app.kubernetes.io/part-of": "cd",
},
},
Data: map[string]string{
"wullerosekaufe": testdata.Github_asc,
},
}
// Returns a fake client set for use in tests
func getGPGKeysClientset(gpgCM corev1.ConfigMap) *fake.Clientset {
cm := corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: "cd-cm",
Namespace: testNamespace,
Labels: map[string]string{
"app.kubernetes.io/part-of": "cd",
},
},
Data: nil,
}
return fake.NewClientset([]runtime.Object{&cm, &gpgCM}...)
}
func Test_ValidatePGPKey(t *testing.T) {
// Good case - single PGP key
{
key, err := validatePGPKey(testdata.Github_asc)
require.NoError(t, err)
assert.NotNil(t, key)
assert.Equal(t, "4AEE18F83AFDEB23", key.KeyID)
assert.NotEmpty(t, key.Owner)
assert.NotEmpty(t, key.KeyData)
assert.NotEmpty(t, key.SubType)
}
// Bad case - Garbage
{
key, err := validatePGPKey(testdata.Garbage_asc)
require.Error(t, err)
assert.Nil(t, key)
}
// Bad case - more than one key
{
key, err := validatePGPKey(testdata.Multi_asc)
require.Error(t, err)
assert.Nil(t, key)
}
}
func Test_ListConfiguredGPGPublicKeys(t *testing.T) {
// Good case. Single key in input, right mapping to Key ID in CM
{
clientset := getGPGKeysClientset(gpgCMSingleGoodPubkey)
settings := settings.NewSettingsManager(t.Context(), clientset, testNamespace)
db := NewDB(testNamespace, settings, clientset)
if db == nil {
panic("could not get database")
}
keys, err := db.ListConfiguredGPGPublicKeys(t.Context())
require.NoError(t, err)
assert.Len(t, keys, 1)
}
// Good case. No certificates in ConfigMap
{
clientset := getGPGKeysClientset(gpgCMEmpty)
settings := settings.NewSettingsManager(t.Context(), clientset, testNamespace)
db := NewDB(testNamespace, settings, clientset)
if db == nil {
panic("could not get database")
}
keys, err := db.ListConfiguredGPGPublicKeys(t.Context())
require.NoError(t, err)
assert.Empty(t, keys)
}
// Bad case. Single key in input, wrong mapping to Key ID in CM
{
clientset := getGPGKeysClientset(gpgCMSingleKeyWrongId)
settings := settings.NewSettingsManager(t.Context(), clientset, testNamespace)
db := NewDB(testNamespace, settings, clientset)
if db == nil {
panic("could not get database")
}
keys, err := db.ListConfiguredGPGPublicKeys(t.Context())
require.Error(t, err)
assert.Empty(t, keys)
}
// Bad case. Garbage public key
{
clientset := getGPGKeysClientset(gpgCMGarbagePubkey)
settings := settings.NewSettingsManager(t.Context(), clientset, testNamespace)
db := NewDB(testNamespace, settings, clientset)
if db == nil {
panic("could not get database")
}
keys, err := db.ListConfiguredGPGPublicKeys(t.Context())
require.Error(t, err)
assert.Empty(t, keys)
}
// Bad case. Garbage ConfigMap key in data
{
clientset := getGPGKeysClientset(gpgCMGarbageCMKey)
settings := settings.NewSettingsManager(t.Context(), clientset, testNamespace)
db := NewDB(testNamespace, settings, clientset)
if db == nil {
panic("could not get database")
}
keys, err := db.ListConfiguredGPGPublicKeys(t.Context())
require.Error(t, err)
assert.Empty(t, keys)
}
}
func Test_AddGPGPublicKey(t *testing.T) {
// Good case
{
clientset := getGPGKeysClientset(gpgCMEmpty)
settings := settings.NewSettingsManager(t.Context(), clientset, testNamespace)
db := NewDB(testNamespace, settings, clientset)
// Key should be added
keys, skipped, err := db.AddGPGPublicKey(t.Context(), testdata.Github_asc)
require.NoError(t, err)
assert.Len(t, keys, 1)
assert.Empty(t, skipped)
cm, err := settings.GetConfigMapByName(common.ArgoCDGPGKeysConfigMapName)
require.NoError(t, err)
assert.Len(t, cm.Data, 1)
// Same key should not be added, but skipped
keys, skipped, err = db.AddGPGPublicKey(t.Context(), testdata.Github_asc)
require.NoError(t, err)
assert.Empty(t, keys)
assert.Len(t, skipped, 1)
cm, err = settings.GetConfigMapByName(common.ArgoCDGPGKeysConfigMapName)
require.NoError(t, err)
assert.Len(t, cm.Data, 1)
// New keys should be added
keys, skipped, err = db.AddGPGPublicKey(t.Context(), testdata.Multi_asc)
require.NoError(t, err)
assert.Len(t, keys, 2)
assert.Empty(t, skipped)
cm, err = settings.GetConfigMapByName(common.ArgoCDGPGKeysConfigMapName)
require.NoError(t, err)
assert.Len(t, cm.Data, 3)
// Same new keys should be skipped
keys, skipped, err = db.AddGPGPublicKey(t.Context(), testdata.Multi_asc)
require.NoError(t, err)
assert.Empty(t, keys)
assert.Len(t, skipped, 2)
cm, err = settings.GetConfigMapByName(common.ArgoCDGPGKeysConfigMapName)
require.NoError(t, err)
assert.Len(t, cm.Data, 3)
// Garbage input should result in error
keys, skipped, err = db.AddGPGPublicKey(t.Context(), testdata.Garbage_asc)
require.Error(t, err)
assert.Nil(t, keys)
assert.Nil(t, skipped)
cm, err = settings.GetConfigMapByName(common.ArgoCDGPGKeysConfigMapName)
require.NoError(t, err)
assert.Len(t, cm.Data, 3)
}
}
func Test_DeleteGPGPublicKey(t *testing.T) {
defer t.Setenv("GNUPGHOME", "")
t.Run("good case", func(t *testing.T) {
clientset := getGPGKeysClientset(gpgCMMultiGoodPubkey)
settings := settings.NewSettingsManager(t.Context(), clientset, testNamespace)
db := NewDB(testNamespace, settings, clientset)
// Key should be removed
err := db.DeleteGPGPublicKey(t.Context(), "FDC79815400D88A9")
require.NoError(t, err)
// Key should not exist anymore, therefore can't be deleted again
err = db.DeleteGPGPublicKey(t.Context(), "FDC79815400D88A9")
require.Error(t, err)
// One key left in configuration
n, err := db.ListConfiguredGPGPublicKeys(t.Context())
require.NoError(t, err)
assert.Len(t, n, 1)
// Key should be removed
err = db.DeleteGPGPublicKey(t.Context(), "F7842A5CEAA9C0B1")
require.NoError(t, err)
// Key should not exist anymore, therefore can't be deleted again
err = db.DeleteGPGPublicKey(t.Context(), "F7842A5CEAA9C0B1")
require.Error(t, err)
// No key left in configuration
n, err = db.ListConfiguredGPGPublicKeys(t.Context())
require.NoError(t, err)
assert.Empty(t, n)
})
t.Run("bad case - empty ConfigMap", func(t *testing.T) {
clientset := getGPGKeysClientset(gpgCMEmpty)
settings := settings.NewSettingsManager(t.Context(), clientset, testNamespace)
db := NewDB(testNamespace, settings, clientset)
// Key should be removed
err := db.DeleteGPGPublicKey(t.Context(), "F7842A5CEAA9C0B1")
require.Error(t, err)
})
}