deploy/util/vendored/kubeclientmetrics/metric_test.go at main

mirror of https://github.com/hanzoai/deploy.git synced 2026-10-07 08:44:50 +00:00

Files

T

zeekayandHanzo Dev 446e343a3d cd: annotations are cd.hanzo.ai, API group is apps.hanzo.ai

Two corrections on top of the naming pass, both found by checking the live
cluster rather than the source.

The rename had silently changed the user-facing annotation key from
argocd.argoproj.io/sync-wave to cd.argoproj.io/sync-wave — 63 live
Applications carry the old key, so deploying that would have ignored every
sync-wave and broken fleet deploy ordering. The key is now cd.hanzo.ai/*,
and universe 575650286 moves the ApplicationSet template that stamps it, so
the controller regenerates all 63 consistently.

The API group in code said argoproj.io/v1alpha1 in 157 places while the
cluster has served apps.hanzo.ai/v1alpha1 since 2026-07-23 (the CRDs are
applications.apps.hanzo.ai). Code now matches what is actually served.

The legacy applications.argoproj.io/app-name label had ZERO live users, so it
went with the rest. foo.argoproj.io test fixtures became foo.example.com —
arbitrary test domains should not carry a vendor name.

go build ./... exit 0.

Co-authored-by: Hanzo Dev <[email protected]>

2026-07-28 16:32:14 -07:00

453 lines

13 KiB

Go

Raw Permalink Blame History

 package kubeclientmetrics
 import (
 	"context"
 	"net/http"
 	"net/http/httptest"
 	"net/url"
 	"testing"
 	"github.com/stretchr/testify/assert"
 	appsv1 "k8s.io/api/apps/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/rest"
 )
 type fakeWrapper struct {
 	t             *testing.T
 	currentCount  int
 	expectedCount int
 }
 func (f fakeWrapper) RoundTrip(r *http.Request) (*http.Response, error) {
 	resp := httptest.NewRecorder()
 	resp.Code = 201
 	assert.Equal(f.t, f.expectedCount, f.currentCount)
 	return resp.Result(), nil
 }
 func NewConfig(url string) *rest.Config {
 	return &rest.Config{
 		Host: url,
 		ContentConfig: rest.ContentConfig{
 			ContentType: "application/json",
 		},
 	}
 }
 // TestWrappingTwice Ensures that the config doesn't lose any previous wrappers and the previous wrapper
 // gets executed first
 func TestAddMetricsTransportWrapperWrapTwice(t *testing.T) {
 	config := &rest.Config{
 		Host: "",
 	}
 	currentCount := 0
 	config.WrapTransport = func(rt http.RoundTripper) http.RoundTripper {
 		return fakeWrapper{
 			t:             t,
 			expectedCount: 0,
 			currentCount:  currentCount,
 		}
 	}
 	newConfig := AddMetricsTransportWrapper(config, func(info ResourceInfo) error {
 		currentCount++
 		return nil
 	})
 	client := kubernetes.NewForConfigOrDie(newConfig)
 	_, _ = client.AppsV1().ReplicaSets(metav1.NamespaceDefault).Get(context.Background(), "test", metav1.GetOptions{})
 	// Ensures second wrapper added by AddMetricsTransportWrapper is executed
 	assert.Equal(t, 1, currentCount)
 }
 func newGetRequest(str string) *http.Request {
 	requestURL, err := url.Parse(str)
 	if err != nil {
 		panic(err)
 	}
 	return &http.Request{
 		Method: "GET",
 		URL:    requestURL,
 	}
 }
 func TestParseRequest(t *testing.T) {
 	testData := []struct {
 		testName string
 		url      string
 		expected ResourceInfo
 	}{
 		{
 			testName: "Pod LIST",
 			url:      "https://127.0.0.1/api/v1/namespaces/default/pods",
 			expected: ResourceInfo{
 				Server:    "https://127.0.0.1",
 				Verb:      List,
 				Namespace: "default",
 				Kind:      "pods",
 			},
 		},
 		{
 			testName: "Pod Cluster LIST",
 			url:      "https://127.0.0.1/api/v1/pods",
 			expected: ResourceInfo{
 				Server: "https://127.0.0.1",
 				Verb:   List,
 				Kind:   "pods",
 			},
 		},
 		{
 			testName: "Pod GET",
 			url:      "https://127.0.0.1/api/v1/namespaces/default/pods/pod-name-123456",
 			expected: ResourceInfo{
 				Server:    "https://127.0.0.1",
 				Verb:      Get,
 				Namespace: "default",
 				Kind:      "pods",
 				Name:      "pod-name-123456",
 			},
 		},
 		{
 			testName: "Namespace LIST",
 			url:      "https://127.0.0.1/api/v1/namespaces",
 			expected: ResourceInfo{
 				Server: "https://127.0.0.1",
 				Verb:   List,
 				Kind:   "namespaces",
 			},
 		},
 		{
 			testName: "Namespace GET",
 			url:      "https://127.0.0.1/api/v1/namespaces/default",
 			expected: ResourceInfo{
 				Server: "https://127.0.0.1",
 				Verb:   Get,
 				Kind:   "namespaces",
 				Name:   "default",
 			},
 		},
 		{
 			testName: "ReplicaSet LIST",
 			url:      "https://127.0.0.1/apis/extensions/v1beta1/namespaces/default/replicasets",
 			expected: ResourceInfo{
 				Server:    "https://127.0.0.1",
 				Verb:      List,
 				Kind:      "replicasets",
 				Namespace: "default",
 			},
 		},
 		{
 			testName: "ReplicaSet Cluster LIST",
 			url:      "https://127.0.0.1/apis/apps/v1/replicasets",
 			expected: ResourceInfo{
 				Server: "https://127.0.0.1",
 				Verb:   List,
 				Kind:   "replicasets",
 			},
 		},
 		{
 			testName: "ReplicaSet GET",
 			url:      "https://127.0.0.1/apis/extensions/v1beta1/namespaces/default/replicasets/rs-abc123",
 			expected: ResourceInfo{
 				Server:    "https://127.0.0.1",
 				Verb:      Get,
 				Kind:      "replicasets",
 				Namespace: "default",
 				Name:      "rs-abc123",
 			},
 		},
 		{
 			testName: "VirtualService LIST",
 			url:      "https://127.0.0.1/apis/networking.istio.io/v1alpha3/namespaces/default/virtualservices",
 			expected: ResourceInfo{
 				Server:    "https://127.0.0.1",
 				Verb:      List,
 				Kind:      "virtualservices",
 				Namespace: "default",
 			},
 		},
 		{
 			testName: "VirtualService GET",
 			url:      "https://127.0.0.1/apis/networking.istio.io/v1alpha3/namespaces/default/virtualservices/virtual-service",
 			expected: ResourceInfo{
 				Server:    "https://127.0.0.1",
 				Verb:      Get,
 				Kind:      "virtualservices",
 				Namespace: "default",
 				Name:      "virtual-service",
 			},
 		},
 		{
 			testName: "ClusterRole LIST",
 			url:      "https://127.0.0.1/apis/rbac.authorization.k8s.io/v1/clusterroles",
 			expected: ResourceInfo{
 				Server: "https://127.0.0.1",
 				Verb:   List,
 				Kind:   "clusterroles",
 			},
 		},
 		{
 			testName: "ClusterRole Get",
 			url:      "https://127.0.0.1/apis/rbac.authorization.k8s.io/v1/clusterroles/argo-rollouts-clusterrole",
 			expected: ResourceInfo{
 				Server: "https://127.0.0.1",
 				Verb:   Get,
 				Kind:   "clusterroles",
 				Name:   "argo-rollouts-clusterrole",
 			},
 		},
 		{
 			testName: "CRD List",
 			url:      "https://127.0.0.1/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions",
 			expected: ResourceInfo{
 				Server: "https://127.0.0.1",
 				Verb:   List,
 				Kind:   "customresourcedefinitions",
 			},
 		},
 		{
 			testName: "CRD Get",
 			url:      "https://127.0.0.1/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions/dummies.apps.hanzo.ai",
 			expected: ResourceInfo{
 				Server: "https://127.0.0.1",
 				Verb:   Get,
 				Kind:   "customresourcedefinitions",
 				Name:   "dummies.apps.hanzo.ai",
 			},
 		},
 		{
 			testName: "Resource With Periods Get",
 			url:      "https://127.0.0.1/apis/apps.hanzo.ai/v1alpha1/namespaces/argocd/applications/my-cluster.cluster.k8s.local",
 			expected: ResourceInfo{
 				Server:    "https://127.0.0.1",
 				Verb:      Get,
 				Kind:      "applications",
 				Namespace: "argocd",
 				Name:      "my-cluster.cluster.k8s.local",
 			},
 		},
 		{
 			testName: "Watch cluster resources",
 			url:      "https://127.0.0.1/api/v1/namespaces?resourceVersion=343003&watch=true",
 			expected: ResourceInfo{
 				Server: "https://127.0.0.1",
 				Verb:   Watch,
 				Kind:   "namespaces",
 			},
 		},
 		{
 			testName: "Watch single cluster resource",
 			url:      "https://127.0.0.1/api/v1/namespaces?fieldSelector=metadata.name%3Ddefault&resourceVersion=0&watch=true",
 			expected: ResourceInfo{
 				Server: "https://127.0.0.1",
 				Verb:   Watch,
 				Kind:   "namespaces",
 				Name:   "default",
 			},
 		},
 		{
 			testName: "Watch namespace resources",
 			url:      "https://127.0.0.1/api/v1/namespaces/kube-system/serviceaccounts?resourceVersion=343091&watch=true",
 			expected: ResourceInfo{
 				Server:    "https://127.0.0.1",
 				Verb:      Watch,
 				Kind:      "serviceaccounts",
 				Namespace: "kube-system",
 			},
 		},
 		{
 			testName: "Watch single namespace resource",
 			url:      "https://127.0.0.1/api/v1/namespaces/kube-system/serviceaccounts?fieldSelector=metadata.name%3Ddefault&resourceVersion=0&watch=true",
 			expected: ResourceInfo{
 				Server:    "https://127.0.0.1",
 				Verb:      Watch,
 				Kind:      "serviceaccounts",
 				Namespace: "kube-system",
 				Name:      "default",
 			},
 		},
 		// Not yet supported
 		// {
 		// 	testName: "Non resource request",
 		// 	url:      "https://127.0.0.1/apis/apiextensions.k8s.io/v1beta1",
 		// 	expected: ResourceInfo{
 		// 		Server: "https://127.0.0.1",
 		// 		Verb:   Get,
 		// 	},
 		// },
 	}
 	for _, td := range testData {
 		t.Run(td.testName, func(t *testing.T) {
 			r := newGetRequest(td.url)
 			info := parseRequest(r)
 			assert.Equal(t, td.expected, info)
 		})
 	}
 }
 func TestGetRequest(t *testing.T) {
 	expectedStatusCode := 201
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(expectedStatusCode)
 	}))
 	defer ts.Close()
 	executed := false
 	config := NewConfig(ts.URL)
 	newConfig := AddMetricsTransportWrapper(config, func(info ResourceInfo) error {
 		assert.Equal(t, expectedStatusCode, info.StatusCode)
 		assert.Equal(t, "replicasets", info.Kind)
 		assert.Equal(t, metav1.NamespaceDefault, info.Namespace)
 		assert.Equal(t, "test", info.Name)
 		assert.Equal(t, Get, info.Verb)
 		executed = true
 		return nil
 	})
 	client := kubernetes.NewForConfigOrDie(newConfig)
 	_, _ = client.AppsV1().ReplicaSets(metav1.NamespaceDefault).Get(context.Background(), "test", metav1.GetOptions{})
 	assert.True(t, executed)
 }
 func TestListRequest(t *testing.T) {
 	expectedStatusCode := 201
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(expectedStatusCode)
 	}))
 	defer ts.Close()
 	executed := false
 	config := NewConfig(ts.URL)
 	newConfig := AddMetricsTransportWrapper(config, func(info ResourceInfo) error {
 		assert.Equal(t, expectedStatusCode, info.StatusCode)
 		assert.Equal(t, "replicasets", info.Kind)
 		assert.Equal(t, metav1.NamespaceDefault, info.Namespace)
 		assert.Empty(t, info.Name)
 		assert.Equal(t, List, info.Verb)
 		executed = true
 		return nil
 	})
 	client := kubernetes.NewForConfigOrDie(newConfig)
 	_, _ = client.AppsV1().ReplicaSets(metav1.NamespaceDefault).List(context.Background(), metav1.ListOptions{})
 	assert.True(t, executed)
 }
 func TestCreateRequest(t *testing.T) {
 	expectedStatusCode := 201
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(expectedStatusCode)
 	}))
 	defer ts.Close()
 	executed := false
 	config := NewConfig(ts.URL)
 	newConfig := AddMetricsTransportWrapper(config, func(info ResourceInfo) error {
 		assert.Equal(t, expectedStatusCode, info.StatusCode)
 		assert.Equal(t, "replicasets", info.Kind)
 		assert.Equal(t, metav1.NamespaceDefault, info.Namespace)
 		assert.Equal(t, "test", info.Name)
 		assert.Equal(t, Create, info.Verb)
 		executed = true
 		return nil
 	})
 	client := kubernetes.NewForConfigOrDie(newConfig)
 	rs := &appsv1.ReplicaSet{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "test",
 			Namespace: metav1.NamespaceDefault,
 		},
 	}
 	_, _ = client.AppsV1().ReplicaSets(metav1.NamespaceDefault).Create(context.Background(), rs, metav1.CreateOptions{})
 	assert.True(t, executed)
 }
 func TestDeleteRequest(t *testing.T) {
 	expectedStatusCode := 201
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(expectedStatusCode)
 	}))
 	defer ts.Close()
 	executed := false
 	config := NewConfig(ts.URL)
 	newConfig := AddMetricsTransportWrapper(config, func(info ResourceInfo) error {
 		assert.Equal(t, expectedStatusCode, info.StatusCode)
 		assert.Equal(t, "replicasets", info.Kind)
 		assert.Equal(t, metav1.NamespaceDefault, info.Namespace)
 		assert.Equal(t, "test", info.Name)
 		assert.Equal(t, Delete, info.Verb)
 		executed = true
 		return nil
 	})
 	client := kubernetes.NewForConfigOrDie(newConfig)
 	_ = client.AppsV1().ReplicaSets(metav1.NamespaceDefault).Delete(context.Background(), "test", metav1.DeleteOptions{})
 	assert.True(t, executed)
 }
 func TestPatchRequest(t *testing.T) {
 	expectedStatusCode := 201
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(expectedStatusCode)
 	}))
 	defer ts.Close()
 	executed := false
 	config := NewConfig(ts.URL)
 	newConfig := AddMetricsTransportWrapper(config, func(info ResourceInfo) error {
 		assert.Equal(t, expectedStatusCode, info.StatusCode)
 		assert.Equal(t, "replicasets", info.Kind)
 		assert.Equal(t, metav1.NamespaceDefault, info.Namespace)
 		assert.Equal(t, "test", info.Name)
 		assert.Equal(t, Patch, info.Verb)
 		executed = true
 		return nil
 	})
 	client := kubernetes.NewForConfigOrDie(newConfig)
 	_, _ = client.AppsV1().ReplicaSets(metav1.NamespaceDefault).Patch(context.Background(), "test", types.MergePatchType, []byte("{}"), metav1.PatchOptions{})
 	assert.True(t, executed)
 }
 func TestUpdateRequest(t *testing.T) {
 	expectedStatusCode := 201
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(expectedStatusCode)
 	}))
 	defer ts.Close()
 	executed := false
 	config := NewConfig(ts.URL)
 	newConfig := AddMetricsTransportWrapper(config, func(info ResourceInfo) error {
 		assert.Equal(t, expectedStatusCode, info.StatusCode)
 		assert.Equal(t, "replicasets", info.Kind)
 		assert.Equal(t, metav1.NamespaceDefault, info.Namespace)
 		assert.Equal(t, "test", info.Name)
 		assert.Equal(t, Update, info.Verb)
 		executed = true
 		return nil
 	})
 	client := kubernetes.NewForConfigOrDie(newConfig)
 	rs := &appsv1.ReplicaSet{
 		ObjectMeta: metav1.ObjectMeta{
 			Name: "test",
 		},
 	}
 	_, _ = client.AppsV1().ReplicaSets(metav1.NamespaceDefault).Update(context.Background(), rs, metav1.UpdateOptions{})
 	assert.True(t, executed)
 }
 func TestUnknownRequest(t *testing.T) {
 	expectedStatusCode := 201
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(expectedStatusCode)
 	}))
 	defer ts.Close()
 	executed := false
 	config := NewConfig(ts.URL)
 	newConfig := AddMetricsTransportWrapper(config, func(info ResourceInfo) error {
 		assert.Equal(t, expectedStatusCode, info.StatusCode)
 		assert.Equal(t, Unknown, info.Verb)
 		executed = true
 		return nil
 	})
 	client := kubernetes.NewForConfigOrDie(newConfig)
 	client.Discovery().RESTClient().Verb("invalid-verb").Do(context.Background())
 	assert.True(t, executed)
 }

453 lines 13 KiB Go Raw Permalink Blame History

453 lines

13 KiB

Go

Raw Permalink Blame History