mirror of
https://github.com/hanzoai/deploy.git
synced 2026-10-07 08:44:50 +00:00
41536738c8
* feat(api): hard-fork CRD API group argoproj.io -> deploy.hanzo.ai
Hanzo CD hard-fork, phase 1.1. Single source of truth is
pkg/apis/application/register.go's Group constant (Application/AppProject/
ApplicationSet all derive their FullName from it); every other Go call-site
that hardcoded the literal group string is updated to match: the 3 generated
informer GVRs, the app-of-apps nested-Application detector in types.go, the
resource-tree Application-kind cache populator, the 3 NotFound error
constructors in server/application, and the applicationset-controller's
leader-election Lease name/ID (kept in lockstep across Go source + RBAC
resourceNames, or leader election would get RBAC-denied on startup).
CRD YAMLs (application/appproject/applicationset) and every RBAC apiGroups
rule that actually governs our 3 CRDs are repointed to deploy.hanzo.ai, across
both manifests/base/* (namespaced Roles) and manifests/cluster-rbac/* (cluster
scope). Two adjacent things that share the "argoproj.io" string but are NOT
ours are deliberately left untouched: gitops-engine's health-check dispatch
for Argo Workflows' `Workflow` kind, and argocd-server-clusterrole's second
apiGroups block granting read on Argo Workflows' `workflows` resource — both
belong to a separate, unrelated Argoproj-family project we are not forking.
Also untouched, per explicit scope: annotation/label keys (argocd.argoproj.io/*)
and finalizers (*.argoproj.io) that track already-applied live resources, and
argocd-cm.yaml's resource.customizations.ignoreResourceUpdates keys (a narrow
app-of-apps diffing nicety, not build- or RBAC-relevant).
CGO_ENABLED=0 go build ./... verified green.
* ci: wire canonical hanzo.yml + cicd.yml (Hanzo CD image build)
Phase 1.3. Follows the same one-way pattern every hanzo/lux/zoo repo uses:
hanzo.yml declares the image (root Dockerfile -> ghcr.io/hanzoai/deploy) and a
fast go-build sanity test (the multi-stage Dockerfile build is the slow, real
gate); cicd.yml is the ~10-line trigger shim importing hanzoai/ci's reusable
build workflow on the arc pool, secrets from KMS only.
No `deploy:` block yet, matching the hanzoai/cms build-only-first-cutover
pattern: this repo's own live hanzo-cd namespace runs the whole Hanzo fleet's
GitOps, so the prod image/CRD swap is a deliberate separate action (see the
[HELD] universe PR), never an automatic rollout on merge. Every PR/push still
builds and pushes an immutable ghcr.io/hanzoai/deploy:sha-<7>-amd64 image.
* feat(ui): rebrand Argo CD -> Hanzo CD (title, favicon, logo, sidebar)
Phase 1.2. User-facing "Argo CD"/"ArgoCD" text replaced with "Hanzo CD"
across the login page, help modal, settings screens, version-info panel,
sync-options warning, fullscreen-logs title, app.tsx page titles, and
index.html's <title>/noscript text (dropped the now-wrong upstream CLI
doc link rather than invent a hanzo.ai URL that doesn't exist).
Logo/favicon assets replaced with the canonical Hanzo mark (never
hand-drawn, copied from ~/work/hanzo/logo/dist): the two real usages of
Argo's logo collapse onto one Hanzo glyph (mono + white variants) at the
same 5 call sites (login icon + footer, login.scss $logoPath/
$logoNegativePath, sidebar text-logo), preserving the existing CSS
invert() filters so both the light login panel and dark sidebar still
render correctly. Old argologo.svg/argo_o.svg/argo.png deleted (no
longer referenced). favicon-{16x16,32x32}.png added at
ui/src/assets/favicon/ (index.html's links to that path were previously
dead - the directory didn't exist in this checkout). package.json name
argo-cd-ui -> hanzo-cd-ui.
Left alone, deliberately: the two Kubernetes resource-kind icon sets
under ui/src/assets/images/resources/ (unrelated to branding), and
upstream doc/project links (argoproj.io, argo-cd.readthedocs.io) since
we have no equivalent hanzo.ai docs to point to yet - except the login
footer logo's outbound link, which now points to hanzo.ai instead of
argoproj.io (a Hanzo-branded mark linking to the upstream project it
was forked from read as an obvious leftover).
* feat(module): rename Go module github.com/argoproj/argo-cd/v3 -> github.com/hanzoai/deploy
Phase 2. No version suffix on the new path (org policy: never publish our
own Go modules above v1.x.x / with a v2+ suffix) — this fork starts a fresh
v0/v1 module identity rather than carrying the v3 the upstream fork point
had reached.
Mechanical, symmetric rewrite: 704 .go files (import statements only; two
disjoint substitutions applied specific-first so the nested gitops-engine
module path never double-matches), plus go.mod (module line, the
gitops-engine require+replace pair, version reset to v0.0.0-... since a
suffix-less path can't carry a v3 semver), gitops-engine/go.mod, Makefile
(ldflags PACKAGE + 2 TEST_MODULE filters), .golangci.yaml, .goreleaser.yaml,
.mockery.yaml (+ gitops-engine's), Procfile, the codegen/proto generation
scripts (hack/generate-proto.sh, update-codegen.sh, update-openapi.sh), and
20 .proto files' go_package options. Also one OpenTelemetry tracer name
string in gitops-engine/pkg/sync/sync_context.go (a cosmestic label, not an
import, but worth keeping consistent).
CGO_ENABLED=0 go build ./... verified green for both the root module and
the nested gitops-engine module; go vet clean on both; go mod tidy run
(network available) to reconcile go.sum, dependency set unchanged.
Left alone, deliberately: doc-only mentions (docs/snyk/*.html scan reports,
gitops-engine/README.md), a comment-only reference in
.github/workflows/release.yaml, and one Renovate bot config line — none are
build- or codegen-load-bearing. Also left alone: comments citing upstream
GitHub issue URLs (github.com/argoproj/argo-cd/issues/NNNNN) and a handful
of test fixtures using "https://github.com/argoproj/argo-cd.git" as a
representative example repo URL — both are accurate historical/test-data
references, not stale self-references.
---------
Co-authored-by: Hanzo Dev <[email protected]>
507 lines
18 KiB
Go
507 lines
18 KiB
Go
package scm_provider
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/microsoft/azure-devops-go-api/azuredevops/v7"
|
|
azureGit "github.com/microsoft/azure-devops-go-api/azuredevops/v7/git"
|
|
|
|
azureMock "github.com/hanzoai/deploy/applicationset/services/scm_provider/azure_devops/git/mocks"
|
|
"github.com/hanzoai/deploy/applicationset/services/scm_provider/mocks"
|
|
)
|
|
|
|
func TestAzureDevopsRepoHasPath(t *testing.T) {
|
|
t.Parallel()
|
|
organization := "myorg"
|
|
teamProject := "myorg_project"
|
|
repoName := "myorg_project_repo"
|
|
path := "dir/subdir/item.yaml"
|
|
branchName := "my/featurebranch"
|
|
|
|
ctx := t.Context()
|
|
uuid := uuid.New().String()
|
|
|
|
testCases := []struct {
|
|
name string
|
|
pathFound bool
|
|
azureDevopsError error
|
|
returnError bool
|
|
errorMessage string
|
|
clientError error
|
|
}{
|
|
{
|
|
name: "RepoHasPath when Azure DevOps client factory fails returns error",
|
|
clientError: errors.New("Client factory error"),
|
|
},
|
|
{
|
|
name: "RepoHasPath when found returns true",
|
|
pathFound: true,
|
|
},
|
|
{
|
|
name: "RepoHasPath when no path found returns false",
|
|
pathFound: false,
|
|
azureDevopsError: azuredevops.WrappedError{TypeKey: new(AzureDevOpsErrorsTypeKeyValues.GitItemNotFound)},
|
|
},
|
|
{
|
|
name: "RepoHasPath when unknown Azure DevOps WrappedError occurs returns error",
|
|
pathFound: false,
|
|
azureDevopsError: azuredevops.WrappedError{TypeKey: new("OtherAzureDevopsException")},
|
|
returnError: true,
|
|
errorMessage: "failed to check for path existence",
|
|
},
|
|
{
|
|
name: "RepoHasPath when unknown Azure DevOps error occurs returns error",
|
|
pathFound: false,
|
|
azureDevopsError: errors.New("Undefined error from Azure Devops"),
|
|
returnError: true,
|
|
errorMessage: "failed to check for path existence",
|
|
},
|
|
{
|
|
name: "RepoHasPath when wrapped Azure DevOps error occurs without TypeKey returns error",
|
|
pathFound: false,
|
|
azureDevopsError: azuredevops.WrappedError{},
|
|
returnError: true,
|
|
errorMessage: "failed to check for path existence",
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
gitClientMock := &azureMock.Client{}
|
|
|
|
clientFactoryMock := &mocks.AzureDevOpsClientFactory{}
|
|
clientFactoryMock.EXPECT().GetClient(mock.Anything).Return(gitClientMock, testCase.clientError)
|
|
|
|
repoId := &uuid
|
|
gitClientMock.EXPECT().GetItem(mock.Anything, azureGit.GetItemArgs{Project: &teamProject, Path: &path, VersionDescriptor: &azureGit.GitVersionDescriptor{Version: &branchName}, RepositoryId: repoId}).Return(nil, testCase.azureDevopsError)
|
|
|
|
provider := AzureDevOpsProvider{organization: organization, teamProject: teamProject, clientFactory: clientFactoryMock}
|
|
|
|
repo := &Repository{Organization: organization, Repository: repoName, RepositoryId: uuid, Branch: branchName}
|
|
hasPath, err := provider.RepoHasPath(ctx, repo, path)
|
|
|
|
if testCase.clientError != nil {
|
|
require.ErrorContains(t, err, testCase.clientError.Error())
|
|
gitClientMock.AssertNotCalled(t, "GetItem", ctx, azureGit.GetItemArgs{Project: &teamProject, Path: &path, VersionDescriptor: &azureGit.GitVersionDescriptor{Version: &branchName}, RepositoryId: repoId})
|
|
|
|
return
|
|
}
|
|
|
|
if testCase.returnError {
|
|
require.ErrorContains(t, err, testCase.errorMessage)
|
|
}
|
|
|
|
assert.Equal(t, testCase.pathFound, hasPath)
|
|
|
|
gitClientMock.AssertCalled(t, "GetItem", ctx, azureGit.GetItemArgs{Project: &teamProject, Path: &path, VersionDescriptor: &azureGit.GitVersionDescriptor{Version: &branchName}, RepositoryId: repoId})
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGetDefaultBranchOnDisabledRepo(t *testing.T) {
|
|
t.Parallel()
|
|
organization := "myorg"
|
|
teamProject := "myorg_project"
|
|
repoName := "myorg_project_repo"
|
|
defaultBranch := "main"
|
|
|
|
ctx := t.Context()
|
|
|
|
testCases := []struct {
|
|
name string
|
|
azureDevOpsError error
|
|
shouldReturnError bool
|
|
}{
|
|
{
|
|
name: "azure devops error when disabled repo causes empty return value",
|
|
azureDevOpsError: azuredevops.WrappedError{TypeKey: new(AzureDevOpsErrorsTypeKeyValues.GitRepositoryNotFound)},
|
|
shouldReturnError: false,
|
|
},
|
|
{
|
|
name: "azure devops error with unknown error type returns error",
|
|
azureDevOpsError: azuredevops.WrappedError{TypeKey: new("OtherError")},
|
|
shouldReturnError: true,
|
|
},
|
|
{
|
|
name: "other error when calling azure devops returns error",
|
|
azureDevOpsError: errors.New("some unknown error"),
|
|
shouldReturnError: true,
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
uuid := uuid.New().String()
|
|
|
|
gitClientMock := azureMock.NewClient(t)
|
|
|
|
clientFactoryMock := &mocks.AzureDevOpsClientFactory{}
|
|
clientFactoryMock.EXPECT().GetClient(mock.Anything).Return(gitClientMock, nil)
|
|
|
|
gitClientMock.EXPECT().GetBranch(mock.Anything, azureGit.GetBranchArgs{RepositoryId: &repoName, Project: &teamProject, Name: &defaultBranch}).Return(nil, testCase.azureDevOpsError)
|
|
|
|
repo := &Repository{Organization: organization, Repository: repoName, RepositoryId: uuid, Branch: defaultBranch}
|
|
|
|
provider := AzureDevOpsProvider{organization: organization, teamProject: teamProject, clientFactory: clientFactoryMock, allBranches: false}
|
|
branches, err := provider.GetBranches(ctx, repo)
|
|
|
|
if testCase.shouldReturnError {
|
|
require.Error(t, err)
|
|
} else {
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
assert.Empty(t, branches)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGetAllBranchesOnDisabledRepo(t *testing.T) {
|
|
t.Parallel()
|
|
organization := "myorg"
|
|
teamProject := "myorg_project"
|
|
repoName := "myorg_project_repo"
|
|
defaultBranch := "main"
|
|
|
|
ctx := t.Context()
|
|
|
|
testCases := []struct {
|
|
name string
|
|
azureDevOpsError error
|
|
shouldReturnError bool
|
|
}{
|
|
{
|
|
name: "azure devops error when disabled repo causes empty return value",
|
|
azureDevOpsError: azuredevops.WrappedError{TypeKey: new(AzureDevOpsErrorsTypeKeyValues.GitRepositoryNotFound)},
|
|
shouldReturnError: false,
|
|
},
|
|
{
|
|
name: "azure devops error with unknown error type returns error",
|
|
azureDevOpsError: azuredevops.WrappedError{TypeKey: new("OtherError")},
|
|
shouldReturnError: true,
|
|
},
|
|
{
|
|
name: "other error when calling azure devops returns error",
|
|
azureDevOpsError: errors.New("some unknown error"),
|
|
shouldReturnError: true,
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
uuid := uuid.New().String()
|
|
|
|
gitClientMock := azureMock.NewClient(t)
|
|
|
|
clientFactoryMock := &mocks.AzureDevOpsClientFactory{}
|
|
clientFactoryMock.EXPECT().GetClient(mock.Anything).Return(gitClientMock, nil)
|
|
|
|
gitClientMock.EXPECT().GetBranches(mock.Anything, azureGit.GetBranchesArgs{RepositoryId: &repoName, Project: &teamProject}).Return(nil, testCase.azureDevOpsError)
|
|
|
|
repo := &Repository{Organization: organization, Repository: repoName, RepositoryId: uuid, Branch: defaultBranch}
|
|
|
|
provider := AzureDevOpsProvider{organization: organization, teamProject: teamProject, clientFactory: clientFactoryMock, allBranches: true}
|
|
branches, err := provider.GetBranches(ctx, repo)
|
|
|
|
if testCase.shouldReturnError {
|
|
require.Error(t, err)
|
|
} else {
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
assert.Empty(t, branches)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestAzureDevOpsGetDefaultBranchStripsRefsName(t *testing.T) {
|
|
t.Parallel()
|
|
t.Run("Get branches only default branch removes characters before querying azure devops", func(t *testing.T) {
|
|
t.Parallel()
|
|
organization := "myorg"
|
|
teamProject := "myorg_project"
|
|
repoName := "myorg_project_repo"
|
|
|
|
ctx := t.Context()
|
|
uuid := uuid.New().String()
|
|
strippedBranchName := "somebranch"
|
|
defaultBranch := fmt.Sprintf("refs/heads/%v", strippedBranchName)
|
|
|
|
branchReturn := &azureGit.GitBranchStats{Name: &strippedBranchName, Commit: &azureGit.GitCommitRef{CommitId: new("abc123233223")}}
|
|
repo := &Repository{Organization: organization, Repository: repoName, RepositoryId: uuid, Branch: defaultBranch}
|
|
|
|
gitClientMock := &azureMock.Client{}
|
|
|
|
clientFactoryMock := &mocks.AzureDevOpsClientFactory{}
|
|
clientFactoryMock.EXPECT().GetClient(mock.Anything).Return(gitClientMock, nil)
|
|
|
|
gitClientMock.EXPECT().GetBranch(mock.Anything, azureGit.GetBranchArgs{RepositoryId: &repoName, Project: &teamProject, Name: &strippedBranchName}).Return(branchReturn, nil).Maybe()
|
|
|
|
provider := AzureDevOpsProvider{organization: organization, teamProject: teamProject, clientFactory: clientFactoryMock, allBranches: false}
|
|
branches, err := provider.GetBranches(ctx, repo)
|
|
|
|
require.NoError(t, err)
|
|
assert.Len(t, branches, 1)
|
|
assert.Equal(t, strippedBranchName, branches[0].Branch)
|
|
|
|
gitClientMock.AssertCalled(t, "GetBranch", ctx, azureGit.GetBranchArgs{RepositoryId: &repoName, Project: &teamProject, Name: &strippedBranchName})
|
|
})
|
|
}
|
|
|
|
func TestAzureDevOpsGetBranchesDefultBranchOnly(t *testing.T) {
|
|
t.Parallel()
|
|
organization := "myorg"
|
|
teamProject := "myorg_project"
|
|
repoName := "myorg_project_repo"
|
|
|
|
ctx := t.Context()
|
|
uuid := uuid.New().String()
|
|
|
|
defaultBranch := "main"
|
|
|
|
testCases := []struct {
|
|
name string
|
|
expectedBranch *azureGit.GitBranchStats
|
|
getBranchesAPIError error
|
|
clientError error
|
|
}{
|
|
{
|
|
name: "GetBranches AllBranches false when single branch returned returns branch",
|
|
expectedBranch: &azureGit.GitBranchStats{Name: &defaultBranch, Commit: &azureGit.GitCommitRef{CommitId: new("abc123233223")}},
|
|
},
|
|
{
|
|
name: "GetBranches AllBranches false when request fails returns error and empty result",
|
|
getBranchesAPIError: errors.New("Remote Azure Devops GetBranches error"),
|
|
},
|
|
{
|
|
name: "GetBranches AllBranches false when Azure DevOps client fails returns error",
|
|
clientError: errors.New("Could not get Azure Devops API client"),
|
|
},
|
|
{
|
|
name: "GetBranches AllBranches false when branch returned with long commit SHA",
|
|
expectedBranch: &azureGit.GitBranchStats{Name: &defaultBranch, Commit: &azureGit.GitCommitRef{CommitId: new("53863052ADF24229AB72154B4D83DAB7")}},
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
gitClientMock := &azureMock.Client{}
|
|
|
|
clientFactoryMock := &mocks.AzureDevOpsClientFactory{}
|
|
clientFactoryMock.EXPECT().GetClient(mock.Anything).Return(gitClientMock, testCase.clientError)
|
|
|
|
gitClientMock.EXPECT().GetBranch(mock.Anything, azureGit.GetBranchArgs{RepositoryId: &repoName, Project: &teamProject, Name: &defaultBranch}).Return(testCase.expectedBranch, testCase.getBranchesAPIError)
|
|
|
|
repo := &Repository{Organization: organization, Repository: repoName, RepositoryId: uuid, Branch: defaultBranch}
|
|
|
|
provider := AzureDevOpsProvider{organization: organization, teamProject: teamProject, clientFactory: clientFactoryMock, allBranches: false}
|
|
branches, err := provider.GetBranches(ctx, repo)
|
|
|
|
if testCase.clientError != nil {
|
|
require.ErrorContains(t, err, testCase.clientError.Error())
|
|
gitClientMock.AssertNotCalled(t, "GetBranch", ctx, azureGit.GetBranchArgs{RepositoryId: &repoName, Project: &teamProject, Name: &defaultBranch})
|
|
|
|
return
|
|
}
|
|
|
|
if testCase.getBranchesAPIError != nil {
|
|
assert.Empty(t, branches)
|
|
require.ErrorContains(t, err, testCase.getBranchesAPIError.Error())
|
|
} else {
|
|
if testCase.expectedBranch != nil {
|
|
assert.NotEmpty(t, branches)
|
|
}
|
|
assert.Len(t, branches, 1)
|
|
assert.Equal(t, repo.RepositoryId, branches[0].RepositoryId)
|
|
}
|
|
|
|
gitClientMock.AssertCalled(t, "GetBranch", ctx, azureGit.GetBranchArgs{RepositoryId: &repoName, Project: &teamProject, Name: &defaultBranch})
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestAzureDevopsGetBranches(t *testing.T) {
|
|
t.Parallel()
|
|
organization := "myorg"
|
|
teamProject := "myorg_project"
|
|
repoName := "myorg_project_repo"
|
|
|
|
ctx := t.Context()
|
|
uuid := uuid.New().String()
|
|
|
|
testCases := []struct {
|
|
name string
|
|
expectedBranches *[]azureGit.GitBranchStats
|
|
getBranchesAPIError error
|
|
clientError error
|
|
allBranches bool
|
|
expectedProcessingErrorMsg string
|
|
}{
|
|
{
|
|
name: "GetBranches when single branch returned returns this branch info",
|
|
expectedBranches: &[]azureGit.GitBranchStats{{Name: new("feature-feat1"), Commit: &azureGit.GitCommitRef{CommitId: new("abc123233223")}}},
|
|
allBranches: true,
|
|
},
|
|
{
|
|
name: "GetBranches when Azure DevOps request fails returns error and empty result",
|
|
getBranchesAPIError: errors.New("Remote Azure Devops GetBranches error"),
|
|
allBranches: true,
|
|
},
|
|
{
|
|
name: "GetBranches when no branches returned returns error",
|
|
allBranches: true,
|
|
expectedProcessingErrorMsg: "empty branch result",
|
|
},
|
|
{
|
|
name: "GetBranches when git client retrievel fails returns error",
|
|
clientError: errors.New("Could not get Azure Devops API client"),
|
|
allBranches: true,
|
|
},
|
|
{
|
|
name: "GetBranches when multiple branches returned returns branch info for all branches",
|
|
expectedBranches: &[]azureGit.GitBranchStats{
|
|
{Name: new("feature-feat1"), Commit: &azureGit.GitCommitRef{CommitId: new("abc123233223")}},
|
|
{Name: new("feature/feat2"), Commit: &azureGit.GitCommitRef{CommitId: new("4334")}},
|
|
{Name: new("feature/feat2"), Commit: &azureGit.GitCommitRef{CommitId: new("53863052ADF24229AB72154B4D83DAB7")}},
|
|
},
|
|
allBranches: true,
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
gitClientMock := &azureMock.Client{}
|
|
|
|
clientFactoryMock := &mocks.AzureDevOpsClientFactory{}
|
|
clientFactoryMock.EXPECT().GetClient(mock.Anything).Return(gitClientMock, testCase.clientError)
|
|
|
|
gitClientMock.EXPECT().GetBranches(mock.Anything, azureGit.GetBranchesArgs{RepositoryId: &repoName, Project: &teamProject}).Return(testCase.expectedBranches, testCase.getBranchesAPIError)
|
|
|
|
repo := &Repository{Organization: organization, Repository: repoName, RepositoryId: uuid}
|
|
|
|
provider := AzureDevOpsProvider{organization: organization, teamProject: teamProject, clientFactory: clientFactoryMock, allBranches: testCase.allBranches}
|
|
branches, err := provider.GetBranches(ctx, repo)
|
|
|
|
if testCase.expectedProcessingErrorMsg != "" {
|
|
require.ErrorContains(t, err, testCase.expectedProcessingErrorMsg)
|
|
assert.Nil(t, branches)
|
|
|
|
return
|
|
}
|
|
if testCase.clientError != nil {
|
|
require.ErrorContains(t, err, testCase.clientError.Error())
|
|
gitClientMock.AssertNotCalled(t, "GetBranches", ctx, azureGit.GetBranchesArgs{RepositoryId: &repoName, Project: &teamProject})
|
|
return
|
|
}
|
|
|
|
if testCase.getBranchesAPIError != nil {
|
|
assert.Empty(t, branches)
|
|
require.ErrorContains(t, err, testCase.getBranchesAPIError.Error())
|
|
} else {
|
|
if len(*testCase.expectedBranches) > 0 {
|
|
assert.NotEmpty(t, branches)
|
|
}
|
|
assert.Len(t, branches, len(*testCase.expectedBranches))
|
|
for _, branch := range branches {
|
|
assert.NotEmpty(t, branch.RepositoryId)
|
|
assert.Equal(t, repo.RepositoryId, branch.RepositoryId)
|
|
}
|
|
}
|
|
|
|
gitClientMock.AssertCalled(t, "GetBranches", ctx, azureGit.GetBranchesArgs{RepositoryId: &repoName, Project: &teamProject})
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGetAzureDevopsRepositories(t *testing.T) {
|
|
t.Parallel()
|
|
organization := "myorg"
|
|
teamProject := "myorg_project"
|
|
|
|
uuid := uuid.New()
|
|
|
|
repoId := &uuid
|
|
|
|
testCases := []struct {
|
|
name string
|
|
getRepositoriesError error
|
|
repositories []azureGit.GitRepository
|
|
expectedNumberOfRepos int
|
|
}{
|
|
{
|
|
name: "ListRepos when single repo found returns repo info",
|
|
repositories: []azureGit.GitRepository{{Name: new("repo1"), DefaultBranch: new("main"), RemoteUrl: new("https://remoteurl.u"), Id: repoId}},
|
|
expectedNumberOfRepos: 1,
|
|
},
|
|
{
|
|
name: "ListRepos when repo has no default branch returns empty list",
|
|
repositories: []azureGit.GitRepository{{Name: new("repo2"), RemoteUrl: new("https://remoteurl.u"), Id: repoId}},
|
|
},
|
|
{
|
|
name: "ListRepos when Azure DevOps request fails returns error",
|
|
getRepositoriesError: errors.New("Could not get repos"),
|
|
},
|
|
{
|
|
name: "ListRepos when repo has no name returns empty list",
|
|
repositories: []azureGit.GitRepository{{DefaultBranch: new("main"), RemoteUrl: new("https://remoteurl.u"), Id: repoId}},
|
|
},
|
|
{
|
|
name: "ListRepos when repo has no remote URL returns empty list",
|
|
repositories: []azureGit.GitRepository{{DefaultBranch: new("main"), Name: new("repo_name"), Id: repoId}},
|
|
},
|
|
{
|
|
name: "ListRepos when repo has no ID returns empty list",
|
|
repositories: []azureGit.GitRepository{{DefaultBranch: new("main"), Name: new("repo_name"), RemoteUrl: new("https://remoteurl.u")}},
|
|
},
|
|
{
|
|
name: "ListRepos when multiple repos returned returns list of eligible repos only",
|
|
repositories: []azureGit.GitRepository{
|
|
{Name: new("returned1"), DefaultBranch: new("main"), RemoteUrl: new("https://remoteurl.u"), Id: repoId},
|
|
{Name: new("missing_default_branch"), RemoteUrl: new("https://remoteurl.u"), Id: repoId},
|
|
{DefaultBranch: new("missing_name"), RemoteUrl: new("https://remoteurl.u"), Id: repoId},
|
|
{Name: new("missing_remote_url"), DefaultBranch: new("main"), Id: repoId},
|
|
{Name: new("missing_id"), DefaultBranch: new("main"), RemoteUrl: new("https://remoteurl.u")},
|
|
},
|
|
expectedNumberOfRepos: 1,
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
gitClientMock := azureMock.NewClient(t)
|
|
gitClientMock.EXPECT().GetRepositories(mock.Anything, azureGit.GetRepositoriesArgs{Project: new(teamProject)}).Return(&testCase.repositories, testCase.getRepositoriesError)
|
|
|
|
clientFactoryMock := &mocks.AzureDevOpsClientFactory{}
|
|
clientFactoryMock.EXPECT().GetClient(mock.Anything).Return(gitClientMock, nil)
|
|
|
|
provider := AzureDevOpsProvider{organization: organization, teamProject: teamProject, clientFactory: clientFactoryMock}
|
|
|
|
repositories, err := provider.ListRepos(t.Context(), "https")
|
|
|
|
if testCase.getRepositoriesError != nil {
|
|
require.Error(t, err, "Expected an error from test case %v", testCase.name)
|
|
}
|
|
|
|
if testCase.expectedNumberOfRepos == 0 {
|
|
assert.Empty(t, repositories)
|
|
} else {
|
|
assert.NotEmpty(t, repositories)
|
|
assert.Len(t, repositories, testCase.expectedNumberOfRepos)
|
|
}
|
|
})
|
|
}
|
|
}
|