mirror of
https://github.com/hanzoai/deploy.git
synced 2026-10-07 08:44:50 +00:00
* feat(api): hard-fork CRD API group argoproj.io -> deploy.hanzo.ai
Hanzo CD hard-fork, phase 1.1. Single source of truth is
pkg/apis/application/register.go's Group constant (Application/AppProject/
ApplicationSet all derive their FullName from it); every other Go call-site
that hardcoded the literal group string is updated to match: the 3 generated
informer GVRs, the app-of-apps nested-Application detector in types.go, the
resource-tree Application-kind cache populator, the 3 NotFound error
constructors in server/application, and the applicationset-controller's
leader-election Lease name/ID (kept in lockstep across Go source + RBAC
resourceNames, or leader election would get RBAC-denied on startup).
CRD YAMLs (application/appproject/applicationset) and every RBAC apiGroups
rule that actually governs our 3 CRDs are repointed to deploy.hanzo.ai, across
both manifests/base/* (namespaced Roles) and manifests/cluster-rbac/* (cluster
scope). Two adjacent things that share the "argoproj.io" string but are NOT
ours are deliberately left untouched: gitops-engine's health-check dispatch
for Argo Workflows' `Workflow` kind, and argocd-server-clusterrole's second
apiGroups block granting read on Argo Workflows' `workflows` resource — both
belong to a separate, unrelated Argoproj-family project we are not forking.
Also untouched, per explicit scope: annotation/label keys (argocd.argoproj.io/*)
and finalizers (*.argoproj.io) that track already-applied live resources, and
argocd-cm.yaml's resource.customizations.ignoreResourceUpdates keys (a narrow
app-of-apps diffing nicety, not build- or RBAC-relevant).
CGO_ENABLED=0 go build ./... verified green.
* ci: wire canonical hanzo.yml + cicd.yml (Hanzo CD image build)
Phase 1.3. Follows the same one-way pattern every hanzo/lux/zoo repo uses:
hanzo.yml declares the image (root Dockerfile -> ghcr.io/hanzoai/deploy) and a
fast go-build sanity test (the multi-stage Dockerfile build is the slow, real
gate); cicd.yml is the ~10-line trigger shim importing hanzoai/ci's reusable
build workflow on the arc pool, secrets from KMS only.
No `deploy:` block yet, matching the hanzoai/cms build-only-first-cutover
pattern: this repo's own live hanzo-cd namespace runs the whole Hanzo fleet's
GitOps, so the prod image/CRD swap is a deliberate separate action (see the
[HELD] universe PR), never an automatic rollout on merge. Every PR/push still
builds and pushes an immutable ghcr.io/hanzoai/deploy:sha-<7>-amd64 image.
* feat(ui): rebrand Argo CD -> Hanzo CD (title, favicon, logo, sidebar)
Phase 1.2. User-facing "Argo CD"/"ArgoCD" text replaced with "Hanzo CD"
across the login page, help modal, settings screens, version-info panel,
sync-options warning, fullscreen-logs title, app.tsx page titles, and
index.html's <title>/noscript text (dropped the now-wrong upstream CLI
doc link rather than invent a hanzo.ai URL that doesn't exist).
Logo/favicon assets replaced with the canonical Hanzo mark (never
hand-drawn, copied from ~/work/hanzo/logo/dist): the two real usages of
Argo's logo collapse onto one Hanzo glyph (mono + white variants) at the
same 5 call sites (login icon + footer, login.scss $logoPath/
$logoNegativePath, sidebar text-logo), preserving the existing CSS
invert() filters so both the light login panel and dark sidebar still
render correctly. Old argologo.svg/argo_o.svg/argo.png deleted (no
longer referenced). favicon-{16x16,32x32}.png added at
ui/src/assets/favicon/ (index.html's links to that path were previously
dead - the directory didn't exist in this checkout). package.json name
argo-cd-ui -> hanzo-cd-ui.
Left alone, deliberately: the two Kubernetes resource-kind icon sets
under ui/src/assets/images/resources/ (unrelated to branding), and
upstream doc/project links (argoproj.io, argo-cd.readthedocs.io) since
we have no equivalent hanzo.ai docs to point to yet - except the login
footer logo's outbound link, which now points to hanzo.ai instead of
argoproj.io (a Hanzo-branded mark linking to the upstream project it
was forked from read as an obvious leftover).
* feat(module): rename Go module github.com/argoproj/argo-cd/v3 -> github.com/hanzoai/deploy
Phase 2. No version suffix on the new path (org policy: never publish our
own Go modules above v1.x.x / with a v2+ suffix) — this fork starts a fresh
v0/v1 module identity rather than carrying the v3 the upstream fork point
had reached.
Mechanical, symmetric rewrite: 704 .go files (import statements only; two
disjoint substitutions applied specific-first so the nested gitops-engine
module path never double-matches), plus go.mod (module line, the
gitops-engine require+replace pair, version reset to v0.0.0-... since a
suffix-less path can't carry a v3 semver), gitops-engine/go.mod, Makefile
(ldflags PACKAGE + 2 TEST_MODULE filters), .golangci.yaml, .goreleaser.yaml,
.mockery.yaml (+ gitops-engine's), Procfile, the codegen/proto generation
scripts (hack/generate-proto.sh, update-codegen.sh, update-openapi.sh), and
20 .proto files' go_package options. Also one OpenTelemetry tracer name
string in gitops-engine/pkg/sync/sync_context.go (a cosmestic label, not an
import, but worth keeping consistent).
CGO_ENABLED=0 go build ./... verified green for both the root module and
the nested gitops-engine module; go vet clean on both; go mod tidy run
(network available) to reconcile go.sum, dependency set unchanged.
Left alone, deliberately: doc-only mentions (docs/snyk/*.html scan reports,
gitops-engine/README.md), a comment-only reference in
.github/workflows/release.yaml, and one Renovate bot config line — none are
build- or codegen-load-bearing. Also left alone: comments citing upstream
GitHub issue URLs (github.com/argoproj/argo-cd/issues/NNNNN) and a handful
of test fixtures using "https://github.com/argoproj/argo-cd.git" as a
representative example repo URL — both are accurate historical/test-data
references, not stale self-references.
---------
Co-authored-by: Hanzo Dev <[email protected]>
343 lines
11 KiB
Go
343 lines
11 KiB
Go
package application
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"net/http"
|
|
"slices"
|
|
"time"
|
|
|
|
"github.com/hanzoai/deploy/gitops-engine/pkg/utils/kube"
|
|
log "github.com/sirupsen/logrus"
|
|
corev1 "k8s.io/api/core/v1"
|
|
apierrors "k8s.io/apimachinery/pkg/api/errors"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/client-go/kubernetes"
|
|
"k8s.io/client-go/kubernetes/scheme"
|
|
"k8s.io/client-go/rest"
|
|
"k8s.io/client-go/tools/remotecommand"
|
|
cmdutil "k8s.io/kubectl/pkg/cmd/util"
|
|
"k8s.io/streaming/pkg/httpstream"
|
|
|
|
appv1 "github.com/hanzoai/deploy/pkg/apis/application/v1alpha1"
|
|
applisters "github.com/hanzoai/deploy/pkg/client/listers/application/v1alpha1"
|
|
"github.com/hanzoai/deploy/util/argo"
|
|
"github.com/hanzoai/deploy/util/db"
|
|
"github.com/hanzoai/deploy/util/rbac"
|
|
"github.com/hanzoai/deploy/util/security"
|
|
util_session "github.com/hanzoai/deploy/util/session"
|
|
"github.com/hanzoai/deploy/util/settings"
|
|
)
|
|
|
|
type terminalHandler struct {
|
|
appLister applisters.ApplicationLister
|
|
db db.ArgoDB
|
|
appResourceTreeFn func(ctx context.Context, app *appv1.Application) (*appv1.ApplicationTree, error)
|
|
allowedShells []string
|
|
namespace string
|
|
enabledNamespaces []string
|
|
sessionManager *util_session.SessionManager
|
|
terminalOptions *TerminalOptions
|
|
}
|
|
|
|
type TerminalOptions struct {
|
|
DisableAuth bool
|
|
Enf *rbac.Enforcer
|
|
}
|
|
|
|
// NewHandler returns a new terminal handler.
|
|
func NewHandler(appLister applisters.ApplicationLister, namespace string, enabledNamespaces []string, db db.ArgoDB, appResourceTree AppResourceTreeFn, allowedShells []string, sessionManager *util_session.SessionManager, terminalOptions *TerminalOptions) *terminalHandler {
|
|
return &terminalHandler{
|
|
appLister: appLister,
|
|
db: db,
|
|
appResourceTreeFn: appResourceTree,
|
|
allowedShells: allowedShells,
|
|
namespace: namespace,
|
|
enabledNamespaces: enabledNamespaces,
|
|
sessionManager: sessionManager,
|
|
terminalOptions: terminalOptions,
|
|
}
|
|
}
|
|
|
|
func (s *terminalHandler) getApplicationClusterRawConfig(ctx context.Context, a *appv1.Application) (*rest.Config, error) {
|
|
destCluster, err := argo.GetDestinationCluster(ctx, a.Spec.Destination, s.db)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
rawConfig, err := destCluster.RawRestConfig()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return rawConfig, nil
|
|
}
|
|
|
|
type GetSettingsFunc func() (*settings.ArgoCDSettings, error)
|
|
|
|
// WithFeatureFlagMiddleware is an HTTP middleware to verify if the terminal
|
|
// feature is enabled before invoking the main handler
|
|
func (s *terminalHandler) WithFeatureFlagMiddleware(getSettings GetSettingsFunc) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
argocdSettings, err := getSettings()
|
|
if err != nil {
|
|
log.Errorf("error executing WithFeatureFlagMiddleware: error getting settings: %s", err)
|
|
http.Error(w, "Failed to get settings", http.StatusBadRequest)
|
|
return
|
|
}
|
|
if !argocdSettings.ExecEnabled {
|
|
w.WriteHeader(http.StatusNotFound)
|
|
return
|
|
}
|
|
s.ServeHTTP(w, r)
|
|
})
|
|
}
|
|
|
|
func (s *terminalHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
|
|
q := r.URL.Query()
|
|
|
|
podName := q.Get("pod")
|
|
container := q.Get("container")
|
|
app := q.Get("appName")
|
|
project := q.Get("projectName")
|
|
namespace := q.Get("namespace")
|
|
|
|
if podName == "" || container == "" || app == "" || project == "" || namespace == "" {
|
|
http.Error(w, "Missing required parameters", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
appNamespace := q.Get("appNamespace")
|
|
|
|
if !argo.IsValidPodName(podName) {
|
|
http.Error(w, "Pod name is not valid", http.StatusBadRequest)
|
|
return
|
|
}
|
|
if !argo.IsValidContainerName(container) {
|
|
http.Error(w, "Container name is not valid", http.StatusBadRequest)
|
|
return
|
|
}
|
|
if !argo.IsValidAppName(app) {
|
|
http.Error(w, "App name is not valid", http.StatusBadRequest)
|
|
return
|
|
}
|
|
if !argo.IsValidProjectName(project) {
|
|
http.Error(w, "Project name is not valid", http.StatusBadRequest)
|
|
return
|
|
}
|
|
if !argo.IsValidNamespaceName(namespace) {
|
|
http.Error(w, "Namespace name is not valid", http.StatusBadRequest)
|
|
return
|
|
}
|
|
if !argo.IsValidNamespaceName(appNamespace) {
|
|
http.Error(w, "App namespace name is not valid", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
ns := appNamespace
|
|
if ns == "" {
|
|
ns = s.namespace
|
|
}
|
|
|
|
if !security.IsNamespaceEnabled(ns, s.namespace, s.enabledNamespaces) {
|
|
http.Error(w, security.NamespaceNotPermittedError(ns).Error(), http.StatusForbidden)
|
|
return
|
|
}
|
|
|
|
shell := q.Get("shell") // No need to validate. Will only be used if it's in the allow-list.
|
|
|
|
ctx := r.Context()
|
|
|
|
appRBACName := security.RBACName(s.namespace, project, appNamespace, app)
|
|
if err := s.terminalOptions.Enf.EnforceErr(ctx.Value("claims"), rbac.ResourceApplications, rbac.ActionGet, appRBACName); err != nil {
|
|
http.Error(w, err.Error(), http.StatusUnauthorized)
|
|
return
|
|
}
|
|
|
|
if err := s.terminalOptions.Enf.EnforceErr(ctx.Value("claims"), rbac.ResourceExec, rbac.ActionCreate, appRBACName); err != nil {
|
|
http.Error(w, err.Error(), http.StatusUnauthorized)
|
|
return
|
|
}
|
|
|
|
fieldLog := log.WithFields(log.Fields{
|
|
"application": app, "userName": util_session.Username(ctx), "container": container,
|
|
"podName": podName, "namespace": namespace, "project": project, "appNamespace": appNamespace,
|
|
})
|
|
|
|
a, err := s.appLister.Applications(ns).Get(app)
|
|
if err != nil {
|
|
if apierrors.IsNotFound(err) {
|
|
http.Error(w, "App not found", http.StatusNotFound)
|
|
return
|
|
}
|
|
fieldLog.Errorf("Error when getting app %q when launching a terminal: %s", app, err)
|
|
http.Error(w, "Cannot get app", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
if a.Spec.Project != project {
|
|
fieldLog.Warnf("The wrong project (%q) was specified for the app %q when launching a terminal", project, app)
|
|
http.Error(w, "The wrong project was specified for the app", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
config, err := s.getApplicationClusterRawConfig(ctx, a)
|
|
if err != nil {
|
|
http.Error(w, "Cannot get raw cluster config", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
kubeClientset, err := kubernetes.NewForConfig(config)
|
|
if err != nil {
|
|
http.Error(w, "Cannot initialize kubeclient", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
resourceTree, err := s.appResourceTreeFn(ctx, a)
|
|
if err != nil {
|
|
http.Error(w, err.Error(), http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
// From the tree find pods which match the given pod.
|
|
if !podExists(resourceTree.Nodes, podName, namespace) {
|
|
http.Error(w, "Pod doesn't belong to specified app", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
pod, err := kubeClientset.CoreV1().Pods(namespace).Get(ctx, podName, metav1.GetOptions{})
|
|
if err != nil {
|
|
fieldLog.Errorf("error retrieving pod: %s", err)
|
|
http.Error(w, "Cannot find pod", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
if !containerRunning(pod, container) {
|
|
fieldLog.Warn("terminal container not running")
|
|
http.Error(w, "container find running", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
fieldLog.Info("terminal session starting")
|
|
|
|
session, err := newTerminalSession(ctx, w, r, nil, s.sessionManager, appRBACName, s.terminalOptions)
|
|
if err != nil {
|
|
http.Error(w, "Failed to start terminal session", http.StatusBadRequest)
|
|
return
|
|
}
|
|
defer session.Done()
|
|
|
|
// send pings across the WebSocket channel at regular intervals to keep it alive through
|
|
// load balancers which may close an idle connection after some period of time
|
|
go session.StartKeepalives(time.Second * 5)
|
|
|
|
if slices.Contains(s.allowedShells, shell) {
|
|
cmd := []string{shell}
|
|
err = startProcess(ctx, kubeClientset, config, namespace, podName, container, cmd, session)
|
|
} else {
|
|
// No shell given or the given shell was not allowed: try the configured shells until one succeeds or all fail.
|
|
for _, testShell := range s.allowedShells {
|
|
cmd := []string{testShell}
|
|
if err = startProcess(ctx, kubeClientset, config, namespace, podName, container, cmd, session); err == nil {
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
if err != nil {
|
|
http.Error(w, "Failed to exec container", http.StatusBadRequest)
|
|
session.Close()
|
|
return
|
|
}
|
|
|
|
session.Close()
|
|
}
|
|
|
|
func podExists(treeNodes []appv1.ResourceNode, podName, namespace string) bool {
|
|
for _, treeNode := range treeNodes {
|
|
if treeNode.Kind == kube.PodKind && treeNode.Group == "" && treeNode.UID != "" &&
|
|
treeNode.Name == podName && treeNode.Namespace == namespace {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func containerRunning(pod *corev1.Pod, containerName string) bool {
|
|
return containerStatusRunning(pod.Status.ContainerStatuses, containerName) ||
|
|
containerStatusRunning(pod.Status.InitContainerStatuses, containerName)
|
|
}
|
|
|
|
func containerStatusRunning(statuses []corev1.ContainerStatus, containerName string) bool {
|
|
for i := range statuses {
|
|
if statuses[i].Name == containerName {
|
|
return statuses[i].State.Running != nil
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
const EndOfTransmission = "\u0004"
|
|
|
|
// PtyHandler is what remotecommand expects from a pty
|
|
type PtyHandler interface {
|
|
io.Reader
|
|
io.Writer
|
|
remotecommand.TerminalSizeQueue
|
|
}
|
|
|
|
// TerminalMessage is the struct for websocket message.
|
|
type TerminalMessage struct {
|
|
Operation string `json:"operation"`
|
|
Data string `json:"data"`
|
|
Rows uint16 `json:"rows"`
|
|
Cols uint16 `json:"cols"`
|
|
}
|
|
|
|
// TerminalCommand is the struct for websocket commands,For example you need ask client to reconnect
|
|
type TerminalCommand struct {
|
|
Code int
|
|
}
|
|
|
|
// startProcess executes specified commands in the container and connects it up with the ptyHandler (a session)
|
|
func startProcess(ctx context.Context, k8sClient kubernetes.Interface, cfg *rest.Config, namespace, podName, containerName string, cmd []string, ptyHandler PtyHandler) error {
|
|
req := k8sClient.CoreV1().RESTClient().Post().
|
|
Resource("pods").
|
|
Name(podName).
|
|
Namespace(namespace).
|
|
SubResource("exec")
|
|
|
|
req.VersionedParams(&corev1.PodExecOptions{
|
|
Container: containerName,
|
|
Command: cmd,
|
|
Stdin: true,
|
|
Stdout: true,
|
|
Stderr: true,
|
|
TTY: true,
|
|
}, scheme.ParameterCodec)
|
|
|
|
exec, err := remotecommand.NewSPDYExecutor(cfg, "POST", req.URL())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Fallback executor is default, unless feature flag is explicitly disabled.
|
|
// Reuse environment variable for kubectl to disable the feature flag, default is enabled.
|
|
if !cmdutil.RemoteCommandWebsockets.IsDisabled() {
|
|
// WebSocketExecutor must be "GET" method as described in RFC 6455 Sec. 4.1 (page 17).
|
|
websocketExec, err := remotecommand.NewWebSocketExecutor(cfg, "GET", req.URL().String())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
exec, err = remotecommand.NewFallbackExecutor(websocketExec, exec, httpstream.IsUpgradeFailure)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return exec.StreamWithContext(ctx, remotecommand.StreamOptions{
|
|
Stdin: ptyHandler,
|
|
Stdout: ptyHandler,
|
|
Stderr: ptyHandler,
|
|
TerminalSizeQueue: ptyHandler,
|
|
Tty: true,
|
|
})
|
|
}
|