mirror of
https://github.com/hanzoai/deploy.git
synced 2026-10-07 08:44:50 +00:00
* feat(api): hard-fork CRD API group argoproj.io -> deploy.hanzo.ai
Hanzo CD hard-fork, phase 1.1. Single source of truth is
pkg/apis/application/register.go's Group constant (Application/AppProject/
ApplicationSet all derive their FullName from it); every other Go call-site
that hardcoded the literal group string is updated to match: the 3 generated
informer GVRs, the app-of-apps nested-Application detector in types.go, the
resource-tree Application-kind cache populator, the 3 NotFound error
constructors in server/application, and the applicationset-controller's
leader-election Lease name/ID (kept in lockstep across Go source + RBAC
resourceNames, or leader election would get RBAC-denied on startup).
CRD YAMLs (application/appproject/applicationset) and every RBAC apiGroups
rule that actually governs our 3 CRDs are repointed to deploy.hanzo.ai, across
both manifests/base/* (namespaced Roles) and manifests/cluster-rbac/* (cluster
scope). Two adjacent things that share the "argoproj.io" string but are NOT
ours are deliberately left untouched: gitops-engine's health-check dispatch
for Argo Workflows' `Workflow` kind, and argocd-server-clusterrole's second
apiGroups block granting read on Argo Workflows' `workflows` resource — both
belong to a separate, unrelated Argoproj-family project we are not forking.
Also untouched, per explicit scope: annotation/label keys (argocd.argoproj.io/*)
and finalizers (*.argoproj.io) that track already-applied live resources, and
argocd-cm.yaml's resource.customizations.ignoreResourceUpdates keys (a narrow
app-of-apps diffing nicety, not build- or RBAC-relevant).
CGO_ENABLED=0 go build ./... verified green.
* ci: wire canonical hanzo.yml + cicd.yml (Hanzo CD image build)
Phase 1.3. Follows the same one-way pattern every hanzo/lux/zoo repo uses:
hanzo.yml declares the image (root Dockerfile -> ghcr.io/hanzoai/deploy) and a
fast go-build sanity test (the multi-stage Dockerfile build is the slow, real
gate); cicd.yml is the ~10-line trigger shim importing hanzoai/ci's reusable
build workflow on the arc pool, secrets from KMS only.
No `deploy:` block yet, matching the hanzoai/cms build-only-first-cutover
pattern: this repo's own live hanzo-cd namespace runs the whole Hanzo fleet's
GitOps, so the prod image/CRD swap is a deliberate separate action (see the
[HELD] universe PR), never an automatic rollout on merge. Every PR/push still
builds and pushes an immutable ghcr.io/hanzoai/deploy:sha-<7>-amd64 image.
* feat(ui): rebrand Argo CD -> Hanzo CD (title, favicon, logo, sidebar)
Phase 1.2. User-facing "Argo CD"/"ArgoCD" text replaced with "Hanzo CD"
across the login page, help modal, settings screens, version-info panel,
sync-options warning, fullscreen-logs title, app.tsx page titles, and
index.html's <title>/noscript text (dropped the now-wrong upstream CLI
doc link rather than invent a hanzo.ai URL that doesn't exist).
Logo/favicon assets replaced with the canonical Hanzo mark (never
hand-drawn, copied from ~/work/hanzo/logo/dist): the two real usages of
Argo's logo collapse onto one Hanzo glyph (mono + white variants) at the
same 5 call sites (login icon + footer, login.scss $logoPath/
$logoNegativePath, sidebar text-logo), preserving the existing CSS
invert() filters so both the light login panel and dark sidebar still
render correctly. Old argologo.svg/argo_o.svg/argo.png deleted (no
longer referenced). favicon-{16x16,32x32}.png added at
ui/src/assets/favicon/ (index.html's links to that path were previously
dead - the directory didn't exist in this checkout). package.json name
argo-cd-ui -> hanzo-cd-ui.
Left alone, deliberately: the two Kubernetes resource-kind icon sets
under ui/src/assets/images/resources/ (unrelated to branding), and
upstream doc/project links (argoproj.io, argo-cd.readthedocs.io) since
we have no equivalent hanzo.ai docs to point to yet - except the login
footer logo's outbound link, which now points to hanzo.ai instead of
argoproj.io (a Hanzo-branded mark linking to the upstream project it
was forked from read as an obvious leftover).
* feat(module): rename Go module github.com/argoproj/argo-cd/v3 -> github.com/hanzoai/deploy
Phase 2. No version suffix on the new path (org policy: never publish our
own Go modules above v1.x.x / with a v2+ suffix) — this fork starts a fresh
v0/v1 module identity rather than carrying the v3 the upstream fork point
had reached.
Mechanical, symmetric rewrite: 704 .go files (import statements only; two
disjoint substitutions applied specific-first so the nested gitops-engine
module path never double-matches), plus go.mod (module line, the
gitops-engine require+replace pair, version reset to v0.0.0-... since a
suffix-less path can't carry a v3 semver), gitops-engine/go.mod, Makefile
(ldflags PACKAGE + 2 TEST_MODULE filters), .golangci.yaml, .goreleaser.yaml,
.mockery.yaml (+ gitops-engine's), Procfile, the codegen/proto generation
scripts (hack/generate-proto.sh, update-codegen.sh, update-openapi.sh), and
20 .proto files' go_package options. Also one OpenTelemetry tracer name
string in gitops-engine/pkg/sync/sync_context.go (a cosmestic label, not an
import, but worth keeping consistent).
CGO_ENABLED=0 go build ./... verified green for both the root module and
the nested gitops-engine module; go vet clean on both; go mod tidy run
(network available) to reconcile go.sum, dependency set unchanged.
Left alone, deliberately: doc-only mentions (docs/snyk/*.html scan reports,
gitops-engine/README.md), a comment-only reference in
.github/workflows/release.yaml, and one Renovate bot config line — none are
build- or codegen-load-bearing. Also left alone: comments citing upstream
GitHub issue URLs (github.com/argoproj/argo-cd/issues/NNNNN) and a handful
of test fixtures using "https://github.com/argoproj/argo-cd.git" as a
representative example repo URL — both are accurate historical/test-data
references, not stale self-references.
---------
Co-authored-by: Hanzo Dev <[email protected]>
163 lines
5.1 KiB
Go
163 lines
5.1 KiB
Go
package rbacpolicy
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"github.com/golang-jwt/jwt/v5"
|
|
log "github.com/sirupsen/logrus"
|
|
|
|
"github.com/hanzoai/deploy/pkg/apis/application/v1alpha1"
|
|
applister "github.com/hanzoai/deploy/pkg/client/listers/application/v1alpha1"
|
|
jwtutil "github.com/hanzoai/deploy/util/jwt"
|
|
"github.com/hanzoai/deploy/util/rbac"
|
|
)
|
|
|
|
// RBACPolicyEnforcer provides an RBAC Claims Enforcer which additionally consults AppProject
|
|
// roles, jwt tokens, and groups. It is backed by a AppProject informer/lister cache and does not
|
|
// make any API calls during enforcement.
|
|
type RBACPolicyEnforcer struct {
|
|
enf *rbac.Enforcer
|
|
projLister applister.AppProjectNamespaceLister
|
|
scopes []string
|
|
}
|
|
|
|
// NewRBACPolicyEnforcer returns a new RBAC Enforcer for the Argo CD API Server
|
|
func NewRBACPolicyEnforcer(enf *rbac.Enforcer, projLister applister.AppProjectNamespaceLister) *RBACPolicyEnforcer {
|
|
return &RBACPolicyEnforcer{
|
|
enf: enf,
|
|
projLister: projLister,
|
|
scopes: nil,
|
|
}
|
|
}
|
|
|
|
func (p *RBACPolicyEnforcer) SetScopes(scopes []string) {
|
|
p.scopes = scopes
|
|
}
|
|
|
|
func (p *RBACPolicyEnforcer) GetScopes() []string {
|
|
scopes := p.scopes
|
|
if scopes == nil {
|
|
scopes = rbac.DefaultScopes
|
|
}
|
|
return scopes
|
|
}
|
|
|
|
func IsProjectSubject(subject string) bool {
|
|
_, _, ok := GetProjectRoleFromSubject(subject)
|
|
return ok
|
|
}
|
|
|
|
func GetProjectRoleFromSubject(subject string) (string, string, bool) {
|
|
parts := strings.Split(subject, ":")
|
|
if len(parts) == 3 && parts[0] == "proj" {
|
|
return parts[1], parts[2], true
|
|
}
|
|
return "", "", false
|
|
}
|
|
|
|
// EnforceClaims is an RBAC claims enforcer specific to the Argo CD API server
|
|
func (p *RBACPolicyEnforcer) EnforceClaims(claims jwt.Claims, rvals ...any) bool {
|
|
mapClaims, err := jwtutil.MapClaims(claims)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
|
|
subject := jwtutil.GetUserIdentifier(mapClaims)
|
|
// Check if the request is for an application resource. We have special enforcement which takes
|
|
// into consideration the project's token and group bindings
|
|
var runtimePolicy string
|
|
var projName string
|
|
proj := p.getProjectFromRequest(rvals...)
|
|
if proj != nil {
|
|
if IsProjectSubject(subject) {
|
|
return p.enforceProjectToken(subject, proj, rvals...)
|
|
}
|
|
runtimePolicy = proj.ProjectPoliciesString()
|
|
projName = proj.Name
|
|
}
|
|
|
|
// NOTE: This calls prevent multiple creation of the wrapped enforcer
|
|
enforcer := p.enf.CreateEnforcerWithRuntimePolicy(projName, runtimePolicy)
|
|
|
|
// Check the subject. This is typically the 'admin' case.
|
|
// NOTE: the call to EnforceWithCustomEnforcer will also consider the default role
|
|
vals := append([]any{subject}, rvals[1:]...)
|
|
if p.enf.EnforceWithCustomEnforcer(enforcer, vals...) {
|
|
return true
|
|
}
|
|
|
|
scopes := p.scopes
|
|
if scopes == nil {
|
|
scopes = rbac.DefaultScopes
|
|
}
|
|
// Finally check if any of the user's groups grant them permissions
|
|
groups := jwtutil.GetScopeValues(mapClaims, scopes)
|
|
|
|
// Get groups to reduce the amount to checking groups
|
|
groupingPolicies, err := enforcer.GetGroupingPolicy()
|
|
if err != nil {
|
|
log.WithError(err).Error("failed to get grouping policy")
|
|
return false
|
|
}
|
|
for gidx := range groups {
|
|
for gpidx := range groupingPolicies {
|
|
// Prefilter user groups by groups defined in the model
|
|
if groupingPolicies[gpidx][0] == groups[gidx] {
|
|
vals := append([]any{groups[gidx]}, rvals[1:]...)
|
|
if p.enf.EnforceWithCustomEnforcer(enforcer, vals...) {
|
|
return true
|
|
}
|
|
break
|
|
}
|
|
}
|
|
}
|
|
logCtx := log.WithFields(log.Fields{"claims": claims, "rval": rvals, "subject": subject, "groups": groups, "project": projName, "scopes": scopes})
|
|
logCtx.Debug("enforce failed")
|
|
return false
|
|
}
|
|
|
|
// getProjectFromRequest parses the project name from the RBAC request and returns the associated
|
|
// project (if it exists)
|
|
func (p *RBACPolicyEnforcer) getProjectFromRequest(rvals ...any) *v1alpha1.AppProject {
|
|
if len(rvals) != 4 {
|
|
return nil
|
|
}
|
|
getProjectByName := func(projName string) *v1alpha1.AppProject {
|
|
proj, err := p.projLister.Get(projName)
|
|
if err != nil {
|
|
return nil
|
|
}
|
|
return proj
|
|
}
|
|
if res, ok := rvals[1].(string); ok {
|
|
if obj, ok := rvals[3].(string); ok {
|
|
switch res {
|
|
case rbac.ResourceApplicationSets, rbac.ResourceApplications, rbac.ResourceRepositories, rbac.ResourceClusters, rbac.ResourceLogs, rbac.ResourceExec:
|
|
if objSplit := strings.Split(obj, "/"); len(objSplit) >= 2 {
|
|
return getProjectByName(objSplit[0])
|
|
}
|
|
case rbac.ResourceProjects:
|
|
// we also automatically give project tokens and groups 'get' access to the project
|
|
return getProjectByName(obj)
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// enforceProjectToken will check to see the valid token has not yet been revoked in the project
|
|
func (p *RBACPolicyEnforcer) enforceProjectToken(subject string, proj *v1alpha1.AppProject, rvals ...any) bool {
|
|
subjectSplit := strings.Split(subject, ":")
|
|
if len(subjectSplit) != 3 {
|
|
return false
|
|
}
|
|
projName, _ := subjectSplit[1], subjectSplit[2]
|
|
if projName != proj.Name {
|
|
// this should never happen (we generated a project token for a different project)
|
|
return false
|
|
}
|
|
|
|
vals := append([]any{subject}, rvals[1:]...)
|
|
return p.enf.EnforceRuntimePolicy(proj.Name, proj.ProjectPoliciesString(), vals...)
|
|
}
|