Files
deploy/test/e2e/app_management_source_integrity_test.go
41536738c8 refactor(cd): hard-fork - rename CRD API group argoproj.io -> deploy.hanzo.ai (#1)
* feat(api): hard-fork CRD API group argoproj.io -> deploy.hanzo.ai

Hanzo CD hard-fork, phase 1.1. Single source of truth is
pkg/apis/application/register.go's Group constant (Application/AppProject/
ApplicationSet all derive their FullName from it); every other Go call-site
that hardcoded the literal group string is updated to match: the 3 generated
informer GVRs, the app-of-apps nested-Application detector in types.go, the
resource-tree Application-kind cache populator, the 3 NotFound error
constructors in server/application, and the applicationset-controller's
leader-election Lease name/ID (kept in lockstep across Go source + RBAC
resourceNames, or leader election would get RBAC-denied on startup).

CRD YAMLs (application/appproject/applicationset) and every RBAC apiGroups
rule that actually governs our 3 CRDs are repointed to deploy.hanzo.ai, across
both manifests/base/* (namespaced Roles) and manifests/cluster-rbac/* (cluster
scope). Two adjacent things that share the "argoproj.io" string but are NOT
ours are deliberately left untouched: gitops-engine's health-check dispatch
for Argo Workflows' `Workflow` kind, and argocd-server-clusterrole's second
apiGroups block granting read on Argo Workflows' `workflows` resource — both
belong to a separate, unrelated Argoproj-family project we are not forking.

Also untouched, per explicit scope: annotation/label keys (argocd.argoproj.io/*)
and finalizers (*.argoproj.io) that track already-applied live resources, and
argocd-cm.yaml's resource.customizations.ignoreResourceUpdates keys (a narrow
app-of-apps diffing nicety, not build- or RBAC-relevant).

CGO_ENABLED=0 go build ./... verified green.

* ci: wire canonical hanzo.yml + cicd.yml (Hanzo CD image build)

Phase 1.3. Follows the same one-way pattern every hanzo/lux/zoo repo uses:
hanzo.yml declares the image (root Dockerfile -> ghcr.io/hanzoai/deploy) and a
fast go-build sanity test (the multi-stage Dockerfile build is the slow, real
gate); cicd.yml is the ~10-line trigger shim importing hanzoai/ci's reusable
build workflow on the arc pool, secrets from KMS only.

No `deploy:` block yet, matching the hanzoai/cms build-only-first-cutover
pattern: this repo's own live hanzo-cd namespace runs the whole Hanzo fleet's
GitOps, so the prod image/CRD swap is a deliberate separate action (see the
[HELD] universe PR), never an automatic rollout on merge. Every PR/push still
builds and pushes an immutable ghcr.io/hanzoai/deploy:sha-<7>-amd64 image.

* feat(ui): rebrand Argo CD -> Hanzo CD (title, favicon, logo, sidebar)

Phase 1.2. User-facing "Argo CD"/"ArgoCD" text replaced with "Hanzo CD"
across the login page, help modal, settings screens, version-info panel,
sync-options warning, fullscreen-logs title, app.tsx page titles, and
index.html's <title>/noscript text (dropped the now-wrong upstream CLI
doc link rather than invent a hanzo.ai URL that doesn't exist).

Logo/favicon assets replaced with the canonical Hanzo mark (never
hand-drawn, copied from ~/work/hanzo/logo/dist): the two real usages of
Argo's logo collapse onto one Hanzo glyph (mono + white variants) at the
same 5 call sites (login icon + footer, login.scss $logoPath/
$logoNegativePath, sidebar text-logo), preserving the existing CSS
invert() filters so both the light login panel and dark sidebar still
render correctly. Old argologo.svg/argo_o.svg/argo.png deleted (no
longer referenced). favicon-{16x16,32x32}.png added at
ui/src/assets/favicon/ (index.html's links to that path were previously
dead - the directory didn't exist in this checkout). package.json name
argo-cd-ui -> hanzo-cd-ui.

Left alone, deliberately: the two Kubernetes resource-kind icon sets
under ui/src/assets/images/resources/ (unrelated to branding), and
upstream doc/project links (argoproj.io, argo-cd.readthedocs.io) since
we have no equivalent hanzo.ai docs to point to yet - except the login
footer logo's outbound link, which now points to hanzo.ai instead of
argoproj.io (a Hanzo-branded mark linking to the upstream project it
was forked from read as an obvious leftover).

* feat(module): rename Go module github.com/argoproj/argo-cd/v3 -> github.com/hanzoai/deploy

Phase 2. No version suffix on the new path (org policy: never publish our
own Go modules above v1.x.x / with a v2+ suffix) — this fork starts a fresh
v0/v1 module identity rather than carrying the v3 the upstream fork point
had reached.

Mechanical, symmetric rewrite: 704 .go files (import statements only; two
disjoint substitutions applied specific-first so the nested gitops-engine
module path never double-matches), plus go.mod (module line, the
gitops-engine require+replace pair, version reset to v0.0.0-... since a
suffix-less path can't carry a v3 semver), gitops-engine/go.mod, Makefile
(ldflags PACKAGE + 2 TEST_MODULE filters), .golangci.yaml, .goreleaser.yaml,
.mockery.yaml (+ gitops-engine's), Procfile, the codegen/proto generation
scripts (hack/generate-proto.sh, update-codegen.sh, update-openapi.sh), and
20 .proto files' go_package options. Also one OpenTelemetry tracer name
string in gitops-engine/pkg/sync/sync_context.go (a cosmestic label, not an
import, but worth keeping consistent).

CGO_ENABLED=0 go build ./... verified green for both the root module and
the nested gitops-engine module; go vet clean on both; go mod tidy run
(network available) to reconcile go.sum, dependency set unchanged.

Left alone, deliberately: doc-only mentions (docs/snyk/*.html scan reports,
gitops-engine/README.md), a comment-only reference in
.github/workflows/release.yaml, and one Renovate bot config line — none are
build- or codegen-load-bearing. Also left alone: comments citing upstream
GitHub issue URLs (github.com/argoproj/argo-cd/issues/NNNNN) and a handful
of test fixtures using "https://github.com/argoproj/argo-cd.git" as a
representative example repo URL — both are accurate historical/test-data
references, not stale self-references.

---------

Co-authored-by: Hanzo Dev <[email protected]>
2026-07-29 18:27:58 -07:00

458 lines
13 KiB
Go

package e2e
import (
"testing"
"github.com/hanzoai/deploy/gitops-engine/pkg/health"
. "github.com/hanzoai/deploy/gitops-engine/pkg/sync/common"
"github.com/stretchr/testify/assert"
. "github.com/hanzoai/deploy/pkg/apis/application/v1alpha1"
"github.com/hanzoai/deploy/test/e2e/fixture"
. "github.com/hanzoai/deploy/test/e2e/fixture/app"
)
var projectWithNoKeys = AppProjectSpec{
SourceRepos: []string{"*"},
Destinations: []ApplicationDestination{{Namespace: "*", Server: "*"}},
SourceIntegrity: &SourceIntegrity{
Git: &SourceIntegrityGit{
Policies: []*SourceIntegrityGitPolicy{{
Repos: []SourceIntegrityGitPolicyRepo{{URL: "*"}},
GPG: &SourceIntegrityGitPolicyGPG{
Keys: []string{}, // Verifying but permitting no keys
Mode: "head",
},
}},
},
},
}
func TestSyncToUnsignedCommit(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Path(guestbookPath).
When().
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(SyncStatusIs(SyncStatusCodeOutOfSync)).
Expect(HealthIs(health.HealthStatusMissing)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision")).
Expect(Condition(ApplicationConditionComparisonError, " unsigned (key_id=)"))
}
func TestSyncToSignedCommitWithoutKnownKey(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Path(guestbookPath).
When().
AddSignedFile("test.yaml", "null").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(SyncStatusIs(SyncStatusCodeOutOfSync)).
Expect(HealthIs(health.HealthStatusMissing)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision")).
Expect(Condition(ApplicationConditionComparisonError, "signed with key not in keyring (key_id="+fixture.GpgGoodKeyID+")"))
}
func TestSyncToSignedCommitWithKnownKey(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
AddSignedFile("test.yaml", "null").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationSucceeded)).
Expect(SyncStatusIs(SyncStatusCodeSynced)).
Expect(HealthIs(health.HealthStatusHealthy)).
Expect(NoConditions())
}
func TestSyncToSignedCommitWithUnallowedKey(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
ProjectSpec(projectWithNoKeys).
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
AddSignedFile("test.yaml", "null").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(SyncStatusIs(SyncStatusCodeOutOfSync)).
Expect(HealthIs(health.HealthStatusMissing)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision")).
Expect(Condition(ApplicationConditionComparisonError, "signed with unallowed key (key_id="+fixture.GpgGoodKeyID+")"))
}
func TestSyncToSignedBranchWithKnownKey(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Path(guestbookPath).
Revision("master").
GPGPublicKeyAdded().
Sleep(2).
When().
AddSignedFile("test.yaml", "null").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationSucceeded)).
Expect(SyncStatusIs(SyncStatusCodeSynced)).
Expect(HealthIs(health.HealthStatusHealthy)).
Expect(NoConditions())
}
func TestSyncToSignedBranchWithUnknownKey(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Path(guestbookPath).
Revision("master").
Sleep(2).
When().
AddSignedFile("test.yaml", "null").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(SyncStatusIs(SyncStatusCodeOutOfSync)).
Expect(HealthIs(health.HealthStatusMissing)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision")).
Expect(Condition(ApplicationConditionComparisonError, "signed with key not in keyring (key_id="+fixture.GpgGoodKeyID+")"))
}
func TestSyncToUnsignedBranch(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Revision("master").
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
AddFile("test.yaml", "TestSyncToUnsignedBranch").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(SyncStatusIs(SyncStatusCodeOutOfSync)).
Expect(HealthIs(health.HealthStatusMissing)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision")).
Expect(Condition(ApplicationConditionComparisonError, "unsigned (key_id=)"))
}
func TestSyncToSignedTagWithKnownKey(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Revision("signed-tag").
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
AddSignedTag("signed-tag").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationSucceeded)).
Expect(SyncStatusIs(SyncStatusCodeSynced)).
Expect(HealthIs(health.HealthStatusHealthy)).
Expect(NoConditions())
}
func TestSyncToSignedTagWithUnknownKey(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Revision("signed-tag").
Path(guestbookPath).
Sleep(2).
When().
AddSignedTag("signed-tag").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(SyncStatusIs(SyncStatusCodeOutOfSync)).
Expect(HealthIs(health.HealthStatusMissing)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision signed-tag by ")).
Expect(Condition(ApplicationConditionComparisonError, "signed with key not in keyring (key_id="+fixture.GpgGoodKeyID+")"))
}
func TestSyncToUnsignedAnnotatedTag(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Revision("unsigned-tag").
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
// Signed commit with an unsigned annotated tag will validate the tag signature
AddSignedFile("test.yaml", "null").
AddAnnotatedTag("unsigned-tag", "message goes here").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(SyncStatusIs(SyncStatusCodeOutOfSync)).
Expect(HealthIs(health.HealthStatusMissing)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision unsigned-tag by ")).
Expect(Condition(ApplicationConditionComparisonError, "unsigned (key_id=)"))
}
func TestSyncToUnsignedSimpleTag(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Revision("unsigned-simple-tag").
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
// Signed commit with an unsigned not-annotated tag will validate the commit, not the tag
AddSignedFile("test.yaml", "null").
AddTag("unsigned-simple-tag").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationSucceeded)).
Expect(SyncStatusIs(SyncStatusCodeSynced)).
Expect(HealthIs(health.HealthStatusHealthy)).
Expect(NoConditions())
}
func TestSyncToSignedAnnotatedTagWithUnallowedKey(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
ProjectSpec(projectWithNoKeys).
Revision("v1.0").
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
AddFile("test.yaml", "null").
AddSignedTag("v1.0").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(SyncStatusIs(SyncStatusCodeOutOfSync)).
Expect(HealthIs(health.HealthStatusMissing)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision v1.0")).
Expect(Condition(ApplicationConditionComparisonError, "signed with unallowed key (key_id="+fixture.GpgGoodKeyID+")"))
}
func TestSyncToTagBasedConstraint(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Revision("1.*").
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
AddSignedFile("test.yaml", "null").
AddSignedTag("1.0").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationSucceeded)).
Expect(SyncStatusIs(SyncStatusCodeSynced)).
Expect(HealthIs(health.HealthStatusHealthy)).
Expect(NoConditions())
}
func TestNamespacedSyncToUnsignedCommit(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
GivenWithNamespace(t, fixture.AppNamespace()).
SetTrackingMethod("annotation").
Project("gpg").
Path(guestbookPath).
When().
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(SyncStatusIs(SyncStatusCodeOutOfSync)).
Expect(HealthIs(health.HealthStatusMissing)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision ")).
Expect(Condition(ApplicationConditionComparisonError, "unsigned (key_id=)"))
}
func TestNamespacedSyncToSignedCommitWithUnknownKey(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
SetAppNamespace(fixture.AppNamespace()).
SetTrackingMethod("annotation").
Project("gpg").
Path(guestbookPath).
When().
AddSignedFile("test.yaml", "null").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(SyncStatusIs(SyncStatusCodeOutOfSync)).
Expect(HealthIs(health.HealthStatusMissing)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision ")).
Expect(Condition(ApplicationConditionComparisonError, "signed with key not in keyring (key_id="+fixture.GpgGoodKeyID+")"))
}
func TestNamespacedSyncToSignedCommit(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
SetAppNamespace(fixture.AppNamespace()).
SetTrackingMethod("annotation").
Project("gpg").
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
AddSignedFile("test.yaml", "null").
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationSucceeded)).
Expect(SyncStatusIs(SyncStatusCodeSynced)).
Expect(HealthIs(health.HealthStatusHealthy)).
Expect(NoConditions())
}
func TestLocalManifestRejectedWithSourceIntegrity(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
AddSignedFile("test.yaml", "null").
CreateApp().
Sync().
Then().
And(func(app *Application) {
res, _ := fixture.RunCli("app", "manifests", app.Name)
assert.Contains(t, res, "containerPort: 80")
assert.Contains(t, res, "image: quay.io/argoprojlabs/argocd-e2e-container:0.2")
}).
Given().
LocalPath(guestbookPathLocal).
When().
IgnoreErrors().
Sync("--local-repo-root", ".").
Then().
Expect(ErrorRegex("", "Cannot use local manifests when source integrity is enforced"))
}
func TestOCISourceIgnoredWithSourceIntegrity(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
// No keys in keyring, no keys in project, OCI is not git, yet source integrity is defined.
// Expecting some of that would cause visible failure if the source integrity should be applied
Given(t).
Project("gpg").
ProjectSpec(appProjectWithSourceIntegrity()).
HTTPSInsecureRepoURLWithClientCertAdded().
PushImageToOCIRegistry("testdata/guestbook", "1.0.0").
OCIRepoAdded("my-oci-repo", "guestbook").
OCIRegistry(fixture.OCIHostURL).
OCIRegistryPath("guestbook").
RepoURLType(fixture.RepoURLTypeOCI).
Revision("1.0.0").
Path(".").
When().
IgnoreErrors().
CreateApp().
Sync().
Then().
Expect(OperationPhaseIs(OperationSucceeded)).
Expect(HealthIs(health.HealthStatusHealthy)).
Expect(SyncStatusIs(SyncStatusCodeSynced)).
// Verify local manifests are permitted - source integrity criteria for git should not apply for oci
Given().
LocalPath(guestbookPathLocal).
When().
DoNotIgnoreErrors().
Sync("--local-repo-root", ".", "--force", "--prune")
}
func TestArtifactCacheInvalidatedOnSourceIntegrityChange(t *testing.T) {
fixture.SkipOnEnv(t, "GPG")
fixture.EnsureCleanState(t)
Given(t).
Project("gpg").
Path(guestbookPath).
GPGPublicKeyAdded().
Sleep(2).
When().
AddSignedFile("test.yaml", "null").
CreateApp().
IgnoreErrors().
Sync().
Then().
Expect(OperationPhaseIs(OperationSucceeded)).
Expect(SyncStatusIs(SyncStatusCodeSynced)).
Expect(HealthIs(health.HealthStatusHealthy)).
Expect(NoConditions()).
Given().
// Should start failing when the project does not bless they key anymore
ProjectSpec(appProjectWithSourceIntegrity()).
When().
IgnoreErrors().
Sync().
Then().
Expect(OperationPhaseIs(OperationError)).
Expect(Condition(ApplicationConditionComparisonError, "GIT/GPG: Failed verifying revision")).
Expect(Condition(ApplicationConditionComparisonError, "signed with unallowed key (key_id="+fixture.GpgGoodKeyID+")"))
}