Files
deploy/util/argo/resource_tracking.go
41536738c8 refactor(cd): hard-fork - rename CRD API group argoproj.io -> deploy.hanzo.ai (#1)
* feat(api): hard-fork CRD API group argoproj.io -> deploy.hanzo.ai

Hanzo CD hard-fork, phase 1.1. Single source of truth is
pkg/apis/application/register.go's Group constant (Application/AppProject/
ApplicationSet all derive their FullName from it); every other Go call-site
that hardcoded the literal group string is updated to match: the 3 generated
informer GVRs, the app-of-apps nested-Application detector in types.go, the
resource-tree Application-kind cache populator, the 3 NotFound error
constructors in server/application, and the applicationset-controller's
leader-election Lease name/ID (kept in lockstep across Go source + RBAC
resourceNames, or leader election would get RBAC-denied on startup).

CRD YAMLs (application/appproject/applicationset) and every RBAC apiGroups
rule that actually governs our 3 CRDs are repointed to deploy.hanzo.ai, across
both manifests/base/* (namespaced Roles) and manifests/cluster-rbac/* (cluster
scope). Two adjacent things that share the "argoproj.io" string but are NOT
ours are deliberately left untouched: gitops-engine's health-check dispatch
for Argo Workflows' `Workflow` kind, and argocd-server-clusterrole's second
apiGroups block granting read on Argo Workflows' `workflows` resource — both
belong to a separate, unrelated Argoproj-family project we are not forking.

Also untouched, per explicit scope: annotation/label keys (argocd.argoproj.io/*)
and finalizers (*.argoproj.io) that track already-applied live resources, and
argocd-cm.yaml's resource.customizations.ignoreResourceUpdates keys (a narrow
app-of-apps diffing nicety, not build- or RBAC-relevant).

CGO_ENABLED=0 go build ./... verified green.

* ci: wire canonical hanzo.yml + cicd.yml (Hanzo CD image build)

Phase 1.3. Follows the same one-way pattern every hanzo/lux/zoo repo uses:
hanzo.yml declares the image (root Dockerfile -> ghcr.io/hanzoai/deploy) and a
fast go-build sanity test (the multi-stage Dockerfile build is the slow, real
gate); cicd.yml is the ~10-line trigger shim importing hanzoai/ci's reusable
build workflow on the arc pool, secrets from KMS only.

No `deploy:` block yet, matching the hanzoai/cms build-only-first-cutover
pattern: this repo's own live hanzo-cd namespace runs the whole Hanzo fleet's
GitOps, so the prod image/CRD swap is a deliberate separate action (see the
[HELD] universe PR), never an automatic rollout on merge. Every PR/push still
builds and pushes an immutable ghcr.io/hanzoai/deploy:sha-<7>-amd64 image.

* feat(ui): rebrand Argo CD -> Hanzo CD (title, favicon, logo, sidebar)

Phase 1.2. User-facing "Argo CD"/"ArgoCD" text replaced with "Hanzo CD"
across the login page, help modal, settings screens, version-info panel,
sync-options warning, fullscreen-logs title, app.tsx page titles, and
index.html's <title>/noscript text (dropped the now-wrong upstream CLI
doc link rather than invent a hanzo.ai URL that doesn't exist).

Logo/favicon assets replaced with the canonical Hanzo mark (never
hand-drawn, copied from ~/work/hanzo/logo/dist): the two real usages of
Argo's logo collapse onto one Hanzo glyph (mono + white variants) at the
same 5 call sites (login icon + footer, login.scss $logoPath/
$logoNegativePath, sidebar text-logo), preserving the existing CSS
invert() filters so both the light login panel and dark sidebar still
render correctly. Old argologo.svg/argo_o.svg/argo.png deleted (no
longer referenced). favicon-{16x16,32x32}.png added at
ui/src/assets/favicon/ (index.html's links to that path were previously
dead - the directory didn't exist in this checkout). package.json name
argo-cd-ui -> hanzo-cd-ui.

Left alone, deliberately: the two Kubernetes resource-kind icon sets
under ui/src/assets/images/resources/ (unrelated to branding), and
upstream doc/project links (argoproj.io, argo-cd.readthedocs.io) since
we have no equivalent hanzo.ai docs to point to yet - except the login
footer logo's outbound link, which now points to hanzo.ai instead of
argoproj.io (a Hanzo-branded mark linking to the upstream project it
was forked from read as an obvious leftover).

* feat(module): rename Go module github.com/argoproj/argo-cd/v3 -> github.com/hanzoai/deploy

Phase 2. No version suffix on the new path (org policy: never publish our
own Go modules above v1.x.x / with a v2+ suffix) — this fork starts a fresh
v0/v1 module identity rather than carrying the v3 the upstream fork point
had reached.

Mechanical, symmetric rewrite: 704 .go files (import statements only; two
disjoint substitutions applied specific-first so the nested gitops-engine
module path never double-matches), plus go.mod (module line, the
gitops-engine require+replace pair, version reset to v0.0.0-... since a
suffix-less path can't carry a v3 semver), gitops-engine/go.mod, Makefile
(ldflags PACKAGE + 2 TEST_MODULE filters), .golangci.yaml, .goreleaser.yaml,
.mockery.yaml (+ gitops-engine's), Procfile, the codegen/proto generation
scripts (hack/generate-proto.sh, update-codegen.sh, update-openapi.sh), and
20 .proto files' go_package options. Also one OpenTelemetry tracer name
string in gitops-engine/pkg/sync/sync_context.go (a cosmestic label, not an
import, but worth keeping consistent).

CGO_ENABLED=0 go build ./... verified green for both the root module and
the nested gitops-engine module; go vet clean on both; go mod tidy run
(network available) to reconcile go.sum, dependency set unchanged.

Left alone, deliberately: doc-only mentions (docs/snyk/*.html scan reports,
gitops-engine/README.md), a comment-only reference in
.github/workflows/release.yaml, and one Renovate bot config line — none are
build- or codegen-load-bearing. Also left alone: comments citing upstream
GitHub issue URLs (github.com/argoproj/argo-cd/issues/NNNNN) and a handful
of test fixtures using "https://github.com/argoproj/argo-cd.git" as a
representative example repo URL — both are accurate historical/test-data
references, not stale self-references.

---------

Co-authored-by: Hanzo Dev <[email protected]>
2026-07-29 18:27:58 -07:00

306 lines
10 KiB
Go

package argo
import (
"errors"
"fmt"
"regexp"
"strings"
kubeutil "github.com/hanzoai/deploy/gitops-engine/pkg/utils/kube"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"github.com/hanzoai/deploy/common"
"github.com/hanzoai/deploy/pkg/apis/application/v1alpha1"
"github.com/hanzoai/deploy/util/kube"
)
var (
ErrWrongResourceTrackingFormat = errors.New("wrong resource tracking format, should be <application-name>:<group>/<kind>:<namespace>/<name>")
LabelMaxLength = 63
OkEndPattern = regexp.MustCompile("[a-zA-Z0-9]$")
)
// ResourceTracking defines methods which allow setup and retrieve tracking information to resource
type ResourceTracking interface {
GetAppName(un *unstructured.Unstructured, key string, trackingMethod v1alpha1.TrackingMethod, installationID string) string
GetAppInstance(un *unstructured.Unstructured, trackingMethod v1alpha1.TrackingMethod, installationID string) *AppInstanceValue
SetAppInstance(un *unstructured.Unstructured, key, val, namespace string, trackingMethod v1alpha1.TrackingMethod, instanceID string) error
BuildAppInstanceValue(value AppInstanceValue) string
ParseAppInstanceValue(value string) (*AppInstanceValue, error)
Normalize(config, live *unstructured.Unstructured, labelKey, trackingMethod string) error
RemoveAppInstance(un *unstructured.Unstructured, trackingMethod string) error
}
// AppInstanceValue store information about resource tracking info
type AppInstanceValue struct {
ApplicationName string
Group string
Kind string
Namespace string
Name string
}
type resourceTracking struct{}
func NewResourceTracking() ResourceTracking {
return &resourceTracking{}
}
func IsOldTrackingMethod(trackingMethod string) bool {
return trackingMethod == "" || trackingMethod == string(v1alpha1.TrackingMethodLabel)
}
func (rt *resourceTracking) getAppInstanceValue(un *unstructured.Unstructured, installationID string) *AppInstanceValue {
if installationID != "" && un.GetAnnotations() == nil || un.GetAnnotations()[common.AnnotationInstallationID] != installationID {
return nil
}
appInstanceAnnotation, err := kube.GetAppInstanceAnnotation(un, common.AnnotationKeyAppInstance)
if err != nil {
return nil
}
value, err := rt.ParseAppInstanceValue(appInstanceAnnotation)
if err != nil {
return nil
}
return value
}
// GetAppName retrieve application name base on tracking method
func (rt *resourceTracking) GetAppName(un *unstructured.Unstructured, key string, trackingMethod v1alpha1.TrackingMethod, instanceID string) string {
retrieveAppInstanceValue := func() string {
value := rt.getAppInstanceValue(un, instanceID)
if value != nil {
return value.ApplicationName
}
return ""
}
switch trackingMethod {
case v1alpha1.TrackingMethodLabel:
label, err := kube.GetAppInstanceLabel(un, key)
if err != nil {
return ""
}
return label
case v1alpha1.TrackingMethodAnnotationAndLabel:
return retrieveAppInstanceValue()
case v1alpha1.TrackingMethodAnnotation:
return retrieveAppInstanceValue()
default:
return retrieveAppInstanceValue()
}
}
// GetAppInstance returns the representation of the app instance annotation.
// If the tracking method does not support metadata, or the annotation could
// not be parsed, it returns nil.
func (rt *resourceTracking) GetAppInstance(un *unstructured.Unstructured, trackingMethod v1alpha1.TrackingMethod, instanceID string) *AppInstanceValue {
switch trackingMethod {
case v1alpha1.TrackingMethodAnnotation, v1alpha1.TrackingMethodAnnotationAndLabel:
return rt.getAppInstanceValue(un, instanceID)
default:
return nil
}
}
// UnstructuredToAppInstanceValue will build the AppInstanceValue based
// on the provided unstructured. The given namespace works as a default
// value if the resource's namespace is not defined. It should be the
// Application's target destination namespace.
func UnstructuredToAppInstanceValue(un *unstructured.Unstructured, appName, namespace string) AppInstanceValue {
ns := un.GetNamespace()
if ns == "" {
ns = namespace
}
gvk := un.GetObjectKind().GroupVersionKind()
return AppInstanceValue{
ApplicationName: appName,
Group: gvk.Group,
Kind: gvk.Kind,
Namespace: ns,
Name: un.GetName(),
}
}
// TruncateLabel truncates the given value to a length that fits within the
// Kubernetes label value limit (63 characters). When truncation is required,
// any trailing special characters are stripped so the result remains a valid
// label value. Inputs that are already within the limit are returned as-is
// without trailing-character validation; callers that need a fully validated
// label should validate separately.
// See https://github.com/argoproj/argo-cd/issues/18237.
func TruncateLabel(val string) (string, error) {
if len(val) <= LabelMaxLength {
return val, nil
}
val = val[:LabelMaxLength]
for !OkEndPattern.MatchString(val) {
if len(val) <= 1 {
return "", errors.New("unable to truncate label to not end with a special character")
}
val = val[:len(val)-1]
}
return val, nil
}
// SetAppInstance set label/annotation base on tracking method
func (rt *resourceTracking) SetAppInstance(un *unstructured.Unstructured, key, val, namespace string, trackingMethod v1alpha1.TrackingMethod, instanceID string) error {
setAppInstanceAnnotation := func() error {
appInstanceValue := UnstructuredToAppInstanceValue(un, val, namespace)
if instanceID != "" {
if err := kube.SetAppInstanceAnnotation(un, common.AnnotationInstallationID, instanceID); err != nil {
return err
}
} else {
if err := kube.RemoveAnnotation(un, common.AnnotationInstallationID); err != nil {
return err
}
}
return kube.SetAppInstanceAnnotation(un, common.AnnotationKeyAppInstance, rt.BuildAppInstanceValue(appInstanceValue))
}
setAppInstanceLabel := func(val string) error {
labelVal, err := TruncateLabel(val)
if err != nil {
return fmt.Errorf("failed to set app instance label: %w", err)
}
if err := kube.SetAppInstanceLabel(un, key, labelVal); err != nil {
return fmt.Errorf("failed to set app instance label: %w", err)
}
return nil
}
switch trackingMethod {
case v1alpha1.TrackingMethodLabel:
// Label-only tracking uses the label value as the app name (see GetAppName),
// so truncating it here would break resource-to-app matching when the app
// name exceeds the label limit. Keep the value as-is and let Kubernetes
// surface the validation error to the user.
if err := kube.SetAppInstanceLabel(un, key, val); err != nil {
return fmt.Errorf("failed to set app instance label: %w", err)
}
return nil
case v1alpha1.TrackingMethodAnnotation:
return setAppInstanceAnnotation()
case v1alpha1.TrackingMethodAnnotationAndLabel:
if err := setAppInstanceAnnotation(); err != nil {
return err
}
return setAppInstanceLabel(val)
default:
return setAppInstanceAnnotation()
}
}
func (rt *resourceTracking) RemoveAppInstance(un *unstructured.Unstructured, trackingMethod string) error {
switch v1alpha1.TrackingMethod(trackingMethod) {
case v1alpha1.TrackingMethodLabel:
if err := kube.RemoveLabel(un, common.LabelKeyAppInstance); err != nil {
return err
}
return nil
case v1alpha1.TrackingMethodAnnotation:
if err := kube.RemoveAnnotation(un, common.AnnotationKeyAppInstance); err != nil {
return err
}
if err := kube.RemoveAnnotation(un, common.AnnotationInstallationID); err != nil {
return err
}
return nil
case v1alpha1.TrackingMethodAnnotationAndLabel:
if err := kube.RemoveAnnotation(un, common.AnnotationKeyAppInstance); err != nil {
return err
}
if err := kube.RemoveAnnotation(un, common.AnnotationInstallationID); err != nil {
return err
}
if err := kube.RemoveLabel(un, common.LabelKeyAppInstance); err != nil {
return err
}
return nil
default:
// By default, only app instance annotations are set and not labels
// hence the default case should be only to remove annotations and not labels
if err := kube.RemoveAnnotation(un, common.AnnotationKeyAppInstance); err != nil {
return err
}
if err := kube.RemoveAnnotation(un, common.AnnotationInstallationID); err != nil {
return err
}
}
return nil
}
// BuildAppInstanceValue build resource tracking id in format <application-name>;<group>/<kind>/<namespace>/<name>
func (rt *resourceTracking) BuildAppInstanceValue(value AppInstanceValue) string {
return fmt.Sprintf("%s:%s/%s:%s/%s", value.ApplicationName, value.Group, value.Kind, value.Namespace, value.Name)
}
// ParseAppInstanceValue parse resource tracking id from format <application-name>:<group>/<kind>:<namespace>/<name> to struct
func (rt *resourceTracking) ParseAppInstanceValue(value string) (*AppInstanceValue, error) {
var appInstanceValue AppInstanceValue
parts := strings.SplitN(value, ":", 3)
appInstanceValue.ApplicationName = parts[0]
if len(parts) != 3 {
return nil, ErrWrongResourceTrackingFormat
}
groupParts := strings.Split(parts[1], "/")
if len(groupParts) != 2 {
return nil, ErrWrongResourceTrackingFormat
}
nsParts := strings.Split(parts[2], "/")
if len(nsParts) != 2 {
return nil, ErrWrongResourceTrackingFormat
}
appInstanceValue.Group = groupParts[0]
appInstanceValue.Kind = groupParts[1]
appInstanceValue.Namespace = nsParts[0]
appInstanceValue.Name = nsParts[1]
return &appInstanceValue, nil
}
// Normalize updates live resource and removes diff caused by missing annotation or extra tracking label.
// The normalization is required to ensure smooth transition to new tracking method.
func (rt *resourceTracking) Normalize(config, live *unstructured.Unstructured, labelKey, trackingMethod string) error {
if IsOldTrackingMethod(trackingMethod) {
return nil
}
if live == nil || config == nil {
return nil
}
label, err := kube.GetAppInstanceLabel(live, labelKey)
if err != nil {
return fmt.Errorf("failed to get app instance label: %w", err)
}
if label == "" {
return nil
}
if kubeutil.IsCRD(live) {
// CRDs don't get tracking annotations.
return nil
}
annotation, err := kube.GetAppInstanceAnnotation(config, common.AnnotationKeyAppInstance)
if err != nil {
return err
}
err = kube.SetAppInstanceAnnotation(live, common.AnnotationKeyAppInstance, annotation)
if err != nil {
return err
}
label, err = kube.GetAppInstanceLabel(config, labelKey)
if err != nil {
return fmt.Errorf("failed to get app instance label: %w", err)
}
if label == "" {
err = kube.RemoveLabel(live, labelKey)
if err != nil {
return fmt.Errorf("failed to remove app instance label: %w", err)
}
}
return nil
}