mirror of
https://github.com/hanzoai/deploy.git
synced 2026-10-07 08:44:50 +00:00
41536738c8
* feat(api): hard-fork CRD API group argoproj.io -> deploy.hanzo.ai
Hanzo CD hard-fork, phase 1.1. Single source of truth is
pkg/apis/application/register.go's Group constant (Application/AppProject/
ApplicationSet all derive their FullName from it); every other Go call-site
that hardcoded the literal group string is updated to match: the 3 generated
informer GVRs, the app-of-apps nested-Application detector in types.go, the
resource-tree Application-kind cache populator, the 3 NotFound error
constructors in server/application, and the applicationset-controller's
leader-election Lease name/ID (kept in lockstep across Go source + RBAC
resourceNames, or leader election would get RBAC-denied on startup).
CRD YAMLs (application/appproject/applicationset) and every RBAC apiGroups
rule that actually governs our 3 CRDs are repointed to deploy.hanzo.ai, across
both manifests/base/* (namespaced Roles) and manifests/cluster-rbac/* (cluster
scope). Two adjacent things that share the "argoproj.io" string but are NOT
ours are deliberately left untouched: gitops-engine's health-check dispatch
for Argo Workflows' `Workflow` kind, and argocd-server-clusterrole's second
apiGroups block granting read on Argo Workflows' `workflows` resource — both
belong to a separate, unrelated Argoproj-family project we are not forking.
Also untouched, per explicit scope: annotation/label keys (argocd.argoproj.io/*)
and finalizers (*.argoproj.io) that track already-applied live resources, and
argocd-cm.yaml's resource.customizations.ignoreResourceUpdates keys (a narrow
app-of-apps diffing nicety, not build- or RBAC-relevant).
CGO_ENABLED=0 go build ./... verified green.
* ci: wire canonical hanzo.yml + cicd.yml (Hanzo CD image build)
Phase 1.3. Follows the same one-way pattern every hanzo/lux/zoo repo uses:
hanzo.yml declares the image (root Dockerfile -> ghcr.io/hanzoai/deploy) and a
fast go-build sanity test (the multi-stage Dockerfile build is the slow, real
gate); cicd.yml is the ~10-line trigger shim importing hanzoai/ci's reusable
build workflow on the arc pool, secrets from KMS only.
No `deploy:` block yet, matching the hanzoai/cms build-only-first-cutover
pattern: this repo's own live hanzo-cd namespace runs the whole Hanzo fleet's
GitOps, so the prod image/CRD swap is a deliberate separate action (see the
[HELD] universe PR), never an automatic rollout on merge. Every PR/push still
builds and pushes an immutable ghcr.io/hanzoai/deploy:sha-<7>-amd64 image.
* feat(ui): rebrand Argo CD -> Hanzo CD (title, favicon, logo, sidebar)
Phase 1.2. User-facing "Argo CD"/"ArgoCD" text replaced with "Hanzo CD"
across the login page, help modal, settings screens, version-info panel,
sync-options warning, fullscreen-logs title, app.tsx page titles, and
index.html's <title>/noscript text (dropped the now-wrong upstream CLI
doc link rather than invent a hanzo.ai URL that doesn't exist).
Logo/favicon assets replaced with the canonical Hanzo mark (never
hand-drawn, copied from ~/work/hanzo/logo/dist): the two real usages of
Argo's logo collapse onto one Hanzo glyph (mono + white variants) at the
same 5 call sites (login icon + footer, login.scss $logoPath/
$logoNegativePath, sidebar text-logo), preserving the existing CSS
invert() filters so both the light login panel and dark sidebar still
render correctly. Old argologo.svg/argo_o.svg/argo.png deleted (no
longer referenced). favicon-{16x16,32x32}.png added at
ui/src/assets/favicon/ (index.html's links to that path were previously
dead - the directory didn't exist in this checkout). package.json name
argo-cd-ui -> hanzo-cd-ui.
Left alone, deliberately: the two Kubernetes resource-kind icon sets
under ui/src/assets/images/resources/ (unrelated to branding), and
upstream doc/project links (argoproj.io, argo-cd.readthedocs.io) since
we have no equivalent hanzo.ai docs to point to yet - except the login
footer logo's outbound link, which now points to hanzo.ai instead of
argoproj.io (a Hanzo-branded mark linking to the upstream project it
was forked from read as an obvious leftover).
* feat(module): rename Go module github.com/argoproj/argo-cd/v3 -> github.com/hanzoai/deploy
Phase 2. No version suffix on the new path (org policy: never publish our
own Go modules above v1.x.x / with a v2+ suffix) — this fork starts a fresh
v0/v1 module identity rather than carrying the v3 the upstream fork point
had reached.
Mechanical, symmetric rewrite: 704 .go files (import statements only; two
disjoint substitutions applied specific-first so the nested gitops-engine
module path never double-matches), plus go.mod (module line, the
gitops-engine require+replace pair, version reset to v0.0.0-... since a
suffix-less path can't carry a v3 semver), gitops-engine/go.mod, Makefile
(ldflags PACKAGE + 2 TEST_MODULE filters), .golangci.yaml, .goreleaser.yaml,
.mockery.yaml (+ gitops-engine's), Procfile, the codegen/proto generation
scripts (hack/generate-proto.sh, update-codegen.sh, update-openapi.sh), and
20 .proto files' go_package options. Also one OpenTelemetry tracer name
string in gitops-engine/pkg/sync/sync_context.go (a cosmestic label, not an
import, but worth keeping consistent).
CGO_ENABLED=0 go build ./... verified green for both the root module and
the nested gitops-engine module; go vet clean on both; go mod tidy run
(network available) to reconcile go.sum, dependency set unchanged.
Left alone, deliberately: doc-only mentions (docs/snyk/*.html scan reports,
gitops-engine/README.md), a comment-only reference in
.github/workflows/release.yaml, and one Renovate bot config line — none are
build- or codegen-load-bearing. Also left alone: comments citing upstream
GitHub issue URLs (github.com/argoproj/argo-cd/issues/NNNNN) and a handful
of test fixtures using "https://github.com/argoproj/argo-cd.git" as a
representative example repo URL — both are accurate historical/test-data
references, not stale self-references.
---------
Co-authored-by: Hanzo Dev <[email protected]>
452 lines
16 KiB
Go
452 lines
16 KiB
Go
package argo
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/hanzoai/deploy/util/kube"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"gopkg.in/yaml.v2"
|
|
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
|
|
|
|
"github.com/hanzoai/deploy/common"
|
|
"github.com/hanzoai/deploy/pkg/apis/application/v1alpha1"
|
|
)
|
|
|
|
func TestSetAppInstanceLabel(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
resourceTracking := NewResourceTracking()
|
|
|
|
err = resourceTracking.SetAppInstance(&obj, common.LabelKeyAppInstance, "my-app", "", v1alpha1.TrackingMethodLabel, "")
|
|
require.NoError(t, err)
|
|
app := resourceTracking.GetAppName(&obj, common.LabelKeyAppInstance, v1alpha1.TrackingMethodLabel, "")
|
|
assert.Equal(t, "my-app", app)
|
|
}
|
|
|
|
func TestSetAppInstanceAnnotation(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
resourceTracking := NewResourceTracking()
|
|
|
|
err = resourceTracking.SetAppInstance(&obj, common.AnnotationKeyAppInstance, "my-app", "", v1alpha1.TrackingMethodAnnotation, "")
|
|
require.NoError(t, err)
|
|
|
|
app := resourceTracking.GetAppName(&obj, common.AnnotationKeyAppInstance, v1alpha1.TrackingMethodAnnotation, "")
|
|
assert.Equal(t, "my-app", app)
|
|
}
|
|
|
|
func TestSetAppInstanceAnnotationAndLabel(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
resourceTracking := NewResourceTracking()
|
|
|
|
err = resourceTracking.SetAppInstance(&obj, common.LabelKeyAppInstance, "my-app", "", v1alpha1.TrackingMethodAnnotationAndLabel, "")
|
|
require.NoError(t, err)
|
|
|
|
app := resourceTracking.GetAppName(&obj, common.LabelKeyAppInstance, v1alpha1.TrackingMethodAnnotationAndLabel, "")
|
|
assert.Equal(t, "my-app", app)
|
|
}
|
|
|
|
func TestSetAppInstanceAnnotationAndLabelLongName(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
resourceTracking := NewResourceTracking()
|
|
|
|
err = resourceTracking.SetAppInstance(&obj, common.LabelKeyAppInstance, "my-app-with-an-extremely-long-name-that-is-over-sixty-three-characters", "", v1alpha1.TrackingMethodAnnotationAndLabel, "")
|
|
require.NoError(t, err)
|
|
|
|
// the annotation should still work, so the name from GetAppName should not be truncated
|
|
app := resourceTracking.GetAppName(&obj, common.LabelKeyAppInstance, v1alpha1.TrackingMethodAnnotationAndLabel, "")
|
|
assert.Equal(t, "my-app-with-an-extremely-long-name-that-is-over-sixty-three-characters", app)
|
|
|
|
// the label should be truncated to 63 characters
|
|
assert.Equal(t, "my-app-with-an-extremely-long-name-that-is-over-sixty-three-cha", obj.GetLabels()[common.LabelKeyAppInstance])
|
|
}
|
|
|
|
func TestSetAppInstanceAnnotationAndLabelLongNameBadEnding(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
resourceTracking := NewResourceTracking()
|
|
|
|
err = resourceTracking.SetAppInstance(&obj, common.LabelKeyAppInstance, "the-very-suspicious-name-with-precisely-sixty-three-characters-with-hyphen", "", v1alpha1.TrackingMethodAnnotationAndLabel, "")
|
|
require.NoError(t, err)
|
|
|
|
// the annotation should still work, so the name from GetAppName should not be truncated
|
|
app := resourceTracking.GetAppName(&obj, common.LabelKeyAppInstance, v1alpha1.TrackingMethodAnnotationAndLabel, "")
|
|
assert.Equal(t, "the-very-suspicious-name-with-precisely-sixty-three-characters-with-hyphen", app)
|
|
|
|
// the label should be truncated to 63 characters, AND the hyphen should be removed
|
|
assert.Equal(t, "the-very-suspicious-name-with-precisely-sixty-three-characters", obj.GetLabels()[common.LabelKeyAppInstance])
|
|
}
|
|
|
|
func TestSetAppInstanceAnnotationAndLabelOutOfBounds(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
resourceTracking := NewResourceTracking()
|
|
|
|
err = resourceTracking.SetAppInstance(&obj, common.LabelKeyAppInstance, "----------------------------------------------------------------", "", v1alpha1.TrackingMethodAnnotationAndLabel, "")
|
|
// this should error because it can't truncate to a valid value
|
|
assert.EqualError(t, err, "failed to set app instance label: unable to truncate label to not end with a special character")
|
|
}
|
|
|
|
func TestTruncateLabel_Short(t *testing.T) {
|
|
t.Parallel()
|
|
got, err := TruncateLabel("my-app")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "my-app", got)
|
|
}
|
|
|
|
func TestTruncateLabel_AtLimit(t *testing.T) {
|
|
t.Parallel()
|
|
val := "the-very-suspicious-name-with-precisely-sixty-three-characters0"
|
|
require.Len(t, val, LabelMaxLength)
|
|
got, err := TruncateLabel(val)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, val, got)
|
|
}
|
|
|
|
func TestTruncateLabel_LongName(t *testing.T) {
|
|
t.Parallel()
|
|
got, err := TruncateLabel("my-app-with-an-extremely-long-name-that-is-over-sixty-three-characters")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "my-app-with-an-extremely-long-name-that-is-over-sixty-three-cha", got)
|
|
assert.LessOrEqual(t, len(got), LabelMaxLength)
|
|
}
|
|
|
|
func TestTruncateLabel_TrailingSpecialCharsStripped(t *testing.T) {
|
|
t.Parallel()
|
|
got, err := TruncateLabel("the-very-suspicious-name-with-precisely-sixty-three-characters-with-hyphen")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "the-very-suspicious-name-with-precisely-sixty-three-characters", got)
|
|
}
|
|
|
|
func TestTruncateLabel_AllSpecialChars(t *testing.T) {
|
|
t.Parallel()
|
|
_, err := TruncateLabel("----------------------------------------------------------------")
|
|
assert.EqualError(t, err, "unable to truncate label to not end with a special character")
|
|
}
|
|
|
|
func TestRemoveAppInstance_LabelOnly(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
rt := NewResourceTracking()
|
|
|
|
err = rt.SetAppInstance(&obj, common.LabelKeyAppInstance, "my-app", "", v1alpha1.TrackingMethodLabel, "")
|
|
require.NoError(t, err)
|
|
|
|
err = rt.RemoveAppInstance(&obj, string(v1alpha1.TrackingMethodLabel))
|
|
require.NoError(t, err)
|
|
|
|
_, exists := obj.GetLabels()[common.LabelKeyAppInstance]
|
|
assert.False(t, exists)
|
|
}
|
|
|
|
func TestRemoveAppInstance_AnnotationOnly(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
rt := NewResourceTracking()
|
|
|
|
err = rt.SetAppInstance(&obj, common.AnnotationKeyAppInstance, "my-app", "", v1alpha1.TrackingMethodAnnotation, "")
|
|
require.NoError(t, err)
|
|
|
|
err = rt.RemoveAppInstance(&obj, string(v1alpha1.TrackingMethodAnnotation))
|
|
require.NoError(t, err)
|
|
|
|
annotations := obj.GetAnnotations()
|
|
assert.NotContains(t, annotations, common.AnnotationKeyAppInstance)
|
|
assert.NotContains(t, annotations, common.AnnotationInstallationID)
|
|
assert.NotContains(t, annotations, v1alpha1.TrackingMethodAnnotation)
|
|
}
|
|
|
|
func TestRemoveAppInstance_AnnotationAndLabel(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
rt := NewResourceTracking()
|
|
|
|
err = rt.SetAppInstance(&obj, common.LabelKeyAppInstance, "my-app", "", v1alpha1.TrackingMethodAnnotationAndLabel, "")
|
|
require.NoError(t, err)
|
|
|
|
err = rt.RemoveAppInstance(&obj, string(v1alpha1.TrackingMethodAnnotationAndLabel))
|
|
require.NoError(t, err)
|
|
|
|
assert.NotContains(t, obj.GetAnnotations(), common.AnnotationKeyAppInstance)
|
|
assert.NotContains(t, obj.GetAnnotations(), common.AnnotationInstallationID)
|
|
assert.NotContains(t, obj.GetLabels(), common.LabelKeyAppInstance)
|
|
}
|
|
|
|
func TestRemoveAppInstance_DefaultCase(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
// Add a label manually to verify if this custom label exists at the end
|
|
obj.SetLabels(map[string]string{
|
|
"my-custom-label": "keep-me",
|
|
})
|
|
|
|
rt := NewResourceTracking()
|
|
|
|
err = rt.SetAppInstance(&obj, common.AnnotationKeyAppInstance, "my-app", "", "", "")
|
|
require.NoError(t, err)
|
|
|
|
err = rt.RemoveAppInstance(&obj, "unknown-method")
|
|
require.NoError(t, err)
|
|
|
|
assert.NotContains(t, obj.GetAnnotations(), common.AnnotationKeyAppInstance)
|
|
assert.NotContains(t, obj.GetAnnotations(), common.AnnotationInstallationID)
|
|
|
|
// Argo CD app-instance label was never added, so it shouldn't exist
|
|
_, argocdLabelExists := obj.GetLabels()[common.LabelKeyAppInstance]
|
|
assert.False(t, argocdLabelExists)
|
|
// Custom label should still exist
|
|
assert.Equal(t, "keep-me", obj.GetLabels()["my-custom-label"])
|
|
}
|
|
|
|
func TestRemoveAppInstance_AnnotationAndLabel_LongName(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
rt := NewResourceTracking()
|
|
|
|
longName := "my-app-with-an-extremely-long-name-that-is-over-sixty-three-characters"
|
|
err = rt.SetAppInstance(&obj, common.LabelKeyAppInstance, longName, "", v1alpha1.TrackingMethodAnnotationAndLabel, "")
|
|
require.NoError(t, err)
|
|
|
|
err = rt.RemoveAppInstance(&obj, string(v1alpha1.TrackingMethodAnnotationAndLabel))
|
|
require.NoError(t, err)
|
|
|
|
assert.NotContains(t, obj.GetAnnotations(), common.AnnotationKeyAppInstance)
|
|
assert.NotContains(t, obj.GetLabels(), common.LabelKeyAppInstance)
|
|
}
|
|
|
|
func TestSetAppInstanceAnnotationNotFound(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
resourceTracking := NewResourceTracking()
|
|
|
|
app := resourceTracking.GetAppName(&obj, common.LabelKeyAppInstance, v1alpha1.TrackingMethodAnnotation, "")
|
|
assert.Empty(t, app)
|
|
}
|
|
|
|
func TestParseAppInstanceValue(t *testing.T) {
|
|
t.Parallel()
|
|
resourceTracking := NewResourceTracking()
|
|
appInstanceValue, err := resourceTracking.ParseAppInstanceValue("app:<group>/<kind>:<namespace>/<name>")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "app", appInstanceValue.ApplicationName)
|
|
assert.Equal(t, "<group>", appInstanceValue.Group)
|
|
assert.Equal(t, "<kind>", appInstanceValue.Kind)
|
|
assert.Equal(t, "<namespace>", appInstanceValue.Namespace)
|
|
assert.Equal(t, "<name>", appInstanceValue.Name)
|
|
}
|
|
|
|
func TestParseAppInstanceValueColon(t *testing.T) {
|
|
t.Parallel()
|
|
resourceTracking := NewResourceTracking()
|
|
appInstanceValue, err := resourceTracking.ParseAppInstanceValue("app:<group>/<kind>:<namespace>/<name>:<colon>")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "app", appInstanceValue.ApplicationName)
|
|
assert.Equal(t, "<group>", appInstanceValue.Group)
|
|
assert.Equal(t, "<kind>", appInstanceValue.Kind)
|
|
assert.Equal(t, "<namespace>", appInstanceValue.Namespace)
|
|
assert.Equal(t, "<name>:<colon>", appInstanceValue.Name)
|
|
}
|
|
|
|
func TestParseAppInstanceValueWrongFormat1(t *testing.T) {
|
|
t.Parallel()
|
|
resourceTracking := NewResourceTracking()
|
|
_, err := resourceTracking.ParseAppInstanceValue("app")
|
|
require.ErrorIs(t, err, ErrWrongResourceTrackingFormat)
|
|
}
|
|
|
|
func TestParseAppInstanceValueWrongFormat2(t *testing.T) {
|
|
t.Parallel()
|
|
resourceTracking := NewResourceTracking()
|
|
_, err := resourceTracking.ParseAppInstanceValue("app;group/kind/ns")
|
|
require.ErrorIs(t, err, ErrWrongResourceTrackingFormat)
|
|
}
|
|
|
|
func TestParseAppInstanceValueCorrectFormat(t *testing.T) {
|
|
t.Parallel()
|
|
resourceTracking := NewResourceTracking()
|
|
_, err := resourceTracking.ParseAppInstanceValue("app:group/kind:test/ns")
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func sampleResource(t *testing.T) *unstructured.Unstructured {
|
|
t.Helper()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj *unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
return obj
|
|
}
|
|
|
|
func TestResourceIdNormalizer_Normalize(t *testing.T) {
|
|
t.Parallel()
|
|
rt := NewResourceTracking()
|
|
|
|
// live object is a resource that has old style tracking label
|
|
liveObj := sampleResource(t)
|
|
err := rt.SetAppInstance(liveObj, common.LabelKeyAppInstance, "my-app", "", v1alpha1.TrackingMethodLabel, "")
|
|
require.NoError(t, err)
|
|
|
|
// config object is a resource that has new style tracking annotation
|
|
configObj := sampleResource(t)
|
|
err = rt.SetAppInstance(configObj, common.AnnotationKeyAppInstance, "my-app2", "", v1alpha1.TrackingMethodAnnotation, "")
|
|
require.NoError(t, err)
|
|
|
|
_ = rt.Normalize(configObj, liveObj, common.LabelKeyAppInstance, string(v1alpha1.TrackingMethodAnnotation))
|
|
|
|
// the normalization should affect add the new style annotation and drop old tracking label from live object
|
|
annotation, err := kube.GetAppInstanceAnnotation(configObj, common.AnnotationKeyAppInstance)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, liveObj.GetAnnotations()[common.AnnotationKeyAppInstance], annotation)
|
|
_, hasOldLabel := liveObj.GetLabels()[common.LabelKeyAppInstance]
|
|
assert.False(t, hasOldLabel)
|
|
}
|
|
|
|
func TestResourceIdNormalizer_NormalizeCRD(t *testing.T) {
|
|
t.Parallel()
|
|
rt := NewResourceTracking()
|
|
|
|
// live object is a CRD resource
|
|
liveObj := &unstructured.Unstructured{
|
|
Object: map[string]any{
|
|
"apiVersion": "apiextensions.k8s.io/v1",
|
|
"kind": "CustomResourceDefinition",
|
|
"metadata": map[string]any{
|
|
"name": "crontabs.stable.example.com",
|
|
"labels": map[string]any{
|
|
common.LabelKeyAppInstance: "my-app",
|
|
},
|
|
},
|
|
"spec": map[string]any{
|
|
"group": "stable.example.com",
|
|
"scope": "Namespaced",
|
|
},
|
|
},
|
|
}
|
|
|
|
// config object is a CRD resource
|
|
configObj := &unstructured.Unstructured{
|
|
Object: map[string]any{
|
|
"apiVersion": "apiextensions.k8s.io/v1",
|
|
"kind": "CustomResourceDefinition",
|
|
"metadata": map[string]any{
|
|
"name": "crontabs.stable.example.com",
|
|
"labels": map[string]any{
|
|
common.LabelKeyAppInstance: "my-app",
|
|
},
|
|
},
|
|
"spec": map[string]any{
|
|
"group": "stable.example.com",
|
|
"scope": "Namespaced",
|
|
},
|
|
},
|
|
}
|
|
|
|
require.NoError(t, rt.Normalize(configObj, liveObj, common.LabelKeyAppInstance, string(v1alpha1.TrackingMethodAnnotation)))
|
|
// the normalization should not apply any changes to the live object
|
|
require.NotContains(t, liveObj.GetAnnotations(), common.AnnotationKeyAppInstance)
|
|
}
|
|
|
|
func TestResourceIdNormalizer_Normalize_ConfigHasOldLabel(t *testing.T) {
|
|
t.Parallel()
|
|
rt := NewResourceTracking()
|
|
|
|
// live object is a resource that has old style tracking label
|
|
liveObj := sampleResource(t)
|
|
err := rt.SetAppInstance(liveObj, common.LabelKeyAppInstance, "my-app", "", v1alpha1.TrackingMethodLabel, "")
|
|
require.NoError(t, err)
|
|
|
|
// config object is a resource that has new style tracking annotation
|
|
configObj := sampleResource(t)
|
|
err = rt.SetAppInstance(configObj, common.AnnotationKeyAppInstance, "my-app2", "", v1alpha1.TrackingMethodAnnotation, "")
|
|
require.NoError(t, err)
|
|
err = rt.SetAppInstance(configObj, common.LabelKeyAppInstance, "my-app", "", v1alpha1.TrackingMethodLabel, "")
|
|
require.NoError(t, err)
|
|
|
|
_ = rt.Normalize(configObj, liveObj, common.LabelKeyAppInstance, string(v1alpha1.TrackingMethodAnnotation))
|
|
|
|
// the normalization should affect add the new style annotation and drop old tracking label from live object
|
|
annotation, err := kube.GetAppInstanceAnnotation(configObj, common.AnnotationKeyAppInstance)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, liveObj.GetAnnotations()[common.AnnotationKeyAppInstance], annotation)
|
|
_, hasOldLabel := liveObj.GetLabels()[common.LabelKeyAppInstance]
|
|
assert.True(t, hasOldLabel)
|
|
}
|
|
|
|
func TestIsOldTrackingMethod(t *testing.T) {
|
|
t.Parallel()
|
|
assert.True(t, IsOldTrackingMethod(string(v1alpha1.TrackingMethodLabel)))
|
|
}
|