Files
41536738c8 refactor(cd): hard-fork - rename CRD API group argoproj.io -> deploy.hanzo.ai (#1)
* feat(api): hard-fork CRD API group argoproj.io -> deploy.hanzo.ai

Hanzo CD hard-fork, phase 1.1. Single source of truth is
pkg/apis/application/register.go's Group constant (Application/AppProject/
ApplicationSet all derive their FullName from it); every other Go call-site
that hardcoded the literal group string is updated to match: the 3 generated
informer GVRs, the app-of-apps nested-Application detector in types.go, the
resource-tree Application-kind cache populator, the 3 NotFound error
constructors in server/application, and the applicationset-controller's
leader-election Lease name/ID (kept in lockstep across Go source + RBAC
resourceNames, or leader election would get RBAC-denied on startup).

CRD YAMLs (application/appproject/applicationset) and every RBAC apiGroups
rule that actually governs our 3 CRDs are repointed to deploy.hanzo.ai, across
both manifests/base/* (namespaced Roles) and manifests/cluster-rbac/* (cluster
scope). Two adjacent things that share the "argoproj.io" string but are NOT
ours are deliberately left untouched: gitops-engine's health-check dispatch
for Argo Workflows' `Workflow` kind, and argocd-server-clusterrole's second
apiGroups block granting read on Argo Workflows' `workflows` resource — both
belong to a separate, unrelated Argoproj-family project we are not forking.

Also untouched, per explicit scope: annotation/label keys (argocd.argoproj.io/*)
and finalizers (*.argoproj.io) that track already-applied live resources, and
argocd-cm.yaml's resource.customizations.ignoreResourceUpdates keys (a narrow
app-of-apps diffing nicety, not build- or RBAC-relevant).

CGO_ENABLED=0 go build ./... verified green.

* ci: wire canonical hanzo.yml + cicd.yml (Hanzo CD image build)

Phase 1.3. Follows the same one-way pattern every hanzo/lux/zoo repo uses:
hanzo.yml declares the image (root Dockerfile -> ghcr.io/hanzoai/deploy) and a
fast go-build sanity test (the multi-stage Dockerfile build is the slow, real
gate); cicd.yml is the ~10-line trigger shim importing hanzoai/ci's reusable
build workflow on the arc pool, secrets from KMS only.

No `deploy:` block yet, matching the hanzoai/cms build-only-first-cutover
pattern: this repo's own live hanzo-cd namespace runs the whole Hanzo fleet's
GitOps, so the prod image/CRD swap is a deliberate separate action (see the
[HELD] universe PR), never an automatic rollout on merge. Every PR/push still
builds and pushes an immutable ghcr.io/hanzoai/deploy:sha-<7>-amd64 image.

* feat(ui): rebrand Argo CD -> Hanzo CD (title, favicon, logo, sidebar)

Phase 1.2. User-facing "Argo CD"/"ArgoCD" text replaced with "Hanzo CD"
across the login page, help modal, settings screens, version-info panel,
sync-options warning, fullscreen-logs title, app.tsx page titles, and
index.html's <title>/noscript text (dropped the now-wrong upstream CLI
doc link rather than invent a hanzo.ai URL that doesn't exist).

Logo/favicon assets replaced with the canonical Hanzo mark (never
hand-drawn, copied from ~/work/hanzo/logo/dist): the two real usages of
Argo's logo collapse onto one Hanzo glyph (mono + white variants) at the
same 5 call sites (login icon + footer, login.scss $logoPath/
$logoNegativePath, sidebar text-logo), preserving the existing CSS
invert() filters so both the light login panel and dark sidebar still
render correctly. Old argologo.svg/argo_o.svg/argo.png deleted (no
longer referenced). favicon-{16x16,32x32}.png added at
ui/src/assets/favicon/ (index.html's links to that path were previously
dead - the directory didn't exist in this checkout). package.json name
argo-cd-ui -> hanzo-cd-ui.

Left alone, deliberately: the two Kubernetes resource-kind icon sets
under ui/src/assets/images/resources/ (unrelated to branding), and
upstream doc/project links (argoproj.io, argo-cd.readthedocs.io) since
we have no equivalent hanzo.ai docs to point to yet - except the login
footer logo's outbound link, which now points to hanzo.ai instead of
argoproj.io (a Hanzo-branded mark linking to the upstream project it
was forked from read as an obvious leftover).

* feat(module): rename Go module github.com/argoproj/argo-cd/v3 -> github.com/hanzoai/deploy

Phase 2. No version suffix on the new path (org policy: never publish our
own Go modules above v1.x.x / with a v2+ suffix) — this fork starts a fresh
v0/v1 module identity rather than carrying the v3 the upstream fork point
had reached.

Mechanical, symmetric rewrite: 704 .go files (import statements only; two
disjoint substitutions applied specific-first so the nested gitops-engine
module path never double-matches), plus go.mod (module line, the
gitops-engine require+replace pair, version reset to v0.0.0-... since a
suffix-less path can't carry a v3 semver), gitops-engine/go.mod, Makefile
(ldflags PACKAGE + 2 TEST_MODULE filters), .golangci.yaml, .goreleaser.yaml,
.mockery.yaml (+ gitops-engine's), Procfile, the codegen/proto generation
scripts (hack/generate-proto.sh, update-codegen.sh, update-openapi.sh), and
20 .proto files' go_package options. Also one OpenTelemetry tracer name
string in gitops-engine/pkg/sync/sync_context.go (a cosmestic label, not an
import, but worth keeping consistent).

CGO_ENABLED=0 go build ./... verified green for both the root module and
the nested gitops-engine module; go vet clean on both; go mod tidy run
(network available) to reconcile go.sum, dependency set unchanged.

Left alone, deliberately: doc-only mentions (docs/snyk/*.html scan reports,
gitops-engine/README.md), a comment-only reference in
.github/workflows/release.yaml, and one Renovate bot config line — none are
build- or codegen-load-bearing. Also left alone: comments citing upstream
GitHub issue URLs (github.com/argoproj/argo-cd/issues/NNNNN) and a handful
of test fixtures using "https://github.com/argoproj/argo-cd.git" as a
representative example repo URL — both are accurate historical/test-data
references, not stale self-references.

---------

Co-authored-by: Hanzo Dev <[email protected]>
2026-07-29 18:27:58 -07:00

392 lines
14 KiB
Go

package helm
import (
"fmt"
"net/http"
"net/http/httptest"
"testing"
"time"
"github.com/golang-jwt/jwt/v5"
gocache "github.com/patrickmn/go-cache"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
argoutils "github.com/hanzoai/deploy/util"
"github.com/hanzoai/deploy/util/workloadidentity"
"github.com/hanzoai/deploy/util/workloadidentity/mocks"
)
func TestWorkLoadIdentityUserNameShouldBeEmptyGuid(t *testing.T) {
t.Parallel()
workloadIdentityMock := &mocks.TokenProvider{}
creds := NewAzureWorkloadIdentityCreds("contoso.azurecr.io/charts", "", nil, nil, false, workloadIdentityMock)
username := creds.GetUsername()
assert.Equal(t, workloadidentity.EmptyGuid, username, "The username for azure workload identity is not empty Guid")
}
func TestGetAccessTokenShouldReturnTokenFromCacheIfPresent(t *testing.T) {
t.Parallel()
workloadIdentityMock := &mocks.TokenProvider{}
creds := NewAzureWorkloadIdentityCreds("contoso.azurecr.io/charts", "", nil, nil, false, workloadIdentityMock)
cacheKey, err := argoutils.GenerateCacheKey("accesstoken-%s", "contoso.azurecr.io")
require.NoError(t, err, "Error generating cache key")
// Store the token in the cache
storeAzureToken(cacheKey, "testToken", time.Hour)
// Retrieve the token from the cache
token, err := creds.GetAccessToken()
require.NoError(t, err, "Error getting access token")
assert.Equal(t, "testToken", token, "The retrieved token should match the stored token")
}
func TestGetPasswordShouldReturnTokenFromCacheIfPresent(t *testing.T) {
t.Parallel()
workloadIdentityMock := &mocks.TokenProvider{}
creds := NewAzureWorkloadIdentityCreds("contoso.azurecr.io/charts", "", nil, nil, false, workloadIdentityMock)
cacheKey, err := argoutils.GenerateCacheKey("accesstoken-%s", "contoso.azurecr.io")
require.NoError(t, err, "Error generating cache key")
// Store the token in the cache
storeAzureToken(cacheKey, "testToken", time.Hour)
// Retrieve the token from the cache
token, err := creds.GetPassword()
require.NoError(t, err, "Error getting access token")
assert.Equal(t, "testToken", token, "The retrieved token should match the stored token")
}
func TestGetPasswordShouldGenerateTokenIfNotPresentInCache(t *testing.T) {
t.Parallel()
mockServerURL := ""
mockedServerURL := func() string {
return mockServerURL
}
// Mock the server to return a successful response
mockServer := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch r.URL.Path {
case "/v2/":
w.Header().Set("Www-Authenticate", fmt.Sprintf(`Bearer realm=%q,service=%q`, mockedServerURL(), mockedServerURL()[8:]))
w.WriteHeader(http.StatusUnauthorized)
case "/oauth2/exchange":
response := `{"refresh_token":"newRefreshToken"}`
w.WriteHeader(http.StatusOK)
_, err := w.Write([]byte(response))
require.NoError(t, err)
}
}))
mockServerURL = mockServer.URL
defer mockServer.Close()
workloadIdentityMock := &mocks.TokenProvider{}
workloadIdentityMock.EXPECT().GetToken("https://management.core.windows.net/.default").Return(&workloadidentity.Token{AccessToken: "accessToken"}, nil).Maybe()
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
// Retrieve the token from the cache
token, err := creds.GetPassword()
require.NoError(t, err)
assert.Equal(t, "newRefreshToken", token, "The retrieved token should match the stored token")
}
func TestChallengeAzureContainerRegistry(t *testing.T) {
t.Parallel()
// Set up the mock server
mockServer := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/v2/", r.URL.Path)
w.Header().Set("Www-Authenticate", `Bearer realm="https://login.microsoftonline.com/",service="registry.example.com"`)
w.WriteHeader(http.StatusUnauthorized)
}))
defer mockServer.Close()
workloadIdentityMock := &mocks.TokenProvider{}
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
tokenParams, err := creds.challengeAzureContainerRegistry(t.Context(), creds.repoURL)
require.NoError(t, err)
expectedParams := map[string]string{
"realm": "https://login.microsoftonline.com/",
"service": "registry.example.com",
}
assert.Equal(t, expectedParams, tokenParams)
}
func TestChallengeAzureContainerRegistryNoChallenge(t *testing.T) {
t.Parallel()
// Set up the mock server without Www-Authenticate header
mockServer := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/v2/", r.URL.Path)
w.WriteHeader(http.StatusOK)
}))
defer mockServer.Close()
// Replace the real URL with the mock server URL
workloadIdentityMock := &mocks.TokenProvider{}
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
_, err := creds.challengeAzureContainerRegistry(t.Context(), creds.repoURL)
require.Error(t, err)
assert.Contains(t, err.Error(), "did not issue a challenge")
}
func TestChallengeAzureContainerRegistryNonBearer(t *testing.T) {
t.Parallel()
// Set up the mock server with a non-Bearer Www-Authenticate header
mockServer := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/v2/", r.URL.Path)
w.Header().Set("Www-Authenticate", `Basic realm="example"`)
w.WriteHeader(http.StatusUnauthorized)
}))
defer mockServer.Close()
// Replace the real URL with the mock server URL
workloadIdentityMock := &mocks.TokenProvider{}
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
_, err := creds.challengeAzureContainerRegistry(t.Context(), creds.repoURL)
assert.ErrorContains(t, err, "does not allow 'Bearer' authentication")
}
func TestChallengeAzureContainerRegistryNoService(t *testing.T) {
t.Parallel()
// Set up the mock server with a non-Bearer Www-Authenticate header
mockServer := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/v2/", r.URL.Path)
w.Header().Set("Www-Authenticate", `Bearer realm="example"`)
w.WriteHeader(http.StatusUnauthorized)
}))
defer mockServer.Close()
// Replace the real URL with the mock server URL
workloadIdentityMock := &mocks.TokenProvider{}
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
_, err := creds.challengeAzureContainerRegistry(t.Context(), creds.repoURL)
assert.ErrorContains(t, err, "service parameter not found in challenge")
}
func TestChallengeAzureContainerRegistryNoRealm(t *testing.T) {
t.Parallel()
// Set up the mock server with a non-Bearer Www-Authenticate header
mockServer := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/v2/", r.URL.Path)
w.Header().Set("Www-Authenticate", `Bearer service="example"`)
w.WriteHeader(http.StatusUnauthorized)
}))
defer mockServer.Close()
// Replace the real URL with the mock server URL
workloadIdentityMock := &mocks.TokenProvider{}
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
_, err := creds.challengeAzureContainerRegistry(t.Context(), creds.repoURL)
assert.ErrorContains(t, err, "realm parameter not found in challenge")
}
func TestGetAccessTokenAfterChallenge_Success(t *testing.T) {
t.Parallel()
// Mock the server to return a successful response
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/oauth2/exchange", r.URL.Path)
response := `{"refresh_token":"newRefreshToken"}`
w.WriteHeader(http.StatusOK)
_, err := w.Write([]byte(response))
require.NoError(t, err)
}))
defer mockServer.Close()
workloadIdentityMock := &mocks.TokenProvider{}
workloadIdentityMock.EXPECT().GetToken("https://management.core.windows.net/.default").Return(&workloadidentity.Token{AccessToken: "accessToken"}, nil).Maybe()
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
tokenParams := map[string]string{
"realm": mockServer.URL,
"service": "registry.example.com",
}
refreshToken, err := creds.getAccessTokenAfterChallenge(t.Context(), tokenParams)
require.NoError(t, err)
assert.Equal(t, "newRefreshToken", refreshToken)
}
func TestGetAccessTokenAfterChallenge_Failure(t *testing.T) {
t.Parallel()
// Mock the server to return an error response
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/oauth2/exchange", r.URL.Path)
w.WriteHeader(http.StatusBadRequest)
_, err := w.Write([]byte(`{"error": "invalid_request"}`))
require.NoError(t, err)
}))
defer mockServer.Close()
// Create an instance of AzureWorkloadIdentityCreds with the mock credential wrapper
workloadIdentityMock := &mocks.TokenProvider{}
workloadIdentityMock.EXPECT().GetToken("https://management.core.windows.net/.default").Return(&workloadidentity.Token{AccessToken: "accessToken"}, nil).Maybe()
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
tokenParams := map[string]string{
"realm": mockServer.URL,
"service": "registry.example.com",
}
refreshToken, err := creds.getAccessTokenAfterChallenge(t.Context(), tokenParams)
require.ErrorContains(t, err, "failed to get refresh token")
assert.Empty(t, refreshToken)
}
func TestGetAccessTokenAfterChallenge_MalformedResponse(t *testing.T) {
t.Parallel()
// Mock the server to return a malformed JSON response
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "/oauth2/exchange", r.URL.Path)
w.WriteHeader(http.StatusOK)
_, err := w.Write([]byte(`{"refresh_token":`))
require.NoError(t, err)
}))
defer mockServer.Close()
// Create an instance of AzureWorkloadIdentityCreds with the mock credential wrapper
workloadIdentityMock := &mocks.TokenProvider{}
workloadIdentityMock.EXPECT().GetToken("https://management.core.windows.net/.default").Return(&workloadidentity.Token{AccessToken: "accessToken"}, nil).Maybe()
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
tokenParams := map[string]string{
"realm": mockServer.URL,
"service": "registry.example.com",
}
refreshToken, err := creds.getAccessTokenAfterChallenge(t.Context(), tokenParams)
require.ErrorContains(t, err, "failed to unmarshal response body")
assert.Empty(t, refreshToken)
}
// Helper to generate a mock JWT token with a given expiry time
func generateMockJWT(expiry time.Time) (string, error) {
claims := jwt.MapClaims{
"exp": expiry.Unix(),
}
token := jwt.NewWithClaims(jwt.SigningMethodHS256, claims)
// Use a dummy secret for signing
return token.SignedString([]byte("dummy-secret"))
}
func TestGetAccessToken_FetchNewTokenIfExistingIsExpired(t *testing.T) {
resetAzureTokenCache()
accessToken1, _ := generateMockJWT(time.Now().Add(1 * time.Minute))
accessToken2, _ := generateMockJWT(time.Now().Add(1 * time.Minute))
mockServerURL := ""
mockedServerURL := func() string {
return mockServerURL
}
callCount := 0
mockServer := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch r.URL.Path {
case "/v2/":
assert.Equal(t, "/v2/", r.URL.Path)
w.Header().Set("Www-Authenticate", fmt.Sprintf(`Bearer realm=%q,service=%q`, mockedServerURL(), mockedServerURL()[8:]))
w.WriteHeader(http.StatusUnauthorized)
case "/oauth2/exchange":
assert.Equal(t, "/oauth2/exchange", r.URL.Path)
var response string
switch callCount {
case 0:
response = fmt.Sprintf(`{"refresh_token": %q}`, accessToken1)
case 1:
response = fmt.Sprintf(`{"refresh_token": %q}`, accessToken2)
default:
response = `{"refresh_token": "defaultToken"}`
}
callCount++
w.WriteHeader(http.StatusOK)
_, err := w.Write([]byte(response))
require.NoError(t, err)
default:
http.NotFound(w, r)
}
}))
defer mockServer.Close()
mockServerURL = mockServer.URL
workloadIdentityMock := &mocks.TokenProvider{}
workloadIdentityMock.EXPECT().GetToken("https://management.core.windows.net/.default").Return(&workloadidentity.Token{AccessToken: "accessToken"}, nil).Maybe()
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
refreshToken, err := creds.GetAccessToken()
require.NoError(t, err)
assert.Equal(t, accessToken1, refreshToken)
time.Sleep(5 * time.Second) // Wait for the token to expire
refreshToken, err = creds.GetAccessToken()
require.NoError(t, err)
assert.Equal(t, accessToken2, refreshToken)
}
func TestGetAccessToken_ReuseTokenIfExistingIsNotExpired(t *testing.T) {
resetAzureTokenCache()
accessToken1, _ := generateMockJWT(time.Now().Add(6 * time.Minute))
accessToken2, _ := generateMockJWT(time.Now().Add(1 * time.Minute))
mockServerURL := ""
mockedServerURL := func() string {
return mockServerURL
}
callCount := 0
mockServer := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch r.URL.Path {
case "/v2/":
assert.Equal(t, "/v2/", r.URL.Path)
w.Header().Set("Www-Authenticate", fmt.Sprintf(`Bearer realm=%q,service=%q`, mockedServerURL(), mockedServerURL()[8:]))
w.WriteHeader(http.StatusUnauthorized)
case "/oauth2/exchange":
assert.Equal(t, "/oauth2/exchange", r.URL.Path)
var response string
switch callCount {
case 0:
response = fmt.Sprintf(`{"refresh_token": %q}`, accessToken1)
case 1:
response = fmt.Sprintf(`{"refresh_token": %q}`, accessToken2)
default:
response = `{"refresh_token": "defaultToken"}`
}
callCount++
w.WriteHeader(http.StatusOK)
_, err := w.Write([]byte(response))
require.NoError(t, err)
default:
http.NotFound(w, r)
}
}))
defer mockServer.Close()
mockServerURL = mockServer.URL
workloadIdentityMock := &mocks.TokenProvider{}
workloadIdentityMock.EXPECT().GetToken("https://management.core.windows.net/.default").Return(&workloadidentity.Token{AccessToken: "accessToken"}, nil).Maybe()
creds := NewAzureWorkloadIdentityCreds(mockServer.URL[8:], "", nil, nil, true, workloadIdentityMock)
refreshToken, err := creds.GetAccessToken()
require.NoError(t, err)
assert.Equal(t, accessToken1, refreshToken)
time.Sleep(5 * time.Second) // Wait for the token to expire
refreshToken, err = creds.GetAccessToken()
require.NoError(t, err)
assert.Equal(t, accessToken1, refreshToken)
}
func resetAzureTokenCache() {
azureTokenCache = gocache.New(gocache.NoExpiration, 0)
}