mirror of
https://github.com/hanzoai/deploy.git
synced 2026-10-07 08:44:50 +00:00
41536738c8
* feat(api): hard-fork CRD API group argoproj.io -> deploy.hanzo.ai
Hanzo CD hard-fork, phase 1.1. Single source of truth is
pkg/apis/application/register.go's Group constant (Application/AppProject/
ApplicationSet all derive their FullName from it); every other Go call-site
that hardcoded the literal group string is updated to match: the 3 generated
informer GVRs, the app-of-apps nested-Application detector in types.go, the
resource-tree Application-kind cache populator, the 3 NotFound error
constructors in server/application, and the applicationset-controller's
leader-election Lease name/ID (kept in lockstep across Go source + RBAC
resourceNames, or leader election would get RBAC-denied on startup).
CRD YAMLs (application/appproject/applicationset) and every RBAC apiGroups
rule that actually governs our 3 CRDs are repointed to deploy.hanzo.ai, across
both manifests/base/* (namespaced Roles) and manifests/cluster-rbac/* (cluster
scope). Two adjacent things that share the "argoproj.io" string but are NOT
ours are deliberately left untouched: gitops-engine's health-check dispatch
for Argo Workflows' `Workflow` kind, and argocd-server-clusterrole's second
apiGroups block granting read on Argo Workflows' `workflows` resource — both
belong to a separate, unrelated Argoproj-family project we are not forking.
Also untouched, per explicit scope: annotation/label keys (argocd.argoproj.io/*)
and finalizers (*.argoproj.io) that track already-applied live resources, and
argocd-cm.yaml's resource.customizations.ignoreResourceUpdates keys (a narrow
app-of-apps diffing nicety, not build- or RBAC-relevant).
CGO_ENABLED=0 go build ./... verified green.
* ci: wire canonical hanzo.yml + cicd.yml (Hanzo CD image build)
Phase 1.3. Follows the same one-way pattern every hanzo/lux/zoo repo uses:
hanzo.yml declares the image (root Dockerfile -> ghcr.io/hanzoai/deploy) and a
fast go-build sanity test (the multi-stage Dockerfile build is the slow, real
gate); cicd.yml is the ~10-line trigger shim importing hanzoai/ci's reusable
build workflow on the arc pool, secrets from KMS only.
No `deploy:` block yet, matching the hanzoai/cms build-only-first-cutover
pattern: this repo's own live hanzo-cd namespace runs the whole Hanzo fleet's
GitOps, so the prod image/CRD swap is a deliberate separate action (see the
[HELD] universe PR), never an automatic rollout on merge. Every PR/push still
builds and pushes an immutable ghcr.io/hanzoai/deploy:sha-<7>-amd64 image.
* feat(ui): rebrand Argo CD -> Hanzo CD (title, favicon, logo, sidebar)
Phase 1.2. User-facing "Argo CD"/"ArgoCD" text replaced with "Hanzo CD"
across the login page, help modal, settings screens, version-info panel,
sync-options warning, fullscreen-logs title, app.tsx page titles, and
index.html's <title>/noscript text (dropped the now-wrong upstream CLI
doc link rather than invent a hanzo.ai URL that doesn't exist).
Logo/favicon assets replaced with the canonical Hanzo mark (never
hand-drawn, copied from ~/work/hanzo/logo/dist): the two real usages of
Argo's logo collapse onto one Hanzo glyph (mono + white variants) at the
same 5 call sites (login icon + footer, login.scss $logoPath/
$logoNegativePath, sidebar text-logo), preserving the existing CSS
invert() filters so both the light login panel and dark sidebar still
render correctly. Old argologo.svg/argo_o.svg/argo.png deleted (no
longer referenced). favicon-{16x16,32x32}.png added at
ui/src/assets/favicon/ (index.html's links to that path were previously
dead - the directory didn't exist in this checkout). package.json name
argo-cd-ui -> hanzo-cd-ui.
Left alone, deliberately: the two Kubernetes resource-kind icon sets
under ui/src/assets/images/resources/ (unrelated to branding), and
upstream doc/project links (argoproj.io, argo-cd.readthedocs.io) since
we have no equivalent hanzo.ai docs to point to yet - except the login
footer logo's outbound link, which now points to hanzo.ai instead of
argoproj.io (a Hanzo-branded mark linking to the upstream project it
was forked from read as an obvious leftover).
* feat(module): rename Go module github.com/argoproj/argo-cd/v3 -> github.com/hanzoai/deploy
Phase 2. No version suffix on the new path (org policy: never publish our
own Go modules above v1.x.x / with a v2+ suffix) — this fork starts a fresh
v0/v1 module identity rather than carrying the v3 the upstream fork point
had reached.
Mechanical, symmetric rewrite: 704 .go files (import statements only; two
disjoint substitutions applied specific-first so the nested gitops-engine
module path never double-matches), plus go.mod (module line, the
gitops-engine require+replace pair, version reset to v0.0.0-... since a
suffix-less path can't carry a v3 semver), gitops-engine/go.mod, Makefile
(ldflags PACKAGE + 2 TEST_MODULE filters), .golangci.yaml, .goreleaser.yaml,
.mockery.yaml (+ gitops-engine's), Procfile, the codegen/proto generation
scripts (hack/generate-proto.sh, update-codegen.sh, update-openapi.sh), and
20 .proto files' go_package options. Also one OpenTelemetry tracer name
string in gitops-engine/pkg/sync/sync_context.go (a cosmestic label, not an
import, but worth keeping consistent).
CGO_ENABLED=0 go build ./... verified green for both the root module and
the nested gitops-engine module; go vet clean on both; go mod tidy run
(network available) to reconcile go.sum, dependency set unchanged.
Left alone, deliberately: doc-only mentions (docs/snyk/*.html scan reports,
gitops-engine/README.md), a comment-only reference in
.github/workflows/release.yaml, and one Renovate bot config line — none are
build- or codegen-load-bearing. Also left alone: comments citing upstream
GitHub issue URLs (github.com/argoproj/argo-cd/issues/NNNNN) and a handful
of test fixtures using "https://github.com/argoproj/argo-cd.git" as a
representative example repo URL — both are accurate historical/test-data
references, not stale self-references.
---------
Co-authored-by: Hanzo Dev <[email protected]>
284 lines
8.9 KiB
Go
284 lines
8.9 KiB
Go
package kube
|
|
|
|
import (
|
|
"encoding/json"
|
|
"log"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
corev1 "k8s.io/api/core/v1"
|
|
extv1beta1 "k8s.io/api/extensions/v1beta1"
|
|
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
|
|
"sigs.k8s.io/yaml"
|
|
|
|
"github.com/hanzoai/deploy/common"
|
|
)
|
|
|
|
const depWithoutSelector = `
|
|
apiVersion: extensions/v1beta1
|
|
kind: Deployment
|
|
metadata:
|
|
name: nginx-deployment
|
|
spec:
|
|
template:
|
|
metadata:
|
|
labels:
|
|
app: nginx
|
|
spec:
|
|
containers:
|
|
- image: nginx:1.7.9
|
|
name: nginx
|
|
ports:
|
|
- containerPort: 80
|
|
`
|
|
|
|
const depWithSelector = `
|
|
apiVersion: extensions/v1beta1
|
|
kind: Deployment
|
|
metadata:
|
|
name: nginx-deployment
|
|
spec:
|
|
selector:
|
|
matchLabels:
|
|
app: nginx
|
|
template:
|
|
metadata:
|
|
labels:
|
|
app: nginx
|
|
spec:
|
|
containers:
|
|
- image: nginx:1.7.9
|
|
name: nginx
|
|
ports:
|
|
- containerPort: 80
|
|
`
|
|
|
|
func TestSetLabels(t *testing.T) {
|
|
t.Parallel()
|
|
for _, yamlStr := range []string{depWithoutSelector, depWithSelector} {
|
|
var obj unstructured.Unstructured
|
|
err := yaml.Unmarshal([]byte(yamlStr), &obj)
|
|
require.NoError(t, err)
|
|
|
|
err = SetAppInstanceLabel(&obj, common.LabelKeyAppInstance, "my-app")
|
|
require.NoError(t, err)
|
|
|
|
manifestBytes, err := json.MarshalIndent(obj.Object, "", " ")
|
|
require.NoError(t, err)
|
|
log.Println(string(manifestBytes))
|
|
|
|
var depV1Beta1 extv1beta1.Deployment
|
|
err = json.Unmarshal(manifestBytes, &depV1Beta1)
|
|
require.NoError(t, err)
|
|
|
|
// the following makes sure we are not falling into legacy code which injects labels
|
|
switch yamlStr {
|
|
case depWithoutSelector:
|
|
assert.Nil(t, depV1Beta1.Spec.Selector)
|
|
case depWithSelector:
|
|
assert.Len(t, depV1Beta1.Spec.Selector.MatchLabels, 1)
|
|
assert.Equal(t, "nginx", depV1Beta1.Spec.Selector.MatchLabels["app"])
|
|
}
|
|
assert.Len(t, depV1Beta1.Spec.Template.Labels, 1)
|
|
assert.Equal(t, "nginx", depV1Beta1.Spec.Template.Labels["app"])
|
|
}
|
|
}
|
|
|
|
func TestSetLegacyLabels(t *testing.T) {
|
|
t.Parallel()
|
|
for _, yamlStr := range []string{depWithoutSelector, depWithSelector} {
|
|
var obj unstructured.Unstructured
|
|
err := yaml.Unmarshal([]byte(yamlStr), &obj)
|
|
require.NoError(t, err)
|
|
|
|
err = SetAppInstanceLabel(&obj, common.LabelKeyLegacyApplicationName, "my-app")
|
|
require.NoError(t, err)
|
|
|
|
manifestBytes, err := json.MarshalIndent(obj.Object, "", " ")
|
|
require.NoError(t, err)
|
|
log.Println(string(manifestBytes))
|
|
|
|
var depV1Beta1 extv1beta1.Deployment
|
|
err = json.Unmarshal(manifestBytes, &depV1Beta1)
|
|
require.NoError(t, err)
|
|
assert.Len(t, depV1Beta1.Spec.Selector.MatchLabels, 1)
|
|
assert.Equal(t, "nginx", depV1Beta1.Spec.Selector.MatchLabels["app"])
|
|
assert.Len(t, depV1Beta1.Spec.Template.Labels, 2)
|
|
assert.Equal(t, "nginx", depV1Beta1.Spec.Template.Labels["app"])
|
|
assert.Equal(t, "my-app", depV1Beta1.Spec.Template.Labels[common.LabelKeyLegacyApplicationName])
|
|
}
|
|
}
|
|
|
|
func TestSetLegacyJobLabel(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/job.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
err = SetAppInstanceLabel(&obj, common.LabelKeyLegacyApplicationName, "my-app")
|
|
require.NoError(t, err)
|
|
|
|
manifestBytes, err := json.MarshalIndent(obj.Object, "", " ")
|
|
require.NoError(t, err)
|
|
log.Println(string(manifestBytes))
|
|
|
|
job := unstructured.Unstructured{}
|
|
err = json.Unmarshal(manifestBytes, &job)
|
|
require.NoError(t, err)
|
|
|
|
labels := job.GetLabels()
|
|
assert.Equal(t, "my-app", labels[common.LabelKeyLegacyApplicationName])
|
|
|
|
templateLabels, ok, err := unstructured.NestedMap(job.UnstructuredContent(), "spec", "template", "metadata", "labels")
|
|
assert.True(t, ok)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "my-app", templateLabels[common.LabelKeyLegacyApplicationName])
|
|
}
|
|
|
|
func TestSetSvcLabel(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
err = SetAppInstanceLabel(&obj, common.LabelKeyAppInstance, "my-app")
|
|
require.NoError(t, err)
|
|
|
|
manifestBytes, err := json.MarshalIndent(obj.Object, "", " ")
|
|
require.NoError(t, err)
|
|
log.Println(string(manifestBytes))
|
|
|
|
var s corev1.Service
|
|
err = json.Unmarshal(manifestBytes, &s)
|
|
require.NoError(t, err)
|
|
|
|
log.Println(s.Name)
|
|
log.Println(s.ObjectMeta)
|
|
assert.Equal(t, "my-app", s.Labels[common.LabelKeyAppInstance])
|
|
}
|
|
|
|
func TestIsValidResourceName(t *testing.T) {
|
|
t.Parallel()
|
|
assert.True(t, IsValidResourceName("guestbook-ui"))
|
|
assert.True(t, IsValidResourceName("guestbook-ui1"))
|
|
assert.False(t, IsValidResourceName("Guestbook-ui"))
|
|
assert.False(t, IsValidResourceName("-guestbook-ui"))
|
|
}
|
|
|
|
func TestSetAppInstanceAnnotation(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
err = SetAppInstanceAnnotation(&obj, common.LabelKeyAppInstance, "my-app")
|
|
require.NoError(t, err)
|
|
|
|
manifestBytes, err := json.MarshalIndent(obj.Object, "", " ")
|
|
require.NoError(t, err)
|
|
log.Println(string(manifestBytes))
|
|
|
|
var s corev1.Service
|
|
err = json.Unmarshal(manifestBytes, &s)
|
|
require.NoError(t, err)
|
|
|
|
log.Println(s.Name)
|
|
log.Println(s.ObjectMeta)
|
|
assert.Equal(t, "my-app", s.Annotations[common.LabelKeyAppInstance])
|
|
}
|
|
|
|
func TestSetAppInstanceAnnotationWithInvalidData(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc-with-invalid-data.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
err = SetAppInstanceAnnotation(&obj, common.LabelKeyAppInstance, "my-app")
|
|
assert.EqualError(t, err, "failed to get annotations from target object /v1, Kind=Service /my-service: .metadata.annotations accessor error: contains non-string value in the map under key \"invalid-annotation\": <nil> is of the type <nil>, expected string")
|
|
}
|
|
|
|
func TestGetAppInstanceAnnotation(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
err = SetAppInstanceAnnotation(&obj, common.LabelKeyAppInstance, "my-app")
|
|
require.NoError(t, err)
|
|
|
|
annotation, err := GetAppInstanceAnnotation(&obj, common.LabelKeyAppInstance)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "my-app", annotation)
|
|
}
|
|
|
|
func TestGetAppInstanceAnnotationWithInvalidData(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc-with-invalid-data.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
_, err = GetAppInstanceAnnotation(&obj, "valid-annotation")
|
|
assert.EqualError(t, err, "failed to get annotations from target object /v1, Kind=Service /my-service: .metadata.annotations accessor error: contains non-string value in the map under key \"invalid-annotation\": <nil> is of the type <nil>, expected string")
|
|
}
|
|
|
|
func TestGetAppInstanceLabel(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
err = SetAppInstanceLabel(&obj, common.LabelKeyAppInstance, "my-app")
|
|
require.NoError(t, err)
|
|
label, err := GetAppInstanceLabel(&obj, common.LabelKeyAppInstance)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "my-app", label)
|
|
}
|
|
|
|
func TestGetAppInstanceLabelWithInvalidData(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc-with-invalid-data.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
_, err = GetAppInstanceLabel(&obj, "valid-label")
|
|
assert.EqualError(t, err, "failed to get labels for /v1, Kind=Service /my-service: .metadata.labels accessor error: contains non-string value in the map under key \"invalid-label\": <nil> is of the type <nil>, expected string")
|
|
}
|
|
|
|
func TestRemoveLabel(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
obj.SetLabels(map[string]string{"test": "value"})
|
|
|
|
err = RemoveLabel(&obj, "test")
|
|
require.NoError(t, err)
|
|
|
|
assert.Nil(t, obj.GetLabels())
|
|
}
|
|
|
|
func TestRemoveLabelWithInvalidData(t *testing.T) {
|
|
t.Parallel()
|
|
yamlBytes, err := os.ReadFile("testdata/svc-with-invalid-data.yaml")
|
|
require.NoError(t, err)
|
|
var obj unstructured.Unstructured
|
|
err = yaml.Unmarshal(yamlBytes, &obj)
|
|
require.NoError(t, err)
|
|
|
|
err = RemoveLabel(&obj, "valid-label")
|
|
assert.EqualError(t, err, "failed to get labels for /v1, Kind=Service /my-service: .metadata.labels accessor error: contains non-string value in the map under key \"invalid-label\": <nil> is of the type <nil>, expected string")
|
|
}
|