Files
deploy/gitops-engine/pkg/sync/sync_task.go
T
zeekayandHanzo Dev 446e343a3d cd: annotations are cd.hanzo.ai, API group is apps.hanzo.ai
Two corrections on top of the naming pass, both found by checking the live
cluster rather than the source.

The rename had silently changed the user-facing annotation key from
argocd.argoproj.io/sync-wave to cd.argoproj.io/sync-wave — 63 live
Applications carry the old key, so deploying that would have ignored every
sync-wave and broken fleet deploy ordering. The key is now cd.hanzo.ai/*,
and universe 575650286 moves the ApplicationSet template that stamps it, so
the controller regenerates all 63 consistently.

The API group in code said argoproj.io/v1alpha1 in 157 places while the
cluster has served apps.hanzo.ai/v1alpha1 since 2026-07-23 (the CRDs are
applications.apps.hanzo.ai). Code now matches what is actually served.

The legacy applications.argoproj.io/app-name label had ZERO live users, so it
went with the rest. foo.argoproj.io test fixtures became foo.example.com —
arbitrary test domains should not carry a vendor name.

go build ./... exit 0.

Co-authored-by: Hanzo Dev <[email protected]>
2026-07-28 16:32:14 -07:00

165 lines
4.5 KiB
Go

package sync
import (
"fmt"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/runtime/schema"
"github.com/hanzoai/deploy/gitops-engine/pkg/sync/common"
"github.com/hanzoai/deploy/gitops-engine/pkg/sync/hook"
"github.com/hanzoai/deploy/gitops-engine/pkg/sync/syncwaves"
"github.com/hanzoai/deploy/gitops-engine/pkg/utils/kube"
)
// syncTask holds the live and target object. At least one should be non-nil. A targetObj of nil
// indicates the live object needs to be pruned. A liveObj of nil indicates the object has yet to
// be deployed
type syncTask struct {
phase common.SyncPhase
liveObj *unstructured.Unstructured
targetObj *unstructured.Unstructured
skipDryRun bool
syncStatus common.ResultCode
operationState common.OperationPhase
message string
waveOverride *int
}
func ternary(val bool, a, b string) string {
if val {
return a
}
return b
}
func (t *syncTask) String() string {
return fmt.Sprintf("%s/%d %s %s/%s:%s/%s %s->%s (%s,%s,%s)",
t.phase, t.wave(),
ternary(t.isHook(), "hook", "resource"), t.group(), t.kind(), t.namespace(), t.name(),
ternary(t.liveObj != nil, "obj", "nil"), ternary(t.targetObj != nil, "obj", "nil"),
t.syncStatus, t.operationState, t.message,
)
}
func (t *syncTask) isPrune() bool {
return t.targetObj == nil
}
func (t *syncTask) resultKey() string {
return resourceResultKey(kube.GetResourceKey(t.obj()), t.phase)
}
// return the target object (if this exists) otherwise the live object
// some caution - often you explicitly want the live object not the target object
func (t *syncTask) obj() *unstructured.Unstructured {
return obj(t.targetObj, t.liveObj)
}
func (t *syncTask) wave() int {
if t.waveOverride != nil {
return *t.waveOverride
}
return syncwaves.Wave(t.obj())
}
func (t *syncTask) isHook() bool {
return hook.IsHook(t.obj())
}
func (t *syncTask) group() string {
return t.groupVersionKind().Group
}
func (t *syncTask) kind() string {
return t.groupVersionKind().Kind
}
func (t *syncTask) version() string {
return t.groupVersionKind().Version
}
func (t *syncTask) groupVersionKind() schema.GroupVersionKind {
return t.obj().GroupVersionKind()
}
func (t *syncTask) name() string {
return t.obj().GetName()
}
func (t *syncTask) namespace() string {
return t.obj().GetNamespace()
}
func (t *syncTask) pending() bool {
return t.operationState == ""
}
func (t *syncTask) running() bool {
return t.operationState.Running()
}
func (t *syncTask) completed() bool {
return t.operationState.Completed()
}
func (t *syncTask) successful() bool {
return t.operationState.Successful()
}
func (t *syncTask) pruned() bool {
return t.syncStatus == common.ResultCodePruned
}
func (t *syncTask) hookType() common.HookType {
if t.isHook() {
return common.HookType(t.phase)
}
return ""
}
func (t *syncTask) hasHookDeletePolicy(policy common.HookDeletePolicy) bool {
// cannot have a policy if it is not a hook, it is meaningless
if !t.isHook() {
return false
}
for _, p := range hook.DeletePolicies(t.obj()) {
if p == policy {
return true
}
}
return false
}
func (t *syncTask) deleteBeforeCreation() bool {
return t.liveObj != nil && t.pending() && t.hasHookDeletePolicy(common.HookDeletePolicyBeforeHookCreation)
}
func (t *syncTask) deleteOnPhaseCompletion() bool {
return t.deleteOnPhaseFailed() || t.deleteOnPhaseSuccessful()
}
func (t *syncTask) deleteOnPhaseSuccessful() bool {
return t.liveObj != nil && t.hasHookDeletePolicy(common.HookDeletePolicyHookSucceeded)
}
func (t *syncTask) deleteOnPhaseFailed() bool {
return t.liveObj != nil && t.hasHookDeletePolicy(common.HookDeletePolicyHookFailed)
}
func (t *syncTask) resourceKey() kube.ResourceKey {
resourceKey := kube.GetResourceKey(t.obj())
if t.liveObj != nil {
// t.targetObj has a namespace set for cluster-scoped resources, which causes kube.GetResourceKey()
// to produce an incorrect key with the namespace included. For example:
// rbac.authorization.k8s.io/ClusterRole/my-namespace/my-cluster-role
// instead of the correct rbac.authorization.k8s.io/ClusterRole//my-cluster-role.
// To prevent resource lookup issues, we always rely on the namespace of the live object if it is available.
// This logic will work for both cluster scoped and namespace scoped resources.
//
// Refer to https://github.com/hanzoai/cd/blob/8007df5f6c5dd78a1a8cef73569468ce4d83682c/gitops-engine/pkg/sync/sync_context.go#L827-L833
resourceKey.Namespace = t.liveObj.GetNamespace()
}
return resourceKey
}