Fix Windows build and trailing whitespace

- Fix type mismatch in Chrome path vector on Windows
- Remove trailing whitespace in codex.rs and chatwidget.rs
- Ensure all paths in chrome_paths vector are String type
This commit is contained in:
James Peter
2025-08-14 19:14:35 +10:00
parent 8a081c1648
commit 2953a7f60a
2 changed files with 11 additions and 11 deletions
+3 -3
View File
@@ -3869,7 +3869,7 @@ async fn handle_browser_move(
let has_dy = json.get("dy").is_some();
let has_x = json.get("x").is_some();
let has_y = json.get("y").is_some();
let result = if has_dx || has_dy {
// Relative movement
let dx = json.get("dx").and_then(|v| v.as_f64()).unwrap_or(0.0);
@@ -3884,7 +3884,7 @@ async fn handle_browser_move(
// No parameters provided, just return current position
browser_manager.get_cursor_position().await
};
match result {
Ok((x, y)) => {
// Capture screenshot after moving mouse
@@ -3892,7 +3892,7 @@ async fn handle_browser_move(
{
add_pending_screenshot(sess_clone, screenshot_path, url);
}
ResponseInputItem::FunctionCallOutput {
call_id: call_id_clone.clone(),
output: FunctionCallOutputPayload {
+8 -8
View File
@@ -1976,8 +1976,8 @@ impl ChatWidget<'_> {
{
let log_path = format!("{}\\coder-chrome.log", std::env::temp_dir().display());
let chrome_paths = vec![
"C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe",
"C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe",
"C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe".to_string(),
"C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe".to_string(),
format!(
"{}\\AppData\\Local\\Google\\Chrome\\Application\\chrome.exe",
std::env::var("USERPROFILE").unwrap_or_default()
@@ -2236,8 +2236,8 @@ impl ChatWidget<'_> {
{
let log_path = format!("{}\\coder-chrome.log", std::env::temp_dir().display());
let chrome_paths = vec![
"C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe",
"C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe",
"C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe".to_string(),
"C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe".to_string(),
format!(
"{}\\AppData\\Local\\Google\\Chrome\\Application\\chrome.exe",
std::env::var("USERPROFILE").unwrap_or_default()
@@ -2426,11 +2426,11 @@ impl ChatWidget<'_> {
let latest_screenshot_inner = latest_screenshot_global.clone();
let app_event_tx_inner = app_event_tx_global.clone();
let url_inner = url.clone();
tokio::spawn(async move {
// Wait a moment for the navigation to complete
tokio::time::sleep(tokio::time::Duration::from_millis(1000)).await;
// Capture screenshot after navigation
let browser_manager = codex_browser::global::get_browser_manager().await;
if let Some(browser_manager) = browser_manager {
@@ -2438,12 +2438,12 @@ impl ChatWidget<'_> {
Ok((paths, _url)) => {
if let Some(first_path) = paths.first() {
tracing::info!("Auto-captured screenshot after global navigation: {}", first_path.display());
// Update the latest screenshot
if let Ok(mut latest) = latest_screenshot_inner.lock() {
*latest = Some((first_path.clone(), url_inner.clone()));
}
// Send update event
use codex_core::protocol::{BrowserScreenshotUpdateEvent, EventMsg};
let _ = app_event_tx_inner.send(AppEvent::CodexEvent(Event {