hanzoai/dev
2
0
Fork 0
mirror of https://github.com/hanzoai/dev.git synced 2026-10-25 03:32:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(tui/reasoning): remove brittle phrase checks; rely solely on formatting (all-bold, leading-bold with colon, or markdown heading) for collapsed reasoning titles. Clean up unused var.

Browse Source
This commit is contained in:
James Peter
2025-09-01 21:49:19 +10:00
parent 5ca1670d0a
commit 7f4c569c8c
1 changed files with 3 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/tui/src/history_cell.rs
+3 -30
View File
@@ -2714,7 +2714,7 @@ impl CollapsibleReasoningCell {
fn extract_section_titles(&self) -> Vec<Line<'static>> {
let lines = self.normalized_lines();
let mut titles: Vec<Line<'static>> = Vec::new();
for (idx, l) in lines.iter().enumerate() {
for (_idx, l) in lines.iter().enumerate() {
// Skip blank lines
let text: String = l.spans.iter().map(|s| s.content.as_ref()).collect();
let trimmed = text.trim();
@@ -2742,35 +2742,8 @@ impl CollapsibleReasoningCell {
// 3) Markdown heading (begins with '#') - renderer includes hashes in content
let is_md_heading = trimmed.starts_with('#');
// 4) Title-like plain line: reasonably short, not a meta/instructional preamble,
// no terminal punctuation (including ':'), and either first line or preceded
// by a blank separator.
let prev_blank = idx == 0
|| lines
.get(idx.saturating_sub(1))
.map(|pl| pl.spans.iter().all(|s| s.content.trim().is_empty()))
.unwrap_or(true);
let len_ok = trimmed.chars().count() >= 3 && trimmed.chars().count() <= 80;
// Consider quotes/closing brackets at the end when checking punctuation
let mut tail = trimmed;
while let Some(last) = tail.chars().last() {
if matches!(last, '"' | '\'' | '”' | '’' | ')' | ']' | '}') {
tail = &tail[..tail.len()-last.len_utf8()];
} else { break; }
}
let no_terminal_punct = !tail.ends_with('.') && !tail.ends_with('!') && !tail.ends_with('?') && !tail.ends_with(':');
let lowered = trimmed.to_ascii_lowercase();
let is_meta_intro = lowered.starts_with("here are ")
|| lowered.starts_with("i need to ")
|| lowered.starts_with("i plan to ")
|| lowered.starts_with("let's ")
|| lowered.starts_with("we should ")
|| lowered.starts_with("i'll ")
|| lowered.starts_with("next, ")
|| lowered.starts_with("now, ");
let plain_title_like = prev_blank && len_ok && no_terminal_punct && !is_meta_intro;
if all_bold || (leading_bold && ends_colon) || is_md_heading || plain_title_like {
// Keep detection strict and formatting-driven only.
if all_bold || (leading_bold && ends_colon) || is_md_heading {
titles.push(l.clone());
}
}