Commit Graph
2 Commits
Author SHA1 Message Date
Michael BolinandGitHub 3aeee0d65b chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)
## Why

`argument-comment-lint` was green in CI even though the repo still had
many uncommented literal arguments. The main gap was target coverage:
the repo wrapper did not force Cargo to inspect test-only call sites, so
examples like the `latest_session_lookup_params(true, ...)` tests in
`codex-rs/tui_app_server/src/lib.rs` never entered the blocking CI path.

This change cleans up the existing backlog, makes the default repo lint
path cover all Cargo targets, and starts rolling that stricter CI
enforcement out on the platform where it is currently validated.

## What changed

- mechanically fixed existing `argument-comment-lint` violations across
the `codex-rs` workspace, including tests, examples, and benches
- updated `tools/argument-comment-lint/run-prebuilt-linter.sh` and
`tools/argument-comment-lint/run.sh` so non-`--fix` runs default to
`--all-targets` unless the caller explicitly narrows the target set
- fixed both wrappers so forwarded cargo arguments after `--` are
preserved with a single separator
- documented the new default behavior in
`tools/argument-comment-lint/README.md`
- updated `rust-ci` so the macOS lint lane keeps the plain wrapper
invocation and therefore enforces `--all-targets`, while Linux and
Windows temporarily pass `-- --lib --bins`

That temporary CI split keeps the stricter all-targets check where it is
already cleaned up, while leaving room to finish the remaining Linux-
and Windows-specific target-gated cleanup before enabling
`--all-targets` on those runners. The Linux and Windows failures on the
intermediate revision were caused by the wrapper forwarding bug, not by
additional lint findings in those lanes.

## Validation

- `bash -n tools/argument-comment-lint/run.sh`
- `bash -n tools/argument-comment-lint/run-prebuilt-linter.sh`
- shell-level wrapper forwarding check for `-- --lib --bins`
- shell-level wrapper forwarding check for `-- --tests`
- `just argument-comment-lint`
- `cargo test` in `tools/argument-comment-lint`
- `cargo test -p codex-terminal-detection`

## Follow-up

- Clean up remaining Linux-only target-gated callsites, then switch the
Linux lint lane back to the plain wrapper invocation.
- Clean up remaining Windows-only target-gated callsites, then switch
the Windows lint lane back to the plain wrapper invocation.
2026-03-27 19:00:44 -07:00
+16 644056f080 [apps] Add tool_suggest tool. (#14287)
- [x] Add tool_suggest tool.
- [x] Move chatgpt/src/connectors.rs and core/src/connectors.rs into a
dedicated mod so that we have all the logic and global cache in one
place.
- [x] Update TUI app link view to support rendering the installation
view for mcp elicitation.

---------

Co-authored-by: Shaqayeq <[email protected]>
Co-authored-by: Eric Traut <[email protected]>
Co-authored-by: pakrym-oai <[email protected]>
Co-authored-by: Ahmed Ibrahim <[email protected]>
Co-authored-by: guinness-oai <[email protected]>
Co-authored-by: Eugene Brevdo <[email protected]>
Co-authored-by: Charlie Guo <[email protected]>
Co-authored-by: Fouad Matin <[email protected]>
Co-authored-by: Fouad Matin <[email protected]>
Co-authored-by: xl-openai <[email protected]>
Co-authored-by: alexsong-oai <[email protected]>
Co-authored-by: Owen Lin <[email protected]>
Co-authored-by: sdcoffey <[email protected]>
Co-authored-by: Codex <[email protected]>
Co-authored-by: Won Park <[email protected]>
Co-authored-by: Dylan Hurd <[email protected]>
Co-authored-by: celia-oai <[email protected]>
Co-authored-by: gabec-openai <[email protected]>
Co-authored-by: joeytrasatti-openai <[email protected]>
Co-authored-by: Leo Shimonaka <[email protected]>
Co-authored-by: Rasmus Rygaard <[email protected]>
Co-authored-by: maja-openai <[email protected]>
Co-authored-by: pash-openai <[email protected]>
Co-authored-by: Josh McKinney <[email protected]>
2026-03-11 22:06:59 -07:00