Files
dev/LLM.md
T
zeekayandHanzo Dev 0a1b157d2c feat(exec,app-server): a real JSON contract, and steering that does not abort
Three things the last pass left flagged. Two are done; the third turned out to
belong somewhere else and is reported rather than forced in.

## exec --json emits the schema instead of the SDK guessing it

`exec_events.rs` and `experimental_event_processor_with_json_output.rs` had no
`mod` declaration, so 683 lines defining the `thread.*`/`item.*` schema never
compiled. `sdk/typescript/src/events.ts` says "based on event types from
code-rs/exec/src/exec_events.rs" and then rebuilt those events client-side from
raw core events — the contract existed only in TypeScript, and nothing checked
the two halves agreed.

Declared the modules and fixed what drifted while dead: TaskStarted became a
unit variant, WebSearchEnd became WebSearchComplete, StreamError folded into
Error, ExecCommandEndEvent lost `aggregated_output`, print_config_summary lost a
parameter. `--json` now uses it (`--experimental-json` is an alias, matching
upstream), and the old raw-event processor is deleted rather than left as a
second way to do this. thread.started needed a route because exec consumes
SessionConfigured before the event loop, so EventProcessor grew a defaulted
`on_session_configured`.

Making it real immediately found a lie: the SDK's `Usage` declares five fields
and we emitted three. core::TokenUsage had `cache_write_input_tokens` and
`reasoning_output_tokens` all along; the processor dropped them. Against a mock
model:

  {"type":"thread.started","thread_id":"2bd35c77-..."}
  {"type":"turn.started"}
  {"type":"item.completed","item":{"id":"item_0","type":"agent_message","text":"Hello from the model."}}
  {"type":"turn.completed","usage":{"input_tokens":11,"cached_input_tokens":2,
   "cache_write_input_tokens":0,"output_tokens":5,"reasoning_output_tokens":1}}

The SDK now passes those through instead of reconstructing them. Its test suite
did not compile — at HEAD and in just-every upstream: runStreamed.test.ts uses
`path` and `createMockClient` without importing either, testCodex.ts passes
`config` to a type declaring `configOverrides`, and findCodexPath() referenced
four names (`moduleRequire`, `CODEX_NPM_NAME`, `createRequire`,
`PLATFORM_PACKAGE_BY_TARGET`) that were never declared anywhere. Declared them
against @hanzo/dev, added `env` to CodexOptions, pointed the harness at
code-rs/target/debug/dev instead of codex-rs/target/debug/codex.

  pnpm exec jest tests/runStreamed.test.ts --testTimeout=120000
  3 passed  (asserts thread.started, turn.started, item.completed, turn.completed
             and item.type === "agent_message" against the real binary)

## queueUserMessage: steer a turn instead of tearing it

`sendUserMessage` submits Op::UserInput, and core/src/codex/streaming.rs:998
calls `sess.abort()` before spawning a new turn — over app-server you could
interrupt a turn, never redirect one. Op::QueueUserInput folds items into the
running task instead, and only the TUI used it. It is now an app-server method.
Separate method, not a flag: interrupting and steering are different acts and a
caller should not pick the destructive one by accident.

  → {"method":"queueUserMessage","id":3,"params":{"conversationId":"999222eb-…",
     "items":[{"type":"text","data":{"text":"steer me"}}]}}
  ← {"id":3,"jsonrpc":"2.0","result":{}}
  ← {"error":{"code":-32600,"message":"conversation not found: 00000000-…"},"id":4}

## zrok: not ours to build

Assessed and deliberately not implemented here. `hanzo link` already composes
ttyd + share::start + publish_terminal into exactly this feature, and
cli/src/commands/share.rs calls itself "the ONE implementation of 'publish a
local port on the fabric'". `dev` has no framable surface anyway — app-server is
raw JSON-RPC — and no IAM identity to reach POST /v1/share/enable. The gap is in
cloud/cmd/boxd, which already execs `dev`. Details in the report.

Also: git.hanzo.ai release migration precondition written into LLM.md (four
call sites, forge serves /v1/ not /api/v1/, publish to both for a cycle before
moving the updater). SDK package was @openai/codex-sdk; now @hanzo/dev-sdk.

  cargo test -p {code-core,code-protocol,code-cli,code-app-server,
                 code-exec,code-mcp-server,code-tui} -- --test-threads=1
  1311 passed; 1 failed

The failure is git_info::test_collect_git_info_with_remote, still environmental:
the new narrower insteadOf rule only covers hanzoai/*, and the test's URL is
github.com/example/repo, which the broad rule still rewrites.

Version 0.2.189 -> 0.2.190.

Co-authored-by: Hanzo Dev <[email protected]>
2026-08-06 01:13:15 -07:00

16 KiB
Raw Blame History

Rust/codex-rs

In the codex-rs folder where the rust code lives:

  • Crate names are prefixed with codex-. For example, the core folder's crate is named codex-core
  • When using format! and you can inline variables into {}, always do that.
  • Treat codex-rs as a read-only mirror of openai/codex:main; edit Rust sources under code-rs instead.

Completion/build step

  • Always validate using ./build-fast.sh from the repo root. This is the single required check and must pass cleanly.
  • ./build-fast.sh can take 20+min to run from a cold cache!!! Please use long timeout when running ./build-fast.sh or waiting for it to complete.
  • Policy: All errors AND all warnings must be fixed before you’re done. Treat any compiler warning as a failure and address it (rename unused vars with _, remove mut, delete dead code, etc.).
  • Do not run additional format/lint/test commands on completion (e.g., just fmt, just fix, cargo test) unless explicitly requested for a specific task.
  • NEVER run rustfmt
  • Before pushing to main, run ./pre-release.sh to mirror the release preflight (dev-fast build, CLI smokes, workspace nextest).

Optional regression checks (recommended when touching the Rust workspace):

  • cargo nextest run --no-fail-fast — runs all workspace tests with the TUI helpers automatically enabled. The suite is green after the resume fixtures/git-init fallback updates; older Git builds may print a warning when falling back from --initial-branch, but tests still pass.
  • Focused sweeps stay quick and green: cargo test -p code-tui --features test-helpers, cargo test -p code-cloud-tasks --tests, and cargo test -p mcp-types --tests.

When debugging regressions or bugs, write a failing test (or targeted reproduction script) first and confirm it captures the issue before touching code—if it can’t fail, you can’t be confident the fix works.

Product identity — do not let a merge take it back

dev is the Hanzo coding agent. hanzo code launches a bare dev off PATH, so these are contract, not preference:

Property Value Where
Default provider hanzo — api.hanzo.ai/v1, Responses wire, bearer HANZO_USER_KEY code-rs/core/src/model_provider_info.rs
Default model zen5-coder (Zen family) code-rs/core/src/config.rs
Login command hanzo auth login code-rs/core/src/auth.rs LOGIN_COMMAND
Canonical binary dev (declared first; code is an alias to the same program) code-rs/cli/Cargo.toml
npm @hanzo/dev + @hanzo/dev-<target> codex-cli/package.json, .github/workflows/release.yml
Homebrew hanzoai/homebrew-tap, Formula/hanzo-dev.rb, assets dev-<triple> scripts/generate-homebrew-formula.sh
Release repo hanzoai/dev code-rs/tui/src/updates.rs, codex-cli/postinstall.js

code-rs/ is the workspace that SHIPS. codex-rs/ is the vendored upstream copy. A change that only edits codex-rs/ changes nothing a user runs — this is the single easiest mistake to make here, and .github/merge-policy.json made it for a long time (every glob pointed at codex-rs/**).

That sentence only became true with the v0.6.169 merge. Before it, building dev compiled ten crates out of codex-rs/ — they were real path dependencies, so the "read-only mirror" was load-bearing. Upstream finished the migration and the two workspaces are now separate. One thread remains: codex-rs/models-manager/models.json is include_str!'d by code-version/src/lib.rs, core/src/model_family.rs and core/src/agent_defaults.rs. Deleting codex-rs/ would not build.

Why there is a test for all of this. A one-time edit to a default is a suggestion that lasts until the next merge. code-rs/core/tests/hanzo_identity.rs asserts every row above and fails the build if any regresses. Upstream has no file at that path, so a merge can neither conflict with it nor carry it away along with the thing it guards. If it goes red after a merge: re-apply the identity, do not delete the test. (It is not decorative — it caught the un-retargeted release pipeline and only went green once the pipeline was genuinely fixed.)

Model ids are not guessable. GET https://api.hanzo.ai/v1/models needs a bearer and is the only authority. The previous default, gpt-5-codex, is not in the catalog and returns 400 model is not available from our own gateway — which is why hanzo's CLI passes -c model= on every launch. Verify a model id against /v1/responses (the wire dev speaks) before making it a default; some ids answer on chat/completions but return system-prompt text on responses.

Packaging is a supply chain. codex-cli/postinstall.js runs on every npm install and downloads and executes a binary. It, and the TUI auto-updater (code-rs/tui/src/updates.rs), must point at hanzoai/dev. codex-cli/.pack/ is npm pack output that CI regenerates — it is gitignored on purpose; when it was committed it was a second, stale home for that download URL.

Moving releases to git.hanzo.ai — the precondition

Releases are served by GitHub today. Nothing in this repo points at git.hanzo.ai, and retargeting it blind breaks every installed copy, because the updater and the installer both fetch a URL the user already has baked in. There are exactly four places, and they must move together:

What Where Currently
Update check code-rs/tui/src/updates.rs LATEST_RELEASE_URL api.github.com/repos/hanzoai/dev/releases/latest
Release page code-rs/tui/src/updates.rs CODE_RELEASE_URL github.com/hanzoai/dev/releases/latest
Binary download codex-cli/postinstall.js downloadUrl github.com/hanzoai/dev/releases/download/v${version}/…
Asset upload .github/workflows/release.yml GitHub release assets

The forge serves its API at /v1/, not /api/v1/ — so the update check becomes git.hanzo.ai/v1/repos/hanzoai/dev/releases/latest, and the JSON it returns must keep the tag_name and assets[].name fields updates.rs reads.

The flip is safe only once the forge is serving release assets for a tag that already exists on GitHub, so an old client fetching the GitHub URL and a new client fetching the forge URL get the same bytes. Publish to both for one full release cycle, then move the updater, then stop publishing to GitHub. Moving the updater first strands everyone who has not yet updated — they poll a host that has no releases, and the CLI silently stops offering upgrades.

Upstream lineage — where the code actually comes from

Read this before attempting a sync. The directory names lie about the topology.

  • Proximate upstream is just-every/code, not openai/codex. Our history is just-every's history with every author email rewritten to [email protected], which is why git merge-base against just-every returns nothing: identical trees, different SHAs, disjoint graph.
  • codex-rs/ is not ours to track. just-every carries it as a read-only mirror of openai/codex:main and refreshes it with "Refresh codex-rs mirror to upstream/main" commits. It reaches us through them. We never merge openai/codex directly. (The upstream git remote pointing at openai/codex is a leftover — it is not the sync path.)
  • code-rs/ is the product. It is what builds and what ships.

Syncing

Because the graphs are disjoint, git merge needs a merge base supplied by hand. The base is the just-every commit matching our last sync — recorded here, and nowhere else:

upstream        just-every/code
synced-to       e4fe007150  (v0.6.169)
merge-base-used e92d81b496  ("fix(tui/auto-drive): block resume while auto-resolve pending")

To sync: fetch just-every, git replace --graft <our-fork-point> <its-parent> <merge-base-used>, git merge, resolve, git replace -d <our-fork-point>, then update the two SHAs above. Conflicts concentrate in the TUI chatwidget, core/src/config.rs, and every file carrying our name.

Documentation hygiene

  • Keep docs clean, clear, and current; prune stale instructions instead of piling on caveats.
  • Avoid excessive verbosity; prioritize concise guidance over long narratives.
  • Do not document minor or non-core features; focus on system-critical flows and expectations.
  • Never commit temporary "working" docs, plans, or scratch notes.

Strict Ordering In The TUI History

The TUI enforces strict, per‑turn ordering for all streamed content. Every stream insert (Answer or Reasoning) must be associated with a stable (request_ordinal, output_index, sequence_number) key provided by the model.

  • A stream insert MUST carry a non‑empty stream id. The UI seeds an order key for (kind, id) from the event's OrderMeta before any insert.
  • The TUI WILL NOT insert streaming content without a stream id. Any attempt to insert without an id is dropped with an error log to make the issue visible during development.

Commit Messages

  • Review staged changes before every commit: git --no-pager diff --staged --stat (and skim git --no-pager diff --staged if needed).
  • Write a descriptive subject that explains what changed and why. Avoid placeholders like "chore: commit local work".
  • Prefer Conventional Commits with an optional scope: feat(tui/history): …, fix(core/exec): …, docs(agents): ….
  • Keep the subject ≤ 72 chars; add a short body if rationale or context helps future readers.
  • Use imperative, present tense: "add", "fix", "update" (not "added", "fixes").
  • For merge commits, skip custom prefixes like merge(main<-origin/main):. Use a clear subject such as Merge origin/main: <what changed and how conflicts were resolved>.

Examples:

  • feat(tui/history): show exit code and duration for Exec cells
  • fix(core/codex): handle SIGINT in on_exec_command_begin to avoid orphaned child
  • docs(agents): clarify commit-message expectations

How to Git Push

Merge-and-Push Policy (Do Not Rebase)

When the user asks you to "push" local work:

  • Never rebase in this flow. Do not use git pull --rebase or attempt to replay local commits.
  • Prefer a simple merge of origin/main into the current branch, keeping our local history intact.
  • If the remote only has trivial release metadata changes (e.g., codex-cli/package.json version bumps), adopt the remote version for those files and keep ours for everything else unless the user specifies otherwise.
  • If in doubt or if conflicts touch non-trivial areas, pause and ask before resolving.

Quick procedure (merge-only):

  • Commit your local work first:
    • Review: git --no-pager diff --stat and git --no-pager diff
    • Stage + commit: git add -A && git commit -m "<descriptive message of local changes>"
  • Fetch remote: git fetch origin
  • Merge without auto-commit: git merge --no-ff --no-commit origin/main (stops before committing so you can choose sides)
  • Resolve policy:
    • Default to ours: git checkout --ours .
    • Take remote for trivial package/version files as needed, e.g.: git checkout --theirs codex-cli/package.json
  • Stage and commit the merge with a descriptive message, e.g.:
    • git add -A && git commit -m "Merge origin/main: adopt remote version bumps; keep ours elsewhere (<areas>)"
  • Run ./build-fast.sh and then git push

Command Execution Architecture

The command execution flow in Codex follows an event-driven pattern:

  1. Core Layer (codex-core/src/codex.rs):

    • on_exec_command_begin() initiates command execution
    • Creates EventMsg::ExecCommandBegin events with command details
  2. TUI Layer (codex-tui/src/chatwidget.rs):

    • handle_codex_event() processes execution events
    • Manages RunningCommand state for active commands
    • Creates HistoryCell::Exec for UI rendering
  3. History Cell (codex-tui/src/history_cell.rs):

    • new_active_exec_command() - Creates cell for running command
    • new_completed_exec_command() - Updates with final output
    • Handles syntax highlighting via ParsedCommand

This architecture separates concerns between execution logic (core), UI state management (chatwidget), and rendering (history_cell).

Auto Drive Escape Handling

  • All Auto Drive escape routing lives in code-rs/tui/src/chatwidget.rs. The ChatWidget::auto_should_handle_global_esc helper decides whether the global Esc handler in app.rs should defer to Auto Drive, and ChatWidget::handle_key_event owns the actual stop / pause behaviour. When you need to tweak Esc semantics, update those two locations together.
  • The approval pane must never swallow Esc. code-rs/tui/src/bottom_pane/auto_coordinator_view.rs intentionally lets Esc (and the other approval shortcuts) bubble back to the chat widget; keep this contract intact when editing the view layer.
  • Avoid adding additional Esc handlers elsewhere for Auto Drive flows. Doing so breaks the modal-first ordering in app.rs and prevents users from reliably stopping a run.

Writing New UI Regression Tests

  • Start with make_chatwidget_manual() (or make_chatwidget_manual_with_sender()) to build a ChatWidget in isolation with in-memory channels.
  • Simulate user input by defining a small enum (ScriptStep) and feeding key events via chat.handle_key_event(); see run_script() in tests.rs for a ready-to-use helper that also pumps AppEvents.
  • After the scripted interaction, render with a ratatui::Terminal/TestBackend, then use buffer_to_string() (wraps strip_ansi_escapes) to normalize ANSI output before asserting.
  • Prefer snapshot assertions (assert_snapshot!) or rich string comparisons so UI regressions are obvious. Keep snapshots deterministic by trimming trailing space and driving commit ticks just like the existing tests do.
  • When adding fixtures or updating snapshots, gate rewrites behind an opt-in env var (e.g., UPDATE_IDEAL=1) so baseline refreshes remain explicit.

VT100 Snapshot Harness

  • The VT100 harness lives under code-rs/tui/tests/vt100_chatwidget_snapshot.rs. It renders the live ChatWidget UI into a Terminal<VT100Backend> so snapshots capture the exact PTY output the user sees (including frame chrome, composer rows, and streaming inserts).
  • Use ChatWidgetHarness helpers from code_tui::test_helpers to seed history events and drain AppEvents. Call render_chat_widget_to_vt100(width, height) for a single frame, or render_chat_widget_frames_to_vt100(&[(w,h), ...]) to simulate successive draws while streaming.
  • The harness now exports layout_metrics() so tests can assert scroll offsets and viewport heights without spelunking through private fields.
  • Snapshots are deterministic: tests set CODEX_TUI_FAKE_HOUR=12 automatically so greeting text (“What can I code for you today?”) doesn’t oscillate. If you need a different hour in a test, override the env var before constructing the harness.
  • To add a new scenario, push history/events onto the harness, call render_*_to_vt100, and either insta::assert_snapshot! the frame(s) or manually assert string contents. For multi-frame streaming, push deltas/events first, then capture frames in the order the UI would display them.
  • Run all VT100 snapshots via:
    • cargo test -p code-tui --test vt100_chatwidget_snapshot --features test-helpers -- --nocapture
  • When you intentionally change rendering, review the .snap.new files that appear in code-rs/tui/tests/snapshots/ and accept them with cargo insta review / cargo insta accept (limit to this test where possible).

Monitor Release Workflows After Pushing

  • Use scripts/wait-for-gh-run.sh to follow GitHub Actions releases without spamming manual gh commands.
  • Typical release check right after a push: scripts/wait-for-gh-run.sh --workflow Release --branch main.
  • If you already know the run ID (e.g., from webhook output), run scripts/wait-for-gh-run.sh --run <run-id>.
  • Adjust the poll cadence via --interval <seconds> (defaults to 8). The script exits 0 on success and 1 on failure, so it can gate local automation.
  • Pass --failure-logs to automatically dump logs for any job that does not finish successfully.
  • Dependencies: GitHub CLI (gh) and jq must be available in PATH.