Seven of the metrics integration tests could not find the metric they had just
registered:
reload_test.go:130: Failed to see coredns_build_info in metric output
The exposition was fine — coredns_cache_hits_total was in the same scrape the
whole time. luxfi/metric built each name as
prefixedName(AppendNamespace(namespace, subsystem), name), and
AppendNamespace returned namespace+"_" when the subsystem was empty, so the
caller's own separator made it coredns__build_info. Only metrics WITHOUT a
subsystem were affected, which is why some were there and some were not.
Fixed upstream in luxfi/metric v1.10.1, with tests for both halves; this takes
that version.
TestMetricsRewriteRequestSize was a separate fault, and it passed alone:
getBucketCount read mf.Metrics[0], but the registry is process-wide and an
earlier test in the package leaves a series for a zone named "dropped" that
sorts ahead of this test's own. It measured that, saw 1 request where it
expected 5, and failed. The series is now picked by its zone label.
Whole repo green: `go build` and `go test` with the Makefile's tags, and the
test package twice over to be sure the ordering fault is gone.
zooqueen
c23d8c402e