Files
d1d2946de6 feat: check sequence expressions in for-direction (#20701)
* fix: detect wrong direction in or-direction when update uses SequenceExpression

* fix: detect wrong direction in or-direction when update uses SequenceExpression

* fix: skip report when counter appears in multiple sequence expressions

When a SequenceExpression update has the counter modified in more than one sub-expression, treat direction as unknown and skip. Only report when exactly one expression in the sequence modifies the counter in the wrong direction.

Refs #20726

* fix: perfectly handle nested SequenceExpressions and unknown assignment RHS in for-direction

* chore

---------

Co-authored-by: Amaresh  S M <[email protected]>
2026-05-10 23:18:13 +02:00

517 lines
10 KiB
JavaScript

/**
* @fileoverview Tests for for-direction rule.
* @author Aladdin-ADD <[email protected]>
*/
"use strict";
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------
const rule = require("../../../lib/rules/for-direction");
const RuleTester = require("../../../lib/rule-tester/rule-tester");
//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------
const ruleTester = new RuleTester({ languageOptions: { ecmaVersion: 2020 } });
const incorrectDirection = { messageId: "incorrectDirection" };
ruleTester.run("for-direction", rule, {
valid: [
// test if '++', '--'
"for(var i = 0; i < 10; i++){}",
"for(var i = 0; i <= 10; i++){}",
"for(var i = 10; i > 0; i--){}",
"for(var i = 10; i >= 0; i--){}",
// test if '++', '--' with counter 'i' on the right side of test condition
"for(var i = 0; 10 > i; i++){}",
"for(var i = 0; 10 >= i; i++){}",
"for(var i = 10; 0 < i; i--){}",
"for(var i = 10; 0 <= i; i--){}",
/*
* loops where the condition is statically false from the start (dead code),
* but the direction is consistent, so the rule does not report them
*/
"for(var i = 0; i < 0; i++){}",
"for(var i = 0; 0 > i; i++){}",
// test if '+=', '-=',
"for(var i = 0; i < 10; i+=1){}",
"for(var i = 0; i <= 10; i+=1){}",
"for(var i = 0; i < 10; i-=-1){}",
"for(var i = 0; i <= 10; i-=-1){}",
"for(var i = 10; i > 0; i-=1){}",
"for(var i = 10; i >= 0; i-=1){}",
"for(var i = 10; i > 0; i+=-1){}",
"for(var i = 10; i >= 0; i+=-1){}",
"for(var i = 0n; i > l; i-=1n){}",
"for(var i = 0n; i < l; i-=-1n){}",
"for(var i = MIN; i <= MAX; i+=true){}",
"for(var i = 0; i < 10; i+=+5e-7){}",
"for(var i = 0; i < MAX; i -= ~2);",
"for(var i = 0, n = -1; i < MAX; i += -n);",
// test if '+=', '-=' with counter 'i' on the right side of test condition
"for(var i = 0; 10 > i; i+=1){}",
// test if no update.
"for(var i = 10; i > 0;){}",
"for(var i = 10; i >= 0;){}",
"for(var i = 10; i < 0;){}",
"for(var i = 10; i <= 0;){}",
"for(var i = 10; i <= 0; j++){}",
"for(var i = 10; i <= 0; j--){}",
"for(var i = 10; i >= 0; j++){}",
"for(var i = 10; i >= 0; j--){}",
"for(var i = 10; i >= 0; j += 2){}",
"for(var i = 10; i >= 0; j -= 2){}",
"for(var i = 10; i >= 0; i |= 2){}",
"for(var i = 10; i >= 0; i %= 2){}",
"for(var i = 0; i < MAX; i += STEP_SIZE);",
"for(var i = 0; i < MAX; i -= STEP_SIZE);",
"for(var i = 10; i > 0; i += STEP_SIZE);",
"for(var i = 10; i >= 0; i += 0);",
"for(var i = 10n; i >= 0n; i += 0n);",
"for(var i = 10; i >= 0; i += this.step);",
"for(var i = 10; i >= 0; i += 'foo');",
"for(var i = 10; i > 0; i += !foo);",
"for(var i = MIN; i <= MAX; i -= false);",
"for(var i = MIN; i <= MAX; i -= 0/0);",
// other cond-expressions.
"for(var i = 0; i !== 10; i+=1){}",
"for(var i = 0; i === 10; i+=1){}",
"for(var i = 0; i == 10; i+=1){}",
"for(var i = 0; i != 10; i+=1){}",
// test SequenceExpression (comma operator) - counter moves in the correct direction
"for(var i = 0; i < 10; (i++, j++)){}",
"for(var i = 0; i <= 10; (i++, j++)){}",
"for(var i = 10; i > 0; (i--, j++)){}",
"for(var i = 10; i >= 0; (i--, j++)){}",
"for(var i = 0; i < 10; (j++, i++)){}",
"for(var i = 0; i < 10; (j++, k++)){}",
"for(var i = 0; i < 10; (i+=1, j++)){}",
"for(var i = 10; i > 0; (i-=1, j++)){}",
// test SequenceExpression - counter modified multiple times (direction unknown, skip)
"for(var i = 10; i < 20; (i--, i++)){}",
"for(var i = 10; i < 20; (i--, i += 2)){}",
"for(var i = 0; i < 10; (i++, i--)){}",
"for(var i = 0; i < 10; (i-=1, i+=2)){}",
// test SequenceExpression - three expressions
"for(var i = 0; i < 10; (j++, i++, k++)){}",
"for(var i = 10; i > 0; (j++, i--, k++)){}",
// test SequenceExpression - nested SequenceExpressions
"for(var i = 10; i < 20; (i--, (i = 5, j++))){}",
"for(var i = 10; i < 20; ((i--, j++), i += 2)){}",
// test SequenceExpression - unknown AssignmentExpression RHS
"for(var i = 10; i < 20; (i--, i += STEP_SIZE)){}",
],
invalid: [
// test if '++', '--'
{
code: "for(var i = 0; i < 10; i--){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 28,
},
],
},
{
code: "for(var i = 0; i <= 10; i--){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 29,
},
],
},
{
code: "for(var i = 10; i > 10; i++){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 29,
},
],
},
{
code: "for(var i = 10; i >= 0; i++){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 29,
},
],
},
// test if '++', '--' with counter 'i' on the right side of test condition
{
code: "for(var i = 0; 10 > i; i--){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 28,
},
],
},
{
code: "for(var i = 0; 10 >= i; i--){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 29,
},
],
},
{
code: "for(var i = 10; 10 < i; i++){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 29,
},
],
},
{
code: "for(var i = 10; 0 <= i; i++){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 29,
},
],
},
// test if '+=', '-='
{
code: "for(var i = 0; i < 10; i-=1){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 29,
},
],
},
{
code: "for(var i = 0; i <= 10; i-=1){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 30,
},
],
},
{
code: "for(var i = 10; i > 10; i+=1){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 30,
},
],
},
{
code: "for(var i = 10; i >= 0; i+=1){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 30,
},
],
},
{
code: "for(var i = 0; i < 10; i+=-1){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 30,
},
],
},
{
code: "for(var i = 0; i <= 10; i+=-1){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 31,
},
],
},
{
code: "for(var i = 10; i > 10; i-=-1){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 31,
},
],
},
{
code: "for(var i = 10; i >= 0; i-=-1){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 31,
},
],
},
{
code: "for(var i = 0n; i > l; i+=1n){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 30,
},
],
},
{
code: "for(var i = 0n; i < l; i+=-1n){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 31,
},
],
},
{
code: "for(var i = MIN; i <= MAX; i-=true){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 36,
},
],
},
{
code: "for(var i = 0; i < 10; i-=+5e-7){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 33,
},
],
},
{
code: "for(var i = 0; i < MAX; i += (2 - 3));",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 38,
},
],
},
{
code: "var n = -2; for(var i = 0; i < 10; i += n);",
errors: [
{
...incorrectDirection,
line: 1,
column: 13,
endLine: 1,
endColumn: 43,
},
],
},
// test if '+=', '-=' with counter 'i' on the right side of test condition
{
code: "for(var i = 0; 10 > i; i-=1){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 29,
},
],
},
// test SequenceExpression (comma operator) - counter moves in the wrong direction
{
code: "for(var i = 0; i < 10; (i--, j++)){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 35,
},
],
},
{
code: "for(var i = 0; i <= 10; (i--, j++)){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 36,
},
],
},
{
code: "for(var i = 10; i > 0; (i++, j--)){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 35,
},
],
},
{
code: "for(var i = 10; i >= 0; (i++, j--)){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 36,
},
],
},
{
code: "for(var i = 0; i < 10; (j++, i--)){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 35,
},
],
},
{
code: "for(var i = 0; i < 10; (i-=1, j++)){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 36,
},
],
},
{
code: "for(var i = 10; i > 0; (i+=1, j--)){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 36,
},
],
},
{
code: "for(var i = 0; 10 > i; (i--, j++)){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 35,
},
],
},
// test SequenceExpression - nested SequenceExpressions with wrong direction
{
code: "for(var i = 10; i < 20; (j++, (i--, k++))){}",
errors: [
{
...incorrectDirection,
line: 1,
column: 1,
endLine: 1,
endColumn: 43,
},
],
},
],
});