Files
eslint/tests/lib/rules/handle-callback-err.js

175 lines
5.6 KiB
JavaScript

/**
* @fileoverview Tests for missing-err rule.
* @author Jamund Ferguson
*/
"use strict";
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------
const rule = require("../../../lib/rules/handle-callback-err"),
RuleTester = require("../../../lib/rule-tester/rule-tester");
//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------
const ruleTester = new RuleTester();
const expectedFunctionDeclarationError = {
messageId: "expected",
};
const expectedFunctionExpressionError = {
messageId: "expected",
};
ruleTester.run("handle-callback-err", rule, {
valid: [
"function test(error) {}",
"function test(err) {console.log(err);}",
"function test(err, data) {if(err){ data = 'ERROR';}}",
"var test = function(err) {console.log(err);};",
"var test = function(err) {if(err){/* do nothing */}};",
"var test = function(err) {if(!err){doSomethingHere();}else{};}",
"var test = function(err, data) {if(!err) { good(); } else { bad(); }}",
"try { } catch(err) {}",
"getData(function(err, data) {if (err) {}getMoreDataWith(data, function(err, moreData) {if (err) {}getEvenMoreDataWith(moreData, function(err, allOfTheThings) {if (err) {}});});});",
"var test = function(err) {if(! err){doSomethingHere();}};",
"function test(err, data) {if (data) {doSomething(function(err) {console.error(err);});} else if (err) {console.log(err);}}",
"function handler(err, data) {if (data) {doSomethingWith(data);} else if (err) {console.log(err);}}",
"function handler(err) {logThisAction(function(err) {if (err) {}}); console.log(err);}",
"function userHandler(err) {process.nextTick(function() {if (err) {}})}",
"function help() { function userHandler(err) {function tester() { err; process.nextTick(function() { err; }); } } }",
"function help(done) { var err = new Error('error'); done(); }",
{ code: "var test = err => err;", languageOptions: { ecmaVersion: 6 } },
{
code: "var test = err => !err;",
languageOptions: { ecmaVersion: 6 },
},
{
code: "var test = err => err.message;",
languageOptions: { ecmaVersion: 6 },
},
{
code: "var test = function(error) {if(error){/* do nothing */}};",
options: ["error"],
},
{
code: "var test = (error) => {if(error){/* do nothing */}};",
options: ["error"],
languageOptions: { ecmaVersion: 6 },
},
{
code: "var test = function(error) {if(! error){doSomethingHere();}};",
options: ["error"],
},
{
code: "var test = function(err) { console.log(err); };",
options: ["^(err|error)$"],
},
{
code: "var test = function(error) { console.log(error); };",
options: ["^(err|error)$"],
},
{
code: "var test = function(anyError) { console.log(anyError); };",
options: ["^.+Error$"],
},
{
code: "var test = function(any_error) { console.log(anyError); };",
options: ["^.+Error$"],
},
{
code: "var test = function(any_error) { console.log(any_error); };",
options: ["^.+(e|E)rror$"],
},
],
invalid: [
{
code: "function test(err) {}",
errors: [expectedFunctionDeclarationError],
},
{
code: "function test(err, data) {}",
errors: [expectedFunctionDeclarationError],
},
{
code: "function test(err) {errorLookingWord();}",
errors: [expectedFunctionDeclarationError],
},
{
code: "function test(err) {try{} catch(err) {}}",
errors: [expectedFunctionDeclarationError],
},
{
code: "function test(err, callback) { foo(function(err, callback) {}); }",
errors: [
expectedFunctionDeclarationError,
expectedFunctionExpressionError,
],
},
{
code: "var test = (err) => {};",
languageOptions: { ecmaVersion: 6 },
errors: [{ messageId: "expected" }],
},
{
code: "var test = function(err) {};",
errors: [expectedFunctionExpressionError],
},
{
code: "var test = function test(err, data) {};",
errors: [expectedFunctionExpressionError],
},
{
code: "var test = function test(err) {/* if(err){} */};",
errors: [expectedFunctionExpressionError],
},
{
code: "function test(err) {doSomethingHere(function(err){console.log(err);})}",
errors: [expectedFunctionDeclarationError],
},
{
code: "function test(error) {}",
options: ["error"],
errors: [expectedFunctionDeclarationError],
},
{
code: "getData(function(err, data) {getMoreDataWith(data, function(err, moreData) {if (err) {}getEvenMoreDataWith(moreData, function(err, allOfTheThings) {if (err) {}});}); });",
errors: [expectedFunctionExpressionError],
},
{
code: "getData(function(err, data) {getMoreDataWith(data, function(err, moreData) {getEvenMoreDataWith(moreData, function(err, allOfTheThings) {if (err) {}});}); });",
errors: [
expectedFunctionExpressionError,
expectedFunctionExpressionError,
],
},
{
code: "function userHandler(err) {logThisAction(function(err) {if (err) { console.log(err); } })}",
errors: [expectedFunctionDeclarationError],
},
{
code: "function help() { function userHandler(err) {function tester(err) { err; process.nextTick(function() { err; }); } } }",
errors: [expectedFunctionDeclarationError],
},
{
code: "var test = function(anyError) { console.log(otherError); };",
options: ["^.+Error$"],
errors: [expectedFunctionExpressionError],
},
{
code: "var test = function(anyError) { };",
options: ["^.+Error$"],
errors: [expectedFunctionExpressionError],
},
{
code: "var test = function(err) { console.log(error); };",
options: ["^(err|error)$"],
errors: [expectedFunctionExpressionError],
},
],
});