mirror of
https://github.com/hanzoai/eslint.git
synced 2026-10-30 19:38:10 +00:00
* chore: remove formatting-related lint rules internally * chore: formatted files with Prettier via trunk fmt * rm .prettierrc.json * chore: correct comment directives and formatting * Apply introduced fmt changes post-merge * Also disable MD010 and MD030 in preparation for 19355 * Also disable MD013 in preparation for 19355 * Updated tools/update-rule-type-headers.js to print tabs * Fix introduced issues from the main merge * Manually format conf/*.json * Switch conf/*.json files back to two spaces, per prettier config * chore: empty commit to hopefully unblock GitHub
560 lines
12 KiB
JavaScript
560 lines
12 KiB
JavaScript
/**
|
|
* @fileoverview enforce the location of arrow function bodies
|
|
* @author Sharmila Jesupaul
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const rule = require("../../../lib/rules/implicit-arrow-linebreak");
|
|
const RuleTester = require("../../../lib/rule-tester/rule-tester");
|
|
const { unIndent } = require("../../_utils");
|
|
|
|
const EXPECTED_LINEBREAK = { messageId: "expected" };
|
|
const UNEXPECTED_LINEBREAK = { messageId: "unexpected" };
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Tests
|
|
//------------------------------------------------------------------------------
|
|
|
|
const ruleTester = new RuleTester({ languageOptions: { ecmaVersion: 6 } });
|
|
|
|
ruleTester.run("implicit-arrow-linebreak", rule, {
|
|
valid: [
|
|
// always valid
|
|
`(foo) => {
|
|
bar
|
|
}`,
|
|
|
|
// 'beside' option
|
|
"() => bar;",
|
|
"() => (bar);",
|
|
"() => bar => baz;",
|
|
"() => ((((bar))));",
|
|
`(foo) => (
|
|
bar
|
|
)`,
|
|
"(foo) => bar();",
|
|
`
|
|
//comment
|
|
foo => bar;
|
|
`,
|
|
`
|
|
foo => (
|
|
// comment
|
|
bar => (
|
|
// another comment
|
|
baz
|
|
)
|
|
)
|
|
`,
|
|
`
|
|
foo => (
|
|
// comment
|
|
bar => baz
|
|
)
|
|
`,
|
|
`
|
|
/* text */
|
|
() => bar;
|
|
`,
|
|
`
|
|
/* foo */
|
|
const bar = () => baz;
|
|
`,
|
|
`
|
|
(foo) => (
|
|
//comment
|
|
bar
|
|
)
|
|
`,
|
|
`
|
|
[ // comment
|
|
foo => 'bar'
|
|
]
|
|
`,
|
|
`
|
|
/*
|
|
One two three four
|
|
Five six seven nine.
|
|
*/
|
|
(foo) => bar
|
|
`,
|
|
`
|
|
const foo = {
|
|
id: 'bar',
|
|
// comment
|
|
prop: (foo1) => 'returning this string',
|
|
}
|
|
`,
|
|
`
|
|
// comment
|
|
"foo".split('').map((char) => char
|
|
)
|
|
`,
|
|
{
|
|
code: `
|
|
async foo => () => bar;
|
|
`,
|
|
languageOptions: { ecmaVersion: 8 },
|
|
},
|
|
{
|
|
code: `
|
|
// comment
|
|
async foo => 'string'
|
|
`,
|
|
languageOptions: { ecmaVersion: 8 },
|
|
},
|
|
|
|
// 'below' option
|
|
{
|
|
code: `
|
|
(foo) =>
|
|
(
|
|
bar
|
|
)
|
|
`,
|
|
options: ["below"],
|
|
},
|
|
{
|
|
code: `
|
|
() =>
|
|
((((bar))));
|
|
`,
|
|
options: ["below"],
|
|
},
|
|
{
|
|
code: `
|
|
() =>
|
|
bar();
|
|
`,
|
|
options: ["below"],
|
|
},
|
|
{
|
|
code: `
|
|
() =>
|
|
(bar);
|
|
`,
|
|
options: ["below"],
|
|
},
|
|
{
|
|
code: `
|
|
() =>
|
|
bar =>
|
|
baz;
|
|
`,
|
|
options: ["below"],
|
|
},
|
|
],
|
|
|
|
invalid: [
|
|
// 'beside' option
|
|
{
|
|
code: `
|
|
(foo) =>
|
|
bar();
|
|
`,
|
|
output: `
|
|
(foo) => bar();
|
|
`,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: `
|
|
() =>
|
|
(bar);
|
|
`,
|
|
output: `
|
|
() => (bar);
|
|
`,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: `
|
|
() =>
|
|
bar =>
|
|
baz;
|
|
`,
|
|
output: `
|
|
() => bar => baz;
|
|
`,
|
|
errors: [UNEXPECTED_LINEBREAK, UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: `
|
|
() =>
|
|
((((bar))));
|
|
`,
|
|
output: `
|
|
() => ((((bar))));
|
|
`,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: `
|
|
(foo) =>
|
|
(
|
|
bar
|
|
)
|
|
`,
|
|
output: `
|
|
(foo) => (
|
|
bar
|
|
)
|
|
`,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
(foo) =>
|
|
// test comment
|
|
bar
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
const foo = () =>
|
|
// comment
|
|
[]
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: `
|
|
(foo) =>
|
|
(
|
|
//comment
|
|
bar
|
|
)
|
|
`,
|
|
output: `
|
|
(foo) => (
|
|
//comment
|
|
bar
|
|
)
|
|
`,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: `
|
|
(foo) =>
|
|
(
|
|
bar
|
|
//comment
|
|
)
|
|
|
|
`,
|
|
output: `
|
|
(foo) => (
|
|
bar
|
|
//comment
|
|
)
|
|
|
|
`,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
(foo) =>
|
|
// comment
|
|
// another comment
|
|
bar`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
(foo) =>
|
|
// comment
|
|
(
|
|
// another comment
|
|
bar
|
|
)`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: "() => // comment \n bar",
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: "(foo) => //comment \n bar",
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
(foo) =>
|
|
/* test comment */
|
|
bar
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
(foo) =>
|
|
// hi
|
|
bar =>
|
|
// there
|
|
baz;`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK, UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
(foo) =>
|
|
// hi
|
|
bar => (
|
|
// there
|
|
baz
|
|
)
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
const foo = {
|
|
id: 'bar',
|
|
prop: (foo1) =>
|
|
// comment
|
|
'returning this string',
|
|
}
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
[ foo =>
|
|
// comment
|
|
'bar'
|
|
]
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
"foo".split('').map((char) =>
|
|
// comment
|
|
char
|
|
)
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
new Promise((resolve, reject) =>
|
|
// comment
|
|
resolve()
|
|
)
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
() =>
|
|
/*
|
|
succinct
|
|
explanation
|
|
of code
|
|
*/
|
|
bar
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
stepOne =>
|
|
/*
|
|
here is
|
|
what is
|
|
happening
|
|
*/
|
|
stepTwo =>
|
|
// then this happens
|
|
stepThree`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK, UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
() =>
|
|
/*
|
|
multi
|
|
line
|
|
*/
|
|
bar =>
|
|
/*
|
|
many
|
|
lines
|
|
*/
|
|
baz
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK, UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
foo('', boo =>
|
|
// comment
|
|
bar
|
|
)
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
async foo =>
|
|
// comment
|
|
'string'
|
|
`,
|
|
output: null,
|
|
languageOptions: { ecmaVersion: 8 },
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
async foo =>
|
|
// comment
|
|
// another
|
|
bar;
|
|
`,
|
|
output: null,
|
|
languageOptions: { ecmaVersion: 8 },
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
async (foo) =>
|
|
// comment
|
|
'string'
|
|
`,
|
|
output: null,
|
|
languageOptions: { ecmaVersion: 8 },
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
const foo = 1,
|
|
bar = 2,
|
|
baz = () => // comment
|
|
qux
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
const foo = () =>
|
|
//comment
|
|
qux,
|
|
bar = 2,
|
|
baz = 3
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
const foo = () =>
|
|
//two
|
|
1,
|
|
boo = () =>
|
|
//comment
|
|
2,
|
|
bop = "what"
|
|
`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK, UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
start()
|
|
.then(() =>
|
|
/* If I put a comment here, eslint --fix breaks badly */
|
|
process && typeof process.send === 'function' && process.send('ready')
|
|
)
|
|
.catch(err => {
|
|
/* catch seems to be needed here */
|
|
console.log('Error: ', err)
|
|
})`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
hello(response =>
|
|
// comment
|
|
response, param => param)`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: unIndent`
|
|
start(
|
|
arr =>
|
|
// cometh
|
|
bod => {
|
|
// soon
|
|
yyyy
|
|
}
|
|
)`,
|
|
output: null,
|
|
errors: [UNEXPECTED_LINEBREAK],
|
|
},
|
|
|
|
// 'below' option
|
|
{
|
|
code: "(foo) => bar();",
|
|
output: "(foo) => \nbar();",
|
|
options: ["below"],
|
|
errors: [EXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: "(foo) => bar => baz;",
|
|
output: "(foo) => \nbar => \nbaz;",
|
|
options: ["below"],
|
|
errors: [EXPECTED_LINEBREAK, EXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: "(foo) => (bar);",
|
|
output: "(foo) => \n(bar);",
|
|
options: ["below"],
|
|
errors: [EXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: "(foo) => (((bar)));",
|
|
output: "(foo) => \n(((bar)));",
|
|
options: ["below"],
|
|
errors: [EXPECTED_LINEBREAK],
|
|
},
|
|
{
|
|
code: `
|
|
(foo) => (
|
|
bar
|
|
)
|
|
`,
|
|
output: `
|
|
(foo) => \n(
|
|
bar
|
|
)
|
|
`,
|
|
options: ["below"],
|
|
errors: [EXPECTED_LINEBREAK],
|
|
},
|
|
],
|
|
});
|